Re: Review Request 113216: some little performance improvement for network kio

2016-08-08 Thread Jaime Torres Amate
work/ioslave/networkslave.cpp a548f1a Diff: https://git.reviewboard.kde.org/r/113216/diff/ Testing --- Thanks, Jaime Torres Amate

Review Request 121935: Compile with -Werror=return-true -Wno-variadic-macros

2015-01-08 Thread Jaime Torres Amate
g.cpp be55ff5 src/workspace/settings/MainConfigurationWidget.cpp e130d1d Diff: https://git.reviewboard.kde.org/r/121935/diff/ Testing --- It compiles with gcc 4.9 and clang++ (without those flags) Thanks, Jaime Torres Amate

Re: Review Request 116097: No longer use strlcpy in kstartupconfig

2014-03-14 Thread Jaime Torres Amate
WIN32, you have my ship it!. - Jaime Torres Amate On Feb. 26, 2014, 6:11 p.m., Alexander Richardson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Review Request 113216: some little performance improvement for network kio

2013-10-12 Thread Jaime Torres Amate
diff/ Testing --- Thanks, Jaime Torres Amate

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

2013-09-22 Thread Jaime Torres Amate
> On Sept. 21, 2013, 6:40 p.m., Jaime Torres Amate wrote: > > I've tried to apply it to today master head and it does not apply clean. > > Some previous patch has done something similar to your patch. (sorry, not > > much time to check it all). > > Jon

Re: Review Request 111093: PolKit Actions KCM: do not crash if policies could not be read

2013-09-21 Thread Jaime Torres Amate
s not apply clean. Some previous patch has done something similar to your patch. (sorry, not much time to check it all). - Jaime Torres Amate On Sept. 18, 2013, 8:37 a.m., Jonathan Marten wrote: > > --- > This is an automatically ge

Re: release schedule BoF

2013-07-17 Thread Jaime Torres Amate
Why not the other direction? 4 months to develop new features, 2 months freeze and fixing? Jonathan Riddell escribió: > >Albert Astals Cid: >idea is to shorten release >we have now lots of freezes and a branch >alex wants something shorter, suggested 3 months between release with >only 1

Re: Releases in 3 months

2013-07-13 Thread Jaime Torres Amate
How would the release schedule ( http://techbase.kde.org/Schedules/KDE4/4.11_Release_Schedule) be in a 3 or 4 mounths release? 1 month for new features, 2 or 3 for bugfixing, translating, language bindings? Or like linux kernel, allways develop new features in other branches, and 1 month to me

Re: Review Request: favicon local cache

2012-11-20 Thread Jaime Torres Amate
Diffs (updated) - kdecore/services/kmimetype.cpp 955bf62 Diff: http://git.reviewboard.kde.org/r/107358/diff/ Testing --- In my tests, there are more than 5 thousands requests for a favicon answered by the local cache vs. less than new 50 favicons inserted. Thanks, Jaime Torres Amate

Review Request: favicon local cache

2012-11-17 Thread Jaime Torres Amate
Diffs - kdecore/services/kmimetype.cpp 955bf62 Diff: http://git.reviewboard.kde.org/r/107358/diff/ Testing --- In my tests, there are more than 5 thousands requests for a favicon answered by the local cache vs. less than new 50 favicons inserted. Thanks, Jaime Torres Amate

Re: Review Request: parenthesis and not null checking

2012-11-11 Thread Jaime Torres Amate
) ^ b (what gcc produces) vs. !(a ^ b) (what the author wanted?) - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107213/#review21785 ------

Re: Review Request: remove an assert

2012-11-06 Thread Jaime Torres Amate
$KDE_INSTALL_DIR/share/apps/kdevappwizard/templates/kderubyapp.tar.bz2 - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107211/#review21475 ---

Review Request: parenthesis and not null checking

2012-11-05 Thread Jaime Torres Amate
khtml/rendering/render_object.cpp f37627c solid/solid/backends/wmi/wmiopticaldisc.cpp c6e390f Diff: http://git.reviewboard.kde.org/r/107213/diff/ Testing --- I've been using this code several weeks. Thanks, Jaime Torres Amate

Review Request: remove an assert

2012-11-05 Thread Jaime Torres Amate
crash. Thanks, Jaime Torres Amate

Re: Review Request: missing initializations in plasma

2012-10-10 Thread Jaime Torres Amate
/declarativewidget.cpp 93d0438 Diff: http://git.reviewboard.kde.org/r/106781/diff/ Testing --- Thanks, Jaime Torres Amate

Re: Review Request: miscelaneous things for kdelibs/plasma

2012-10-10 Thread Jaime Torres Amate
Thanks, Jaime Torres Amate

Review Request: miscelaneous things

2012-10-10 Thread Jaime Torres Amate
rivate/applethandle.cpp f6d51a2 Diff: http://git.reviewboard.kde.org/r/106782/diff/ Testing --- This has helped me to know more about bug 297684 (that I still suffer :-( ) Thanks, Jaime Torres Amate

Review Request: missing initializations in plasma

2012-10-10 Thread Jaime Torres Amate
://git.reviewboard.kde.org/r/106781/diff/ Testing --- Thanks, Jaime Torres Amate

Re: Review Request: proper fix for my inexcusable commit without review

2012-07-11 Thread Jaime Torres Amate
364/#review15666 >--- > >Ship it! > > >Ship It! > >- David Faure > > >On June 29, 2012, 4:22 p.m., Jaime Torres Amate wrote: >> >> ---

Re: Review Request: proper fix for my inexcusable commit without review

2012-06-29 Thread Jaime Torres Amate
it this afternoon. Thanks, Jaime Torres Amate

Review Request: one assigment and one duplicated test

2011-12-31 Thread Jaime Torres Amate
/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8815 --- It works for me. You have my ship it. - Jaime Torres Amate

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-05 Thread Jaime Torres Amate
Range(0, 0); > > verticalScrollBar()->setRange(0, 0); > > return; > > } > > > > but i actually doubt this is relevant. > > > > However, i cannot reproduce the issue (commenting the fixed policies in > > kpluginse

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Jaime Torres Amate
Diff: http://git.reviewboard.kde.org/r/103313/diff/diff Testing --- Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug). Please, test with other programs. Thanks, Jaime Torres Amate

Review Request: three trivial fixes and one not so trivial

2011-12-04 Thread Jaime Torres Amate
plasma/popupapplet.cpp c363503 plasma/private/associatedapplicationmanager.cpp cf8bbe5 plasma/private/style.cpp e3449f5 Diff: http://git.reviewboard.kde.org/r/103323/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Jaime Torres Amate
with break; to exit from them to do binary search. You are free to create a patch for them. - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8683 -----

Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Jaime Torres Amate
(neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug). Please, test with other programs. Thanks, Jaime Torres Amate

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
e causing a behaviour > > change. > > Jaime Torres Amate wrote: > Could you explain more about the problems you've noticed or fill a bug > report? > Do I have some time to try to fix the problem you've found in KRunner, > instead of reverting the code to a w

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
e causing a behaviour > > change. > > Jaime Torres Amate wrote: > Could you explain more about the problems you've noticed or fill a bug > report? > Do I have some time to try to fix the problem you've found in KRunner, > instead of reverting the code to a w

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
e causing a behaviour > > change. Could you explain more about the problems you've noticed or fill a bug report? Do I have some time to try to fix the problem you've found in KRunner, instead of reverting the code to a wrong status (as not intended by th

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Jaime Torres Amate
/modules/form.cpp 5e260c1 kutils/kemoticons/kemoticonstheme.cpp c145741 kutils/kpluginselector.cpp 0a39fcc Diff: http://git.reviewboard.kde.org/r/103165/diff/diff Testing --- Still compiles with g++ Thanks, Jaime Torres Amate

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Jaime Torres Amate
> On Nov. 17, 2011, 12:59 p.m., David Faure wrote: > > Looks good except for one item. which item? - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#r

Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Jaime Torres Amate
Testing --- Still compiles with g++ Thanks, Jaime Torres Amate

Review Request: limit the amount of columns & rows of any layer

2011-10-07 Thread Jaime Torres Amate
also unable to open that file. This addresses bug 234030. http://bugs.kde.org/show_bug.cgi?id=234030 Diffs - kimgio/xcf.cpp 2a03d03 Diff: http://git.reviewboard.kde.org/r/102800/diff/diff Testing --- not oom killer in action. Thanks, Jaime Torres Amate

Re: Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Jaime Torres Amate
ff: http://git.reviewboard.kde.org/r/102794/diff/diff Testing --- no regressions in kdelibs tests. Thanks, Jaime Torres Amate

Review Request: Avoid possible null pointer dereferences in khtml

2011-10-07 Thread Jaime Torres Amate
iff/diff Testing --- no regressions in kdelibs tests. Thanks, Jaime Torres Amate

Review Request: fix sycoca off by one

2011-09-30 Thread Jaime Torres Amate
kde session (linking all the .so and programs again). None of the kde programs crashes, nor any protocol is missing. No valgrind errors (except fontconfig). Thanks, Jaime Torres Amate

Re: Review Request: little faster sycoca

2011-09-29 Thread Jaime Torres Amate
faster than light, but it is only a four lines patch. Diffs (updated) - kdecore/sycoca/ksycocadict.cpp 17ed9ac Diff: http://git.reviewboard.kde.org/r/102723/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: little faster sycoca

2011-09-28 Thread Jaime Torres Amate
wboard.kde.org/r/102723/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: little faster sycoca

2011-09-28 Thread Jaime Torres Amate
a for loop (I'm checking it this has been this way since the beginning, or if fixing it makes other things faster) as Rolf has pointed. - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http:

Review Request: little faster sycoca

2011-09-27 Thread Jaime Torres Amate
/102723/diff/diff Testing --- Thanks, Jaime Torres Amate

Re: Review Request: new kded daemon to check .thumbnail directory space usage

2011-09-21 Thread Jaime Torres Amate
until the files left use less or equal space than the specified. Thanks, Jaime Torres

Review Request: show a warning message when there are more sessions to close

2011-09-12 Thread Jaime Torres Amate
shown when there are more than the actual session active. Thanks, Jaime Torres

Re: Review Request: new kded daemon to check .thumbnail directory space usage

2011-09-02 Thread Jaime Torres Amate
ATION directoryusagenotifier/settings.kcfgc PRE-CREATION directoryusagenotifier/tests/CMakeLists.txt PRE-CREATION directoryusagenotifier/tests/cleanupunittest.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102083/diff Testing (updated) --- It works as expected. Thanks, Jaime Torres

Re: Review Request: Do not crash because a badly servicetype_profilerc is found

2011-08-20 Thread Jaime Torres Amate
does not crash in the assertion :-) Thanks, Jaime Torres

Re: Review Request: new kded daemon to check .thumbnail directory space usage

2011-08-04 Thread Jaime Torres Amate
arounds.. file rights in the first case, and removing the noatime in the second. I tried to present more than 3 buttons (delete, file manager, sweeper and config), but I only know how to handle the 3 first buttons. Nepomuk, and thumbnai

Re: Review Request: faster kmd5

2011-08-01 Thread Jaime Torres Amate
s probably because of the removal of memset). The totals for transform are: 91,13% without the patch and 61,97% with it (only 4/3 times faster), and 85,19% without register. g++ is not yet smart enough. - Jaime Torres --- This is an au

Review Request: faster kmd5

2011-07-31 Thread Jaime Torres Amate
,00%; 1,03% +0,33% passing parameters In the new way, FF, GG, HH and II calls in the transform method take 0,83%; 0,80%; 0,76%; 0,78% +0,21% passing parameters I've tried also the kmd5benchmarktest, but I do not understand very well the results (or if they are as accurate as callgrind). Thanks, Jaime Torres

Review Request: new kded daemon to check .thumbnail directory space usage

2011-07-25 Thread Jaime Torres Amate
hanks, Jaime Torres

Review Request: Do not crash because a badly servicetype_profilerc is found

2011-07-11 Thread Jaime Torres Amate
? active-development? This addresses bug 269785. http://bugs.kde.org/show_bug.cgi?id=269785 Diffs - kdecore/services/kservicetypeprofile.cpp 7403e2a Diff: http://git.reviewboard.kde.org/r/101914/diff Testing --- It does not crash :-) Thanks, Jaime Torres

Re: Review Request: a very little fix

2011-05-24 Thread Jaime Torres Amate
g/r/101433/#comment2943> Even better, change it to log the previous value and the new one. But look, it is commented. - Jaime Torres On May 24, 2011, 4:17 p.m., Guy Maurel wrote: > > --- > This is an automatically g

Review Request: remove valgrind warnings about non unitialized values in calendar.

2010-12-31 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6249/ --- Review request for kdelibs. Summary --- There were two paths where the

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ --- (Updated 2010-11-07 14:17:29.120532) Review request for kdelibs. Changes -

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Jaime Torres
matically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/#review8527 ------- On 2010-11-07 12:54:32, Jaime Torres wrote: > > --- > This is

Re: Review Request: Four simple patches for kdecore

2010-11-07 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ --- (Updated 2010-11-07 12:54:32.253284) Review request for kdelibs. Changes -

Re: Review Request: Four simple patches for kdecore

2010-11-06 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ --- (Updated 2010-11-06 22:35:06.086790) Review request for kdelibs. Changes -

Review Request: Four simple patches for kdecore

2010-11-06 Thread Jaime Torres
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5775/ --- Review request for kdelibs. Summary --- As I do not know if that kind o