Re: Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

d e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112129/#review38015 --- On Aug. 16, 2013, 9:06 p.m., Jeremy Paul Whiting wrote: > > --- > This is an automatically g

Re: Review Request 112144: Smal KXmlGuiWindow documentation improvements

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112144/#review38157 --- Ship it! Ship It! - Jeremy Paul Whiting On Aug. 18, 2013

Review Request 112129: Make Plasma::PackageStructure look for metadata.desktop files in only subfolder of extracted plasmapkg archives

with this and my other patch. Any better ideas for getting the only subdirectory are welcome, it feels a bit kludgy as is. Thanks, Jeremy Paul Whiting

Review Request 112128: Fix plasmapkg -t theme -r ThemeName to actually uninstall the theme.

e. Diffs - plasma/tools/plasmapkg/main.cpp 6a2982b292ec9736710f4b41dcaa0cbff3986c46 Diff: http://git.reviewboard.kde.org/r/112128/diff/ Testing --- Plasma themes correctly uninstall here with this and my other patch. Thanks, Jeremy Paul Whiting

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

for you. > > Commit message should contain a separate string "REVIEW: 111952" to close > this RR. > > Jeremy Paul Whiting wrote: > Gabi, Let me know if you don't have a kde account and I'll commit the fix > to git myself. > > Gabi Sarki

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

> On Aug. 13, 2013, 12:06 p.m., Gabi Sarkis wrote: > > Ship It! > > Gabi Sarkis wrote: > Sorry about that. How do I go about "Shipping it"? > > Thanks > > Yuri Chornoivan wrote: > Just commit it into the repo or ask someone to do it for you. > > Commit message should c

Re: Review Request 111952: Properly detect xz and lzma compressed archives in Get New Stuff

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111952/#review37625 --- Ship it! Looks good to me. - Jeremy Paul Whiting On Aug. 8

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

/4.10 branch. - Jeremy Paul Whiting On March 14, 2013, 9:24 a.m., Sven Brauch wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request 109421: Support custom providers in the GHNS upload dialog

providers should only be listed if they are also in the new providers file. Otherwise it's impossible to set your application to not use the default provider. - Jeremy Paul Whiting On March 11, 2013, 5:34 p.m., Sven Brauch wrote: > > ---

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107821/#review24952 --- Ship it! Ship It! - Jeremy Paul Whiting On Dec. 21, 2012

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

> On Jan. 7, 2013, 6:38 p.m., Jeremy Paul Whiting wrote: > > Looks good to me, I wonder why you changed the suffix bits the way you did, > > why not just make it initialized in the BackgroundFinder constructor and > > use m_suffixes directly instead of calling suffixes()

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

way you did, why not just make it initialized in the BackgroundFinder constructor and use m_suffixes directly instead of calling suffixes() itself? - Jeremy Paul Whiting On Dec. 21, 2012, 5:11 p.m., Erwan MATHIEU wrote: > > --- >

Re: Review Request: Correction of bug 235710 : Plasma Wallpaper Slideshow to periodially recheck contents of image folder

> On Dec. 21, 2012, 12:28 a.m., Kai Uwe Broulik wrote: > > plasma/generic/wallpapers/image/image.cpp, line 589 > > > > > > I give you an “i” ;) > > Erwan MATHIEU wrote: > What do you mean ? He means you prob

Re: Review Request: Fix multiple issues in colors KCM

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106066/#review17635 --- Ship it! Ship It! - Jeremy Paul Whiting On Aug. 18, 2012

Re: Review Request: Fix KWidgetItemDelegate not updating on FocusIn and FocusOut

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104149/#review11317 --- Ship it! Ship It! - Jeremy Paul Whiting On March 4, 2012

Re: Review Request: Update KWidgetItemDelegate widgets when selection changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104134/#review11061 --- Ship it! Ship It! - Jeremy Paul Whiting On March 1, 2012

Re: Review Request: Make the writeConfig() method a public slot

. - Jeremy Paul Whiting On Jan. 30, 2012, 8:57 p.m., Laszlo Papp wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103719/#review9937 --- Ship it! Ship It! - Jeremy Paul Whiting On Jan. 17, 2012, 9

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

IC in frameworks. If we are, a duplicate method with KConfigSkeleton that simply calls this new method should be added to keep BC. - Jeremy Paul Whiting On Jan. 17, 2012, 9:28 p.m., Laszlo Papp wrote: > > --- > This is an automatic

Re: Review Request: Support GnuPG2 in KNewstuff3

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102439/#review6012 --- Ship it! Looks good, go for it. - Jeremy Paul On Aug. 25, 20

Re: Review Request: Fixed rating in knewstupp3.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102416/#review5953 --- Ship it! Looks good. If you have commit access, go for it, oth

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

branches. - Jeremy Paul --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3619 --- On June 1, 2011, 7:29 p.m.,

Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/ --- Review request for kdelibs and Eike Hein. Summary --- QComboBox in qt

Review Request: Make kdelibs build against qt 4.8 which has added QStringBuilder to QByteArray + operations.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101342/ --- Review request for kdelibs and David Faure. Summary --- This makes kd

Re: Review Request: Shares the KNS3::Cache amongst users of the same program instance

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100960/#review2214 --- Ship it! This looks good. Ship it! - Jeremy Paul On March 2

Re: Review Request: KNS3 correctly stores updated entries as installed.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100958/#review2213 --- Ship it! This looks good, ship it. - Jeremy Paul On March 27

Re: Review Request: KNS overwrites existing files automatically on an update

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100961/#review2211 --- Ship it! This looks good, ship it. - Jeremy Paul On March 27