Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-12-01 Thread Thomas Lübking
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-12-01 Thread Andras Mantia
On Tuesday, November 29, 2011 17:29:33 Thomas =?ISO-8859-1?Q?L=FCbking?= wrote: > Ok, last observation: > > The critical value seems to be "13" in Bespin (what means > PM_ScrollBarExtent to be "15" for horizontal sliders) > The value of qcommonstyle is qMax(16, QApplication::globalStrut()); FYI,

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Thomas Lübking
Ok, last observation: The critical value seems to be "13" in Bespin (what means PM_ScrollBarExtent to be "15" for horizontal sliders) The value of qcommonstyle is qMax(16, QApplication::globalStrut()); Cheers, Thomas

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Thomas Lübking
Sorry, forgot: raising the value then did expose the issue. I *guess* that kcatergoizedview somewhere blindly copied/borrowed a "random" padding value from Qt/measuring/guessing and simply hardcoded that. Cheers, Thomas

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Thomas Lübking
Am Tue, 29 Nov 2011 09:41:08 +0100 schrieb Jaime : > I just wanted to show you this "nice" view of the mutual recursion. > too deep > recursion.png > Unfortunately, I still have not

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Jaime
I just wanted to show you this "nice" view of the mutual recursion. too deep recursion.png Unfortunately, I still have not found the point of exit from it. Any help is wellcome. Best

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-28 Thread Thomas Lübking
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Thomas Lübking
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Ben Cooksley
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Jaime Torres Amate
> On Nov. 27, 2011, 10:22 a.m., Ben Cooksley wrote: > > This fix causes a nasty regression which causes the plugin list in KRunner > > and other apps to be nearly unusable when compiled with gcc. Please adjust > > the KPluginSelector component of this fix as it must be causing a behaviour > >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-27 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8503 --- This fix causes a nasty regression which causes the plugin list

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8272 --- This review has been submitted with commit e91e5fed6b1aad365e12

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8271 --- Ship it! Ah, no, you're right, I read 'man operator' wrong. + d

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/ --- (Updated Nov. 17, 2011, 2:37 p.m.) Review request for kdelibs. Changes -

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread David Faure
On Thursday 17 November 2011 13:33:25 David Faure wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103165/#review8264 > --- >

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8264 --- kutils/kpluginselector.cpp

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Jaime Torres Amate
> On Nov. 17, 2011, 12:59 p.m., David Faure wrote: > > Looks good except for one item. which item? - Jaime Torres --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8262 --

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/#review8262 --- Looks good except for one item. - David Faure On Nov. 17, 201

Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-17 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103165/ --- Review request for kdelibs. Description --- Trivial c++ fixes for som