Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2014-09-21 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/112991/#review67133 --- Thanks, Gilles, for letting us know, that this is covered

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-25 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- (Updated Oct. 26, 2013, 4:57 a.m.) Review request for kde-workspace.

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-22 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review42169 --- Martin, KDE 4.11 or master (Qt5) _must_ compile under OSX. My

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Kurt Hindenburg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41886 --- The patch doesn't apply cleanly to KDE/4.11 branch - it looks

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41897 --- Ok, thanks for you feedback. I make patch with git/master,

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-17 Thread Martin Gräßlin
On Oct. 17, 2013, 5:11 p.m., Gilles Caulier wrote: Ok, thanks for you feedback. I make patch with git/master, not KDE/4.11 branch. I will checkout this code and adapt patch accordingly Gilles Caulier I make patch with git/master, not KDE/4.11 branch You are aware that master is

Re: Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-10-14 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/#review41727 --- There is nobody to review this simple complation fix for OSX ?

Review Request 112991: Fix compilation rules of KDE-Workspace under OSX/Macports

2013-09-29 Thread Gilles Caulier
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112991/ --- Review request for kde-workspace. Description --- This patch fix