Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Dmitry Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated July 29, 2014, 9:03 p.m.) Status -- This change has been ma

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Albert Astals Cid
> On jul. 29, 2014, 5:12 p.m., Marco Martin wrote: > > Ship It! Marco, Dmitry doesn't have an account, can you please push this to 4.11? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kd

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Marco Martin
> On July 29, 2014, 10:31 a.m., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit > > Dmitry Ivanov wrote: > Well, I've been living with this patch for half a year already, since > January 8 :) I used it with a number of KDE 4.x

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 --- Ship it! Ship It! - Marco Martin On Jan. 8, 2014, 4:25 p.m

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Dmitry Ivanov
> On Июль 29, 2014, 2:31 п.п., Marco Martin wrote: > > this would require some testing before pushing to 4.x, too delicate to just > > commit Well, I've been living with this patch for half a year already, since January 8 :) I used it with a number of KDE 4.x versions from 4.11.3 to 4.13.1 (co

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-07-29 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63413 --- this would require some testing before pushing to 4.x, too del

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 8:25 p.m.) Review request for kde-workspace and Pl

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
> On Jan. 8, 2014, 5:06 p.m., Thomas Lübking wrote: > > briefly looking at the bug - wouldn't it be better to only cause a full > > parent repaint when adding/removing an (fdo) icon? I have tried it but without success. Adding/removing/changing visibility preference of icons is done on QML sid

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review47049 --- briefly looking at the bug - wouldn't it be better to only cau

Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing ")

2014-01-08 Thread Dmitry Ivanov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/ --- (Updated Jan. 8, 2014, 12:59 p.m.) Review request for kde-workspace and P