Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/#review17640 --- kdeui/tests/klineedittest.cpp

Re: KColorScheme

2012-08-18 Thread David Faure
On Thursday 09 August 2012 17:16:27 Matthew Woehlke wrote: I think you're going to have to either: a. Accept a SIC and just let some roles be wrong for old code b. Have a suffix on all the new flags c. Put the new flags in some namespace that isn't QPalette, and keep a method taking the old

Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/ --- (Updated Aug. 18, 2012, 3:23 p.m.) Review request for KDE Frameworks.

Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/ --- (Updated Aug. 18, 2012, 3:23 p.m.) Review request for KDE Frameworks.

Re: Review Request: Remove uses of KApplication where not needed

2012-08-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106063/#review17674 --- Ship it! Ship It! - David Faure On Aug. 18, 2012, 3:23

Re: Review Request: Remember current desktop when changing activity

2012-08-18 Thread Rolf Eike Beer
Am Samstag, 18. August 2012, 20:19:55 schrieb makism: Yeah i read a bug report about this (new) behavior. It would be fair to support all perceptions of activities (because of their abstract meaning). Ivan mentioned that in @4.10 there will be a KCM for activities, i believe that we could add

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/#review17676 --- This review has been submitted with commit

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-08-18 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/#review17677 --- This review has been submitted with commit

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-18 Thread Dawit Alemayehu
On Aug. 17, 2012, 8:29 p.m., David Faure wrote: Not a strong objection, but KonqViewManager::doSetActivePart is supposed to do this already, so I'm surprised it doesn't work? If that method isn't called in your case, then OK. Well I finally figured out why this was happening! Believe

Re: How to construct the DBus identifier for current app?

2012-08-18 Thread Milian Wolff
On Friday 17 August 2012 00:25:16 Kevin Krammer wrote: On Thursday, 2012-08-16, Milian Wolff wrote: On Thursday 16 August 2012 23:12:16 Kevin Krammer wrote: On Thursday, 2012-08-16, Milian Wolff wrote: Hey there, see for context:

Re: Application specific cache

2012-08-18 Thread Milian Wolff
On Thursday 16 August 2012 23:55:14 Kevin Krammer wrote: On Thursday, 2012-08-16, Milian Wolff wrote: Hey there, where should an app store it's cache data? I see that KStandardDirs notes cache, but how would one actually use that? I.e. if I want to write a file to the app's cache