Re: Review Request 117902: Use PUBLIC and PRIVATE in target_link_libraries for the installed libs

2014-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117902/#review57354 --- This review has been submitted with commit 507fbd3e20b88d591a

Re: Review Request 117902: Use PUBLIC and PRIVATE in target_link_libraries for the installed libs

2014-05-05 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117902/ --- (Updated May 5, 2014, 9:07 p.m.) Status -- This change has been mark

Re: Thank you for Baloo!

2014-05-05 Thread Martin Steigerwald
Am Montag, 5. Mai 2014, 18:51:52 schrieb Vishesh Handa: > On Sunday, May 04, 2014 11:59:49 PM Martin Steigerwald wrote: > > Hi Vishesh and all the other devs working on it! > > > > I don´t know how it indexed more than 70 mails in a local maildir in > > less than half an hour, but it seems it

Re: Launch Bug Report Wizard failing on Apple OS X (was "ksycoca4")

2014-05-05 Thread mk-lists
On 05 May 2014, at 21:25 , Thomas Lübking wrote: > -> can you lookup your local KDE code for the section in kfmclient.cpp? Since I am using current KDE 4.12.4 here this change is - of course - present. >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

Re: Launch Bug Report Wizard failing on Apple OS X (was "ksycoca4")

2014-05-05 Thread Thomas Lübking
On Montag, 5. Mai 2014 21:05:46 CEST, mk-li...@email.de wrote: On 05 May 2014, at 21:00 , Thomas Lübking wrote: Many thanks for the update - let's see whether Jose can confirm this observation. You’re welcome. We’ll see. The only odd thing is that some kio_client apps clutter up the dock, wh

Re: Launch Bug Report Wizard failing on Apple OS X (was "ksycoca4")

2014-05-05 Thread mk-lists
On 05 May 2014, at 21:00 , Thomas Lübking wrote: > Many thanks for the update - let's see whether Jose can confirm this > observation. You’re welcome. We’ll see. >> The only odd thing is that some kio_client apps clutter up the dock, which >> I’ve also seen for kglobalaccel in konversation [1].

Re: Launch Bug Report Wizard failing on Apple OS X (was "ksycoca4")

2014-05-05 Thread Thomas Lübking
On Samstag, 3. Mai 2014 23:38:22 CEST, mk-li...@email.de wrote: On 23 Mar 2014, at 19:18 , Thomas Lübking wrote: Another idea would be that OSX doesn't like the "!" prefix (no idea why componentchooser writes it - here. Works fine w/o as well) Hmm, I think that’s indeed the problem! Many

Re: Thank you for Baloo!

2014-05-05 Thread Vishesh Handa
On Sunday, May 04, 2014 11:59:49 PM Martin Steigerwald wrote: > Hi Vishesh and all the other devs working on it! > > I don´t know how it indexed more than 70 mails in a local maildir in > less than half an hour, but it seems it did. > > I did no measurements, but I wouldn´t be surprised if Ba

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57330 --- This review has been submitted with commit ce183ae409aa9104ca

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ --- (Updated May 5, 2014, 4:35 p.m.) Status -- This change has been mark

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57329 --- Ship it! from my pov, +1 I hope noone will miss the word-cou

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ --- (Updated May 5, 2014, 4:14 p.m.) Review request for Baloo and Milian Wolf

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Milian Wolff
> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Vishesh Handa
> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Milian Wolff
> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57322 --- src/extractionresult.cpp

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Vishesh Handa
> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Vishesh Handa
> On May 5, 2014, 2:08 p.m., Milian Wolff wrote: > > src/extractionresult.cpp, line 59 > > > > > > this is pure virtual in the header, no? Yeah. I had originally kept it as virtual instead of pure virtual, but cl

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57315 --- src/extractionresult.cpp

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57314 --- What is the speed difference compared to the old QString API,

Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

2014-05-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ --- Review request for Baloo and Milian Wolff. Repository: kfilemetadata De

Re: Review Request 117902: Use PUBLIC and PRIVATE in target_link_libraries for the installed libs

2014-05-05 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117902/#review57313 --- Ship it! Sorry, I didn't notice. - Vishesh Handa On April