Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Ivan Čukić
On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-17 Thread Martin Klapetek
On Nov. 15, 2014, 12:16 a.m., Martin Klapetek wrote: src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 https://git.reviewboard.kde.org/r/121098/diff/1/?file=327582#file327582line301 Looking at QDialog docs, it says modal : bool This property holds

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Ivan Čukić
Yeah, it looks like I've been looking at the CTP from November 2012 - for VS11 [1]. It would be awesome if somebody who has VS11 actually investigated this. Namely, the 11.0 proper should support variadics up to some number of arguments (yes, sounds really daft and hackish). If true, it

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Nicolás Álvarez
El 17/11/2014, a las 06:03, Ivan Čukić ivan.cu...@kde.org escribió: On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: - initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the

Re: Problem with kdeinit and StartupInfo

2014-11-17 Thread Martin Klapetek
On Sat, Oct 4, 2014 at 1:47 PM, Alex Merry alex.me...@kde.org wrote: On 2014-10-04 10:08, David Faure wrote: On Friday 03 October 2014 12:15:09 Alex Merry wrote: Note that KDBusService has a known limitation where it just doesn't work with startup notifications in unique mode - the

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Nicolás Alvarez
El domingo, 16 de noviembre de 2014, Ivan Čukić ivan.cu...@kde.org escribió: Hi, The topic of increasing the compiler versions we require might have been started for the specific issue one of the frameworks had, but I think it shouldn't have died out when the issue in question got patched.

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-17 Thread Kai Uwe Broulik
- initializer lists Unsupported on VS2012. Again, seems to be that CTP thingie, damn. (though, again, the initializer lists should also be tested - maybe they also work if the number of arguments is less than ...) I've had problems with them even on VS2013, like return QHashint,

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

2014-11-17 Thread Marco Martin
On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: hm, i don't really like it. is it working around a problem in particular? if i try the patch, the difference during startup (or just duringopening a popup on the first time) is pretty noticeable like, the wallpaper appearing several

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi Milian, Thanks for looking at my patches. Since the branch, as you noticed, is quite contaminated with unrelated changes, merging in and out stuff, I'll push these changes to a cleaned branch, and will address the issues you pointed out. I'll post a new RR then. On Sunday, November 16,

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-17 Thread Sebastian Kügler
Hi David, On Sunday, November 16, 2014 18:10:27 David Faure wrote: Cool that you're looking into this. On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: - a small tool called kplugin-update-index collects the json metadata from the plugins, and puts the list of plugins in a

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 17, 2014, 3:39 p.m.) Review request for KDE Frameworks,

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
On nov. 17, 2014, 3:24 après-midi, Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Christoph Feck
On Nov. 17, 2014, 3:24 p.m., Christoph Feck wrote: src/ksplittercollapserbutton.cpp, line 276 https://git.reviewboard.kde.org/r/121145/diff/3/?file=328890#file328890line276 Please pass at least a QStyleOption to pixelMetric(). For some styles, the metric depends on the font size,

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/ --- (Updated Nov. 17, 2014, 9:39 a.m.) Status -- This change has been

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

2014-11-17 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated nov. 17, 2014, 4:48 après-midi) Review request for KDE

Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-17 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/ --- Review request for KDE Frameworks. Repository: frameworkintegration

Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository:

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70541 --- Ship it! Ship It! - Christoph Cullmann On Nov. 17, 2014,

Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository:

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/#review70545 --- Ship it! Works for me :) - Albert Astals Cid On nov. 17,

Re: Review Request 121160: Add libgit2 compile-time check for threads support

2014-11-17 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- (Updated Nov. 17, 2014, 10:45 p.m.) Status -- This change has been

OSX/CI: gwenview build fails on branch master

2014-11-17 Thread Marko Käning
1) Kdcraw is not found, although project libkdcraw is installed on the OSX/CI system. 2) I am wondering also why gwenview fails building on OSX for the not installed optional package Exiv2. --- . . . -- Could NOT find Exiv2 (missing: EXIV2_LIBRARY EXIV2_INCLUDE_DIR) (Required is at least

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- (Updated Nov. 17, 2014, 11:28 p.m.) Status -- This change has been

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/#review70564 --- I tested this here and FileDialog qml still hangs the ui with

tagging releases

2014-11-17 Thread Tobias Leupold
Hi list! Sorry for the potentially dumb question, but I'm very new to all this ;-) Recently, libkface has been moved from extragear to kdegraphics/libs. The intention was to have automated releases of this library, as KPhotoAlbum now also uses it and not only Digikam anymore. As of today,

Re: attica_kde.so closing crash

2014-11-17 Thread Thomas Lübking
On Montag, 17. November 2014 00:38:03 CEST, Albert Astals Cid wrote: El Dilluns, 17 de novembre de 2014, a les 00:33:17, Thomas Lübking va escriure: You do not happen to delete a bechilded member in the destructor explicitly, are you? Why would this be wrong? Nothing* *in general, but:

Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- Review request for kdelibs, Alex Merry, Aleix Pol Gonzalez, David Faure,

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70516 --- Looks good to me. +1 Can you look into doing this in KF5

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70517 --- There's no master branch of kdelibs - Albert Astals Cid On

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 17, 2014, 3:29 p.m.) Review request for kdelibs, Alex

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
On Nov. 17, 2014, 3:26 p.m., Aleix Pol Gonzalez wrote: Looks good to me. +1 Can you look into doing this in KF5 (ECM) as well? It's not applicable since we don't define `_BSD_SOURCE` at all there. It might even work to just remove this in KDE4 as well, but I don't want to have to test

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70519 --- Looks solid to me :-) +1 - Matthias Klumpp On Nov. 17,

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70520 --- This silences the following compile warnings with newer GCC

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 17, 2014, 3:48 p.m.) Review request for kdelibs, Alex

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/ --- (Updated Nov. 17, 2014, 3:48 p.m.) Review request for kdelibs, Alex

Re: attica_kde.so closing crash

2014-11-17 Thread Jeremy Whiting
Thomas, Thanks for the pointer. I tried changing KIO::AccessManager's destructor to this: AccessManager::~AccessManager() { QObjectList childList = children(); Q_FOREACH(QObject *child, childList) { QNetworkReply *reply = qobject_castQNetworkReply*(child); if (reply != 0)

Re: desktoptojson and list properties

2014-11-17 Thread Sebastian Kügler
On Monday, November 17, 2014 02:04:51 Aleix Pol wrote: On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff m...@milianw.de wrote: On Sunday 16 November 2014 23:52:25 Milian Wolff wrote: KDevelop is currently bitten hard by a bug/limitation in desktoptojson. It does not actually understand the

Re: desktoptojson and list properties

2014-11-17 Thread Milian Wolff
On Monday 17 November 2014 18:35:51 Sebastian Kügler wrote: On Monday, November 17, 2014 02:04:51 Aleix Pol wrote: On Mon, Nov 17, 2014 at 12:24 AM, Milian Wolff m...@milianw.de wrote: snip Fine, I could add similar code to desktoptojson, but: Since desktoptojson will be called for the

Re: tagging releases

2014-11-17 Thread Albert Astals Cid
El Dilluns, 17 de novembre de 2014, a les 13:39:07, Tobias Leupold va escriure: Hi list! Hi Sorry for the potentially dumb question, but I'm very new to all this ;-) Recently, libkface has been moved from extragear to kdegraphics/libs. The intention was to have automated releases of this

Re: attica_kde.so closing crash

2014-11-17 Thread Thiago Macieira
On Sunday 16 November 2014 18:18:07 Jeremy Whiting wrote: ==22353== Address 0x1cd1b758 is not stack'd, malloc'd or (recently) free'd This looks like the case of accessing memory from a plugin that has been unloaded. Note how the backtrace started from qlibraryCleanup in qlibrary.cpp, which is

Re: Review Request 121147: Define _DEFAULT_SOURCE together with _BSD_SOURCE.

2014-11-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121147/#review70532 --- Ship it! Yep, after reading the feature_test_macros(7)

Re: attica_kde.so closing crash

2014-11-17 Thread Jeremy Whiting
Ok, how can I fix the unload order then? On Mon, Nov 17, 2014 at 12:02 PM, Thiago Macieira thi...@kde.org wrote: On Sunday 16 November 2014 18:18:07 Jeremy Whiting wrote: ==22353== Address 0x1cd1b758 is not stack'd, malloc'd or (recently) free'd This looks like the case of accessing

Re: attica_kde.so closing crash

2014-11-17 Thread Thiago Macieira
On Monday 17 November 2014 12:07:36 Jeremy Whiting wrote: Ok, how can I fix the unload order then? You don't. The libraries are unloaded in alphabetical order, but I might change that later to a QHash and then the order is arbitrary and random. Fix the problem in a different way. If necessary,

Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- Review request for kdelibs and Plasma. Repository: plasma-desktop

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/ --- (Updated Nov. 17, 2014, 2:11 p.m.) Review request for kdelibs and

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121161/#review70542 --- attica-kde/kdeplugin/kdeplatformdependent.cpp

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Albert Astals Cid
On nov. 17, 2014, 9:45 p.m., Thomas Lübking wrote: attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56 is KdePlatformDependent::~KdePlatformDependent() { if

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Thomas Lübking
On Nov. 17, 2014, 9:45 nachm., Thomas Lübking wrote: attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56 is KdePlatformDependent::~KdePlatformDependent() { if

Re: Review Request 121161: Set KIO::Integration::AccessManager to null so we don't crash on close.

2014-11-17 Thread Jeremy Whiting
On Nov. 17, 2014, 2:45 p.m., Thomas Lübking wrote: attica-kde/kdeplugin/kdeplatformdependent.cpp, line 56 https://git.reviewboard.kde.org/r/121161/diff/2/?file=328928#file328928line56 is KdePlatformDependent::~KdePlatformDependent() { if

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-17 Thread Milian Wolff
On Thursday 13 November 2014 22:47:19 Thomas Lübking wrote: On Donnerstag, 13. November 2014 22:27:44 CEST, Milian Wolff wrote: eval `dbus-launch` So can/should I just remove this? The warning is obsolete, yeah? Likely (rather, better do so) This will run a second dbus daemon and

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-17 Thread Milian Wolff
On Monday 17 November 2014 13:03:13 Milian Wolff wrote: On Thursday 13 November 2014 22:47:19 Thomas Lübking wrote: On Donnerstag, 13. November 2014 22:27:44 CEST, Milian Wolff wrote: eval `dbus-launch` So can/should I just remove this? The warning is obsolete, yeah? Likely

Re: Use KTextEditor In Custom Widget Rather Than As Central Widget of MainWindow

2014-11-17 Thread Dominik Haumann
On Sunday 16 November 2014 04:20:28 Jason Alan Smith wrote: Hello everyone, I am developing an application that helps users and developers manage a variety of database servers, and I would like to use a KTextEditor (or Kate) as my text editing widget as it has line numbering and

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-17 Thread Milian Wolff
On Monday 17 November 2014 11:05:03 Thiago Macieira wrote: On Monday 17 November 2014 13:12:34 Milian Wolff wrote: I was just told that I need to run kdeinit5 --kded manually. That does fix the issue above. But how is this supposed to work when someone launches a KF5 application from - say

Re: DBUS issues with KDE 4 and Frameworks 5

2014-11-17 Thread Thiago Macieira
On Monday 17 November 2014 20:12:41 Milian Wolff wrote: Yep, that is also what is documented on the Techbase article. Thing is, I don't want multiple dbus sessions (see the first mail of this thread). But when I log in to my KDE4 environment, the KF5 environment data, including its custom