Re: Review Request 129182: [baloo] CLazy fixes: use const ref in for loop instead object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/#review100012 --- Fix it, then Ship it! src/engine/transaction.cpp (line 4

Re: Review Request 129185: [baloo] Add a small benchmark for PostingCodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129185/#review100011 --- tests/benchmarks/positioncodectest.cpp (line 47)

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/ --- (Updated Oct. 14, 2016, 9:13 p.m.) Review request for Baloo. Changes --

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

> On Oct. 14, 2016, 8:58 p.m., Aleix Pol Gonzalez wrote: > > src/engine/transaction.cpp, line 457 > > > > > > add const The question here is - why create a temporary QList here at all - I'm now using Q_FOREACH

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/ --- (Updated Oct. 14, 2016, 9:11 p.m.) Review request for Baloo. Changes --

Review Request 129186: [baloo] Speedup PostingCodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129186/ --- Review request for Baloo. Repository: baloo Description --- This p

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/ --- (Updated Oct. 14, 2016, 8:58 p.m.) Review request for Baloo. Summary (u

Re: Review Request 129183: [baloo] CLazy fixes: removed unused member var, add Q_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/#review18 --- src/file/extractor/iohandler.h (line 34)

Re: Review Request 129182: CLazy fixes: use const ref in for loop instead object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/#review17 --- src/engine/transaction.cpp (line 457)

Review Request 129185: [baloo] Add a small benchmark for PostingCodec::encode()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129185/ --- Review request for Baloo. Repository: baloo Description --- This s

Review Request 129183: CLazy fixes: removed unused member var, add Q_OBJECT

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129183/ --- Review request for Baloo. Repository: baloo Description --- CLayz

Review Request 129182: CLazy fixes: use const ref in for loop instead object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129182/ --- Review request for Baloo. Repository: baloo Description --- While