[ANNOUNCE] GammaRay 3.0.0

2023-09-04 Thread Allen Winter
age at http://www.kdab.com/gammaray * the GammaRay wiki at https://github.com/KDAB/GammaRay/wiki * the GammaRay User Manual at https://docs.kdab.com/gammaray-manual/latest/ * the GammaRay API doc at https://docs.kdab.com/gammaray/latest/ -- Allen Winter | allen.win...@kdab.com | Senior Softw

Re: RFC: Erroring out if the platform you're building the Framework is not supported

2022-02-16 Thread Allen Winter
On Wednesday, February 16, 2022 9:42:18 AM EST Albert Astals Cid wrote: > Supported == listed in metainfo.yaml > > https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/245 > > What do you think? > > I know parsing yaml like that isn't great but it seems to work for something

Re: Fwd: KCalendarCore Require Libical 3.0

2020-11-24 Thread Allen Winter
Sorry. typo in the original message subject. This is about "Libical" not "Libcal" On Tuesday, November 24, 2020 8:13:12 AM EST Allen Winter wrote: > I plan to implement this new requirement 2 weeks from now. > unless there are good reasons against. > > -Allen &g

Fwd: KCalendarCore Require Libcal 3.0

2020-11-24 Thread Allen Winter
I plan to implement this new requirement 2 weeks from now. unless there are good reasons against. -Allen -- Forwarded Message -- Subject: KCalendarCore Require Libcal 3.0 Date: Tuesday, November 17, 2020, 12:10:22 PM EST From: Allen Winter To: KDE release coordination

Re: Gitlab Turn-off Issues

2020-06-30 Thread Allen Winter
On Sunday, June 28, 2020 12:27:41 PM EDT Allen Winter wrote: > Can we remove the Issues feature on all invent projects? > We're starting to see more and more people adding Issues. > > For KOrganizer, bshah replaced Issues with Bugzilla. > > I very much doubt we want or ar

Gitlab Turn-off Issues

2020-06-28 Thread Allen Winter
Can we remove the Issues feature on all invent projects? We're starting to see more and more people adding Issues. For KOrganizer, bshah replaced Issues with Bugzilla. I very much doubt we want or are ready to replace Bugzilla.

Re: Who merges Merge Requests, and when?

2020-06-10 Thread Allen Winter
On Wednesday, June 10, 2020 12:19:36 PM EDT Glen Ditchfield wrote: > In the Phabricator work flow, I would submit a patch, someone knowledgeable > would accept it, and I would `arc land` it. Clear and simple. > > GitLab doesn't have that "accept" step AFAIK. The KDE Wiki's Infrastructure/ >

D29223: Update Taiwanese holidays

2020-05-13 Thread Allen Winter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:b1291acbfc09: Update Taiwanese holidays (authored by nhiga, committed by winterz). REPOSITORY R175 KHolidays

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-11 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R175:7f7533260efc: holidayregion.cpp - provide translatable strings for the German regions. (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D29223: Update Taiwanese holidays

2020-05-10 Thread Allen Winter
winterz added a comment. all opposed to this patch please speak up soon REVISION DETAIL https://phabricator.kde.org/D29223 To: nhiga, winterz, cgiboudeaux, shrapnel Cc: weisi, #kde_pim, kde-frameworks-devel, shrapnel, LeGast00n, cblack, fbampaloukas, michaelh, ngraham, bruns, dvasin,

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-10 Thread Allen Winter
winterz updated this revision to Diff 82442. winterz added a comment. QLatin1-ify REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82398=82442 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29575 AFFECTED FILES

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-09 Thread Allen Winter
winterz updated this revision to Diff 82398. winterz added a comment. don't try to provide translatable string for unknown subdivisions REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29575?vs=82396=82398 BRANCH master REVISION DETAIL

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-09 Thread Allen Winter
winterz added a comment. I'm guessing it's ok to depend on K5I18N ? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29575 To: winterz, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-09 Thread Allen Winter
winterz created this revision. winterz added a reviewer: vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. winterz requested review of this revision. REVISION SUMMARY The German holiday files now all have a proper country and name since commits

EBN Going Away

2020-05-06 Thread Allen Winter
In 2005 Adriaan and I setup a little service for improving code quality which we named "The English Breakfast Network" (ebn.kde.org) Sometime soon the server that runs the EBN will be taken down and I have no intention of moving it elsewhere. We could have jenkins take over if someone wants to

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz added a comment. I committed this one for Weisi Dai REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R175:682b18f75ca7: holidays/plan2/holiday_gb-sct_en-gb (authored by weisi, committed by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29374?vs=81773=81953

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-04 Thread Allen Winter
winterz accepted this revision. winterz added a comment. do you need me to commit this for you? my fault. I should have run the test that looks for the syntax errors .. I don't recall doing that. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To:

D29415: Add holiday file for DE-BE (Germany/Berlin)

2020-05-04 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I don't know German and I don't know the Berlin holidays. but the tests pass and in general things look fine. REPOSITORY R175 KHolidays BRANCH master REVISION DETAIL

Re: Information regarding upcoming Gitlab Migration

2020-05-01 Thread Allen Winter
On Sunday, April 26, 2020 9:40:01 PM EDT Bhushan Shah wrote: > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for the repositories on

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Allen Winter
On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different projects > > > > that

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Allen Winter
On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different projects > > > > that

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Allen Winter
On Thursday, April 30, 2020 5:15:43 PM EDT Albert Astals Cid wrote: > El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > > > We have made a big fuss in the past about having different projects > > > > that

D28874: Taiwanese holidays

2020-04-17 Thread Allen Winter
winterz added a comment. In D28874#650661 , @ngraham wrote: > Do you not have commit access? I thought you were the maintainer based on the repo's history! Yes of course. I'm asking for assistance at this time. REPOSITORY R175

D28891: Nicaragua Holidays

2020-04-17 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. other than the indentation in the .qrc file this is good to go.. tests pass would appreciate if someone would commit this for us. (after fixing the indentation) REPOSITORY R175

D28874: Taiwanese holidays

2020-04-17 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks good. all tests pass. could someone commit this for us? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz

D28874: Taiwanese holidays

2020-04-17 Thread Allen Winter
winterz added a comment. remove holidays/0001-added-holiday_tw_zh-and-updated-holiday.qrc.patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28891: Nicaragua Holidays

2020-04-17 Thread Allen Winter
winterz added inline comments. INLINE COMMENTS > holidays.qrc:101 > plan2/holiday_mx_es > -plan2/holiday_na_en-gb > + plan2/holiday_na_en-gb > plan2/holiday_nc_fr realign the indentation > holidays.qrc:103 > plan2/holiday_nc_fr > +

D28874: Taiwanese holidays

2020-04-16 Thread Allen Winter
winterz added a comment. problems: - "religous" should be "religious" - missing ':' at the start of Constitution Day - missing ':' at the start of Christmas Day REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc:

D28874: Taiwanese holidays

2020-04-16 Thread Allen Winter
winterz requested changes to this revision. winterz added a comment. This revision now requires changes to proceed. testing fails. don't know why yet. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren, winterz Cc: winterz,

D28874: Taiwanese holidays

2020-04-16 Thread Allen Winter
winterz added a comment. you need to add the change to holidays.qrc to this patch REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28874 To: shrapnel, #vdg, Zren Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28850: Updated Romanian holidays

2020-04-15 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks fine. I tested it. can someone commit this please? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D28850 To: sionescu, winterz Cc: winterz,

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter
winterz added a comment. I don't know how things are done in frameworks but it seems to me that the KF5_VERSION (see top of kcalendarcore/CMakeLists.txt) needs to become 5.70.0 now REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To:

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter
winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R172 KCalendar Core BRANCH props REVISION DETAIL https://phabricator.kde.org/D28834 To: nicolasfella, #frameworks, #kde_pim, vkrause, winterz Cc: winterz, kde-pim, fbampaloukas, dcaliste, dvasin,

D28834: Add metadata properties to calendar

2020-04-14 Thread Allen Winter
winterz added a comment. looks good. nice touch using Q_EMIT. INLINE COMMENTS > calendar_p.h:81 > +QString mIcon; > +CalendarType mType; > }; CalendarType mType = ReadWrite ? REPOSITORY R172 KCalendar Core REVISION DETAIL https://phabricator.kde.org/D28834 To:

D27363: KHolidays: Convert license statements to SPDX expressions

2020-02-25 Thread Allen Winter
winterz accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr, winterz Cc: cgiboudeaux, winterz, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

Re: Banning QNetworkAccessManager

2020-02-20 Thread Allen Winter
On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > escriure: > > Additionally, improved documentation, a possible KNAM and/or driving the > > QNAM > > changes upstream can still be done alongside

Re: Banning QNetworkAccessManager

2020-02-20 Thread Allen Winter
On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > escriure: > > Additionally, improved documentation, a possible KNAM and/or driving the > > QNAM > > changes upstream can still be done alongside

Re: Banning QNetworkAccessManager

2020-02-20 Thread Allen Winter
On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > escriure: > > Additionally, improved documentation, a possible KNAM and/or driving the > > QNAM > > changes upstream can still be done alongside

D27419: Update Japanese holidays

2020-02-16 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R175:1f9332f8f322: Update Japanese holidays (authored by winterz). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27419?vs=75732=75777 REVISION DETAIL

D27419: Update Japanese holidays

2020-02-15 Thread Allen Winter
winterz accepted this revision. winterz added a comment. I tested these changes locally. works do you have commit access? REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: #kde_pim, kde-frameworks-devel,

D27363: KHolidays: Convert license statements to SPDX expressions

2020-02-15 Thread Allen Winter
winterz added a comment. looks ok to me. INLINE COMMENTS > cgiboudeaux wrote in lunarphase.cpp:6 > This looks suspicious > > @winterz ? no, it's fine. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27363 To: cordlandwehr Cc: cgiboudeaux, winterz,

D26167: Update holidays and add flagdays and namedays for Sweden

2020-01-27 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. looks fine. I also tested and the changes don't break anything. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D26167 To: riiga, #kde_pim, winterz Cc:

Check for Missing Tooltips and WhatsThis

2020-01-26 Thread Allen Winter
You might not know that Krazy can find widgets-n-stuff with missing tooltip, whatsthis, statustip or sethelptext This is an optional Krazy check that you need to enable in your project .krazy file. The "tipsandthis" check has been available since 2008 and haven't seen it used very much. It

D25753: EBN extra-cmake-modules transport cleanup

2019-12-05 Thread Allen Winter
winterz added a comment. please send me a list of urls that don't have https: and I'll add them to the whitelist REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25753 To: jhayes, apol, cgiboudeaux Cc: winterz, cgiboudeaux, kde-frameworks-devel,

Re: Blacklisting of PIM from the CI system

2019-12-03 Thread Allen Winter
On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > The complexity of the dependency graph is also a problem for onboarding new > people, and with kdelibs4support gone IMHO the largest technical dept here. > It's being worked on, albeit slowly, currently we are losing ~1 module

Re: Blacklisting of PIM from the CI system

2019-12-03 Thread Allen Winter
On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > The complexity of the dependency graph is also a problem for onboarding new > people, and with kdelibs4support gone IMHO the largest technical dept here. > It's being worked on, albeit slowly, currently we are losing ~1 module

D25106: Also allow invoking session restoration logic when apps are manually launched

2019-11-26 Thread Allen Winter
winterz added a comment. yay! REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To: ngraham, davidedmundson, #frameworks, dfaure, vkrause Cc: winterz, lbeltrame, mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-11-08 Thread Allen Winter
winterz added a comment. FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2. Although I am skipping the .htignore's, there will still be lots of false positives especially in the test programs. Let's see what happens. -Allen REPOSITORY

D24826: Enforce 100 chars line width

2019-10-21 Thread Allen Winter
winterz added a comment. I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short. 240 may be a bit too long: in my personal coding style scripts I try to limit to 120. even 120 is hard to achieve sometimes. I feel that 240 is a

Re: Get Hot New Stuff Dead or Alive?

2019-10-14 Thread Allen Winter
On Sunday, October 13, 2019 1:57:06 PM EDT Ben Cooksley wrote: > On Mon, Oct 14, 2019 at 6:06 AM Allen Winter wrote: > > > > or maybe renamed? > > Hi Allen, > > > > > How do I find out if there are any GHNS for KOrganizer. > > The Import->GHNS m

Get Hot New Stuff Dead or Alive?

2019-10-13 Thread Allen Winter
or maybe renamed? How do I find out if there are any GHNS for KOrganizer. The Import->GHNS menu in KOrganizer starts and I see the import dialog ok. but that dialog is empty. I need to know if something is broken with the KOrganizer implementation or if I should remove that feature. Or maybe

D23930: Set XCB to required if building the X backend

2019-09-13 Thread Allen Winter
winterz added a comment. +1 will fix the problem I reported. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D23930 To: davidedmundson, zzag Cc: winterz, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KCalendarCore plugins/datasources?

2019-08-12 Thread Allen Winter
On Monday, August 12, 2019 6:49:48 AM EDT Daniel Vrátil wrote: > On Sunday, 11 August 2019 12:12:10 CEST Bhushan Shah wrote: > > [I am not subscribed to kde-pim list, please keep me or k-f-d in CC] > > > > Hello, > > Hi Bhushan, > > > > > So yesterday I was discussing this with the Volker in

Re: New framework: KCalCore

2019-07-18 Thread Allen Winter
On Thursday, July 18, 2019 12:18:36 PM EDT Volker Krause wrote: > On Wednesday, 17 July 2019 01:51:42 CEST Aleix Pol wrote: > > On Tue, Jul 16, 2019 at 6:10 PM Volker Krause wrote: > > > On Monday, 15 July 2019 18:43:42 CEST Aleix Pol wrote: > > > > On Fri, Jul 12

Re: New framework: KCalCore

2019-07-12 Thread Allen Winter
On Friday, July 12, 2019 12:23:58 PM EDT Volker Krause wrote: > With the 19.08 release approaching (and thus the deadline for incompatible > changes if we go ahead with this plan), I'd like to raise this again for > getting to a decision :) > > Summary of what happened in the past weeks: > -

[ANNOUNCE] GammaRay 2.11.0

2019-07-05 Thread Allen Winter
latest/ * the GammaRay API doc at https://docs.kdab.com/gammaray/latest/ -- Allen Winter | allen.win...@kdab.com | Senior Software Engineer KDAB (USA) LLC, a KDAB Group company Tel. USA +1-866-777-KDAB(5322) ext3 KDAB - The Qt, C++ and OpenGL Experts smime.p7s Description: S/MIME cryptog

Re: New framework: KCalCore

2019-04-30 Thread Allen Winter
Clazy is complaining about missing assign operators. Do we care? If so, I can take a look at adding them or if anyone else wants to do that. -Allen ./src/calendar.cpp line 305: for (it = vals.constBegin(); it != vals.constEnd(); ++it) { => Using assign operator but class QTypedArrayData

Re: New framework: KCalCore

2019-04-14 Thread Allen Winter
On Sunday, April 14, 2019 7:31:41 AM EDT David Faure wrote: > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar standard based on libical, > > I

D19092: Add bison minimum version of 2.4.1 due to %code

2019-03-28 Thread Allen Winter
winterz accepted this revision. winterz added a comment. This revision is now accepted and ready to land. I'm for this. I never created such a patch because I wasn't sure what minimum version was needed. On Mac, what I do is install the homebrew bison and export

EBN Still Needed?

2019-03-26 Thread Allen Winter
I was notified today that the Krazy runs on the EBN have been stuck (due to a stale lockfile) for over 3 months. Is this an indication that nobody looks at the EBN reports any longer? I still maintain Krazy and am happy to make modifications, but I don't see the point unless someone actually

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

2019-03-23 Thread Allen Winter
winterz added a comment. this would be a nice addition to Krazy. on my todo list. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19996 To: vkrause Cc: winterz, knauss, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

[EBN] Re: Fwd: Cron /home/api/bin/update-all

2018-12-29 Thread Allen Winter
This is about investigating brokenness with the API generation on the EBN machine. If you know anything about it please contact me so we can fix properly. -Allen On Thursday, December 27, 2018 8:13:04 AM EST Allen Winter wrote: > Do either of you know why parsedoxlog.sh was removed? > An

D16300: Remove double underscore (__) from header include guards

2018-10-18 Thread Allen Winter
winterz added a comment. fyi, krazy in strict mode will check for leading and trailing underscores on the include guards. I don't run krazy in strict mode on the EBN, however. I could make this a standard check if we want so the EBN would pick it up too. REPOSITORY R39 KTextEditor

D14524: Fix compiler warning -Wimplicit-fallthrough

2018-07-31 Thread Allen Winter
winterz added a comment. agree that Q_FALLTHROUGH(); is a better idea. it doesn't duplicate code and it informs the reader that the fallthrough is intentional REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14524 To: dhaumann, vkrause Cc: winterz,

D14154: Add

2018-07-21 Thread Allen Winter
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R175:8c49f9b3dfe2: more Japanese holiday updates from phanect (authored by winterz). REPOSITORY R175 PIM: KHolidays

D13828: Revert "updated Japanese holidays (in Japanese and English)"

2018-07-09 Thread Allen Winter
winterz added a comment. please close this REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D13828 To: phanect, #kde_pim, #frameworks, winterz, mlaurent Cc: mlaurent, winterz, kde-pim, dvasin, rodsevich, vkrause, knauss, dvratil

D13812: Revert "updated Japanese holidays (in Japanese and English)"

2018-07-08 Thread Allen Winter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R175:1c2ecfbf9570: holiday_jp_ja, holiday_jp-en_us - updated Thanks for the patch phanect (authored by winterz).

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2018-05-07 Thread Allen Winter
This revision was automatically updated to reflect the committed changes. Closed by commit R237:dba6d83ee412: kcfg.xsd - do not require a kcfgfile element (authored by winterz). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7415?vs=18394=33780 REVISION

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2018-04-28 Thread Allen Winter
winterz added a comment. ping. this is still relevant. some kconfigxt files don't set the kcfgfile element. to name a few: mailcommon/src/settings/mailcommon.kcfg kdepim-runtime/agents/newmailnotifier/newmailnotifieragentsettings.kcfg

Re: Changes to networkmanager-qt - breakage in plasma-workspace

2018-03-30 Thread Allen Winter
krop already fixed that On Thursday, March 29, 2018 6:21:41 PM EDT Ben Cooksley wrote: > Hi Jan, > > It seems that as part of your recent changes to networkmanager-qt to > increase the dependency to 1.0.0 you've made some other changes which > mean the appropriate include paths are no longer

Re: KHolidays as Framework (redux)

2018-01-15 Thread Allen Winter
015 from what I can see. > > Regards, > Volker > > > PS: please also inform distributi...@kde.org, if the switch has a fixed > > date. > > On Sonntag, 14. Januar 2018 15:59:46 CET Allen Winter wrote: > > > I don't object to making KHolidays a framewor

Re: KHolidays as Framework (redux)

2018-01-14 Thread Allen Winter
I don't object to making KHolidays a framework. I kinda object to the short timeline. I wanted to finish up some BIC cleaning. No API changes planned at this time. I'll try to hurry. On Sunday, January 14, 2018 4:20:38 AM EST Volker Krause wrote: > On Tuesday, 6 September 2016 12:03:15 CET

Re: Krazy source code

2017-11-12 Thread Allen Winter
On Sunday, November 12, 2017 1:02:42 PM EST Albert Astals Cid wrote: > El diumenge, 12 de novembre de 2017, a les 13:52:24 CET, Elvis Angelaccio va > escriure: > > Hi, > > where do I find the krazy source code? It doesn't seem to be listed under > > https://cgit.kde.org/ > > > > Google tells me

Commit Notifications

2017-10-12 Thread Allen Winter
I still get email notifications on commits to a few repos. How do I unsubscribe from the ones I no longer care about? How do I subscribe to new repos I'm currently interested in? searching the wiki isn't helping. I see mention of CommitFilter, but that's dead. I tried watching github mirrors,

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-09-16 Thread Allen Winter
winterz added a comment. comments? thoughts? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz Cc: #frameworks

Re: Review Request 129381: kconfig fix kconfigskeletontest

2017-08-30 Thread Allen Winter
--- before some of the tests fail and now they all pass. Thanks, Allen Winter

Re: KMarkdownWebView (kpart) in KDE Review

2017-08-22 Thread Allen Winter
One Krazy issue about making an explicit ctor, see http://ebn.kde.org/krazy/reports/kdereview/kmarkdownwebview/src/index.html I ran clazy too and it found no issues. On Monday, August 21, 2017 6:18:19 PM EDT Friedrich W. H. Kossebau wrote: > Hi, > > KMarkdownWebView today entered KDE Review.

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-08-19 Thread Allen Winter
winterz reclaimed this revision. winterz added a comment. un-abandon. I retested and it does work as intended REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz Cc: #frameworks

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-08-19 Thread Allen Winter
winterz abandoned this revision. winterz added a comment. not good. ignore. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D7415 To: winterz Cc: #frameworks

D7415: kconfig: kcfg.xsd do not require a kcfgfile

2017-08-19 Thread Allen Winter
winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY I'm seeing quite a few kconfigxt files that don't set the kcfgfile element. This patch changes the xsd so such files will validate.

Re: kdesrc-build: git pre-commit hooks

2017-08-01 Thread Allen Winter
On Monday, July 31, 2017 9:05:09 PM EDT Michael Pyne wrote: > On Sat, Jul 29, 2017 at 06:24:54PM -0400, Allen Winter wrote: > > Howdy, > > > > Is there a way to add a git hooks automagically with the git clones done by > > kdesrc-build? > > > > I have

kdesrc-build: git pre-commit hooks

2017-07-29 Thread Allen Winter
Howdy, Is there a way to add a git hooks automagically with the git clones done by kdesrc-build? I have a pre-commit hook that I'd like to have for all my kde src repos. also I have a pre-push hook , but that's less important to me. a post clone command, something as simple this would be

D6936: ECMGeneratePriFile - mac os x framework builds of Qt

2017-07-26 Thread Allen Winter
winterz abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6936 To: winterz, dfaure Cc: #frameworks, #build_system

D6936: ECMGeneratePriFile - mac os x framework builds of Qt

2017-07-26 Thread Allen Winter
winterz created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY on mac os x framework builds of Qt, QT/include is not added to the list of include path,. this patch looks up one

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter
winterz closed this revision. winterz added a comment. see https://phabricator.kde.org/R240:db46fb7c2fdcfbff5f8a0445e4d055cf4388ead8 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system, #windows, kfunk Cc: nalvarez,

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-18 Thread Allen Winter
winterz added a comment. In https://phabricator.kde.org/D6762#126463, @nalvarez wrote: > Looks reasonable – although I wonder why on earth you're building KDE stuff on Cygwin... fun. as an experiment. i'm curious. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Allen Winter
winterz added reviewers: skelly, Build System. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D6762 To: winterz, skelly, #build_system Cc: #frameworks, #build_system

D6762: ECM: KDECompilerSettings LINKER_FLAGS on Cygwin

2017-07-17 Thread Allen Winter
winterz created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. REVISION SUMMARY Cygwin systems aren't ELF based so don't try to pass --enable-new-dtags to 'ld' else you get

Re: Building kdelibs4support on Mac

2017-06-07 Thread Allen Winter
On Wednesday, June 7, 2017 4:04:13 PM EDT Garvit Khatri wrote: > Hi, > > I am trying to build kdelibs4support on MacOs Sierra (v10.12.4 Beta) all > the dependencies are already built and installed using kdesrc-build. Now, > when I try to build kdelibs4support using kdesrc-build I get the

D5828: fix plasma-frameworks build without kwayland

2017-06-05 Thread Allen Winter
winterz closed this revision. winterz added a comment. committed https://phabricator.kde.org/R242:6c03c15c08a4b585bc3f320865858e4c2832f70b REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5828 To: winterz, mart, davidedmundson, bshah, #plasma Cc:

D5975: breeze-icons: don't look for bash on Windows

2017-05-28 Thread Allen Winter
winterz closed this revision. winterz added a comment. committed in https://phabricator.kde.org/R266:09291a2b3ecf03577b93c6d4cedc28927668e571 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5975 To: winterz, aacid Cc: aacid, #frameworks

D5975: breeze-icons: don't look for bash on Windows

2017-05-27 Thread Allen Winter
winterz edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5975 To: winterz Cc: aacid, #frameworks

D5975: breeze-icons: don't look for bash on Windows

2017-05-26 Thread Allen Winter
winterz added a comment. Because Hannah told me the script doesn't work on Windows. let's look at validate-svg.sh. you need a working unix 'find' command (not the WIndows find command) as well as xmllint for the bash script to work. REPOSITORY R266 Breeze Icons REVISION DETAIL

D5975: breeze-icons: don't look for bash on Windows

2017-05-26 Thread Allen Winter
winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The GoW package on Windows has bash. We don't want to find bash on Windows. REPOSITORY R266 Breeze Icons REVISION DETAIL

D5828: fix plasma-frameworks build without kwayland

2017-05-13 Thread Allen Winter
winterz created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY fixes the compile errors in plasmaquick/dialog.cpp if you don't have kwayland TEST PLAN compile it REPOSITORY R242 Plasma Framework

D5646: Solve problem with microphone-sensitivity-medium

2017-04-29 Thread Allen Winter
winterz added a comment. my commit was a hack to get the validator to pass. this patch is far more extensive. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5646 To: patrickelectric, #kate, andreaska Cc: ltoscano, winterz, #frameworks

D5456: KDoctools: build on Mac with docbook from homebrew

2017-04-16 Thread Allen Winter
winterz closed this revision. winterz added a comment. committed in https://phabricator.kde.org/R238:5c5bfc2d838993f7d4be1885dff822e3794c529f REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D5456 To: winterz, ltoscano, kfunk Cc: kfunk, #frameworks, #documentation,

D5456: KDoctools: build on Mac with docbook from homebrew

2017-04-16 Thread Allen Winter
winterz updated this revision to Diff 13520. winterz added a comment. I added comments. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5456?vs=13448=13520 REVISION DETAIL https://phabricator.kde.org/D5456 AFFECTED FILES cmake/FindDocBookXML4.cmake

D5456: KDoctools: build on Mac with docbook from homebrew

2017-04-14 Thread Allen Winter
winterz created this revision. Restricted Application added projects: Frameworks, Documentation. Restricted Application added subscribers: Documentation, Frameworks. REVISION SUMMARY On Mac, homebrew installs the docbook-xml and docbook-xls files under /usr/local/opt so add searchpaths

  1   2   3   4   >