Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

> On Nov. 27, 2016, 7:17 p.m., Konstantinos Smanis wrote: > > I can confirm that the patch indeed resolves the natural sorting issue in > > KDirSortFilterProxyModel, which is a logical bug (an omission) introduced > > at some point during the KF5 kio port. It's been there since the initial >

Re: Review Request 128574: Enable natural sorting on QCollator in KDirSortFilterProxyModel

icMode(m_naturalSorting);` instead. It would also take care of disabling the natural sorting, if necessary. - Elvis Angelaccio On Jan. 8, 2017, 4:13 p.m., Mathis Beer wrote: > > --- > This is an automatically generated e-mail.

D5541: Set the icon for the Donate action

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D5541 To: ltoscano, elvisangelaccio, aacid Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

This revision was automatically updated to reflect the committed changes. Closed by commit R236:8a1c758516fd: KPasswordDialog: don't hide visibility action in plaintext mode (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

This revision was automatically updated to reflect the committed changes. Closed by commit R236:6976a54f2355: KNewPasswordWidget: don't hide visibility action in plaintext mode (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

elvisangelaccio added a comment. Ok, I just wanted to be sure :) REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise the user cannot tell whether what's going to be typed will be visible or not. Same fix as in

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

elvisangelaccio added a comment. @cfeck Ping? REPOSITORY R236 KWidgetsAddons BRANCH kpassworddialog-leak REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, fvogt, cfeck Cc: #frameworks

D5030: kioexec: delegate upload to a kded module

This revision was automatically updated to reflect the committed changes. elvisangelaccio marked an inline comment as done. Closed by commit R241:a7758fb66481: kioexec: delegate upload to a kded module (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT

D4847: KAuth integration in document saving

elvisangelaccio added a comment. In https://phabricator.kde.org/D4847#101163, @aacid wrote: > How is this related with https://phabricator.kde.org/T5202 ? Once implemented, it will be possible to get kauth for free when calling (for example) `KIO::move()`. Not sure if that's

D5030: kioexec: delegate upload to a kded module

elvisangelaccio updated this revision to Diff 13202. elvisangelaccio marked an inline comment as done. elvisangelaccio added a comment. - Tested against latest master, now the module is properly cleaned up upon kiod destruction. - Use iterators for the map REPOSITORY R241 KIO CHANGES

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

elvisangelaccio added a comment. In https://phabricator.kde.org/D5312#100027, @fvogt wrote: > Tested locally, works fine! > > The behaviour is a bit unexpected, but IMO correct: > > - Enter a password > - Make it visible > - Delete it > - Toggle visibility ->

D5030: kioexec: delegate upload to a kded module

elvisangelaccio updated this revision to Diff 13163. elvisangelaccio edited the summary of this revision. elvisangelaccio added a comment. Addressed all David's issues. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5030?vs=12414=13163 REVISION DETAIL

D5030: kioexec: delegate upload to a kded module

elvisangelaccio added a comment. Ok I got it working, thanks. There is a downside though, it seems the module is never deleted, not even when kiod5 quits. Bug in kiod? It was deleted as expected with kded, instead. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5030

D5030: kioexec: delegate upload to a kded module

elvisangelaccio marked 3 inline comments as done. elvisangelaccio added a comment. In https://phabricator.kde.org/D5030#98126, @dfaure wrote: > Nice idea. > > Can you use kiod rather than kded? Same plugin mechanism exactly but this way no dependency on kded. How do I do

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

elvisangelaccio added a dependent revision: D5313: Add workaround for bug in QLineEdit's clear button. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5312 To: elvisangelaccio, cfeck, fvogt Cc: #frameworks

D5312: KPasswordDialog: don't hide visibility action in plaintext mode

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise the user cannot tell whether what's going to be typed will be visible or not. BUG: 378276 FIXED-IN: 5.34

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > <https://git.reviewboard.kde.org/r/129983/diff/5/?file=492986#file492986line1> > > > > I don't see the advantage of using a single kauth action.

Re: How am i supposed to use arc? - was - Re: Phabricator: All repositories registered - upcoming workflow changes

On Sun, Mar 26, 2017 at 6:33 PM, Albert Astals Cid wrote: > El diumenge, 29 de gener de 2017, a les 8:32:21 CEST, Ben Cooksley va > escriure: >> Hi everyone, >> >> We've just completed the registration of all mainline repositories >> (not including Websites or Sysadmin namespaced

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 25, 2017, 4:30 p.m., Elvis Angelaccio wrote: > > src/ioslaves/file/file.cpp, line 1428 > > <https://git.reviewboard.kde.org/r/129983/diff/5/?file=492983#file492983line1428> > > > > I tried to delete a folder (`kioclient5 remove /opt/test/`) b

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > <https://git.reviewboard.kde.org/r/129983/diff/5/?file=492986#file492986line1> > > > > I don't see the advantage of using a single kauth action.

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 22, 2017, 10:08 a.m., Elvis Angelaccio wrote: > > src/ioslaves/file/kauth/file.actions, lines 1-5 > > <https://git.reviewboard.kde.org/r/129983/diff/5/?file=492986#file492986line1> > > > > I don't see the advantage of using a single kauth action.

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

(`kioclient5 remove /opt/test/`) but I didn't get this warning. - Elvis Angelaccio On March 14, 2017, 2:48 p.m., Chinmoy Ranjan Pradhan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

we could allow a more fine-grained control. For example, a sysadmin could decide that the users can create files in write protected locations, but they cannot delete existing files. - Elvis Angelaccio On March 14, 2017, 2:48 p.m., Chinmoy Ranj

D5092: [KMessageWidget] Fix wrong size hint when animatedShow() is called with a hidden parentWidget()

elvisangelaccio accepted this revision. elvisangelaccio added a comment. This revision is now accepted and ready to land. I cannot reproduce that bug but the patch looks good to me. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D5092 To: cfeck, kossebau,

D5066: Provide device type for Low Energy devices

This revision was automatically updated to reflect the committed changes. Closed by commit R269:fcab8c31897e: Provide device type for Low Energy devices (authored by elvisangelaccio). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5066?vs=12507=12543

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 13, 2017, 12:10 p.m., Elvis Angelaccio wrote: > > I'm not sure if we should show the warning dialog at the kio_file level. > > This would result in a double dialog when deleting files with Shift+Del > > from file managers. What about making jobuidelegate.

D5066: Provide device type for Low Energy devices

elvisangelaccio edited the test plan for this revision. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D5066 To: elvisangelaccio, drosca Cc: #frameworks

D5066: Provide device type for Low Energy devices

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Bluetooth Low Energy devices have an invalid class value, so we cannot use it to deduce the type of the device. Instead we can use

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

> On March 13, 2017, 12:10 p.m., Elvis Angelaccio wrote: > > I'm not sure if we should show the warning dialog at the kio_file level. > > This would result in a double dialog when deleting files with Shift+Del > > from file managers. What about making jobuidelegate.

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

at the kio_file level. This would result in a double dialog when deleting files with Shift+Del from file managers. What about making jobuidelegate.cpp smarter? It could show a more "scary" message if the file that's being deleted is write-protected. - Elvis Angelaccio On March 9, 2017

D5030: kioexec: delegate upload to a kded module

elvisangelaccio edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5030 To: elvisangelaccio, dfaure Cc: #frameworks

D5030: kioexec: delegate upload to a kded module

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY This introduces a kded module that kioexec can use to watch the cached files for changes. This allows kioexec to be fully

D5023: Restore Cancel button shortcut

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D5023 To: skalinichev, elvisangelaccio Cc: #frameworks

Re: Review Request 129985: [kio-extras] Thumbs for audio files

/audiothumbnail.desktop (line 5) <https://git.reviewboard.kde.org/r/129985/#comment68421> You can drop this translation, it will be overridden by scripty anyway. - Elvis Angelaccio On March 6, 2017, 5:44 a.m., Anthony Fieroni

Re: Review Request 129983: [RFC] PoC patch for polkit support in kio.

ally generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129983/ > --- > > (Updated March 6, 2017, 3:51 p.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. >

Re: Review Request 129985: [kio-extras] Thumbs for audio files

p.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kio-extras > > > Description > --- > > ^^ > > > Diffs > - > > cmake/FindTaglib.cmake PRE-CREATION > thumbnail/CMakeList

Re: Review Request 129985: [kio-extras] Thumbs for audio files

tps://git.reviewboard.kde.org/r/129985/#comment68381> `DrawFrame` has been recently deprecated, see https://cgit.kde.org/kio-extras.git/commit/?id=db7f8d0c945880b0fbb5ea9ad8ed6817d6ba0340 - Elvis Angelaccio On March 5, 2017, 3:02 p.m., Anthony Fieroni

Re: Review Request 129985: [kio-extras] Thumbs for audio files

> On March 5, 2017, 2 p.m., Elvis Angelaccio wrote: > > thumbnail/CMakeLists.txt, lines 241-243 > > <https://git.reviewboard.kde.org/r/129985/diff/2/?file=492266#file492266line241> > > > > This does not work, if you need to do: > >

Re: Review Request 129985: [kio-extras] Thumbs for audio files

TAGLIB_FOUND) install(FILES audiothumbnail.desktop DESTINATION ${SERVICES_INSTALL_DIR}) endif() ``` thumbnail/audiocreator.h (line 36) <https://git.reviewboard.kde.org/r/129985/#comment68375> Not needed, remove it. - Elvis Angelaccio On March 5, 2017, 11:27 a.m., Ant

Re: Review Request 129985: [kio-extras] Thumbs for audio files

reviewboard.kde.org/r/129985/ > --- > > (Updated March 5, 2017, 11:27 a.m.) > > > Review request for KDE Frameworks, David Faure and Elvis Angelaccio. > > > Repository: kio-extras > > > Descrip

Re: Review Request 129985: [kio-extras] Thumbs for audio files

h (line 26) <https://git.reviewboard.kde.org/r/129985/#comment68368> Prefer `#include ` thumbnail/audiothumbs.h (line 34) <https://git.reviewboard.kde.org/r/129985/#comment68369> Prefer `override`, same below. - Elvis Angelaccio On March 5, 2017, 4:

Re: Review Request 129741: Add renaming capability to ioslaves

- Using the new `supportsRenaming()` api from Dolphin, F2 in Trash is now disabled. More context in https://git.reviewboard.kde.org/r/129714 Thanks, Elvis Angelaccio

Re: Review Request 129741: Add renaming capability to ioslaves

gt; > more precision, depending on the actual URLs. What do you think? > > > > Of course the alternative (which is actually simpler short term) is to > > implement renaming in kio_trash ;) > > Actual renaming should be easy, moving between subdirs is a bit more tricky &

Re: Review Request 129741: Add renaming capability to ioslaves

gt; > more precision, depending on the actual URLs. What do you think? > > > > Of course the alternative (which is actually simpler short term) is to > > implement renaming in kio_trash ;) > > Actual renaming should be easy, moving between subdirs is a bit more tricky &

Re: Review Request 129741: Add renaming capability to ioslaves

gt; > more precision, depending on the actual URLs. What do you think? > > > > Of course the alternative (which is actually simpler short term) is to > > implement renaming in kio_trash ;) > > Actual renaming should be easy, moving between subdirs is a bit more tricky &

[Differential] [Closed] D4690: Import remote ioslave from plasma-workspace

This revision was automatically updated to reflect the committed changes. Closed by commit R241:786e5525a00c: Import remote ioslave from plasma-workspace (authored by elvisangelaccio). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4690?vs=11620=11696#toc REPOSITORY R241 KIO CHANGES

[Differential] [Updated, 901 lines] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio updated this revision to Diff 11620. elvisangelaccio added a comment. - Removed redundant dir check - Removed unused include REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4690?vs=11597=11620 BRANCH import-remote REVISION DETAIL

[Differential] [Commented On] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio added a comment. In https://phabricator.kde.org/D4690#88350, @ltoscano wrote: > Is it an import with the git history as well? Initially I wanted to do that, but then I decided against it because it's not worth the effort imho. There are very few changes and a lot

[Differential] [Commented On] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio added a comment. In https://phabricator.kde.org/D4690#88306, @dfaure wrote: > I know this isn't your code and you're just moving it to solve a dependency issue. No problem, go ahead. > > But while at it I took at it, I look at the code and found a few issues, feel

[Differential] [Updated, 909 lines] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio updated this revision to Diff 11597. elvisangelaccio marked 2 inline comments as done. elvisangelaccio added a comment. - renamed kded module to allow co-installability with plasma-workspace <= 5.9 - fixed issues spotted by David REPOSITORY R241 KIO CHANGES SINCE LAST

[Differential] [Updated] D3530: Import plasma-workspace kioslaves

elvisangelaccio removed a dependent revision: D3531: Drop remote ioslave, will be in KIO 5.32. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, #frameworks, #plasma, dfaure Cc: mart, aacid,

[Differential] [Updated] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio added a dependent revision: D3531: Drop remote ioslave, will be in KIO 5.32. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4690 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, dfaure, davidedmundson

[Differential] [Updated, 919 lines] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio updated this revision to Diff 11560. elvisangelaccio added a comment. Drop Messages.sh REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4690?vs=11554=11560 BRANCH import-remote REVISION DETAIL https://phabricator.kde.org/D4690 AFFECTED

[Differential] [Abandoned] D4691: Import remote ioslave from plasma-workspace

elvisangelaccio abandoned this revision. elvisangelaccio added a comment. arcanist fuck-up, sorry. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4691 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio Cc: #frameworks

[Differential] [Request, 919 lines] D4691: Import remote ioslave from plasma-workspace

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY As discussed on plasma-devel, the `remote:/` ioslave is used also by Dolphin, so this move will allow to drop plasma-workspace as

[Differential] [Commented On] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio added a comment. About the co-installability problem: kio 5.32 will install the ioslave plugin as `$QT_PLUGIN_PATH/kf5/kio/remote.so`, while plasma-workspace 5.9 installs `$QT_PLUGIN_PATH/kio_remote.so`. So far so good. The only conflict is on the kded plugin

[Differential] [Abandoned] D3530: Import plasma-workspace kioslaves

elvisangelaccio abandoned this revision. elvisangelaccio added a comment. I've decided to keep it simple and only move `remote:/` for now. Please continue in https://phabricator.kde.org/D4690. REVISION DETAIL https://phabricator.kde.org/D3530 EMAIL PREFERENCES

[Differential] [Request, 921 lines] D4690: Import remote ioslave from plasma-workspace

elvisangelaccio created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY As discussed on plasma-devel, the `remote:/` ioslave is used also by Dolphin, so this move will allow to drop plasma-workspace as

Re: Exporting KFilePlaceEditDialog

On Sun, Feb 19, 2017 at 6:51 PM, Albert Astals Cid <aa...@kde.org> wrote: > El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va > escriure: >> Hi, >> currently KFilePlaceEditDialog is not exported by kfilewidgets. As I >> understand it, it's su

Exporting KFilePlaceEditDialog

Hi, currently KFilePlaceEditDialog is not exported by kfilewidgets. As I understand it, it's supposed to be used only through KFilePlacesView (that's what gwenview and konqueror do). However, Dolphin is using its own implementation of KFilePlacesModel/KFilePlacesView. This is why Dolphin has its

[Differential] [Closed] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

This revision was automatically updated to reflect the committed changes. Closed by commit R236:8ab5a291e855: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero (authored by elvisangelaccio). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

elvisangelaccio added a comment. In https://phabricator.kde.org/D4564#86076, @cfeck wrote: > Does calling setHideDelay(0) also need to immediately hide()? It seems not necessary, `setHideDelay(0)` will set a 0 interval on the timer, which causes `timeout` to be emitted (and this

[Differential] [Request, 8 lines] D4564: KToolTipWidget: hide tooltip in enterEvent if hideDelay is zero

elvisangelaccio created this revision. elvisangelaccio added a reviewer: cfeck. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Otherwise the tooltip will stay visible when the mouse cursor (by accident) hovers it.

[Differential] [Closed] D4496: Don't use KConfig keys with backslashes

This revision was automatically updated to reflect the committed changes. Closed by commit R263:4c436ce2a291: Don't use KConfig keys with backslashes (authored by elvisangelaccio). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4496?vs=11055=11088 REVISION

[Differential] [Commented On] D4496: Don't use KConfig keys with backslashes

elvisangelaccio added a comment. In https://phabricator.kde.org/D4496#84368, @aacid wrote: > It's probably better to actually fix kile ;) > > But ok. I agree, even though if I press Alt+Shift+F in Kile I don't get the warning dialog, so I suppose the two actions are not

[Differential] [Request, 3 lines] D4496: Don't use KConfig keys with backslashes

elvisangelaccio created this revision. elvisangelaccio added a reviewer: aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Kile has ambiguous shortcuts which result in the following string used as KConfig key for

Re: Differential commit log keyword is uncomfortable - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

On Sat, Feb 4, 2017 at 7:28 PM, Ben Cooksley wrote: > On Sun, Feb 5, 2017 at 6:30 AM, Albert Astals Cid wrote: >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va >> escriure: >>> Hi everyone, >>> >>> We've just completed the registration of

Re: Phabricator differential is not good - WAS - Re: Phabricator: All repositories registered - upcoming workflow changes

On Fri, Feb 3, 2017 at 9:06 AM, Ben Cooksley wrote: > On Fri, Feb 3, 2017 at 12:18 PM, Albert Astals Cid wrote: >> El diumenge, 29 de gener de 2017, a les 8:32:21 CET, Ben Cooksley va >> escriure: >>> Hi everyone, >>> >>> We've just completed the registration

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 26b1ec257ab38c56e69803e96de695af2773024c by Elvis Angelaccio to branch master. Repository: kwidgetsaddons Description --- While the layout of the tooltip sets the tooltip

[Differential] [Updated] D4355: Add methods to hide the reveal password action

elvisangelaccio updated the summary for this revision. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D4355 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: elvisangelaccio, cfeck, broulik Cc: #frameworks

[Differential] [Request, 87 lines] D4355: Add methods to hide the reveal password action

elvisangelaccio created this revision. elvisangelaccio added reviewers: cfeck, broulik. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY The new `lineedit_reveal_password` kiosk key cannot be queried from

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

nks, Elvis Angelaccio

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

ed e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129849/#review102324 --- On Jan. 17, 2017, 10:47 p.m., Elvis Angelaccio wrote: > > --- > This is an automaticall

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

marked as submitted. Review request for KDE Frameworks and Christoph Feck. Changes --- Submitted with commit 83c9ecfe0baf0396c5f03c3bd4fea2514215684a by Elvis Angelaccio to branch master. Repository: kwidgetsaddons Description --- Otherwise the tooltip will be visible but empty

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

marked as submitted. Review request for KDE Frameworks and Aleix Pol Gonzalez. Changes --- Submitted with commit 6cbfcbf2dbb27266ecd36d0592cefd5cb1cc568d by Elvis Angelaccio to branch master. Repository: kauth Description --- This moves most of the example snippets (which were

Re: Review Request 129842: KAuth: update most of the examples, drop outdated ones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129842/#review102296 --- Ping? - Elvis Angelaccio On Jan. 15, 2017, 5:10 p.m

Re: Review Request 129849: KToolTipWidget: don't take ownership of the content widget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129849/#review102295 --- Ping? - Elvis Angelaccio On Jan. 17, 2017, 10:47 p.m

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129833/#review102294 --- Ping? - Elvis Angelaccio On Jan. 14, 2017, 6:54 p.m

Re: Screenshot hosting repo (e.g. for Appstream)

On Tue, Nov 29, 2016 at 9:55 AM, Harald Sitter wrote: > Hey, > > We have just finished sorting out a centralized screenshot repo. This > repo should be used for promotional screenshots of KDE software. > Specifically, when using screenshots for appstream data you should put > your

Re: What's kde-core-devel for?

On Mon, Dec 19, 2016 at 10:01 AM, Harald Sitter wrote: > On Thu, Dec 15, 2016 at 10:18 PM, Albert Astals Cid wrote: >> In the old days it had kdelibs development discussion but not that that has >> moved over to kde-frameworks-devel, waht's kde-core-devel for? > >

[Differential] [Commented On] D3850: Pass -fno-operator-names when supported

elvisangelaccio added a comment. In https://phabricator.kde.org/D3850#72081, @kfunk wrote: > In https://phabricator.kde.org/D3850#72077, @elvisangelaccio wrote: > > > What about adding a way (cmake variable?) to opt-in if one wants to use the alternative operators? Personally I like

Review Request 129849: KToolTipWidget: don't take ownership of the content widget

544eb74d005bb4c963c8cc6cd8b941c018cf463e Diff: https://git.reviewboard.kde.org/r/129849/diff/ Testing --- Test case reproduces the crash, which is fixed by the patch. Thanks, Elvis Angelaccio

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

marked as submitted. Review request for KDE Frameworks, Albert Astals Cid and David Faure. Changes --- Submitted with commit 500c20fdd2857d8af2905821e0efb6dbdabe55e8 by Elvis Angelaccio to branch master. Repository: kio Description --- CVE-2017-5330 shows that `runExecutables

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

the > > old method is deprecated, so anyone porting away from it will have to set > > the flags. > > > > BTW the default was true because the original use case was filemanagers > > (and krunner), which do want to run executables. But indeed in most apps > > i

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129844/#review102070 ------- On Jan. 15, 2017, 8:46 p.m., Elvis Angelaccio wrote: > > --

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

s to the now > > non-existing target? > > Elvis Angelaccio wrote: > Good point. Actually I just realized that the tooltip does take > ownership, so what happens is a double delete :/ > However, this is unrelated from this patch (it crashes even if I remove >

[Differential] [Commented On] D4130: Let KConfigDialogManager get a property's change signal from the metaObject

elvisangelaccio added a comment. @kossebau That looks good, way more easier :) REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D4130 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kossebau, #frameworks Cc: elvisangelaccio

Re: Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

889642160ad960dd7e43d1c6dad2a6f2133e17bf src/widgets/krun.cpp d04a4825e5ea696c1072054c39dc11cc9e5c63f5 Diff: https://git.reviewboard.kde.org/r/129844/diff/ Testing (updated) --- Builds, tests pass. Thanks, Elvis Angelaccio

Review Request 129844: KRun: deprecate runUrl() in favor of runUrl() with RunFlags

d04a4825e5ea696c1072054c39dc11cc9e5c63f5 Diff: https://git.reviewboard.kde.org/r/129844/diff/ Testing --- Thanks, Elvis Angelaccio

Review Request 129842: KAuth: update most of the examples, drop outdated ones

of the KAuth namespace. Thanks, Elvis Angelaccio

Re: Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

.org/r/129833/#review102031 --- On Jan. 14, 2017, 6:54 p.m., Elvis Angelaccio wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

[Differential] [Commented On] D4130: Let KConfigDialogManager get a property's change signal from the metaObject

elvisangelaccio added a comment. I see a problem with this patch, it seems it breaks custom widgets that are using properties //without// a `NOTIFY` signal. In Ark we are using a plain QTreeWidget in the config dialog, and we have the following code: // Set the custom property

Review Request 129833: KToolTipWidget: hide immediately if content gets destroyed

979d4f71b5ebf9d0716e12453ecbfc88e48be72d Diff: https://git.reviewboard.kde.org/r/129833/diff/ Testing --- The new test case reproduces this issue. Thanks, Elvis Angelaccio

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

e wheel. > > > > "Qt 5.7.1 with this patch" is much more jumpier than Qt 5.6.1. > > > > So i guess that'd be a -1 from my side. > > Elvis Angelaccio wrote: > >"Qt 5.7.1 with this patch" is much more jumpier than Qt 5.6.1. >

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

f/browse/master/src/ui/itemsview.cpp;58b0e2435492dffa019b16182cffb3bc7d7e631d$33 - Elvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129694/#review101851 -------

Re: Review Request 129741: Add renaming capability to ioslaves

ative (which is actually simpler short term) is to > implement renaming in kio_trash ;) Definitely :) All right, let's discuss this again later, waiting for news from kio_trash. - Elvis --- This is an automatically generated e

Re: Review Request 129694: About dialog: fix scrolling in Authors tab

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129694/#review101843 --- Ping? - Elvis Angelaccio On Dec. 22, 2016, 4:56 p.m

Review Request 129741: Add renaming capability to ioslaves

ore context in https://git.reviewboard.kde.org/r/129714 Thanks, Elvis Angelaccio

Re: Review Request 129648: New widget: tooltip that contains another widget

marked as submitted. Review request for KDE Frameworks, Ben Cooksley, Christoph Feck, and Martin Gräßlin. Changes --- Submitted with commit d0b80687769d0b33d4ec0f3f747383f5c28bc1d6 by Elvis Angelaccio to branch master. Repository: kwidgetsaddons Description --- This new widget

<    3   4   5   6   7   8   9   10   11   12   >