D13061: Fixed kfileplacesviewtest when not running on empty home

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. renatoo requested review of this revision. REVISION SUMMARY Make sure that the test always run on a empty home dir REPOSITORY R241 KIO BRANCH

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266694 , @bruns wrote: > Shouldn't this be handled by: > http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled this is different "setTestModeEnabled" sets the XDG_* dirs but the KIO tests

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266626 , @ngraham wrote: > I know you didn't change that, but it might be a nice enhancement (hint hint). :) In D13018#266626 , @ngraham wrote: > I

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34666. renatoo added a comment. Run tests in an empty home dir CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34646=34666 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To:

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266623 , @ngraham wrote: > Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. I am not sure, this is

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. as maximilianocuria said, before run the tests you need to create a temporary home path: HOMETMP=$(mktemp -d) trap 'rm -rf $HOMETMP' EXIT export HOME="$HOMETMP" REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham,

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. ok it should work now. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo Cc: maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34646. renatoo added a comment. Fixed code style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34645=34646 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc:

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34645. renatoo added a comment. Fixed all tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34644=34645 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc:

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34644. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34581=34644 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc: maximilianocuria, elvisangelaccio,

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34581. renatoo added a comment. Add missing url REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34580=34581 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp

D13018: Fix unit test for kfileplacesmodeltest

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. renatoo requested review of this revision. TEST PLAN Run "kiofilewidgets-kfileplacesmodeltest" make sure that "testRemoteUrls" is passing

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 25880. renatoo added a comment. Updated @since tag REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9332?vs=24605=25880 REVISION DETAIL https://phabricator.kde.org/D9332 AFFECTED FILES

D9863: Fix overlap of the first item in KFilePlacesView

renatoo accepted this revision. renatoo added a comment. This revision is now accepted and ready to land. looks good REPOSITORY R241 KIO BRANCH fixes REVISION DETAIL https://phabricator.kde.org/D9863 To: fvogt, #frameworks, dfaure, renatoo

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 24605. renatoo marked 3 inline comments as done. renatoo added a comment. Fixed typo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9332?vs=23930=24605 REVISION DETAIL https://phabricator.kde.org/D9332 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo added a comment. In https://phabricator.kde.org/D8332#179633, @rkflx wrote: > This change caused a little bit of fallout for #Gwenview. Apparently the review focussed more on the code, but less so on the behaviour in users of the class. I'm not complaining, but given one of our

D9332: Allow filter places based on alternative application name

renatoo marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent, aacid, ngraham, #frameworks

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 23930. renatoo added a comment. Added kf6 comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9332?vs=23926=23930 REVISION DETAIL https://phabricator.kde.org/D9332 AFFECTED FILES

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 23926. renatoo marked 3 inline comments as done. renatoo edited the summary of this revision. renatoo added a comment. Added documention for the new constructor REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: aacid, ngraham, #frameworks

D9332: Allow filter places based on alternative application name

renatoo marked an inline comment as done. renatoo added inline comments. INLINE COMMENTS > aacid wrote in kfileplacesmodel.h:67 > This breaks ABI so it's not acceptable. > > Also how does this fix anything if the new alternativeApplicationName > parameter is never passed in any of the existing

D9332: Allow filter places based on alternative application name

renatoo updated this revision to Diff 23922. renatoo added a comment. Avoid ABI break REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9332?vs=23920=23922 REVISION DETAIL https://phabricator.kde.org/D9332 AFFECTED FILES autotests/kfileplacesmodeltest.cpp

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: ngraham, #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo added a reviewer: mwolff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo added a dependent revision: D9333: Make sure that old ulrs does not appear duplicated in places model. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo Cc: #frameworks

D9332: Allow filter places based on alternative application name

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY You can use a alternative application name to filter items on places model. This new parameter will will be use to match the

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo updated this revision to Diff 23647. renatoo added a comment. Refactored unit test REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9252?vs=23644=23647 REVISION DETAIL https://phabricator.kde.org/D9252 AFFECTED FILES

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo added a dependent revision: D9242: Implemented support for hide/show groups. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo edited the summary of this revision. renatoo added a reviewer: mwolff. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252 To: renatoo, mwolff Cc: #frameworks

D9252: Created 'GroupHiddenRole' for KPlacesModel

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Created new role for KPlacesModel TEST PLAN unit test REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9252

D9241: Emit 'groupHiddenChanged' signal.

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot, mwolff Cc: mwolff, #frameworks

D9241: Emit 'groupHiddenChanged' signal.

renatoo updated this revision to Diff 23617. renatoo added a comment. used static_cast() for cast enums REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9241?vs=23614=23617 REVISION DETAIL https://phabricator.kde.org/D9241 AFFECTED FILES

D9241: Emit 'groupHiddenChanged' signal.

renatoo added a reviewer: franckarrecot. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo, franckarrecot Cc: #frameworks

D8450: User can now hide an entire places group from KFilePlacesView

renatoo added a dependent revision: D9241: Emit 'groupHiddenChanged' signal.. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8450 To: franckarrecot, ngraham, renatoo, ervin, mwolff, mlaurent Cc: mwolff, #frameworks

D9241: Emit 'groupHiddenChanged' signal.

renatoo edited the summary of this revision. renatoo added a dependency: D8450: User can now hide an entire places group from KFilePlacesView. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9241 To: renatoo Cc: #frameworks

D9241: Emit 'groupHiddenChanged' signal.

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Emit 'groupHiddenChanged' when group hidden value change TEST PLAN Unit test created REPOSITORY R241 KIO REVISION DETAIL

D8450: User can now hide an entire places group from KFilePlacesView

renatoo accepted this revision. renatoo added a comment. Looks good and work as expected INLINE COMMENTS > kfileplacesview.cpp:766 > +} > if (!clickOverHeader && index.isValid()) { > if (!placesModel->isDevice(index)) { I think that you can replace if (!clickOverHeader &&

D8367: Hidding place groups implementation in KFilePlacesModel

renatoo accepted this revision. renatoo added a comment. Looks good and works as expected REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8367 To: franckarrecot, renatoo, ngraham, ervin, mwolff, mlaurent Cc: mwolff, ngraham, mlaurent, #frameworks

D8243: Implement support for categories on KfilesPlacesView

renatoo added a comment. In https://phabricator.kde.org/D8243#173442, @broulik wrote: > Can we expose the group type enum in the model in addition to the name, so I can do some filtering in e.g. task manager? This will be exposed by this mr:

D9017: Avoid run kfileplacesmodeltest and kfileplacesviewtest in parallel

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY Both tests modify the bookmark file and that can cause test failure TEST PLAN run all kio unit test REPOSITORY R241 KIO BRANCH

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 23013. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22966=23013 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 23011. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22964=23011 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 23012. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22965=23012 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 23014. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22967=23014 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 23010. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22963=23010 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 23009. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22962=23009 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 22964. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22953=22964 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 22966. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22955=22966 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 22965. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22954=22965 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22967. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22956=22967 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 22963. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22952=22963 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 22962. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22951=22962 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 22961. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22950=22961 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo added a comment. In https://phabricator.kde.org/D8348#172032, @ngraham wrote: > @renatoo, now that https://phabricator.kde.org/D8332 is in, this no patch longer applies cleanly. Can you update so I can land it? I updated it. Could you try again. REPOSITORY R241 KIO

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22956. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22818=22956 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 22955. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22817=22955 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 22954. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22816=22954 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 22952. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22814=22952 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 22953. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22815=22953 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 22951. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22813=22951 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22949. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22811=22949 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 22950. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22812=22950 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo marked an inline comment as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure, mwolff Cc: mwolff, dfaure, ervin, usta, mlaurent, dvratil, ngraham,

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22811. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22776=22811 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 22817. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22782=22817 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 22814. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22779=22814 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 22812. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22777=22812 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 22813. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22778=22813 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 22816. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22781=22816 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22818. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22809=22818 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 22815. renatoo added a comment. Parent branch updated REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22780=22815 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo added a comment. @dvratil, @ervin any comments? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D8332 To: renatoo, #frameworks, #dolphin, #kde_applications, dvratil, #vdg, ngraham, ervin, mlaurent, dfaure, mwolff Cc: mwolff, dfaure, ervin, usta, mlaurent,

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 22810. renatoo marked an inline comment as done. renatoo added a comment. Renamed test function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=22775=22810 REVISION DETAIL https://phabricator.kde.org/D8332

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22809. renatoo marked 7 inline comments as done. renatoo added a comment. Fixed typos Fixed code style REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22783=22809 REVISION DETAIL

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 22782. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22770=22782 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 22775. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=22763=22775 REVISION DETAIL https://phabricator.kde.org/D8332 AFFECTED FILES autotests/CMakeLists.txt

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22776. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22764=22776 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 22779. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22767=22779 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 22780. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22768=22780 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22783. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22771=22783 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 22778. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22766=22778 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 22781. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22769=22781 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 22777. renatoo added a comment. Updated from master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22765=22777 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 22770. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22759=22770 REVISION DETAIL https://phabricator.kde.org/D8947 AFFECTED FILES

D8946: Avoid unnecessary 'dataChanged' signal

renatoo updated this revision to Diff 22769. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8946?vs=22758=22769 REVISION DETAIL https://phabricator.kde.org/D8946 AFFECTED FILES

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22771. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22762=22771 REVISION DETAIL https://phabricator.kde.org/D8948 AFFECTED FILES

D8943: Create 'KFilePlacesModel::convertedUrl' static function

renatoo updated this revision to Diff 22766. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8943?vs=22755=22766 REVISION DETAIL https://phabricator.kde.org/D8943 AFFECTED FILES

D8945: Return a valid bookmark object for any entry in KFilePlacesModel

renatoo updated this revision to Diff 22768. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8945?vs=22757=22768 REVISION DETAIL https://phabricator.kde.org/D8945 AFFECTED FILES

D8944: Create a 'KFilePlacesModel::refresh' function

renatoo updated this revision to Diff 22767. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8944?vs=22756=22767 REVISION DETAIL https://phabricator.kde.org/D8944 AFFECTED FILES

D8434: Created 'remote' section

renatoo updated this revision to Diff 22765. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8434?vs=22454=22765 REVISION DETAIL https://phabricator.kde.org/D8434 AFFECTED FILES

D8348: Add a section for removable devices

renatoo updated this revision to Diff 22764. renatoo added a comment. Updated parent branch REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8348?vs=22453=22764 REVISION DETAIL https://phabricator.kde.org/D8348 AFFECTED FILES

D8332: Added baloo urls into places model

renatoo updated this revision to Diff 22763. renatoo marked 2 inline comments as done. renatoo added a comment. Updated unit test name REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8332?vs=22451=22763 REVISION DETAIL https://phabricator.kde.org/D8332

D8948: Created an auxiliary function 'KFilePlacesModel::movePlace'

renatoo updated this revision to Diff 22762. renatoo marked an inline comment as done. renatoo added a comment. Implemented unit test Fixed documentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8948?vs=22741=22762 REVISION DETAIL

D8947: Expose KFilePlacesModel 'iconName' role

renatoo updated this revision to Diff 22759. renatoo marked an inline comment as done. renatoo added a comment. Updated documentation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8947?vs=22740=22759 REVISION DETAIL https://phabricator.kde.org/D8947

  1   2   3   >