Merging a 2nd style (non xml) for KConfigXT?

Hello All, This is my 2nd attempt on this, but hear me out. I'm using for ~5 years a configuration schema that is really different from KConfigXT XML syntax because I sincerely don't like to hand code XML specially when it's intermixed with C++ within the *same* file, and I feel that all the

Re: Review of Codevis (ie - Making Codevis a KDE Project)

Update, now it works on windows and FreeBSD. <3 On Tue, 22 Aug 2023 at 21:21 Tomaz Canabrava wrote: > Update, it now builds on qt6 and qt5. > Struggling a bit with craft for windows. > > > On Fri, 18 Aug 2023 at 21:22 Ben Cooksley wrote: > >> On Sat, Aug 19, 2023

Re: [announcement] Telegram bridging to be retired Wed. 20 Sept. | 5 to-dos

(On top of what Paul said, if this happens, should we also stop with the Reddit and Facebook management, since it’s a closed source software on for profit companies?) On Wed, 23 Aug 2023 at 03:41 Paul Brown wrote: > On Tuesday, 22 August 2023 22:08:34 CEST Albert Vaca Cintora wrote: > > KDE

Re: Review of Codevis (ie - Making Codevis a KDE Project)

Update, it now builds on qt6 and qt5. Struggling a bit with craft for windows. On Fri, 18 Aug 2023 at 21:22 Ben Cooksley wrote: > On Sat, Aug 19, 2023 at 3:37 AM Tomaz Canabrava > wrote: > >> (some help / I need to set the default branch to master, from main, >> becaus

Re: Review of Codevis (ie - Making Codevis a KDE Project)

(some help / I need to set the default branch to master, from main, because the tooling doesn't accept the later, I don't think I have the permission to do that). On Fri, Aug 18, 2023 at 5:10 PM Tomaz Canabrava wrote: > Small update that the CI is now fully passing. > > On Fri, Aug

Re: Review of Codevis (ie - Making Codevis a KDE Project)

Small update that the CI is now fully passing. On Fri, Aug 18, 2023 at 2:25 PM Tomaz Canabrava wrote: > Carl, Sysadmins: > > The current error on the KDE ci is this: > > Looking for clang tool headers at /usr/lib64/clang/16.0.6/include. You can > change this by defining CT

Re: Review of Codevis (ie - Making Codevis a KDE Project)

properly, but not compile, so I removed the FATAL from the message. On Thu, Aug 17, 2023 at 6:51 PM Tomaz Canabrava wrote: > > > On Thu, 17 Aug 2023 at 18:29 Carl Schwan wrote: > >> On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote: >> > Hello Fellow K

Re: Review of Codevis (ie - Making Codevis a KDE Project)

On Thu, 17 Aug 2023 at 18:29 Carl Schwan wrote: > On Thursday, August 17, 2023 11:18:24 AM CEST Tomaz Canabrava wrote: > > Hello Fellow KDE Devs, > > > > I'm here, formally asking for a review of the Codevis project, to move > > forward and make it a part of kdesd

Re: Review of Codevis (ie - Making Codevis a KDE Project)

Ben, Thanks so much for all the hints, I'm adapting the CI now. Best, Tomaz On Thu, Aug 17, 2023 at 11:46 AM Ben Cooksley wrote: > On Thu, Aug 17, 2023 at 9:20 PM Tomaz Canabrava > wrote: > >> (Another thing to add, it is currently on Qt5 but we plan to move it to >> Qt

Re: Review of Codevis (ie - Making Codevis a KDE Project)

(Another thing to add, it is currently on Qt5 but we plan to move it to Qt6 as soon as possible, and as soon as we have a working CI on windows, mac and linux on KDE infrastructure) On Thu, Aug 17, 2023 at 11:18 AM Tomaz Canabrava wrote: > Hello Fellow KDE Devs, > > I'm here, formal

Review of Codevis (ie - Making Codevis a KDE Project)

Hello Fellow KDE Devs, I'm here, formally asking for a review of the Codevis project, to move forward and make it a part of kdesdk. Currently we are using parts of KWdigetsAddons as a submodule Most things that are related to buildsystems will be moved to craft / kdesrc-build as soon as

Re: Eloquens now on KDEREVIEW)

Hello All, All discussion was resolved by Felipe in the past few weeks, I Assume this is done, and should be moved out of KDE Review? Best. On Tue, Jun 28, 2022 at 4:54 PM Felipe Kinoshita wrote: > friendly ping! :) > > On Wed, Jun 22, 2022 at 5:44 PM Felipe Kinoshita > wrote: > > > > > Ah!

Re: State of server-side retrace of KDE crashes?

Arch already has this, via debuginfod. On Wed, 16 Feb 2022 at 09:04 Kevin Kofler wrote: > Lyubomir Parvanov wrote: > > There were some talks about adding a server-side retrace service for KDE, > > what's the latest status quo? I really believe that KDE would be way more > > stable if this was

Re: kconfig_compiler question: reusing the enum of a previous config entry

The enums are always saved as int on the config, this is not a bug, but per design. On Sun, 21 Mar 2021 at 11:37 Albert Astals Cid wrote: > El dissabte, 20 de març de 2021, a les 17:02:19 CET, David Hurka va > escriure: > > Hi all, > > > > I am working on >

Plasma Firewall on KDE Review

People, I have send this e-mail to kde devel months ago, and forgot to send here. I would like to move Plasma Firewall to kdereview, Plasma Firewall is a Multi - Backend Firewall KCM that currently supports UFW and FirewallD, with a FreeBSD backend on the way. the current repository is on

Move Plasma Firewall to KDE Review

Hello I would like to move Plasma Firewall to KDE Review. What's Plasma Firewall? It's a frontend for firewalls, currently it supports FirewallD, UFW and BSD firewalls are being implemented as we speak. The code is based on NXFirewall from the awesome people at NX, thanks for Uri Herrera and

konsole master broken / help

Hello, I broke something in master and I can't quite figure out what is it. All the tests are passing, but a static library that I created is not being correctly used with signals / slots. I separated a bunch of code in konsole and created static libraries that later on are linked against a

Re: Gitlab, Git History and Merge Options

Ah, you are a saint <3 On Tue, May 19, 2020 at 10:20 AM Bhushan Shah wrote: > Hi Tomaz, > > On Tue, May 19, 2020 at 10:10:41AM +0200, Tomaz Canabrava wrote: > > By default Gitlab will create merge commits, and this can create a really > > nasty history if a bra

Gitlab, Git History and Merge Options

By default Gitlab will create merge commits, and this can create a really nasty history if a branch is based on a branch and not in master. To overcome this, please - if you own a repository - go to the repository settings, Merge Requests, Fast Forward Merge. I see that a few repositories are

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

tcanabrava added a comment. +1. @cfeck do you think this can land now? REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham Cc: cblack, broulik, cfeck,

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

tcanabrava added inline comments. INLINE COMMENTS > kcolorcombo.cpp:244 > +{ > +QList namedColors; > +for (int colorIndex = 0; colorIndex < colors.count(); colorIndex++) { namedColors.reserve(colors.size()); > kcolorcombo.cpp:245 > +QList namedColors; > +for (int colorIndex =

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

tcanabrava added a comment. In D29502#665582 , @cfeck wrote: > Does the delegate ensure the text is rendered in a color visible over the colored background? not yet, I talked to gustavo and he's working in an updated version of the

Re: D26877: Simplify calls to whitespace() and use it in more places.

I like indentedStream. On Sun, 2 Feb 2020 at 11:36 David Faure wrote: > dfaure requested changes to this revision. > dfaure added a comment. > This revision now requires changes to proceed. View Revision > > > I don't like it either. It doesn't "read" well.

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added a subscriber: ervin. tcanabrava added a comment. I like indentedStream. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

tcanabrava added a comment. > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. I disagree here. my application can be a simple QWidget based and have a KConfigXT enabled

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava updated this revision to Diff 74600. tcanabrava added a comment. - Fix code style REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26868?vs=74234=74600 BRANCH simplify_newEntry REVISION DETAIL https://phabricator.kde.org/D26868 AFFECTED

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava added a comment. In D26868#602162 , @kossebau wrote: > In D26868#602150 , @dfaure wrote: > > > There is indeed a QString overload for concatenating QLatin1String, but it will have to be

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26127 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26128 To: tcanabrava, ervin Cc: ervin, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26126: Simplify param method: Return Early, Use a Map and Assert.

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava, ervin, dfaure Cc: dfaure, ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D26130: Simplify return logic

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26129: Remove Iterator based loops for range based loops

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26129 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava added a comment. update / rebased. INLINE COMMENTS > ervin wrote in KConfigHeaderGenerator.cpp:252 > I lost track of constness here so I might be wrong, shouldn't this use > qAsConst in this context? yeah. REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava updated this revision to Diff 74596. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Use qAsConst REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26876?vs=74253=74596 BRANCH remove_enum_hack REVISION DETAIL

D26368: Add an isImmutable to know if a property is immutable

tcanabrava added a comment. it's a +1 for me. @dfaure and @ervin ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26368: Add an isImmutable to know if a property is immutable

tcanabrava added a comment. I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind of code in Qml: enabled:

D26573: Add missing Import Env Variable

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ee0531749057: Add missing Import Env Variable (authored by tcanabrava). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26573?vs=74512=74513 REVISION

D26573: Add missing Import Env Variable

tcanabrava updated this revision to Diff 74512. tcanabrava added a comment. - Fix Variable REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26573?vs=73237=74512 BRANCH add_missing_env_var REVISION DETAIL https://phabricator.kde.org/D26573

D26961: Be more helpfully verbose when we can't start an action

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D26961 To: davidedmundson, tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

tcanabrava added a comment. I agree with the comments, but I'm a bit lost on how to implement that in KCoreConfigSkeleton: the isSaveNeeded reads the value of the variable and return if it's different from the reference variable. (that I tougth it was a reference *value*, to find out that

D26131: Braces around for, break early.

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26131 To: tcanabrava, ervin, dfaure Cc: ervin, patrickelectric, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26867: New class: KConfigTypeInformation

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26867 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26868 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added reviewers: dfaure, ervin. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26131: Braces around for, break early.

tcanabrava updated this revision to Diff 74258. tcanabrava added a comment. - use std::any_of REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26131?vs=71913=74258 BRANCH arcpatch-D26131 REVISION DETAIL https://phabricator.kde.org/D26131 AFFECTED

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY whitespace now returns a textStream so we don't need to stream() << whitespace() Use whitespace where we had

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Run tests REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is only used here, should only be exposed here. TEST PLAN Run unittests REPOSITORY R237 KConfig

D26867: New class: KConfigTypeInformation

tcanabrava updated this revision to Diff 74231. tcanabrava added a comment. - Fix position of reference on parameter REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26867?vs=74224=74231 BRANCH rewrite_maps REVISION DETAIL

D26867: New class: KConfigTypeInformation

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This class handles transformations and queries for xml types to cpp types. Use KConfigTypeInformation to

D26202: Refactor KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R237:95aee1294e32: Refactor KConfigXT (authored by tcanabrava). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=74118=74121 REVISION DETAIL

D26202: Refactor KConfigXT

tcanabrava updated this revision to Diff 74118. tcanabrava marked an inline comment as done. tcanabrava retitled this revision from "Refactor KConfigXT " to "Refactor KConfigXT". tcanabrava added a comment. - Rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26768: Revert "Revert "WIP: Refactor KConfigXT""

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26768 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26202: Refactor KConfigXT

tcanabrava marked 26 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in KConfigCodeGeneratorBase.cpp:80 > This is an odd indentation logic, is it to stay close to the original? (which > I'd actually support, just trying to understand where that's coming

D26202: Refactor KConfigXT

tcanabrava added a comment. @ervin since they are just nitpicks I'll fix in code and land the patch. REPOSITORY R237 KConfig BRANCH rework_kconfig_compiler REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: davidre, bcooksley,

D26202: Refactor KConfigXT

tcanabrava added a comment. In D26202#597044 , @davidre wrote: > I checked https://cgit.kde.org/kconfig.git/tree/src/kconfig_compiler/kcfg.xsd and it says > > > > >

Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

do see a warning on a linux system about windows or mac run time issues (and missing icons is a run time issue). On Sun, 19 Jan 2020 at 12:03 Tomaz Canabrava wrote: > That’s not a developer issue, it’s a packaging issue. > > On Sun, 19 Jan 2020 at 12:02 Christophe Giboudeaux

D26202: Refactor KConfigXT

tcanabrava added a comment. @dfaure I tried to remove the `WIP` from the history but I'm worried that will force git push --force as I merged this with the wip before. any hints? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks,

D26202: Refactor KConfigXT

tcanabrava retitled this revision from "WIP: Refactor KConfigXT" to "Refactor KConfigXT ". REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: cgiboudeaux, kossebau, bport, ngraham, kde-frameworks-devel,

D26768: Revert "Revert "WIP: Refactor KConfigXT""

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This reverts commit 5f8c2ce63499d05dfb4753eb1acc21dccf21d434

D26766: Revert "Revert "WIP: Refactor KConfigXT""

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Simplify If-Else chain inside of defaultValue function Use a type collection to verify which value we should

D26766: Revert "Revert "WIP: Refactor KConfigXT""

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26766 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

tcanabrava added a comment. That’s not a developer issue, it’s a packaging issue. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava, cgiboudeaux Cc: apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem,

Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

That’s not a developer issue, it’s a packaging issue. On Sun, 19 Jan 2020 at 12:02 Christophe Giboudeaux < nore...@phabricator.kde.org> wrote: > cgiboudeaux added a comment. View Revision > > > You may use Linux to develop software that's intended to be used

D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

tcanabrava added a subscriber: apol. tcanabrava added a comment. But why would I get the warning if I build on Linux? The warning should target the platform, not the entire build system. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26752 To:

Re: D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build

But why would I get the warning if I build on Linux? The warning should target the platform, not the entire build system. On Sun, 19 Jan 2020 at 10:00 Christophe Giboudeaux < nore...@phabricator.kde.org> wrote: > cgiboudeaux requested changes to this revision. > cgiboudeaux added a comment. >

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Aparently the kmymoney issue was the same: empty kconfig file. I just successfully compiled kdevelop and kmymoney. I'll let the computer to compile the whole kde applications from scratch tonigth to see if it will fail somewhere. REPOSITORY R237 KConfig

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73846. tcanabrava added a comment. - Revert "Revert "WIP: Refactor KConfigXT"" - Add Reference files for Broken KDevelop Configuration - Fix generating of empty configuration files REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. who knew? This actually was not a false positive: the kdevelop build failure was a bug in kdevelop. I already opened a ticket: https://invent.kde.org/kde/kdevelop/merge_requests/90 but at the same time I added code to handle the case of broken / empty

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH warning_icons REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n,

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrickelectric, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D26202: WIP: Refactor KConfigXT

tcanabrava reopened this revision. tcanabrava added a comment. This revision is now accepted and ready to land. Reopening for review :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport,

D26202: WIP: Refactor KConfigXT

tcanabrava requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. In D26202#595820 , @tcanabrava wrote: > We can revert, and I’ll fix the full build. Doing that now. I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. We can revert, and I’ll fix the full build. Doing that now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: kossebau, bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

Re: D26202: WIP: Refactor KConfigXT

We can revert, and I’ll fix the full build. Doing that now. On Fri, 17 Jan 2020 at 09:03 Friedrich W. H. Kossebau < nore...@phabricator.kde.org> wrote: > kossebau added a comment. View Revision > > > where "full" would also need to mean "clean fresh build

D26202: WIP: Refactor KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R237:98c32e29f504: WIP: Refactor KConfigXT (authored by tcanabrava). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73608=73688 REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava added inline comments. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:129 > OK, this needs a hint for the person debugging regressions then. Something > like > > QVERIFY2(content == contentRef, "Failure, see foo.diff"); This is done now within the appendFileDiff

D26202: WIP: Refactor KConfigXT

tcanabrava marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73608. tcanabrava added a comment. - Rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73557=73608 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED FILES

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73557. tcanabrava added a comment. - Add missing copyright holders REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73510=73557 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Took the time to nuke the SignalArguments and use Param instead, easier than I initially tougth. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:180 > I meant QVERIFY2(diffFile.open(...), ...). > No need to make a separate call to isOpen(). ups :)

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73510. tcanabrava marked 10 inline comments as done. tcanabrava added a comment. - Simplify List creation - Fail with the diff file name - Simplify Code - Fix Typo - Remove `SignalArgument` for `Param` - Nitpicks and Include fixes REPOSITORY

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. @dfaure , @ervin Right now the code passes all the tests and I tried to be extra careful not to break away with the general architecture. I think it's the first "safe" version to review. REPOSITORY R237 KConfig REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73345. tcanabrava added a comment. - Fix bug ediging param variable that's supposed to be const - Const Correctness: REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73336=73345 BRANCH arcpatch-D26202

D26202: WIP: Refactor KConfigXT

tcanabrava marked 8 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava added inline comments. INLINE COMMENTS > tcanabrava wrote in kconfig_compiler.cpp:753 > that was a bit harder than I want, but done. Inside of the code generation > there was code that manipulated the ParseResult. I think this is one of the > good spots that show that this rewrite

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73336. tcanabrava marked 4 inline comments as done. tcanabrava added a comment. - Rename KConfigCodeGenerator to KconfigCodeGeneratorBase - Simplify diff file saving - Add License Headers - Documentation, Privatization, Unused method / variable

D26202: WIP: Refactor KConfigXT

tcanabrava marked 22 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:129 > Why did you remove this? It's just a more user-friendly version of the > QVERIFY on the next line, so it can't possibly have failed while the next >

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Looking at the review you it's a bis strange to see that I'v touched some test reference generated code, I did this only on *whitespace only changes* where the new whitespace made more sense than the old one. there is *one* bug I havent fixed on this code that I

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73310. tcanabrava added a comment. - Fix whitespace on the reference code / genreator REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73301=73310 BRANCH arcpatch-D26202 REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73301. tcanabrava added a comment. - More whiteespaces fixed - Fix *space only* issues with the test reference headers - More whitespace fixes, only six files to go - Way more tests passing - space fixes REPOSITORY R237 KConfig CHANGES SINCE

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73292. tcanabrava added a comment. - Fix many small whitespace issues REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73290=73292 BRANCH arcpatch-D26202 REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73290. tcanabrava added a comment. - Rebase on master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=72715=73290 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED

D26573: Add missing Import Env Variable

tcanabrava created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Without this, in Qt 5.14 I get an android-like QQC2 theme This used to work on Qt

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72715. tcanabrava edited the test plan for this revision. tcanabrava added a comment. - Add Hack for Enums - Fix Whitespace diff - Move some raw scopes to start/end scope() REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26202: WIP: Refactor KConfigXT

tcanabrava edited the summary of this revision. tcanabrava edited the test plan for this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72711. tcanabrava added a comment. - Add missing .h - Fixes placement of code - Change how tests save tests - Change how the Indentation is done - Fix filename in the preamble - Separate logic to make function readable - Fix more newlines

D26202: WIP: Refactor KConfigXT

tcanabrava added a subscriber: bport. tcanabrava added a comment. Not really as all the calls are the same, just split into classes and logical bits. I haven’t write a single line of logic. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava,

  1   2   3   >