Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-02-18 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-02-18 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/#review50183 --- src/file/lib/baloo_xattr_p.h

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-04 Thread Raphael Kubo da Costa
> On Feb. 19, 2014, 1:48 a.m., Thomas Lübking wrote: > > src/file/lib/baloo_xattr_p.h, line 26 > > > > > > I've to admit that i'm not sure how various compilers or the xattr > > headers will react to this, but yo

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-04 Thread Thomas Braxton
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/#review50490 --- src/file/lib/filecustommetadata.cpp

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-05 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/ --- (Updated March 6, 2014, 1:26 a.m.) Review request for Baloo, David Edmund

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-10 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/#review52560 --- Ping again. 4.13 is coming soon and if this doesn't get into K

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-10 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/#review52586 --- Ship it! Looks good. I haven't tested it though, but I suppos

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-10 Thread Raphael Kubo da Costa
> On March 10, 2014, 8:52 p.m., Vishesh Handa wrote: > > Looks good. I haven't tested it though, but I suppose you have. Please push > > into KDE/4.13, we can merge that into master. That's right, all the tests pass here. They were also passing on a Linux box, it's just build.kde.org that, I g

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/#review52604 --- This review has been submitted with commit 63f7804588d9357c5c

Re: Review Request 115878: File: Add a thin wrapper around different xattr implementations.

2014-03-10 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115878/ --- (Updated March 10, 2014, 10:55 p.m.) Status -- This change has been