D12015: Add docs to the user manual about the terminal key bindings

This revision was automatically updated to reflect the committed changes. Closed by commit R319:666c1c8372f8: Add docs to the user manual about the terminal key bindings (authored by ahmadsamir, committed by hindenburg). REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir marked 7 inline comments as done. REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor, ltoscano Cc: kde-doc-english, hindenburg, #konsole, herrold, ngraham

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31654. ahmadsamir added a comment. Change Ctrl to REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12015?vs=31622=31654 BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL

D12015: Add docs to the user manual about the terminal key bindings

yurchor added inline comments. INLINE COMMENTS > index.docbook:1363 > + > +A + preceding a Mode name means that mode is > set; for a modifier key, that means it's pressed, > whereas for all other modes it means that particular mode is in effect ( > active). For example +Ctrl means the key

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir added reviewers: yurchor, ltoscano. REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor, ltoscano Cc: kde-doc-english, hindenburg, #konsole, herrold,

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31622. ahmadsamir edited the summary of this revision. ahmadsamir removed a reviewer: yurchor. ahmadsamir removed a subscriber: ltoscano. ahmadsamir added a comment. I finally found doc/user/README.keyboard which mentioned some more stuff about the key

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31609. ahmadsamir added a comment. Add a section about NewLine mode Replace "Return" with Carriage Return in the output field section Change version to 18.08 REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE

D12015: Add docs to the user manual about the terminal key bindings

hindenburg accepted this revision. hindenburg added a comment. Thanks, LGTM - this is too late for 18.04 so it will go in 18.08 REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole,

D12015: Add docs to the user manual about the terminal key bindings

yurchor accepted this revision. This revision is now accepted and ready to land. REPOSITORY R319 Konsole BRANCH keybinding-editor-docs (branched from master) REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor Cc: ltoscano, kde-doc-english,

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir updated this revision to Diff 31592. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Update the diff to address some of the issues pointed out in the review request REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir marked 7 inline comments as done. ahmadsamir added a comment. In D12015#241801 , @ltoscano wrote: > The doc team was automatically added as subscriber. > Regarding the entity, just expand it inline, or define the entity in this

D12015: Add docs to the user manual about the terminal key bindings

yurchor added inline comments. INLINE COMMENTS > index.docbook:1332 > + > + > +How Uses Key Bindings Would it be better to have multiple sect1s (sect2s -> sect1s) in a chapter rather than have just one? > index.docbook:1337 > +Introduction > + uses *.keytab files to translate key

D12015: Add docs to the user manual about the terminal key bindings

yurchor requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg, yurchor Cc: ltoscano, kde-doc-english, hindenburg, #konsole, herrold, ngraham

D12015: Add docs to the user manual about the terminal key bindings

ltoscano added a comment. The doc team was automatically added as subscriber. Regarding the entity, just expand it inline, or define the entity in this file: we add it for people who have more contributions (and it would introduce a dependency on a new version of Frameworks, so you would

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir added a comment. I totally missed the Newline mode, I'll update the diff (hopefully soon). REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D12015 To: ahmadsamir, #konsole, hindenburg Cc: kde-doc-english, hindenburg, #konsole, herrold, ngraham

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir added a comment. I couldn't find a guide on how to get my name and email added to the docbook entities in KDE, I would appreciate any pointers about that. Also, should I add the docs team on this review or is there another way to notify them about this docbook addition?

D12015: Add docs to the user manual about the terminal key bindings

ahmadsamir created this revision. ahmadsamir added reviewers: Konsole, hindenburg. Restricted Application added a project: Konsole. Restricted Application added a subscriber: kde-doc-english. ahmadsamir requested review of this revision. REVISION SUMMARY Also mention the manual on the Keyboard