nononux marked 2 inline comments as done.
nononux added inline comments.
INLINE COMMENTS
> dhaumann wrote in plugin_kateopenselection.cpp:80
> A PluginViewKateOpenSelection instance is created here for every
> KTextEditor::MainWindow - this is ok and works as designed / intended.
>
> However,
nononux updated this revision to Diff 62250.
nononux added a comment.
Fix the required parts, I hope it's ok this time :)
REPOSITORY
R40 Kate
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22199?vs=61266=62250
BRANCH
openselection (branched from master)
REVISION DETAIL
dhaumann requested changes to this revision.
dhaumann added a comment.
This revision now requires changes to proceed.
The KTextEditor::Command implementation is wrong, see my other comments.
Please fix this first :-)
INLINE COMMENTS
> plugin_kateopenselection.cpp:80
> +{
> +return new
nononux added a comment.
Hi, can the code be pushed ? I don't think there are still changes to do.
(I don't have a dev account)
REPOSITORY
R40 Kate
REVISION DETAIL
https://phabricator.kde.org/D22199
To: nononux
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad,
nononux marked 2 inline comments as done.
nononux added inline comments.
INLINE COMMENTS
> pino wrote in plugin_kateopenselection.cpp:58
> This should be "Open Selected Paths"; see
> https://hig.kde.org/style/writing/capitalization.html
Ok, changed. In fact, menus are not capitalized in my
nononux updated this revision to Diff 61266.
nononux added a comment.
Add support of remote paths (http://) + change action name
REPOSITORY
R40 Kate
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22199?vs=61239=61266
BRANCH
openselection (branched from master)
REVISION DETAIL
pino added inline comments.
INLINE COMMENTS
> plugin_kateopenselection.cpp:58
> +QAction *a =
> actionCollection()->addAction(QStringLiteral("file_openselection"));
> +a->setText(i18n("Open selected path"));
> +actionCollection()->setDefaultShortcut(a, QKeySequence(Qt::ALT +
>
nononux updated this revision to Diff 61239.
nononux added a comment.
Change the shortcut to Alt+O as Ctrl+Shift+O was already used for the
spelling correction
REPOSITORY
R40 Kate
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22199?vs=61027=61239
BRANCH
openselection
nononux marked 9 inline comments as done.
REPOSITORY
R40 Kate
REVISION DETAIL
https://phabricator.kde.org/D22199
To: nononux
Cc: dhaumann, pino, yurchor, kwrite-devel, kde-doc-english, gennad,
fbampaloukas, domson, michaelh, ngraham, demsking, skadinna, cullmann, sars
nononux updated this revision to Diff 61026.
nononux added a comment.
Improve coding guidelines respect
REPOSITORY
R40 Kate
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22199?vs=61022=61026
BRANCH
openselection (branched from master)
REVISION DETAIL
yurchor added inline comments.
INLINE COMMENTS
> nononux wrote in kateopenselectionplugin.desktop:6-7
> I removed all the translations. Is it a dedicated team who do the
> translations ?
Sure. We (translation team) do.
https://l10n.kde.org/teams-list.php
Then scripty (our friendly
nononux marked 11 inline comments as done.
nononux added a comment.
Thanks for your advices for my first KDE dev. I hope I've taken them into
account in a good way.
INLINE COMMENTS
> pino wrote in kateopenselectionplugin.desktop:6-7
> Please do not add translations manually, there is a
nononux updated this revision to Diff 61022.
nononux added a comment.
Taking into account the proposed changes
REPOSITORY
R40 Kate
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22199?vs=60958=61022
BRANCH
openselection (branched from master)
REVISION DETAIL
dhaumann added inline comments.
INLINE COMMENTS
> plugin_kateopenselection.cpp:91
> +KTextEditor::View* editView =
> application->activeMainWindow()->activeView();
> +if (editView && editView->document()) {
> +QString selection;
A view always has a valid document, no need to
pino added a comment.
In addition to the assumption done about a path being a local file: what if
the selection contains more than one path/URL?
INLINE COMMENTS
> kateopenselectionplugin.desktop:6-7
> +Name=Open Selection
> +Name[en_GB]=Open Selection
> +Name[fr]=Ouvrir la sélection
>
yurchor added a comment.
Thanks in advance for fixing the issue with docs.
INLINE COMMENTS
> plugin_kateopenselection.cpp:59
> +QAction *a =
> actionCollection()->addAction(QStringLiteral("file_openselection"));
> +a->setText(i18n("Opens the selected path"));
> +
nononux created this revision.
Herald added projects: Kate, Documentation.
Herald added subscribers: kde-doc-english, kwrite-devel.
nononux requested review of this revision.
REVISION SUMMARY
The plugin allow the user to open the selected file path in the current
document. If there is no
17 matches
Mail list logo
