On Saturday 21 December 2013 12:42:04 Kevin Ottens wrote:
Hello people,
I see that new tasks appeared in the wiki, that's great, they were clearly
missing. That said, they were all earmarked for the tech preview, so I took
the liberty to move most of them to the list about the final release.
On Monday 23 December 2013 14:51:19 Alex Merry wrote:
If $PREFIX/share/applications does not exist, KStandardDirs will not add
it. It will then notice that nothing matching the installation prefix
was added, and add installPath(xdgdata-apps), which is
$PREFIX/share/applications/kde5/.
OK,
On Friday 27 December 2013 19:54:14 Àlex Fiestas wrote:
On Friday 27 December 2013 19:00:14 Aleix Pol wrote:
Hi,
I've been going through the kde4support forward includes, since I wanted
to
start making the modules I decided we'd better make sure all of them are
working properly.
On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote:
So existing code ported from kdelibs would have to explicitely prefix the
includes, e.g. be changed like
#include KLocalizedString - #include KI18n/KLocalizedString
Definitely don't want this.
See the QtGui/QLabel -
On Tuesday 24 December 2013 15:46:34 Alex Merry wrote:
This got a bit lost in the other thread on the kde4support tests...
Ah. I think I unconfused it a few minutes ago, didn't see this.
I want to advocate setting XDG_APPS_INSTALL_DIR to be
$CMAKE_INSTALL_PREFIX/share/applications instead of
Hello all,
Everything is in the subject of this email. Thanks to Ben for doing the grunt
work as usual. Ben you rock!
So now people can report bugs on bugzilla and can send us patches through
reviewboard.
Cheers!
--
Kévin Ottens, http://ervin.ipsquad.net
KDAB - proud supporter of KDE,
On Saturday 28 December 2013 11:39:50 David Faure wrote:
On Saturday 21 December 2013 12:42:04 Kevin Ottens wrote:
Hello people,
I see that new tasks appeared in the wiki, that's great, they were clearly
missing. That said, they were all earmarked for the tech preview, so I
took
the
On Saturday 28 December 2013 11:55:56 David Faure wrote:
On Friday 27 December 2013 19:01:09 Friedrich W. H. Kossebau wrote:
So existing code ported from kdelibs would have to explicitely prefix the
includes, e.g. be changed like
#include KLocalizedString - #include KI18n/KLocalizedString
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114693/
---
Review request for KDE Frameworks.
Repository: kio
Description
---
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114697/#review46257
---
Ship it!
Thanks.
- David Faure
On Dec. 28, 2013, 12:35
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/
---
Review request for KDE Frameworks and David Faure.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114697/#review46259
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/#review46258
---
Ship it!
Ship It!
- David Faure
On Dec. 28, 2013, 12:39
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114697/
---
(Updated Dec. 28, 2013, 12:42 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/#review46263
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/#review46261
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/#review46262
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/
---
(Updated Dec. 28, 2013, 12:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114698/#review46265
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114699/
---
Review request for KDE Frameworks.
Repository: kmediaplayer
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114700/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114701/
---
Review request for KDE Frameworks.
Repository: kguiaddons
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114700/#review46271
---
OK for this particular case, but in general I don't like Qt's
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114701/#review46273
---
See, this will print an unnecessary (i.e. wrong) warning in
On Dec. 28, 2013, 1:19 p.m., David Faure wrote:
See, this will print an unnecessary (i.e. wrong) warning in case we *are*
linking to KCoreAddons, but not using cmake.
qmake users will have to add a define just to silence the warning. So this
create more work, rather than helping...
On Dec. 28, 2013, 1:42 p.m., David Faure wrote:
Ah indeed, well done.
Does that mean you're happy for me to ship 114700 as well?
- Alex
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114700/#review46279
---
Ship it!
Ship It!
- David Faure
On Dec. 28, 2013, 1:03
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114701/#review46280
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114700/
---
(Updated Dec. 28, 2013, 1:52 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114701/
---
(Updated Dec. 28, 2013, 1:53 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114524/#review46281
---
I'm inclined to say that we don't care about the frameworks
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114524/
---
(Updated Dec. 28, 2013, 2:02 p.m.)
Status
--
This change has been
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote:
IMO the patch as it is is not good.
Several things:
1) This file, is not mandatory at all with KDE frameworks.
You can build applications using KDE frameworks libraries without it. You
(the developer of the application) simply
On Nov. 12, 2013, 7:24 p.m., Alexander Neundorf wrote:
IMO the patch as it is is not good.
Several things:
1) This file, is not mandatory at all with KDE frameworks.
You can build applications using KDE frameworks libraries without it. You
(the developer of the application) simply
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/
---
Review request for KDE Frameworks.
Repository: kdesignerplugin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/
---
Review request for KDE Frameworks.
Repository: kdesignerplugin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114705/
---
Review request for KDE Frameworks.
Repository: kdesignerplugin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114706/
---
Review request for KDE Frameworks.
Repository: kdewebkit
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/#review46292
---
Ship it!
Looks nice.
- David Faure
On Dec. 28, 2013, 3
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/
---
(Updated Dec. 28, 2013, 5:37 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114703/#review46305
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114704/
---
(Updated Dec. 28, 2013, 5:38 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/
---
Review request for KDE Frameworks.
Repository: kcoreaddons
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114716/#review46342
---
src/lib/kaboutdata.cpp
On Dec. 29, 2013, 1:05 a.m., Albert Astals Cid wrote:
src/lib/kaboutdata.cpp, line 969
https://git.reviewboard.kde.org/r/114716/diff/1/?file=227634#file227634line969
Not related to your patch, but i wonder if we need a \n here too?
I don't think so. The output of kgeography
45 matches
Mail list logo