Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 3:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47884 --- something went wrong with the latest patch. CMake looks fine b

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
> On Jan. 21, 2014, 2:55 p.m., Martin Gräßlin wrote: > > I like this approach better (though I don't know whether that's causing > > problems on the DBus side). Maybe we could keep the files as they are and > > just rename at install? new patch attached - Jonathan -

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/#review47879 --- I like this approach better (though I don't know whether that'

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

2014-01-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47881 --- Note that I fixed the "build failure with kdesrc-build" differ

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. > > Hrvoje Senjan

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115078/ --- (Updated Jan. 21, 2014, 2:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

2014-01-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/#review47874 --- Ship it! Ship It! - Alex Merry On Jan. 21, 2014, 1:49 p.m.

Review Request 115165: Use a proper temporary file for the doxygen config

2014-01-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115165/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Review Request 115166: Add a CMakeLists.txt which wraps python setup.py

2014-01-21 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115166/ --- Review request for Build System, KDE Frameworks and Alex Merry. Repositor

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

2014-01-21 Thread Thomas Lübking
> On Jan. 20, 2014, 5 p.m., Thomas Lübking wrote: > > given the ratio by this property is set (often) and read (rarely), i wonder > > whether we could establish a semi-async functionality, where the client > > sends a message to have the property updated, then syncs, reads and returns > > the

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. > > Hrvoje Senjan

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Martin Gräßlin
> On Jan. 17, 2014, 9:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. > > Hrvoje Senjan

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Martin Gräßlin
> On Jan. 17, 2014, 9:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. > > Hrvoje Senjan

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
> On Jan. 17, 2014, 8:43 p.m., Martin Gräßlin wrote: > > this would break my workflow given that I install kde4 and kf5 to different > > prefixes. I think this needs a different approach, but please don't ask me > > for it. I'm lacking ideas how we could solve this upstream. > > Hrvoje Senjan

Re: Review Request 115078: don't install dbus interface files in kglobalaccel

2014-01-21 Thread Jonathan Riddell
> On Jan. 17, 2014, 5:39 p.m., Thomas Lübking wrote: > > and what if kdelibs (really, not kde-runtime?) from SC4 is not installed? > > KF/5 would be broken then, would it not? > > What about having a common data package downstream? No it wouldn't be broken, it would continue to compile using th

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/ --- (Updated Jan. 21, 2014, 12:24 p.m.) Status -- This change has been m

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47861 --- This review has been submitted with commit 096faf3d2bf7786bbc

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Sebastian Kügler
On Tuesday, January 21, 2014 11:03:57 Bhushan Shah wrote: > On Tue, Jan 21, 2014 at 1:19 AM, Àlex Fiestas wrote: > > In the plasma sprint we have done a session to plan what we are going to > > do > > with kde-workspace/kde-runtime repositories, here is the proposal we came > > with. > > > > We a

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115157/#review47860 --- Ship it! Ship It! - Martin Gräßlin On Jan. 20, 2014, 6:58

Jenkins build is back to normal : ktexteditor_master_qt5 #87

2014-01-21 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktexteditor_master_qt5 #86

2014-01-21 Thread KDE CI System
See -- [...truncated 340 lines...] Removing autotests/input/indent/pascal/longtest3/actual Removing autotests/input/indent/pascal/longtest4/actual Removing autotests/input/indent/pascal/openpar1/actual Re

Re: Review Request 115157: Make better use of KWindowSystem in KPassivePopup

2014-01-21 Thread Alex Merry
> On Jan. 21, 2014, 6:42 a.m., Martin Gräßlin wrote: > > src/kpassivepopup.cpp, lines 466-467 > > > > > > small suggestion: > > if (QWidget *widget = QWidget::find(d->window)) { > > ... > > } I have

Re: Review Request 115147: Fix non-X11 implementation of KPassivePopup placement

2014-01-21 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115147/ --- (Updated Jan. 21, 2014, 11:12 a.m.) Status -- This change has been d

Review Request 115164: Keep tests together

2014-01-21 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Bhushan Shah
Hello! On Tue, Jan 21, 2014 at 3:35 PM, Antonis Tsiapaliokas wrote: > I think that splitting each individual component to its own repo might be a > bit confusing. Because if we don't have two groups (plasma-desktop and plasma- > workspace), then we will not be able to provide something as a stand

Re: Splitting kde-workspace and kde-runtime proposal

2014-01-21 Thread Antonis Tsiapaliokas
> 1) Create two different groups named plasma-workspace and > plasma-desktop like frameworks > 2) Split out every component into individual repos > 3) Assign repos to the related group. > > Advantages: > > 1) Easy to assign maintainer to individual component. > 2) If we split only some repos, we

<    1   2