Re: c++ plugins with Frameworks 5

On Monday 03 March 2014 12:28:07 Aaron J. Seigo wrote: > do we want .desktop files as well as generated .json? > > if so, for applications that wish to put additional data in the json files, > is it expected that they continue to do this by adding more “X-Foo” > entries to the [Desktop Entry] gro

Re: KUnitConversion Review

On Tuesday 04 March 2014 01:04:05 John Layt wrote: > So, now KPrintUtils and KUnitConversion are about done (bar the > KCurrencyCode move), are there any other Frameworks needing review? All the unmaintained ones, some of the maintained ones too. > At Tier 1 level it just looks like KCodecs, KGui

Re: Review Request 116568: Fixes to PIC image format handler

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116568/#review51854 --- Ship it! Too many C casts to not get nightmares, but other th

Re: Binary incompatible changes

On Tuesday 04 March 2014 12:08:07 Ben Cooksley wrote: > On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid wrote: > > El Dissabte, 1 de març de 2014, a les 16:53:28, David Faure va escriure: > >> On Saturday 01 March 2014 16:39:56 Albert Astals Cid wrote: > >> > Every time someone commits to okula

Re: Binary incompatible changes

On Tue, Mar 4, 2014 at 9:30 PM, David Faure wrote: > On Tuesday 04 March 2014 12:08:07 Ben Cooksley wrote: >> On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid wrote: >> > El Dissabte, 1 de març de 2014, a les 16:53:28, David Faure va escriure: >> >> On Saturday 01 March 2014 16:39:56 Albert Ast

Build failed in Jenkins: knotifications_master_qt5 #36

See Changes: [mklapetek] Bump the tier to tier 3 -- Started by remote host 127.0.0.1 with note: Triggered by commit Building remotely on LinuxSlave - 4 in workspace

Build failed in Jenkins: knotifications_master_qt5 #37

See -- Started by user gateau Building remotely on LinuxSlave - 4 in workspace Running Prebuild steps [knotifications_master_qt5] $ /bin/sh -xe

Review Request 116591: Use dedicated NET::Properties and NET::Properties2 in NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116591/ --- Review request for KDE Frameworks. Repository: kwindowsystem Descriptio

Re: Review Request 116591: Use dedicated NET::Properties and NET::Properties2 in NETWinInfo

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116591/ --- (Updated March 4, 2014, 10:50 a.m.) Review request for KDE Frameworks.

Re: Review Request 116103: Make KI18N a public dependency of KIO since public installed headers of KIO requires it

> On March 4, 2014, 12:06 a.m., Aleix Pol Gonzalez wrote: > > Ok, I just realized this was being dealt with and I did a different patch: > > https://git.reviewboard.kde.org/r/116573/ > > > > I think that having UI strings on a header file is quite bad TBH, but since > > I see there's consensus

Re: c++ plugins with Frameworks 5

On Tuesday, March 04, 2014 09:22:11 David Faure wrote: > What I don't know is how much do we need support for queries that filter > this further, and whether just reading the json from all the plugins of > type "foo" is good enough. In my tests it was expectedly slow: scaling linearly with number

Jenkins build is back to normal : knotifications_master_qt5 #38

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: c++ plugins with Frameworks 5

On Tuesday 04 March 2014 11:21:06 Sebastian Kügler wrote: > On Tuesday, March 04, 2014 09:22:11 David Faure wrote: > > What I don't know is how much do we need support for queries that filter > > this further, and whether just reading the json from all the plugins of > > type "foo" is good enough.

[kwallet] src/runtime/kwalletd: Change KWallet daemon files to LGPLv2+

Git commit 0da2a5c94544ffc58230dd6dc2f12fe3fdcb98f7 by Alex Merry. Committed on 04/03/2014 at 10:55. Pushed by alexmerry into branch 'master'. Change KWallet daemon files to LGPLv2+ Permission granted by George Staikos on kde-frameworks-devel. CCMAIL: stai...@kde.org CCMAIL: hrvoje.sen...@gmail.

Re: Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/#review51865 --- README.md

Re: KUnitConversion Review

On 02/03/14 18:58, Kevin Ottens wrote: > On Thursday 27 February 2014 17:15:56 John Layt wrote: >> I've done the first step, and I just need a volunteer to do the git magic >> required to: >> >> * Move kcurrencycode.h and kcurrencycode.cpp including history from >> "kunitconversion/src" to "kde4sup

Re: Review Request 116588: Improve the README

> On March 4, 2014, 12:02 p.m., Alex Merry wrote: > > README.md, line 9 > > > > > > "allows to interact with" is bad grammar; "allows interaction with" > > would work, and "allows to interact with" would be bette

Re: Review Request 116568: Fixes to PIC image format handler

> On March 4, 2014, 8:28 a.m., David Faure wrote: > > src/imageformats/pic.cpp, line 452 > > > > > > Does this work on both big endian and little endian architectures? It > > looks like it's extracting individua

Re: Review Request 116588: Improve the README

> On March 4, 2014, 11:02 a.m., Alex Merry wrote: > > README.md, line 9 > > > > > > "allows to interact with" is bad grammar; "allows interaction with" > > would work, and "allows to interact with" would be bette

Re: c++ plugins with Frameworks 5

On Tuesday, March 4, 2014 11:52:11 David Faure wrote: > Unless someone has a plan for it, my suggestion would be, let's model it > after the upcoming app desktop cache, i.e. update it at install time. I'll This sounds perfect. In that vein, I did do some measuring of what takes time, and it reall

Re: Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/ --- (Updated March 4, 2014, 1:32 p.m.) Review request for KDE Frameworks. C

Re: Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/#review51872 --- Ship it! Ship It! - Alex Merry On March 4, 2014, 12:32 p.m

Re: KUnitConversion Review

On 4 March 2014 09:25, Kevin Ottens wrote: > On Tuesday 04 March 2014 01:04:05 John Layt wrote: >> So, now KPrintUtils and KUnitConversion are about done (bar the >> KCurrencyCode move), are there any other Frameworks needing review? > > All the unmaintained ones, some of the maintained ones too.

Re: KUnitConversion Review

On Tuesday 04 March 2014 15:29:33 John Layt wrote: > On 4 March 2014 09:25, Kevin Ottens wrote: > > On Tuesday 04 March 2014 01:04:05 John Layt wrote: > >> So, now KPrintUtils and KUnitConversion are about done (bar the > >> KCurrencyCode move), are there any other Frameworks needing review? > >

Re: KUnitConversion Review

On 4 March 2014 15:59, Kevin Ottens wrote: > KGuiAddons definitely. The other two are important too, but this one is even > more important. OK, I'll get onto that then. John. ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://m

Re: Review Request 116090: Use $ instead of get_target_property(... LOCATION)

> On Feb. 27, 2014, 10:54 a.m., Alex Merry wrote: > > The problem with doing this in support code is that it is not strictly > > source compatible. An example this would break is if you want to embed the > > value of QT_QMAKE_EXECUTABLE into a C++ executable using something like > > add_defini

Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/ --- Review request for Build System, Extra Cmake Modules, KDE Frameworks, and

KF5 Update Meeting Minutes 2014-w10

Hello everyone, This is the minutes of the Week 10 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: afiestas, agateau, alexmerry, apol, mck182, mgraesslin, notmart, Riddell, sebas, teo, tosky and myself. Announcement: * Alpha 2 is out! * Next stop beta 1,

KCodecs - Quick Review

Hi, I know nothing about text codecs, but I've had a *very* quick look at KCodecs: * Original code by Lars dated 1999! * One method marked as deprecated to be removed for KDE4 * "###FIXME KDE4: the name of the encodings should mostly be uppercase" * Code generated by script generate_string_table.

Re: Review Request 116098: Use KDEInstallDirs

> On March 1, 2014, 1:32 p.m., Lamarque Souza wrote: > > CMakeLists.txt, line 23 > > > > > > NMQt is supposed to depend on Qt only. > > > > What is E-C-M? > > > > Does GNUInstallDirs support all

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/ --- (Updated March 4, 2014, 5:13 p.m.) Review request for KDE Frameworks, Dan

Re: Review Request 116087: KCrash: remove usage of strlcpy

> On March 1, 2014, 5:17 p.m., David Faure wrote: > > Hmm, this might be equivalent, but all it means is that the orig code was > > wrong. > > > > We should not make any memory allocations within the crash handler. > > > > So we should instead store the startup id as a const char* somewhere an

Re: Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51904 --- +1 but someone else has to approve - Martin Gräßlin On Marc

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116098/#review51909 --- Ship it! Ship It! - Lamarque Souza On March 4, 2014, 4:13

Re: Review Request 116098: Drop unneccessary dependency on extra-cmake-modules and use GNUInstallDirs

> On March 4, 2014, 4:42 p.m., Lamarque Souza wrote: > > Ship It! This should be ported to branches master and NM/0.9.8 as well. - Lamarque --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/

Re: Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51912 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On March 4

KIdleTime Quick Review

Hi, Nice simple one this, one public class, looks OK. Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need Wayland or systemd support eventually? Does have one TODO, but that's an implementation detail: "widgetbasedpoller.cpp # TODO: make optional, to avoid always depend

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/ --- (Updated March 4, 2014, 6:42 p.m.) Status -- This change has been ma

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115982/#review51919 --- This review has been submitted with commit 5dd178321fc4837cc1

KGuiAddons Review

Hi, Here's my first pass through KGuiAddons, focussing on the public api. KColorCollection - Should probably become a QSharedDataPointer KWorkdWrap - "// KDE5 TODO: return a value, not a pointer, and use QSharedDataPointer." KModifierKeyInfo - Generally looks OK - Has lots of "bool isKeyPress

Re: Binary incompatible changes

El Dimarts, 4 de març de 2014, a les 21:34:12, Ben Cooksley va escriure: > On Tue, Mar 4, 2014 at 9:30 PM, David Faure wrote: > > On Tuesday 04 March 2014 12:08:07 Ben Cooksley wrote: > >> On Sun, Mar 2, 2014 at 5:03 AM, Albert Astals Cid wrote: > >> > El Dissabte, 1 de març de 2014, a les 16:53

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116069/#review51923 --- Ship it! Ship It! - Burkhard Lück On Feb. 27, 2014, 10:43

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116068/#review51924 --- Ship it! Ship It! - Burkhard Lück On Feb. 27, 2014, 10:40

Re: Review Request 116542: Fix compilation with clang 3.4.

> On March 4, 2014, 6:03 a.m., Michael Pyne wrote: > > From what I can tell declaring *any* type A::B is a "qualified id" per the > > C++ spec and therefore changes the template lookup rules for > > argument-dependent lookup (which means the specialized function to be > > called must already b

Re: KIdleTime Quick Review

On Tuesday 04 March 2014 19:35:10 John Layt wrote: > Hi, > > Nice simple one this, one public class, looks OK. > > Has QWidget, Windows, Mac, and X11 (XScreensaver/XSync) backends, will need > Wayland or systemd support eventually? > > Does have one TODO, but that's an implementation detail: >

Re: Review Request 115478: Add QFileDialog unit autotest for filters (which reveals a QPA bug)

> On Feb. 4, 2014, 5:17 p.m., Alex Merry wrote: > > Has the Qt patch been submitted upstream? > > Dominik Haumann wrote: > Meanwhile yes: https://codereview.qt-project.org/#change,77390 > > Alex Merry wrote: > I don't think it's useful to have tests that fail because of upstream > issu

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

> On Feb. 20, 2014, 12:07 p.m., Kevin Ottens wrote: > > Aren't the concern raised initially on that patch addressed now? Please > > make a second round of reviews or ship it. More than a week with no reaction, should it be discarded? - Kevin -

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115752/ --- (Updated March 4, 2014, 8:09 p.m.) Status -- This change has been di

Re: Review Request 115916: Fix MSVC build of kprintpreview_test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115916/#review51930 --- Ship it! Ship It! - Kevin Ottens On Feb. 20, 2014, 4:41 p.

Re: Review Request 115717: Do not require to have a DISPLAY env variable if WAYLAND_DISPLAY is set

> On Feb. 19, 2014, 2:07 p.m., Alex Merry wrote: > > I don't think papering over the X11-ness of kdesu like this is the right > > approach. Of course, what this framework really needs is a test app; maybe > > a simple port of the kdesu app from kde-runtime? > > Kevin Ottens wrote: > This

Re: Review Request 115602: Rename kactivitymanagerd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115602/ --- (Updated March 4, 2014, 8:15 p.m.) Status -- This change has been di

Re: Review Request 115907: Link tests with extra libraries as well

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115907/ --- (Updated March 4, 2014, 8:17 p.m.) Status -- This change has been di

Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData

> On Feb. 22, 2014, 9:09 a.m., David Faure wrote: > > src/lib/kaboutdata.cpp, line 919 > > > > > > A unittest would have shown you the bug in this line... > > (you're modifying a copy -> no effect). > >

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

> On Feb. 3, 2014, 6:07 p.m., Raphael Kubo da Costa wrote: > > Please see the big comment below the elseif line, the link to the > > kde-core-devel and > > http://lists.kde.org/?l=kde-core-devel&m=138244424421211&w=2: the issue > > here is that if you pass -fno-exceptions to clang you need to

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

> On Feb. 23, 2014, 1:21 p.m., David Faure wrote: > > Any news? - Kevin --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review50580 --

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115977/#review51936 --- src/karchive.h

Re: Review Request 115316: Add demo for KRecentFileList

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115316/#review51937 --- Ship it! Ship It! - Kevin Ottens On Feb. 24, 2014, 10:05 p

Re: Review Request 116044: In kstyle: Use the iconSize from mainToolbar

> On Feb. 25, 2014, 12:10 p.m., David Faure wrote: > > The part of the description that says "if accepted will modify kstyle as > > well" doesn't really make sense anymore (to fix if it's in your commit log > > too). > > > > The bit I'm not sure about is: using MainToolbar icon style everywher

Re: Review Request 116025: Add documentation about writing find modules

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116025/#review51940 --- Anything blocking you from addressing the last two issues? -

Re: Review Request 116462: Keep KSharedConfigPtr("kdeglobals") around in KHintSettings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116462/ --- (Updated March 4, 2014, 8:38 p.m.) Status -- This change has been ma

Re: Review Request 116462: Keep KSharedConfigPtr("kdeglobals") around in KHintSettings.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116462/#review51942 --- This review has been submitted with commit bef59bad73e688574a

Re: Review Request 116096: Re-enable autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116096/#review51943 --- autotests/proxymodeltestsuite/CMakeLists.txt

Re: Review Request 115932: Add declarative plugin for KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115932/ --- (Updated March 4, 2014, 8:41 p.m.) Status -- This change has been di

Re: Review Request 116088: Remove FindDBusMenuQt5.cmake

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116088/#review51945 --- Ship it! Ship It! - Kevin Ottens On Feb. 27, 2014, 12:19 p

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/ --- (Updated March 4, 2014, 8:45 p.m.) Review request for KDE Frameworks and

Re: Review Request 115918: Fix kservice_desktop_to_json for Visual Studio

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115918/#review51946 --- Ship it! And I agree with Aurélien, a bug should be filed and

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review51947 --- Ship it! Ship It! - Kevin Ottens On Feb. 25, 2014, 10:50 p

Re: Review Request 116037: change entities to reflect new branding

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116037/#review51948 --- Ship it! Ship It! - Kevin Ottens On Feb. 25, 2014, 1:02 a.

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51949 --- Ship it! Ship It! - Kevin Ottens On Feb. 23, 2014, 11 a.m.

Re: Review Request 116538: Make README.md consistent with other frameworks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116538/#review51950 --- Ship it! Ship It! - Kevin Ottens On March 2, 2014, 8:05 p.

Re: Review Request 116541: Fix compiler error when using clang:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116541/#review51951 --- Ship it! Ship It! - Kevin Ottens On March 2, 2014, 8:12 p.

Re: Review Request 116544: Fix clang compilation warning:

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116544/#review51952 --- Ship it! Ship It! - Kevin Ottens On March 2, 2014, 8:53 p.

Re: Review Request 116545: Fix KHTML compilation when using clang.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116545/#review51953 --- Ship it! Ship It! - Kevin Ottens On March 2, 2014, 9:11 p.

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/ --- (Updated March 4, 2014, 9:58 p.m.) Review request for KDE Frameworks. R

Re: Review Request 116075: Provide an implementation for QPlatformSystemTrayIcon

> On Feb. 26, 2014, 9:41 a.m., Kevin Krammer wrote: > > src/platformtheme/kdeplatformsystemtrayicon.cpp, line 78 > > > > > > I see lambdas being using later on, in which case this looks like a > > candidate for s

Re: Review Request 116561: Drop KWindowEffects::showWindowThumbnails

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116561/#review51957 --- Ship it! Ship It! - Kevin Ottens On March 3, 2014, 8:48 a.

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated March 4, 2014, 10:02 p.m.) Review request for Build System, Extr

Re: Review Request 116567: Implement fuzzy image matching in readtest

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116567/#review51959 --- Ship it! Ship It! - Kevin Ottens On March 3, 2014, 3:23 p.

Re: Review Request 116588: Improve the README

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116588/#review51960 --- Ship it! Ship It! - Kevin Ottens On March 4, 2014, 12:32 p

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115875/#review51961 --- Ship it! autotests/kconfigtest.cpp

Re: Review Request 116598: Check versions for individual components of Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116598/#review51962 --- Ship it! Ship It! - Kevin Ottens On March 4, 2014, 3:53 p.

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116069/#review51963 --- Ship it! Ship It! - Kevin Ottens On Feb. 27, 2014, 10:43 p

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116068/#review51965 --- Ship it! Ship It! - Kevin Ottens On Feb. 27, 2014, 10:40 p

Re: Review Request 116542: Fix compilation with clang 3.4.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116542/#review51966 --- Ship it! Ship It! - Kevin Ottens On March 2, 2014, 8:20 p.

Re: Review Request 115137: Provide information about the active screen in KWindowSystem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115137/#review51954 --- src/kwindowsystem_x11.cpp

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/#review51972 --- This review has been submitted with commit eea8251903f427f024

Re: Review Request 115959: Resurrect KConfigDialog::setHelp (used to come from KDialog). Move KHelpClient down from kxmlgui, for use in KConfigDialog.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115959/ --- (Updated March 4, 2014, 9:30 p.m.) Status -- This change has been ma

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/#review51973 --- This review has been submitted with commit c132a0d84ca4a51bb0

Re: Review Request 115710: Hide private methods and slots behind the d-pointer in KHistoryComboBox

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115710/ --- (Updated March 4, 2014, 9:38 p.m.) Status -- This change has been ma

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review51974 --- Ship it! Let's give it a try as the situation in frameworks l

Re: [kdesrc-build] /: kf5: Port rc files to use branch-groups consistently.

On Tuesday 04 March 2014 01:32:14 Michael Pyne wrote: > kf5: Port rc files to use branch-groups consistently. Thanks! > This should be absolutely transparent except that "kde-kactivities" will > rename to "kactivities", though you might have to update > kde-build-metadata first if you're using --

Building KF5/Kate fails

Building KF5 mostly works, except I now get the error (cleaned build + install folder) below when building kate. It looks as if Qt4 is somehow in the way now. This used to work before, so is there any way to get it working again? The detailed cmake logs are on paste.kde.org (see below). Greetings

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116068/#review51978 --- This review has been submitted with commit 60f900ce562a4fb114

Re: Review Request 116068: Bump supported DocBookXML version to 4.5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116068/ --- (Updated March 4, 2014, 10:07 p.m.) Status -- This change has been m

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

> On March 4, 2014, 10:11 p.m., David Faure wrote: > > autotests/kconfigtest.cpp, line 86 > > > > > > Just curious, what's the reason for the ".." then? Doesn't this still > > make this test potentially conflict

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/ --- (Updated March 4, 2014, 10:22 p.m.) Status -- This change has been m

Re: Review Request 115395: Also pass -fno-exceptions when building with clang

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115395/#review51982 --- This review has been submitted with commit 3b5c422eff53161b52

Re: Review Request 115875: kconfigtest: write everything into a subdirectory

> On March 4, 2014, 9:11 p.m., David Faure wrote: > > autotests/kconfigtest.cpp, line 86 > > > > > > Just curious, what's the reason for the ".." then? Doesn't this still > > make this test potentially conflict w

Re: Review Request 116069: Compatibility support for DocBookXML 4.2

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116069/#review51985 --- This review has been submitted with commit ee93faa6b3cc4dc143

  1   2   >