---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116958/
---
(Updated March 24, 2014, 9:45 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116957/
---
(Updated March 24, 2014, 9:48 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116957/#review53932
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/
---
Review request for KDE Frameworks and Dominik Haumann.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/
---
Review request for KDE Frameworks.
Repository: kcrash
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/
---
(Updated March 24, 2014, 10:54 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117005/#review53936
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/#review53937
---
There's a slight difference, and the reason we haven't been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review53938
---
Then you should modify the target_include_directories
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53939
---
What about QStandardPaths::findExecutable? Actually this one
On March 24, 2014, 10:57 a.m., Aleix Pol Gonzalez wrote:
There's a slight difference, and the reason we haven't been doing this for
most headers. From KDE4Support you can include headers prefixing KDE/ (such
as KDE/KTextEditor/MovingRange). If you remove these that won't be possible
On 23/03/14 19:51, David Faure wrote:
On Sunday 23 March 2014 17:33:46 Alex Merry wrote:
On 23/03/14 14:55, Alex Merry wrote:
On 20/03/14 08:13, David Faure wrote:
On Thursday 20 March 2014 00:28:44 Alex Merry wrote:
LXR says the only
users are a couple of projects that haven't even made
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/
---
(Updated March 24, 2014, 11:14 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117006/#review53941
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53944
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53946
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53943
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53942
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/
---
(Updated March 24, 2014, 11:27 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116962/#review53945
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116936/#review53950
---
This review has been submitted with commit
On Monday, March 24, 2014 06:59:24 PM Ben Cooksley wrote:
Baloo developers, please take a look at the failure in this log -
http://build.kde.org/view/FAILED/job/baloo_stable/80/console. When
referencing projects outside your own, it is imperative the correct
include statements are used in
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116936/
---
(Updated March 24, 2014, 11:33 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/#review53951
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117000/
---
(Updated March 24, 2014, 11:34 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116937/#review53952
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116937/
---
(Updated March 24, 2014, 11:43 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53955
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/
---
(Updated March 24, 2014, 11:44 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53953
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53954
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116959/#review53956
---
This review has been submitted with commit
On March 23, 2014, 9:35 p.m., David Faure wrote:
src/kcmultidialog.cpp, line 424
https://git.reviewboard.kde.org/r/116959/diff/1/?file=256012#file256012line424
this if() isn't needed, already tested in the parent scope.
Oops, worse than that. I'd replaced rootOnlyMessage()
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/#review53958
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116993/
---
(Updated March 24, 2014, 11:47 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/#review53961
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116995/
---
(Updated March 24, 2014, 11:50 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117004/#review53963
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117004/
---
(Updated March 24, 2014, 11:52 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/
---
(Updated March 24, 2014, 1:01 p.m.)
Review request for KDE Frameworks.
On March 23, 2014, 11:39 p.m., Aleix Pol Gonzalez wrote:
src/colors/kcolorutils.cpp, line 38
https://git.reviewboard.kde.org/r/116866/diff/5/?file=256190#file256190line38
Wouldn't it make more sense to use qIsNan?
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/
---
Review request for KDE Frameworks, Aleix Pol Gonzalez and Michael Hansen.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/#review53968
---
Ship it!
Less code, less ifdef's, more happiness!
- Aleix
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/#review53973
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/#review53972
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117018/
---
(Updated March 24, 2014, 1:43 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117019/
---
Review request for KDE Frameworks and David Faure.
Repository: kio
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117020/
---
Review request for KDE Frameworks.
Repository: kde4support
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117020/
---
(Updated March 24, 2014, 2:07 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/#review53981
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117017/
---
(Updated March 24, 2014, 2:58 p.m.)
Status
--
This change has been
See http://build.kde.org/job/ktexteditor_master_qt5/319/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117016/#review53985
---
The correct solution is to get drkonqi merged into kcrash
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
What about QStandardPaths::findExecutable? Actually this one should look
into libexec too (at least the equivalent KStandardDirs::findExe used to).
I'm pretty sure QStandardPaths won't look at libexec. How should it know where
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117024/
---
Review request for KDE Frameworks.
Repository: kded
Description
Currently, paths to libexec files are hardcoded (or not... see
https://git.reviewboard.kde.org/r/117023/). This works find unless you
want to relocate anything.
I know that relocating is something that has come up with KDE on Windows
stuff. Is it something we want to support? If so, how would
On March 21, 2014, 4:10 p.m., Hrvoje Senjan wrote:
this seems to broke kded modules loading here:
Cannot load library /usr/lib64/libkdeinit5_kio_file:
(/usr/lib64/libkdeinit5_kio_file.so: cannot open shared object file: No
such file or directory)
Hrvoje Senjan wrote:
err,
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
What about QStandardPaths::findExecutable? Actually this one should look
into libexec too (at least the equivalent KStandardDirs::findExe used to).
Alex Merry wrote:
I'm pretty sure QStandardPaths won't look at libexec. How
On March 24, 2014, 3:41 p.m., Alex Merry wrote:
The correct solution is to get drkonqi merged into kcrash (see
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).
Agreed. If somebody has the time, it would be interesting to figure out what
can be uncommented (see commit
On Thu, Feb 20, 2014 at 6:46 PM, Aleix Pol aleix...@kde.org wrote:
Hi!
I am going through the list of things where we're moving kde-runtime
components to [1] and I see that there's a platform/win directory.
Do you agree that having it in a separate repository would be the best?
Could
On March 24, 2014, 4:41 p.m., Alex Merry wrote:
The correct solution is to get drkonqi merged into kcrash (see
http://community.kde.org/Frameworks/Epics/New_Runtime_Organization).
Aleix Pol Gonzalez wrote:
Agreed. If somebody has the time, it would be interesting to figure out
On March 24, 2014, 12:01 p.m., Aleix Pol Gonzalez wrote:
What about QStandardPaths::findExecutable? Actually this one should look
into libexec too (at least the equivalent KStandardDirs::findExe used to).
Alex Merry wrote:
I'm pretty sure QStandardPaths won't look at libexec. How
On March 4, 2014, 8:28 p.m., Kevin Ottens wrote:
src/karchive.h, line 32
https://git.reviewboard.kde.org/r/115977/diff/1/?file=245721#file245721line32
Hm, why the change to for the includes? We try to stick to in
public headers.
Kevin Ottens wrote:
Any news?
Should it
On March 17, 2014, 4:44 p.m., Kevin Ottens wrote:
OK, let's go for it without a test app...
Anything still blocking?
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
On Feb. 25, 2014, 12:10 p.m., David Faure wrote:
The part of the description that says if accepted will modify kstyle as
well doesn't really make sense anymore (to fix if it's in your commit log
too).
The bit I'm not sure about is: using MainToolbar icon style everywhere ...
how
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54006
---
Ship it!
Ship It!
- Kevin Ottens
On March 18, 2014, 3:58
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116887/
---
(Updated March 24, 2014, 6:43 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116848/#review54007
---
Ship it!
Ship It!
- Kevin Ottens
On March 19, 2014, 6:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116926/#review54008
---
Ship it!
Ship It!
- Kevin Ottens
On March 20, 2014, 1:40
On March 4, 2014, 8:28 p.m., Kevin Ottens wrote:
src/karchive.h, line 32
https://git.reviewboard.kde.org/r/115977/diff/1/?file=245721#file245721line32
Hm, why the change to for the includes? We try to stick to in
public headers.
Kevin Ottens wrote:
Any news?
Kevin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116941/#review54009
---
Ship it!
Ship It!
- Kevin Ottens
On March 21, 2014, 7:15
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116955/#review54011
---
Ship it!
Ship It!
- Kevin Ottens
On March 21, 2014, 4:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/#review54012
---
src/kgraphicswebview.h
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116982/#review54013
---
Ship it!
Ship It!
- Kevin Ottens
On March 22, 2014, 6:46
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116980/#review54014
---
docs/kded5/man-kded5.8.docbook
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116997/#review54015
---
Ship it!
Ship It!
- Kevin Ottens
On March 23, 2014, 3:48
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116999/#review54016
---
Ship it!
Ship It!
- Kevin Ottens
On March 23, 2014, 4:33
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117003/#review54017
---
Ship it!
Ship It!
- Kevin Ottens
On March 23, 2014, 5:36
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116930/#review54018
---
Ship it!
Ship It!
- Kevin Ottens
On March 23, 2014, 8:12
On March 23, 2014, 9:38 p.m., David Faure wrote:
I don't really get the point of this change? (it's mostly a TODO...)
Indeed I don't get it either.
- Kevin
---
This is an automatically generated e-mail. To reply, visit:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117020/#review54020
---
Ship it!
Ship It!
- Kevin Ottens
On March 24, 2014, 2:07
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117023/#review54021
---
Ship it!
Ship It!
- Kevin Ottens
On March 24, 2014, 4:19
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117024/#review54022
---
Ship it!
Ship It!
- Kevin Ottens
On March 24, 2014, 4:19
On Monday 24 March 2014 19:01:14 Aleix Pol wrote:
So if nobody disagrees, we'll split it out into a KWindowsAddons repository
and hope somebody will find a use for it some day.
No objection to have it as separate repository. Just to clarify though: won't
be part of a KF5.0, afaict it's not
See http://build.kde.org/job/ktexteditor_master_qt5/320/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See http://build.kde.org/job/ktexteditor_master_qt5/321/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
See http://build.kde.org/job/ktexteditor_master_qt5/323/changes
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116969/
---
(Updated March 24, 2014, 9:45 p.m.)
Review request for KDE Frameworks.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117036/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117040/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117043/
---
Review request for KDE Frameworks.
Repository: kcompletion
Description
On March 24, 2014, 11:01 a.m., Aleix Pol Gonzalez wrote:
What about QStandardPaths::findExecutable? Actually this one should look
into libexec too (at least the equivalent KStandardDirs::findExe used to).
Alex Merry wrote:
I'm pretty sure QStandardPaths won't look at libexec. How
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54049
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116876/#review54048
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116955/#review54050
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116955/
---
(Updated March 24, 2014, 11:55 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117037/#review54052
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 24, 2014,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117042/#review54053
---
Ship it!
Ship It!
- Aleix Pol Gonzalez
On March 24, 2014,
1 - 100 of 101 matches
Mail list logo
