Re: Review Request 118366: Porting keyboard module to Framework5

> On May 28, 2014, 8:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried

Re: KGlobalAccel Problems

On Thursday 19 June 2014 19:26:45 Vishesh Handa wrote: > Hey guys > > I've been looking into kglobalaccel in order to fix some problems that I > was having. I seems to have opened a can of worms. > > Background Information: KGlobalAccel has 2 kinds of shortcuts - Active > Shortcuts and Default Sh

Re: git hooks for reviews mandatory?

On Thursday 19 June 2014 23:38:05 Luigi Toscano wrote: > Marco Martin ha scritto: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accepts pushes only if the comm

Re: Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/#review60578 --- Ship it! Ship It! - Marco Martin On June 20, 2014, 12:26 a

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 18, 2014, 12:50 a.m., Matthew Dawson wrote: > > autotests/kdesktopfiletest.cpp, line 88 > > > > > > Please add a test for both: > > - when both the country/language match and a modifier is include

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 20, 2014, 10:56 a.m.) Review request for KDE Frameworks, Da

Re: Review Request 118780: Disable the xcb flush connection workaround for Qt >= 5.3.1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118780/ --- (Updated June 20, 2014, 9:03 a.m.) Status -- This change has been ma

Re: Review Request 118780: Disable the xcb flush connection workaround for Qt >= 5.3.1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118780/#review60580 --- This review has been submitted with commit b6b9b1247945b05f59

Build failed in Jenkins: kio_master_qt5 #267

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 844 lines...] [ 17%] [ 17%] Automatic moc for target kioslave-httpauthenticationtest Automatic moc for target httpfiltert

Build failed in Jenkins: frameworkintegration_master_qt5 #81

See Changes: [mgraesslin] Disable the xcb flush connection workaround for Qt >= 5.3.1 -- [...truncated 56 lines...] kiconthemes - Branch master kbookmarks - Branch master

Build failed in Jenkins: kdelibs4support_master_qt5 #224

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 540 lines...] Scanning dependencies of target kdialogbuttonboxtest_automoc [ 14%] [ 14%] [ 14%] Automatic moc

Re: Review Request 118725: use renamed .direcory files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/#review60583 --- This review has been submitted with commit 83b68863ad797fbcbe

Re: Review Request 118725: use renamed .direcory files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/ --- (Updated June 20, 2014, 9:50 a.m.) Status -- This change has been ma

Review Request 118844: Introduce convenient methods to set active and default shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/ --- Review request for KDE Frameworks and Vishesh Handa. Repository: kglobala

Re: Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/ --- (Updated June 20, 2014, 10:41 a.m.) Status -- This change has been m

Re: Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/#review60584 --- This review has been submitted with commit 542d1b8534d56b7278

Re: git hooks for reviews mandatory?

On Fri, Jun 20, 2014 at 7:40 AM, Kevin Ottens wrote: > On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin > wrote: > > > Hi all, > > > I was thinking, since the policy for committing in frameworks is to > always > > > asking for a review, what abo

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118844/#review60588 --- Ship it! I approve. The only problem I have is with the docu

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118783/ --- (Updated June 20, 2014, 11:18 a.m.) Status -- This change has been d

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

> On June 20, 2014, 1:17 p.m., Vishesh Handa wrote: > > I approve. > > > > The only problem I have is with the documentation, but we can improve that > > in another patch. well let's improve directly. What do you think is missing with these new methods or is that more a general comment? - M

Jenkins build became unstable: kwindowsystem_master_qt5 » All,LINBUILDER #73

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #29

See Changes: [scarlett] kde-baseapps frameworks dolphin with snapshot frameworks branch baloo/baloo-widgets path fixes. -- [...truncated 1142 lines...] ^

Review Request 118846: Turn KLauncher into a QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/ --- Review request for KDE Frameworks, David Faure and Harald Sitter. Bugs: 3

Build failed in Jenkins: kcmutils_master_qt5 #60

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kcmutils_master_qt5] $ /

Build failed in Jenkins: kded_master_qt5 #63

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kded_master_qt5] $ /bin/sh -xe /

Build failed in Jenkins: kdesu_master_qt5 #52

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kdesu_master_qt5] $ /bin/sh -x

Build failed in Jenkins: kemoticons_master_qt5 #60

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kemoticons_master_qt

Build failed in Jenkins: kdewebkit_master_qt5 #43

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 1 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kdewebkit_master_qt5]

Build failed in Jenkins: kio_master_qt5 #268

See Changes: [faure] Use QDBusConnection instead of KDBusConnectionPool. [adawit] Do not send config reparse notification to suspended ioslaves. [scripty] SVN_SILENT made messages (.desktop file) -- [

Build failed in Jenkins: kinit_master_qt5 #81

See -- [...truncated 56 lines...] kwallet - Branch master kauth - Branch master kservice - Branch master dogtail - Branch master qt5 - Branch stable kcodecs - Branch master kt

Build failed in Jenkins: knotifyconfig_master_qt5 #59

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [knotifyconfig_

Build failed in Jenkins: knotifications_master_qt5 #83

See -- [...truncated 4 lines...] + /home/jenkins/scripts/setup-env.sh Preparing to perform KDE Continuous Integration build == Setting Up Sources From git://anongit.kde.org/knotifications 62038ef.

Build failed in Jenkins: kparts_master_qt5 #75

See -- Started by user Ben Cooksley Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace Running Prebuild steps [kparts_master_qt5] $ /bin/sh

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60591 --- Ship it! looks good to me - Harald Sitter On June 20, 2014

Jenkins build became unstable: ktexteditor_master_qt5 #425

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118844: Introduce convenient methods to set active and default shortcut

> On June 20, 2014, 11:17 a.m., Vishesh Handa wrote: > > I approve. > > > > The only problem I have is with the documentation, but we can improve that > > in another patch. > > Martin Gräßlin wrote: > well let's improve directly. What do you think is missing with these new > methods or is

Re: Review Request 118692: Fix reading of entries for language/country combinations

> On June 17, 2014, 6:50 p.m., Matthew Dawson wrote: > > autotests/kdesktopfiletest.cpp, line 88 > > > > > > Please add a test for both: > > - when both the country/language match and a modifier is included

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60615 --- Strange, why wasn't this necessary in kdelibs4? - David Faure

Re: KCoreAddons does not install most of its headers on my system

On 19/06/14 00:32, Aleix Pol wrote: > On Wed, Jun 18, 2014 at 10:56 PM, Ben Cooksley > wrote: > Note though that I consider this a workaround for an upstream > regression which we have detected. > One of the reasons the CI system runs the next branch is to de

Re: git hooks for reviews mandatory?

On 19/06/14 22:21, Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have been guilty t

Re: git hooks for reviews mandatory?

On Friday 20 June 2014 19:25:19 Alex Merry wrote: > On 19/06/14 22:21, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an hook that accepts pushes only if

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60621 --- Ship it! Ship It! - Matthew Dawson On June 20, 2014, 4:56

Re: Review Request 118039: Simplify KConfig::readEntry/writeEntry

2014-05-07 14:15 GMT-03:00 Thomas Braxton : > > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118039/ > > Review request for KDE Frameworks and kdewin. > By Thomas Braxton. > > Summary > > Simplify KConfig::readEntry/writeEntry > > Description (upd

Re: git hooks for reviews mandatory?

El Divendres, 20 de juny de 2014, a les 01:46:10, Aleix Pol va escriure: > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding

Re: Building KF5

El Divendres, 20 de juny de 2014, a les 07:33:34, Kevin Ottens va escriure: > Hello, > > On Thursday 19 June 2014 22:30:26 André Wöbbeking wrote: > > I wanted to give KF5 a try and followed the instructions from > > http://community.kde.org/Frameworks/Building. After Albert told me not to > > use

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

> On June 20, 2014, 7:05 p.m., David Faure wrote: > > Strange, why wasn't this necessary in kdelibs4? see the linked bug report. It's basically a regression due to introducing platform detection (X11 vs. Wayland) in both klauncher and KWindowSystem. My first idea to fix it was to check for DIS

Re: Review Request 118366: Porting keyboard module to Framework5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 20, 2014, 9:24 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118366: Porting keyboard module to Framework5

> On May 28, 2014, 6:10 a.m., Martin Gräßlin wrote: > > kcms/keyboard/kcmmisc.cpp, lines 77-78 > > > > > > for new connects I would use the new compile time checked syntax. > > shivam makkar wrote: > I tried

Re: Review Request 118366: Porting keyboard module to Framework5

> On June 19, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > kcms/keyboard/flags.cpp, line 21 > > > > > > remove? see the latest revision, apparently the diff is showing all the revisions made to the same file.

Re: Review Request 118846: Turn KLauncher into a QGuiApplication

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118846/#review60630 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 20, 2014, 1

Review Request 118852: [kconfig] Fix build on Visual C++ 2010

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/ --- Review request for KDE Frameworks and kdewin. Repository: kconfig Descr

Review Request 118853: Log name + size of not found icons in debug output

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118853/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60635 --- This review has been submitted with commit a52b00f31eb5df1cd6

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/ --- (Updated June 21, 2014, 5:47 a.m.) Status -- This change has been ma