Re: Review Request 125419: Fix hunspell plugin ID for proper loading

2015-10-02 Thread Viktar Vauchkevich
> On Oct. 2, 2015, 4:52 a.m., Viktar Vauchkevich wrote: > > Ship It! > > Bhushan Shah wrote: > Erm, do you have commit access or want someone to commit for you? I dont have access. Please commit it. - Viktar --- This is an

Re: Review Request 125419: Fix hunspell plugin ID for proper loading

2015-10-02 Thread Viktar Vauchkevich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125419/ --- (Updated Oct. 2, 2015, 6:26 a.m.) Status -- This change has been

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-10-02 Thread Harald Sitter
> On Sept. 21, 2015, 7:22 a.m., David Faure wrote: > > src/core/kfileitem.cpp, line 905 > > > > > > This is much better done by a readonly array, in order to take less > > memory and less CPU time. > > > >

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 100 - Still unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/100/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 10:14:23 + Build duration: 5 min 10 sec CHANGE SET Revision

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-10-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/ --- (Updated Oct. 2, 2015, 12:59 p.m.) Review request for KDE Frameworks.

Re: Review Request 125158: add logic to use icons for default xdg user dirs

2015-10-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125158/#review86225 --- src/core/kfileitem.cpp (line 903)

Re: Review Request 125338: Fix out of bounds memory access in KNTLM::getAuth

2015-10-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125338/#review86231 --- +1 Makes sense to me. - Aleix Pol Gonzalez On Sept. 21,

Re: Review Request 125480: KFileWidget: provide a "bigger than minimum" sizeHint.

2015-10-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125480/#review86218 --- +1 lgtm - Aleix Pol Gonzalez On Oct. 2, 2015, 9:58 a.m.,

Re: qca-qt5 (qt5 branch) merge into qca (master branch)

2015-10-02 Thread Harald Sitter
QCA's qt5 branch has now been merged back into master. master now behaves like qt5 did. If qt5 is found libqca-qt5 is built, if it isn't found qt4 is a requirement and libqca will be built. You can override this behavior by using the cmake option QT4_BUILD. Going to prep a tarball shortly. HS

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 109 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 15:19:50 + Build duration: 5 min 4 sec CHANGE SET Revision e46dc22d5fe84ed0a64e0712d8083756f99b3fa5

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 101 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/101/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 15:19:50 + Build duration: 5 min 1 sec CHANGE SET Revision

Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

2015-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125483/ --- Review request for KDE Frameworks and David Faure. Repository:

Re: Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

2015-10-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125483/ --- (Updated Oct. 2, 2015, 7:52 p.m.) Review request for KDE Frameworks and

Problem investigating a heap-use-after-free in kwindowsystem

2015-10-02 Thread Martin Graesslin
Hi all, I added a new unit test to kwin today [1] and it failed on the CI system due to the enabled ASAN with an error in kwindowsystem. I'm able to reproduce it locally, but fail to understand it. To me the code and the test conditions looks correct. Relevant part of the bt: #0 0x7f5198ac2c84

Re: Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125483/#review86249 --- Sending Activate to a running Unique process is not a

Review Request 125484: Allow to clear completion history

2015-10-02 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125484/ --- Review request for KDE Frameworks and David Faure. Repository:

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125208/#review86251 --- Please check if the unittests in frameworkintegration still

Re: Review Request 125479: KFileWidget: parent argument should default to 0 like in all widgets.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125479/ --- (Updated Oct. 2, 2015, 9:42 p.m.) Status -- This change has been

Re: Problem investigating a heap-use-after-free in kwindowsystem

2015-10-02 Thread Albert Astals Cid
El Friday 02 October 2015, a les 22:24:00, Martin Graesslin va escriure: > Hi all, > > I added a new unit test to kwin today [1] and it failed on the CI system due > to the enabled ASAN with an error in kwindowsystem. I'm able to reproduce > it locally, but fail to understand it. To me the code

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 102 - Fixed!

2015-10-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 21:37:45 + Build duration: 5 min 0 sec CHANGE SET Revision

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 102 - Fixed!

2015-10-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/102/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 21:37:45 + Build duration: 5 min 0 sec CHANGE SET Revision

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-10-02 Thread Xuetian Weng
> On Oct. 2, 2015, 8:46 p.m., David Faure wrote: > > Please check if the unittests in frameworkintegration still pass for you. > > > >

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-10-02 Thread Xuetian Weng
> On Oct. 2, 2015, 8:46 p.m., David Faure wrote: > > Please check if the unittests in frameworkintegration still pass for you. > > > >

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-10-02 Thread David Faure
> On Oct. 2, 2015, 8:46 p.m., David Faure wrote: > > Please check if the unittests in frameworkintegration still pass for you. > > > >

Re: Review Request 125484: Allow to clear completion history

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125484/#review86250 --- Looks ok to me, except that KHistoryComboBox also adds such a

Re: Review Request 125338: Fix out of bounds memory access in KNTLM::getAuth

2015-10-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125338/ --- (Updated Oct. 2, 2015, 9:37 p.m.) Status -- This change has been

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 110 - Fixed!

2015-10-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/110/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 21:37:45 + Build duration: 5 min 4 sec CHANGE SET Revision e30ccc368be95a0a43b805b9c2f94257a426854d

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 110 - Fixed!

2015-10-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/110/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 21:37:45 + Build duration: 5 min 4 sec CHANGE SET Revision e30ccc368be95a0a43b805b9c2f94257a426854d

Review Request 125497: KSycoca: spot dirs from the future, and `touch` them to avoid constant ksycoca rebuilds.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125497/ --- Review request for KDE Frameworks and Bhushan Shah. Bugs: 353036

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-10-02 Thread Xuetian Weng
> On Oct. 2, 2015, 8:46 p.m., David Faure wrote: > > Please check if the unittests in frameworkintegration still pass for you. > > > >

Re: Problem investigating a heap-use-after-free in kwindowsystem

2015-10-02 Thread Michael Pyne
On Fri, October 2, 2015 23:59:00 Albert Astals Cid wrote: > El Friday 02 October 2015, a les 22:24:00, Martin Graesslin va escriure: > > Hi all, > > > > I added a new unit test to kwin today [1] and it failed on the CI system > > due to the enabled ASAN with an error in kwindowsystem. I'm able to

Re: Review Request 125106: Minor optimizations

2015-10-02 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125106/#review86262 --- Any comment for/against this? - Albert Astals Cid On set.

Re: Review Request 125208: Fixes file dialog randomly not showing up with frameworkintegration

2015-10-02 Thread David Faure
> On Oct. 2, 2015, 8:46 p.m., David Faure wrote: > > Please check if the unittests in frameworkintegration still pass for you. > > > >

Jenkins-kde-ci: frameworkintegration master stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/frameworkintegration%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 22:29:25 + Build duration: 5 min 49 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 125483: [KDBusService] Don't exit after calling Activate if user specified NoExitOnFailure flag

2015-10-02 Thread Martin Klapetek
> On Oct. 2, 2015, 10:35 p.m., David Faure wrote: > > Sending Activate to a running Unique process is not a failure, so > > NoExitOnFailure should not affect it. > > > > If you need a "no exit, ever" flag, then I would recommend adding a > > separate flag for that. I'm not sure I understand

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 99 - Failure!

2015-10-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/99/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 07:49:32 + Build duration: 1 min 40 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 107 - Still Unstable!

2015-10-02 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/107/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 02 Oct 2015 07:49:32 + Build duration: 5 min 16 sec CHANGE SET Revision 35b39f85ff7973156eee7b2221834f8930e33967

Review Request 125479: KFileWidget: parent argument should default to 0 like in all widgets.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125479/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 125480: KFileWidget: provide a "bigger than minimum" sizeHint.

2015-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125480/ --- Review request for KDE Frameworks. Repository: kio Description ---