Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 130 - Failure!

2015-10-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 08:00:12 + Build duration: 1 min 21 sec CHANGE SET Revision 5971decd33224f87840584d2d744aa0108

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 135 - Failure!

2015-10-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/135/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 08:00:12 + Build duration: 1 min 41 sec CHANGE SET Revision 5971decd33224f87840584d2d74

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 131 - Still Failing!

2015-10-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/131/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 08:01:50 + Build duration: 1 min 14 sec CHANGE SET Revision 60c59becf13eb35e7dc558e0dc7a643260

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 136 - Still Failing!

2015-10-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/136/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 08:03:31 + Build duration: 1 min 8 sec CHANGE SET Revision 60c59becf13eb35e7dc558e0dc7a

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Alexander Potashev
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86657 --- libmediawiki is not part of KF5, I would avoid installing into

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 132 - Fixed!

2015-10-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 12:40:43 + Build duration: 7 min 2 sec CHANGE SET Revision a3580955456f0ac5072e72a226588f271e9

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 132 - Fixed!

2015-10-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/132/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 12:40:43 + Build duration: 7 min 2 sec CHANGE SET Revision a3580955456f0ac5072e72a226588f271e9

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 137 - Fixed!

2015-10-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 12:40:43 + Build duration: 6 min 54 sec CHANGE SET Revision a3580955456f0ac5072e72a2265

Jenkins-kde-ci: ktexteditor master stable-kf5-qt5 » Linux,gcc - Build # 137 - Fixed!

2015-10-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/137/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 12:40:43 + Build duration: 6 min 54 sec CHANGE SET Revision a3580955456f0ac5072e72a2265

Re: Review Request 125575: Make program logo non-pixelated on HiDPI

2015-10-11 Thread Christoph Cullmann
> On Oct. 9, 2015, 6:42 p.m., David Edmundson wrote: > > src/kaboutapplicationdialog.cpp, line 94 > > > > > > This doesn't seem right. Sorry. > > > > setDevicePixelRatio should really only be done when lo

Re: Review Request 125575: Make program logo non-pixelated on HiDPI

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125575/ --- (Updated Oct. 11, 2015, 2:07 p.m.) Status -- This change has been di

Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- Review request for KDE Frameworks and David Faure. Repository: kxmlgui

Re: Review Request 124134: Fixing KDED string references

2015-10-11 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124134/ --- (Updated Oct. 11, 2015, 5:03 p.m.) Status -- This change has been di

Re: Review Request 125570: Handle kabc deprecated classes in kabc->kcontact porting script

2015-10-11 Thread R.Harish Navnit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125570/ --- (Updated Oct. 12, 2015, 12:24 a.m.) Review request for KDE Frameworks and

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Dāvis Mosāns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/ --- (Updated Oct. 11, 2015, 10:46 p.m.) Review request for KDE Frameworks and

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Dāvis Mosāns
> On Oct. 11, 2015, 2:02 p.m., Alexander Potashev wrote: > > libmediawiki is not part of KF5, I would avoid installing into > > /usr/include/KF5 to prevent possible collision in the future. ok, like this? but it also installs KF5/mediawiki_version.h that's from main CMakeLists.txt - Dāvis

Re: Review Request 125575: Make program logo non-pixelated on HiDPI

2015-10-11 Thread David Edmundson
> On Oct. 9, 2015, 6:42 p.m., David Edmundson wrote: > > src/kaboutapplicationdialog.cpp, line 94 > > > > > > This doesn't seem right. Sorry. > > > > setDevicePixelRatio should really only be done when lo

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86673 --- This fix looks good to me, but I see an inconsistency overall:

Re: Review Request 125480: KFileWidget: provide a "bigger than minimum" sizeHint.

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125480/ --- (Updated Oct. 11, 2015, 9:04 p.m.) Status -- This change has been ma

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/#review86674 --- Excellent idea. This simplifies deployment greatly. - David F

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124963/#review86678 --- Ship it! src/knewpasswordwidget.cpp (line 97)

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
> On Oct. 11, 2015, 9:06 p.m., David Faure wrote: > > Excellent idea. This simplifies deployment greatly. Then I will update my patch to contain the qrc stuff, too. - Christoph --- This is an automatically generated e-mail. To reply, vi

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- (Updated Oct. 11, 2015, 9:44 p.m.) Review request for KDE Frameworks and

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- (Updated Oct. 11, 2015, 9:45 p.m.) Review request for KDE Frameworks and

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/#review86681 --- src/CMakeLists.txt

Re: Review Request 124963: New widget: KNewPasswordWidget

2015-10-11 Thread Kai Uwe Broulik
> On Okt. 11, 2015, 9:16 nachm., David Faure wrote: > > src/knewpasswordwidget.cpp, line 101 > > > > > > qBound(pwstrength, 0, 100) :-) qBound(0, pwstrength, 100) actually - Kai Uwe -

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- (Updated Oct. 11, 2015, 10 p.m.) Review request for KDE Frameworks and Da

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- (Updated Oct. 11, 2015, 10:01 p.m.) Review request for KDE Frameworks and

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 130 - Still Unstable!

2015-10-11 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/130/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 11 Oct 2015 21:04:39 + Build duration: 7 min 27 sec CHANGE SET Revision 0e232f98c7a7f7706e16c2b7191358e7eaa77c7d

Re: Review Request 125556: Install CamelCase headers

2015-10-11 Thread Dāvis Mosāns
> On Oct. 12, 2015, 12:03 a.m., David Faure wrote: > > src/CMakeLists.txt, line 24 > > > > > > Well, then the lib itself shouldn't be called KF5MediaWiki? > > > > But of course changing this is only possi

Re: Review Request 125514: Add a web shortcut manager

2015-10-11 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125514/#review86688 --- Ping ?:) - Laurent Montel On oct. 10, 2015, 12:56 après-mid

X11 on Windows

2015-10-11 Thread Martin Graesslin
Hi frameworks and windows devs, from the release announcement of the latest frameworks release I learned that there were multiple changes to disable finding X11 on Windows (e.g. [1]). I think such changes are wrong and I have spoken against such changes (they are wrong, CMake supports disabling

Review Request 125598: Allow KConfig to use resources as fallback config files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125598/ --- Review request for KDE Frameworks and David Faure. Repository: kconfig

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/#review86690 --- Ship it! Ship It! - David Faure On Oct. 11, 2015, 10:01 p.

Re: Review Request 125595: Alllow kxmlgui framework to be used without any installed files

2015-10-11 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125595/ --- (Updated Oct. 12, 2015, 6:52 a.m.) Status -- This change has been ma