Re: Review Request 126339: remove kdewin dependency

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126339/#review89580 --- Ship it! Ship It! - David Faure On Dec. 14, 2015, 10:37 a.

Re: Review Request 126362: Allow timeout in reset_oom_protection while waiting for SIGUSR1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126362/#review89577 --- Ship it! I hacked my kinit.git to not send the SIGUSR1 at all

Re: Review Request 126362: Allow timeout in reset_oom_protection while waiting for SIGUSR1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126362/#review89576 --- Ship it! I can confirm the change appears correct, though I'd

Re: kdeinit freezes on Wayland in OOM protection

On Tue, December 15, 2015 09:05:52 Martin Gräßlin wrote: > >> If the kill() call *is* reached then perhaps SIGUSR1 is > >> unintentionally masked > >> in the 'grandchild' process (the child of kdeinit about to be > >> exec()'d). > >> Perhaps something in the wayland/kwin/weston/x11 library interact

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 93 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Dec 2015 00:29:03 + Build duration: 2 min 30 sec CHANGE SET Revision 64bf23c85bb86e8e1a15bc7b

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 93 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/93/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 16 Dec 2015 00:29:03 + Build duration: 2 min 30 sec CHANGE SET Revision 64bf23c85bb86e8e1a15bc7b

Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126369/ --- Review request for KDE Software on Mac OS X and KDE Frameworks. Repositor

Re: system tray test?

René J. V. Bertin wrote: > Sebastian Kügler wrote: >> Seems to make sense to me. Could you file a review request for this? > > Ok, will put that on my todo list :) https://git.reviewboard.kde.org/r/126369/ :) R. ___ Kde-frameworks-devel mailing list

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/#review89562 --- kde-modules/KDETemplateGenerator.cmake (line 41)

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 84 > > > > > > Use ``KDE_INSTALL_KTEMPLATESDIR`` instead of > > ``KTEMPLATES_INSTALL_DIR``. You also need to docum

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. > > Marco Martin wrote: > I'm not sure what the

Re: lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

On Tuesday December 15 2015 18:55:52 René J.V. Bertin wrote: > for packaging purposes it would be preferable if all libraries (symlinks) > that are recorded in dependents' dependency lists are of the form > libKF5*.5.dylib or libKF5*.so.5 (KFileMetadata is the only deviant one). PS : KDE4's kfil

lib/x86_64-linux-gnu/libKF5FileMetaData.so | lib/libKF5FileMetaData.3.dylib

Out of curiosity: is it intended that KFileMetaData sets the library compatibility version to 3, leading to /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so.3 /opt/local/lib/x86_64-linux-gnu/libKF5FileMetaData.so.5.17.0 and on OS X %> o

Jenkins-kde-ci: kcoreaddons master stable-kf5-qt5 » Linux,gcc - Build # 92 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kcoreaddons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/92/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Dec 2015 16:14:27 + Build duration: 20 sec CHANGE SET No changes

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/ --- (Updated Dec. 15, 2015, 4:14 p.m.) Status -- This change has been ma

Re: Review Request 126348: Make it possible to provide the metadata in json

> On Dec. 14, 2015, 9:50 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread.cpp, line 189 > > > > > > Why this change? > > Aleix Pol Gonzalez wrote: > because currently it's not a text f

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/#review89556 --- src/kpackage/package.cpp (line 24)

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/#review89555 --- Ship it! If you have time, a minimal unit test would be nice

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/ --- (Updated Dec. 15, 2015, 4:27 p.m.) Review request for KDE Frameworks. C

Re: Review Request 126348: Make it possible to provide the metadata in json

> On Dec. 14, 2015, 10:50 p.m., Sebastian Kügler wrote: > > src/kpackage/private/packagejobthread.cpp, line 189 > > > > > > Why this change? because currently it's not a text file. I can commit separately if you

Re: Review Request 126348: Make it possible to provide the metadata in json

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126348/ --- (Updated Dec. 15, 2015, 4:24 p.m.) Review request for KDE Frameworks and

Re: Review Request 126366: Make KPluginMetaData constructible from a json path.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/#review89553 --- An autotest would be nice, and I think the ASSERT is too aggre

Review Request 126366: Make KPluginMetaData constructible from a json path.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126366/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Gru 15, 2015, 12:45 po południu) Review request for KDE Framewor

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/#review89538 --- src/kuitmarkup.h (line 193)

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Gru 14, 2015, 8:10 po południu, Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals.

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126350/ --- (Updated Gru 15, 2015, 12:34 po południu) Review request for KDE Framewor

Re: Review Request 126350: Fixed all Clazy level 1 and level 2 warnings

> On Dec. 14, 2015, 8:10 p.m., Sergio Martins wrote: > > src/klocalizedstring.cpp, line 389 > > > > > > this will break the build with MSVC, it doesn't support QStringLiteral > > with multi-line literals. > >

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:40 p.m., Alex Merry wrote: > > Ooh, also, please write a unit test. I can help with that if you find the > > idea of writing a CMake-based unit test daunting, but you can look in the > > tests directory for inspiration. I'm not sure what the test should do... perhaps havi

Re: Review Request 126185: Make the KAppTemplate CMake module global

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126185/ --- (Updated Dec. 15, 2015, 10:38 a.m.) Review request for Build System, KDE

Re: Review Request 126185: Make the KAppTemplate CMake module global

> On Dec. 12, 2015, 3:35 p.m., Alex Merry wrote: > > kde-modules/KDETemplateGenerator.cmake, line 14 > > > > > > OK, what needs to be in the subdirectory? are template1, template2 etc > > the subdriectory names?

about ki18n/locales: installing only a subset?

Hi, The KDE4 approach to internationalisation (sic :)) had the huge advantage that it was rather trivial to provide installer packages for individual languages so users could install only those few languages they would actually use. It seems that with KF5 we have gotten back in the situation whe

Review Request 126362: Allow timeout in reset_oom_protection while waiting for SIGUSR1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126362/ --- Review request for KDE Frameworks and Michael Pyne. Repository: kinit D

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 66 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Dec 2015 08:03:19 + Build duration: 2 min 30 sec CHANGE SET Revision aa412c02657828f68f2ac4a3a303853f25

Jenkins-kde-ci: kdeclarative master kf5-qt5 » Linux,gcc - Build # 66 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kdeclarative%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Dec 2015 08:03:19 + Build duration: 2 min 30 sec CHANGE SET Revision aa412c02657828f68f2ac4a3a303853f25

Jenkins-kde-ci: kdeclarative master stable-kf5-qt5 » Linux,gcc - Build # 66 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kdeclarative%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/66/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 15 Dec 2015 08:03:38 + Build duration: 10 sec CHANGE SET Revision aa412c02657828f68f2ac4a3a303853f2

Re: kdeinit freezes on Wayland in OOM protection

Am 2015-12-15 08:33, schrieb Martin Gräßlin: Am 2015-12-15 03:20, schrieb Michael Pyne: On Mon, December 14, 2015 16:07:38 Martin Graesslin wrote: On Friday, November 27, 2015 1:05:26 PM CET Michael Pyne wrote: > On Thu, November 26, 2015 13:16:04 Martin Graesslin wrote: > > we are facing a pro