Re: Review Request 127205: Add stubs to allow compilation on Android.

> On März 1, 2016, 12:26 vorm., Aleix Pol Gonzalez wrote: > > src/lib/CMakeLists.txt, line 116 > > > > > > Why does pthread make a difference? Bionic provides native built-in support for (limited set of) pthread

Review Request 127237: Fix crash in kmore tools when DBus is missing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127237/ --- Review request for KDE Frameworks and Gregor Mi. Repository: knewstuff

Re: Review Request 127232: Make breeze the default icon theme name for KIconThemes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127232/ --- (Updated March 1, 2016, 4:28 a.m.) Status -- This change has been di

Re: Review Request 127211: Properly use static QMaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/ --- (Updated Feb. 29, 2016, 7:26 p.m.) Status -- This change has been ma

Review Request 127236: Leverage QDir to know what's in a KIconThemeDir

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127236/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Re: Review Request 127232: Make breeze the default icon theme name for KIconThemes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127232/#review92960 --- This was already tried and reverted, see bug 336739 - Christ

Review Request 127233: Skip looking up . and .. to find the translations for an application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127233/ --- Review request for KDE Frameworks and Chusslove Illich. Repository: ki18n

Review Request 127232: Make breeze the default icon theme name for KIconThemes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127232/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kiconth

Re: QString -> QStringLiteral conversions might make applications crash on exit

On Monday, 29 February 2016 23:16:22 CET, Frank Reininghaus wrote: If something like "do not use QStringLiteral in plugins" will be the conclusion from this issue, then I'm all for continuing to use QStringLiteral everywhere else in order to avoid heap allocations. The conclusion is "do not unl

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 285 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/285/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Mar 2016 00:26:27 + Build duration: 2 min 13 sec CHANGE SET Revision 6

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 285 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/285/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Mar 2016 00:26:27 + Build duration: 2 min 13 sec CHANGE SET Revision 6

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 285 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/285/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 01 Mar 2016 00:26:27 + Build duration: 3 min 11 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 285 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/285/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 01 Mar 2016 00:26:27 + Build duration: 3 min 11 sec CHANGE SET Revisi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 292 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/292/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 01 Mar 2016 00:20:54 + Build duration: 2 min 34 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 292 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/292/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Tue, 01 Mar 2016 00:20:54 + Build duration: 2 min 34 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 292 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/292/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Mar 2016 00:20:54 + Build duration: 3 min 4 sec CHANGE SET Revi

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 292 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/292/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 01 Mar 2016 00:20:54 + Build duration: 3 min 4 sec CHANGE SET Revi

Re: Review Request 127205: Add stubs to allow compilation on Android.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127205/#review92959 --- src/lib/CMakeLists.txt (line 114)

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 284 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/284/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 29 Feb 2016 22:22:51 + Build duration: 2 min 20 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 284 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/284/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 29 Feb 2016 22:22:51 + Build duration: 3 min 11 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 291 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 29 Feb 2016 22:16:21 + Build duration: 2 min 17 sec CHANGE SE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 291 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/291/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 29 Feb 2016 22:16:21 + Build duration: 3 min 3 sec CHANGE SET Rev

Re: Review Request 127210: Fix warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127210/ --- (Updated Feb. 29, 2016, 11:42 p.m.) Status -- This change has been m

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 11:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 11:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

> On Feb. 29, 2016, 10:23 p.m., Andreas Kainz wrote: > > hi, heiko fill a bug report cause you cant see the x icon > > https://bugs.kde.org/show_bug.cgi?id=357210 but I am not sure that > > knewpassworddialog use an icon cause there is no x icon. is this icon used > > from KNewPasswordDialog?

Re: Review Request 126523: Use a KMessageWidget in KNewPasswordDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126523/#review92946 --- hi, heiko fill a bug report cause you cant see the x icon ht

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 283 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/283/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 29 Feb 2016 15:59:38 + Build duration: 2 min 57 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 283 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/283/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 29 Feb 2016 15:59:38 + Build duration: 3 min 31 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 290 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/290/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 29 Feb 2016 15:53:31 + Build duration: 2 min 21 sec CHANGE SE

Re: QString -> QStringLiteral conversions might make applications crash on exit

Hi, 2016-02-29 19:04 GMT+01:00 Milian Wolff: > On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: >> Hi everyone, >> >> sorry if most of you know about this already, but since it seems that >> QStringLiterals are being introduced everywhere right now, I think >> that it is import

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 290 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/290/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Mon, 29 Feb 2016 15:53:31 + Build duration: 2 min 49 sec CHANGE SET Re

Re: CMake Error when building attica

Works here, cc'ing the build-system and frameworks lists in case someone gets an idea of what may be wrong from the log. Cheers, Albert El Monday 29 February 2016, a les 22:26:49, Nilesh Kokane va escriure: > Hello, > > While building attica-5.19.0 cmake threw the following error. > > -- >

Re: Review Request 127180: kdeinit: Prefer loading libraries from RUNPATH

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127180/ --- (Updated Feb. 29, 2016, 11:36 p.m.) Status -- This change has been m

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 29, 2016, 11:05 p.m.) Status -- This change has been m

Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/ --- (Updated Фев. 29, 2016, 9:36 след обяд) Status -- This change has be

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review92926 --- This works in 50% of cases for me. I'm not sure if Quassel an

Re: Review Request 127210: Fix warnings

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127210/#review92925 --- Ship it! Ship It! - Martin Klapetek On Feb. 28, 2016, 9

Re: QString -> QStringLiteral conversions might make applications crash on exit

On Friday, February 26, 2016 1:37:57 AM CET Frank Reininghaus wrote: > Hi everyone, > > sorry if most of you know about this already, but since it seems that > QStringLiterals are being introduced everywhere right now, I think > that it is important to raise awareness about the fact that this migh

Review Request 127223: Don't emit destroyedChanged(true) twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127223/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127136/ --- (Updated Feb. 29, 2016, 4:14 p.m.) Status -- This change has been ma

Re: Review Request 127136: XmlGui: Use non native Language name as fallback in KSwitchlangaugeDialog

> On Feb. 27, 2016, 1:51 p.m., David Faure wrote: > > src/kswitchlanguagedialog_p.cpp, line 343 > > > > > > atleast windows -> at least Windows > > (missing space) As Thiago pointed out in the Bug report, my

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 282 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/282/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 28 Feb 2016 10:37:13 + Build duration: 2 min 31 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 289 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/289/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 28 Feb 2016 10:37:13 + Build duration: 3 min 11 sec CHANGE SET Re

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 282 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/282/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 28 Feb 2016 10:37:13 + Build duration: 3 min 34 sec CHANGE SET Revis

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 289 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/289/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sun, 28 Feb 2016 10:37:13 + Build duration: 2 min 30 sec CHANGE SE

Re: Review Request 127209: Fix some issues found by Coverity

> On Feb. 29, 2016, 4:30 p.m., Kai Uwe Broulik wrote: > > src/lib/io/kprocess_p.h, line 33 > > > > > > Why not have a constructor that takes the q ptr? > > > > The only code that uses it does: > > >

Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/#review92912 --- src/lib/io/kprocess_p.h (line 33)

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

> On Feb. 29, 2016, 2:15 p.m., Ivan Čukić wrote: > > Can you check the latest master - whether it builds - I've removed > > model_updaters from the ActivitiesModel. > > > > I have to say that I really hate MSVC... Yes, latest master builds unmodified. Thanks. Closing. > I have to say that I r

Re: Review Request 126991: Try multiple authentication methods in case of failures

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126991/ --- (Updated Feb. 29, 2016, 4:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- (Updated Feb. 29, 2016, 3:07 p.m.) Status -- This change has been di

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/#review92909 --- Can you check the latest master - whether it builds - I've re

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- (Updated Feb. 29, 2016, 1:54 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 127209: Fix some issues found by Coverity

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127209/ --- (Updated Feb. 29, 2016, 2:29 p.m.) Review request for KDE Frameworks. R

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 12:31 p.m., Kai Uwe Broulik wrote: > > src/sycoca/kbuildservicefactory.cpp, line 167 > > > > > > We can't use range-for in Frameworks, right? in this case i benefit from Q_FOREACH taking a co

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92899 --- src/sycoca/kbuildservicefactory.cpp (line 162)

Re: Review Request 127215: simplify code, reduce pointer dereferences

> On Feb. 29, 2016, 4:12 a.m., Aleix Pol Gonzalez wrote: > > src/sycoca/kbuildsycoca.cpp, line 246 > > > > > > foreach like you did above? for loops with simple body i prefer direct iterators to a copy-taking Q_

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/ --- (Updated Feb. 29, 2016, 12:27 p.m.) Review request for KDE Frameworks.

Re: Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/ --- (Updated Feb. 29, 2016, 12:10 p.m.) Status -- This change has been m

Re: Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/#review92893 --- Ship it! Ship It! - Marco Martin On Feb. 29, 2016, noon

Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 127211: Properly use static QMaps

> On Feb. 29, 2016, 10:36 a.m., Milian Wolff wrote: > > even better would be to use > > > > static const QHash map = { > > {QStringLiteral(...), value}, // NOTE: don't use QLatin1String here! > > ... > > }; > > return map[mapCommand]; QStringLiteral here would break

Re: Review Request 127211: Properly use static QMaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127211/#review92889 --- Ship it! even better would be to use static const QHa

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127187/ --- (Updated Feb. 29, 2016, 9:49 a.m.) Review request for KDE Frameworks, kde

Re: Review Request 127216: [KStatusNotifierItem] MinimizeRestore does not "run" over the desktop on X11

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127216/#review92888 --- just store the widget/window position when hiding the window

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92886 --- Ship it! Ship It! - Marco Martin On Feb. 28, 2016, 5:15

Re: Review Request 127215: simplify code, reduce pointer dereferences

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127215/#review92884 --- About the unittest failure, I'm available by email to debug t