Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127398/ --- Review request for KDE Frameworks. Repository: knotifications

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 321 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/321/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 17 Mar 2016 17:30:33 + Build duration: 1 min 57 sec CHANGE SET

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93749 --- src/kcompletionbox.cpp (line 282)

Qt 5.6/QtWebkit

Hi, Is there a page/site somewhere that outlines the current status of Qt 5.6/KF5 compatibility, notably as far as QtWebkit is concerned? A quick search (KF5 qt5.6 qtwebkit) didn't turn up any particularly useful hits in the first page or so, other than that one can apparently still build

Re: Qt 5.6/QtWebkit

Kevin Funk wrote: > I think qt-developm...@qt-project.org is a better fit for this question. Good call. From Jani Heikkinen: > Webkit packages can be found from here: > http://download.qt.io/community_releases/5.6/5.6.0/ R. ___

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/#review93660 --- The only real difference to the original version is that the

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 320 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/320/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 17 Mar 2016 12:40:31 + Build duration: 3 min 13 sec CHANGE SET Revision

Re: Review Request 125965: Add declarative plugin to KHolidays

> On Nov. 6, 2015, 3:29 p.m., Nick Shaforostoff wrote: > > src/declarative/holidayregionsmodel.cpp, line 81 > > > > > > i suggest enclosing strings into QByteArrayLiteral. > > > > see

Re: Qt 5.6/QtWebkit

Aleix Pol wrote: > WebKit integration was done through forking then integrating. It was > awkward because merging upstream changes meant rebasing our work on > theirs. > That's why it's Chromium is better in this regard, you get to interact > the upstream component without forking it, AFAIU.

oxygen icon name clasheroo

Hola! Our most awesome icon maintainers wanted to carry over icon symlinking from breeze to oxygen, alas that turned up a whole slew of compatibility problems. examples: https://bugs.kde.org/show_bug.cgi?id=360605 https://bugs.kde.org/show_bug.cgi?id=360510 # Problem In kde4 software people

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On March 19, 2016, 1:22 p.m., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127380: More conservative approach to saving some disk accesses

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127380/#review93636 --- Since you asked for review: I don't know the code enough to

Jenkins and XDG_DATA_DIRS

It appears that something regressed in the jenkins setup. Almost all of the current failures in the "Frameworks kf5-qt5" group come from XDG_DATA_DIRS not being set up correctly anymore, I think. E.g. in

Re: Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127428/#review93738 --- Ship it! Ship It! - Allen Winter On March 19, 2016,

Re: Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127428/#review93737 --- Ship it! Looks good to me (can definitely not hurt to

Re: Qt 5.6/QtWebkit

On Friday March 18 2016 17:39:18 Milian Wolff wrote: > > If so it seems it should have been possible to reimplement QtWebKit using a > > similar approach with probably far fewer API changes. > > Which WebKit implementation would you have chosen? The GTK one? Huh?? Upstream WebKit is probably

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Review Request 127414: Don't enable acl permissions widget if we don't own the file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127414/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 127428: KEmoticons: fix crash when loadProvider fails for some reason.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127428/ --- Review request for KDE Frameworks. Repository: kemoticons Description

Review Request 127406: Fix encoding for gap.xml (use UTF-8)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127406/ --- Review request for Kate, KDE Frameworks and Daniel Vrátil. Repository:

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive.

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On Март 19, 2016, 3:22 след обяд, Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On Март 19, 2016, 3:22 след обяд, Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

> On März 17, 2016, 5:26 nachm., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive.

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127405/#review93652 --- Ship it! Ship It! - Sebastian Kügler On March 17,

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127406/#review93635 --- Ship it! Ship It! - Kevin Funk On March 17, 2016,

Raising Qt requirement to Qt 5.4

Hi all, with todays release of Qt 5.6 I suggest that we raise the minimum Qt version requirement to 5.4. This would mean the latest three releases are supported. The important new features in Qt 5.4 in my opinion for frameworks development are: * QSignalSpy(const QObject *object,

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

> On March 17, 2016, 5:26 p.m., Dominik Haumann wrote: > > The only real difference to the original version is that the line > > > > int isMtpDevice = LIBMTP_Check_Specific_Device(solidBusNum, > > solidDevNum); > > > > is removed. This somehow implies that this check is too restrictive.

Re: Review Request 127386: kio-extras mtp protocol: Add support for Windows Phones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127386/ --- (Updated March 16, 2016, 4:41 p.m.) Review request for KDE Frameworks,

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 16, 2016, 11:40 a.m.) Status -- This change has been

Jenkins-kde-ci: ktexteditor master kf5-qt5 » Linux,gcc - Build # 203 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ktexteditor%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/203/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 18 Mar 2016 13:10:48 + Build duration: 6 min 8 sec CHANGE SET Revision

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/#review93633 --- Did you also check that on Wayland? There it is important to

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 321 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/321/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 17 Mar 2016 17:30:33 + Build duration: 2 min 16 sec CHANGE SET Revision

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/#review93640 --- works for me, thanks! - Andreas Sturmlechner On March 17,

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

> On März 19, 2016, 1:22 nachm., Thomas Lübking wrote: > > "Loose focus" is the complete wrong concept anyway. > > It makes kickoff and various other plasmashell elements barely usable w/ > > any but the click-to-focus policy (implicit hide) > > > > Try adding Qt::FramelessWindowHint

Re: Review Request 125965: Add declarative plugin to KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/ --- (Updated March 16, 2016, 9:24 p.m.) Status -- This change has been

Re: Review Request 127380: More conservative approach to saving some disk accesses

> On March 17, 2016, 8:57 a.m., Kevin Funk wrote: > > Since you asked for review: I don't know the code enough to judge. > > Generally I'd say "yes". > > > > Does `iconPath(..., KIconLoader::MatchBest)` return results you'd have > > received with `iconPath(..., KIconLoader::MatchExact)`? I

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 16, 2016, 11:40 a.m.) Status -- This change has been

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127405/#review93629 --- Thanks, this fixes building of plasma-workspace on my

Review Request 127415: Set the appropriate feature test macro definitions to enable building on musl libc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127415/ --- Review request for KDE Frameworks. Repository: kdesu Description

Re: Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/#review93716 --- "Loose focus" is the complete wrong concept anyway. It makes

Re: Qt 5.6/QtWebkit

On Wednesday, March 16, 2016 5:59:30 PM CET René J. V. Bertin wrote: > Aleix Pol wrote: > > https://code.qt.io/cgit/qt/qtwebkit.git/ > > Right, thanks, I'd seen that one too (there's also a clone on github but it > isn't clear how recent/unmodified that one is). > > What I didn't yet see is if

Re: Review Request 127271: Disable session restore for kwalletd5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127271/#review93622 --- Ship it! Ship It! - David Faure On March 11, 2016,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 254 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/254/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 19 Mar 2016 11:23:52 + Build duration: 4 min 55 sec CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 269 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/269/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 19 Mar 2016 11:23:52 + Build duration: 4 min 33 sec CHANGE SET Revision bf37e9aa27a2321f4a6ce7188a0901fabd47c962

Re: Raising Qt requirement to Qt 5.4

Hi all, IIRC, the last time we talked about this we decided (I'll try to find the e-mail thread when I get back home, IIRC the conclusion was by dfaure) on KF5 always support the two last versions of Qt. This was decided so that we do not need to have threads like these every time we want to

Review Request 127424: KCompletionBox popup gets full window decoration on Windows

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127424/ --- Review request for KDE Frameworks, kwin and Marco Martin. Repository:

Re: Review Request 125965: Add declarative plugin to KHolidays

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125965/#review93625 --- Ok so I shipped this because I realized KHolidays is still

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/#review93651 --- Change looks good. Would it be possible to get a test? -

Re: Qt 5.6/QtWebkit

On Wed, Mar 16, 2016 at 12:52 PM, René J.V. wrote: > Hi, > > Is there a page/site somewhere that outlines the current status of Qt > 5.6/KF5 compatibility, notably as far as QtWebkit is concerned? > > A quick search (KF5 qt5.6 qtwebkit) didn't turn up any particularly useful

Re: Review Request 127154: GUI option to configure global MarkPartial for KIO slaves

> On Feb. 27, 2016, 11:11 a.m., David Faure wrote: > > It seems weird to have a setting for FTP on one side, and a setting for > > "SMB and SFTP and any slave where this is implemented in the future". > > I understand that it was the path of least code changes, but I fear this > > creates an

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127398/#review93674 --- src/knotification.cpp (line 396)

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/ --- (Updated March 19, 2016, 11:23 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 323 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/323/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 17 Mar 2016 17:30:33 + Build duration: 2 min 52 sec CHANGE

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

> On March 17, 2016, 12:29 p.m., Aleix Pol Gonzalez wrote: > > Change looks good. > > > > Would it be possible to get a test? > > Emmanuel Pescosta wrote: > > Would it be possible to get a test? > > autotest (is it allowed to show a dialog in KF autotests?) or more like >

Re: Raising Qt requirement to Qt 5.4

El dimecres, 16 de març de 2016, a les 13:13:36 CET, Martin Graesslin va escriure: > Hi all, > > with todays release of Qt 5.6 I suggest that we raise the minimum Qt version > requirement to 5.4. This would mean the latest three releases are > supported. > > The important new features in Qt 5.4

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

> On March 17, 2016, 1:29 p.m., Aleix Pol Gonzalez wrote: > > Change looks good. > > > > Would it be possible to get a test? > > Emmanuel Pescosta wrote: > > Would it be possible to get a test? > > autotest (is it allowed to show a dialog in KF autotests?) or more like >

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127405/ --- (Updated March 17, 2016, 1:40 p.m.) Status -- This change has been

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

> On March 17, 2016, 12:29 p.m., Aleix Pol Gonzalez wrote: > > Change looks good. > > > > Would it be possible to get a test? > > Emmanuel Pescosta wrote: > > Would it be possible to get a test? > > autotest (is it allowed to show a dialog in KF autotests?) or more like >

Re: Review Request 127410: Fix crash in rename dialog (KF 5.20)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/#review93710 --- Ship it! Oops, thanks for the fix. - David Faure On

Re: Review Request 127353: [KPasswordDialog] Clear button image overlay echo button one

> On Март 12, 2016, 5:07 след обяд, Christoph Feck wrote: > > Can someone confirm the issue is still present with Qt 5.6? > > > > Unless it is, I suggest to not work around the Qt bug, because the release > > of Qt 5.6 is imminent and this fix does not reach our users earlier. > > Luigi

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,All,gcc - Build # 322 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/322/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 19 Mar 2016 08:04:24 + Build duration: 2 min 54 sec CHANGE SET Revision

Re: Review Request 127405: Make sure PlasmaQuick export file is properly found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127405/#review93649 --- src/plasmaquick/appletquickitem.h (line 31)

Re: Review Request 127326: [KNotification] KNofication remove leak and missing emit closed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127326/ --- (Updated Март 16, 2016, 11:33 след обяд) Status -- This change has

Re: building everything with a set of specific preprocessor token(s)/definition(s)?

Boudhayan Gupta wrote: Sorry, I've been overlooking this thread completely (been going through a bit of a rough patch in life). > > CC="gcc -DWHATEVER_DEFINE" cmake ... > > It really should be as simple as that. Yeah, except that this would very likely apply too: > There's also an

Review Request 127405: Make sure PlasmaQuick export file is properly found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127405/ --- Review request for KDE Frameworks and Plasma. Repository:

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 322 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/322/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 17 Mar 2016 12:40:31 + Build duration: 2 min 43 sec CHANGE

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 320 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/320/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Thu, 17 Mar 2016 12:40:31 + Build duration: 2 min 21 sec CHANGE SET

Re: Qt 5.6/QtWebkit

On Thu, Mar 17, 2016 at 10:54 AM, René J. V. wrote: > David Edmundson wrote: > >> There was a thread "Policy regarding QtWebKit and QtScript" on >> kde-core-devel a while ago. >> http://kde.6490.n7.nabble.com/Policy-regarding-QtWebKit-and-QtScript-td1619988.html > > What I'm

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 324 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/324/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 19 Mar 2016 08:04:24 + Build duration: 2 min 13 sec CHANGE

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 324 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/324/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sat, 19 Mar 2016 08:04:24 + Build duration: 2 min 56 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master kf5-qt5 » Linux,NoX11,gcc - Build # 322 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/322/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Sat, 19 Mar 2016 08:04:24 + Build duration: 2 min 10 sec CHANGE SET

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

> On March 17, 2016, 8:46 a.m., Kevin Funk wrote: > > Ship It! > > Dominik Haumann wrote: > sorry to be late here, but please increase the version number in the > language element. otherwise internal caches are not rebuilt... Sure, done in 7c93a9032ad2296f1141a7c21e3779bf65f96e82 (in

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 323 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/323/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Thu, 17 Mar 2016 17:30:33 + Build duration: 2 min 26 sec CHANGE SET

Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Qt 5.6/QtWebkit (got it, now to build it)

René J. V. Bertin wrote: >> Webkit packages can be found from here: >> http://download.qt.io/community_releases/5.6/5.6.0/ I presume there must be at least one member on this list who managed to build QtWebKit 5.6.0 (and remembers how)? Sorry about asking on here, but I'm not getting any

Re: Review Request 127398: Add unit tests for KNotification and fix a whole bunch of issues uncovered thanks to them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127398/#review93676 --- src/knotification.cpp (line 63)

Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/#review93685 --- Ship it! Ship It! - Sebastian Kügler On March 18,

Re: Review Request 127418: Set text on QCheckbox widget rather than using a separate label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/ --- (Updated March 18, 2016, 2:51 a.m.) Review request for KDE Frameworks.

Re: Qt 5.6/QtWebkit

On Donnerstag, 17. März 2016 14:52:15 CET René J. V. Bertin wrote: > Aleix Pol wrote: > > WebKit integration was done through forking then integrating. It was > > awkward because merging upstream changes meant rebasing our work on > > theirs. > > That's why it's Chromium is better in this regard,

Re: Qt 5.6/QtWebkit

On Wed, Mar 16, 2016 at 2:54 PM, René J. V. wrote: > David Edmundson wrote: > > >> There was a thread "Policy regarding QtWebKit and QtScript" on >> kde-core-devel a while ago. >> http://kde.6490.n7.nabble.com/Policy-regarding-QtWebKit-and-QtScript-td1619988.html > > Indeed

Re: Review Request 127406: Fix encoding for gap.xml (use UTF-8)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127406/ --- (Updated March 17, 2016, 9:17 p.m.) Status -- This change has been

Review Request 127410: Fix crash in rename dialog (KF 5.20)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127410/ --- Review request for KDE Frameworks, Andreas Sturmlechner and David Faure.

Review Request 127418: Set text on QCheckbox widget rather than using a separate label

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127418/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Qt 5.6/QtWebkit

David Edmundson wrote: > There was a thread "Policy regarding QtWebKit and QtScript" on > kde-core-devel a while ago. > http://kde.6490.n7.nabble.com/Policy-regarding-QtWebKit-and-QtScript-td1619988.html What I'm missing (as in not getting) in that discussion is the whole thing about