Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 22 - Still Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/22/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Wed, 04 May 2016 05:45:00 + Build duration: 7 min 59 sec CHANGE SET No

Re: Review Request 127655: Fix KAboutData::applicationData() to init from current Q*Application metadata

2016-05-03 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127655/#review95147 --- Fix it, then Ship it! A couple of minor things but this

Re: Find out whether a file is a remote file or not

2016-05-03 Thread Vishesh Handa
On Sun, May 1, 2016 at 6:28 PM, Dominik Haumann wrote: > > CC: Vishesh, since maybe baloo also had to solve these issues We mostly just use Solid to query the list of mount points and ignore non local stuff. baloo/src/file/storagedevices.h -- Vishesh Handa

Jenkins-kde-ci: breeze-icons master stable-kf5-qt5 » Linux,gcc - Build # 83 - Failure!

2016-05-03 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/breeze-icons%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 20:45:48 + Build duration: 4 min 23 sec CHANGE SET Revision

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:32:15 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: khtml master stable-kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khtml%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:32:15 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kdelibs4support master stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:32:15 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 42 - Still Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:37:28 + Build duration: 4 min 20 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kdelibs4support master kf5-qt5 » Linux,gcc - Build # 24 - Still Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kdelibs4support%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:29:33 + Build duration: 4 min 39 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-03 Thread Allen Winter
> On May 3, 2016, 2:30 p.m., Jan Grulich wrote: > > That doesn't make much sense to me, if you are getting that error then it > > means either LastSeen property was introduced in older NM version or it was > > backported in your distribution. I'll check that and update that > >

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 29 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:18:33 + Build duration: 6 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kservice master kf5-qt5 » Linux,gcc - Build # 29 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kservice%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/29/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:18:33 + Build duration: 6 min 2 sec CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: kpty master stable-kf5-qt5 » Linux,gcc - Build # 23 - Still Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:22:31 + Build duration: 57 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kpty master kf5-qt5 » Linux,gcc - Build # 24 - Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kpty%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/24/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:18:33 + Build duration: 56 sec CHANGE SET No changes JUNIT RESULTS Name: (root)

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 21 - Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/21/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 15:17:09 + Build duration: 4 min 16 sec CHANGE SET No

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:09:59 + Build duration: 2 min 51 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: kwidgetsaddons master kf5-qt5 » Linux,gcc - Build # 18 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwidgetsaddons%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/18/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 15:09:59 + Build duration: 2 min 51 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-03 Thread Jan Grulich
> On Kvě. 3, 2016, 2:30 odp., Jan Grulich wrote: > > That doesn't make much sense to me, if you are getting that error then it > > means either LastSeen property was introduced in older NM version or it was > > backported in your distribution. I'll check that and update that > >

Re: Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-03 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127825/#review95140 --- That doesn't make much sense to me, if you are getting that

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 21 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/21/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 14:08:03 + Build duration: 2 min 55 sec CHANGE SET Revision

Re: Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

2016-05-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127819/#review95139 --- Ship it! Ship It! - Sebastian Kügler On May 3, 2016,

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 20 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/20/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 14:08:03 + Build duration: 2 min 28 sec CHANGE SET

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 20 - Fixed!

2016-05-03 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/20/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 14:08:03 + Build duration: 2 min 28 sec CHANGE SET

Re: Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

2016-05-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127819/ --- (Updated May 3, 2016, 5:07 p.m.) Status -- This change has been

Review Request 127825: networkmanager-qt: Don't complain so much about unhandled LastSeen property

2016-05-03 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127825/ --- Review request for KDE Frameworks and Jan Grulich. Bugs: 362611

Re: Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

2016-05-03 Thread René J . V . Bertin
> On May 3, 2016, 2:42 p.m., Aleix Pol Gonzalez wrote: > > Is this specific to Attica or it will happen on other frameworks? I have a > > memory of having such an issue worked on at some point. Hah... The principal applies universally of course, to all filesystems that will silently accept

Review Request 127822: address the potential name/case clash of the Attica/Attica and Attica/attica header dirs

2016-05-03 Thread René J . V . Bertin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127822/ --- Review request for KDE Software on Mac OS X and KDE Frameworks.

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

2016-05-03 Thread Anthony Fieroni
> On Май 3, 2016, 1:49 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > > > > > should this line still be here? > > Anthony Fieroni wrote: > dataengine.cpp:305 and 319 is

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

2016-05-03 Thread Anthony Fieroni
> On Май 3, 2016, 1:49 след обяд, David Edmundson wrote: > > src/plasma/dataengine.cpp, line 573 > > > > > > should this line still be here? dataengine.cpp:305 and 319 is emitted, so this slot is called after

Re: Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

2016-05-03 Thread Kai Uwe Broulik
> On Mai 3, 2016, 10:38 vorm., Aleix Pol Gonzalez wrote: > > autotests/netwininfotestwm.cpp, line 119 > > > > > > You can drom the parenthesis: `QStringList({})` -> `QStringList{}`. It > > might call the copy

Re: Review Request 127795: [DataEngine] Invalidate DataEngine on unknown plugin + detailed test

2016-05-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127795/#review95130 --- src/plasma/dataengine.cpp

Re: case in filenames

2016-05-03 Thread René J . V . Bertin
Michael Pyne wrote: > 2. Do not rely on file names that differ only in case (e.g. don't install a > fileA.foo and FileA.foo and expect to be able to open a precise one of those > two later) > > As far as temp file names and things like that, it would be incumbent on the > code generating such

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-03 Thread Anthony Fieroni
> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-03 Thread Anthony Fieroni
> On Май 2, 2016, 5:02 след обяд, Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Re: Review Request for KWayland for inclusion in frameworks

2016-05-03 Thread David Faure
On Tuesday 03 May 2016 07:59:29 Martin Graesslin wrote: > Hi David, > > did you forget to update the version number of KWayland to 5.22 or is > something still missing in KWayland? Neither, kwayland just wasn't in the list of modules yet, that's further in the process. The step1 version

Re: Review Request 127809: [Platform xcb] Get best icon size when he's not specified

2016-05-03 Thread Martin Gräßlin
> On May 2, 2016, 4:02 p.m., Martin Gräßlin wrote: > > What is the "best" size if it's not specified? Why is your change better > > than how it was? > > > > This change adjusts a very important part of the icon lookup functionality > > used by KWin and Plasma. I'm a little bit scared of

Review Request 127819: [autotests] Use -displayfd as argument to start Xvfb

2016-05-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127819/ --- Review request for KDE Frameworks. Repository: kwindowsystem

Re: Review Request 127694: Add a Find module for WaylandProtocols

2016-05-03 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127694/ --- (Updated May 3, 2016, 8:15 a.m.) Review request for Extra Cmake Modules,

Jenkins-kde-ci: kwindowsystem master kf5-qt5 » Linux,All,gcc - Build # 20 - Still Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/20/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 05:57:36 + Build duration: 2 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: kwindowsystem master stable-kf5-qt5 » Linux,All,gcc - Build # 19 - Unstable!

2016-05-03 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kwindowsystem%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/19/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Tue, 03 May 2016 05:57:36 + Build duration: 3 min 8 sec CHANGE SET

Re: Review Request for KWayland for inclusion in frameworks

2016-05-03 Thread Martin Graesslin
Hi David, did you forget to update the version number of KWayland to 5.22 or is something still missing in KWayland? Cheers Martin On Sunday, April 17, 2016 10:42:08 AM CEST David Faure wrote: > Hi Martin, > > Very nice run down of the check list! > > I approve the move of kwayland to