Review Request 128904: Avoid creating a KPluginInfo from a KPluginMetaData instance

2016-09-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128904/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 128892: Open baloo lmdb database read-only beside in baloo_file/baloo_file_extractor + balooctl (for some commands) + unit tests

2016-09-13 Thread Milian Wolff
> On Sept. 11, 2016, 9:35 p.m., Vishesh Handa wrote: > > This is awesome. Ship it. > > Christoph Cullmann wrote: > Lets hope it is awesome correct. :D - Milian --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

2016-09-13 Thread Andreas Kainz
> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? > > Andreas Kainz wrote: > I would use visibility and hint to show/hide the font's that are not > available in the selected font. will the font change to "not selected" grayed >

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

2016-09-13 Thread Andreas Kainz
> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? > > Andreas Kainz wrote: > I would use visibility and hint to show/hide the font's that are not > available in the selected font. will the font change to "not selected" grayed >

Re: C++11 & friends

2016-09-13 Thread Kevin Funk
On Monday, 12 September 2016 09:10:46 CEST Jaroslaw Staniek wrote: > On 12 September 2016 at 08:04, Kevin Funk wrote: > > On Sunday, 11 September 2016 03:21:21 CEST Dominik Haumann wrote: > > > Hi all, > > > > > > I just saw a commit by Volker turning nullptr into Q_NULLPTR with

Re: Review Request 128680: [KCharSelect] Add ToolButton for disabling characters not available in selected font

2016-09-13 Thread Heiko Tietze
> On Sept. 4, 2016, 2:34 vorm., Christoph Feck wrote: > > Andreas, any idea which icon the action could use? > > Andreas Kainz wrote: > I would use visibility and hint to show/hide the font's that are not > available in the selected font. will the font change to "not selected" grayed >