Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

> On Окт. 31, 2016, 12:38 преди обяд, David Faure wrote: > > src/core/kcoredirlister.h, line 429 > > > > > > You can't add virtual methods to a public class, this is not binary > > compatible. That because

[Differential] [Closed] D3178: Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES

apol closed this revision. REVISION DETAIL https://phabricator.kde.org/D3178 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #frameworks, dfaure Cc: dfaure

Re: Review Request 129280: Fix editing autostart items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/#review100415 --- Ship it! You could improve performance by using the same

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

> On Oct. 30, 2016, 10:38 p.m., David Faure wrote: > > KCoreDirLister is complex enough, I'd rather not add features to it. > > > > Let's take a step back. > > > > This looks like an already solved problem to me, if I understand it > > correctly: > > - a kioslave creates a virtual filesystem

Re: Review Request 129170: Add KArchive::errorString() method to provide more details on KArchive errors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129170/#review100413 --- autotests/karchivetest.cpp (line 369)

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/#review100411 --- KCoreDirLister is complex enough, I'd rather not add

Re: Review Request 129280: Fix editing autostart items

> On Oct. 30, 2016, 10:20 a.m., David Faure wrote: > > src/widgets/kpropertiesdialog.cpp, line 1242 > > > > > > But this returns the *parent* of base, right? > > > > I guess what we need here is rather

Re: Review Request 129280: Fix editing autostart items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/ --- (Updated Oct. 30, 2016, 10:36 p.m.) Review request for KDE Frameworks

Re: Review Request 129283: kwidgetaddons - add overrides

> On Oct. 30, 2016, 2:22 p.m., Christoph Feck wrote: > > src/kcursor_p.h, line 46 > > > > > > Do we remove the "virtual" keyword? Or would that mean that subclasses > > can no longer override? > > Dominik

Re: Review Request 129283: kwidgetaddons - add overrides

> On Oct. 30, 2016, 2:22 p.m., Christoph Feck wrote: > > src/kcursor_p.h, line 46 > > > > > > Do we remove the "virtual" keyword? Or would that mean that subclasses > > can no longer override? Personally, I

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/#review100404 --- I don't know about this... It smells like an "eliphant

Re: Review Request 129283: kwidgetaddons - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/#review100403 --- Ship it! Ship It! src/kcursor_p.h (line 46)

Review Request 129283: kwidgetaddons - add overrides

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129283/ --- Review request for KDE Frameworks. Repository: kwidgetsaddons

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 252 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/252/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 11:53:19 + Build duration: 12 min CHANGE SET Revision

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 250 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 11:53:19 + Build duration: 6 min 25 sec CHANGE SET Revision 36e730f22480ea7f4bb425ddfcc5ad6da445cfcd

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 250 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 11:53:19 + Build duration: 6 min 25 sec CHANGE SET Revision 36e730f22480ea7f4bb425ddfcc5ad6da445cfcd

Re: Review Request 129205: [kcoredirlister] Ability to watch files changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129205/#review100401 --- Ping, any suggestions? - Anthony Fieroni On Окт. 24,

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/ --- (Updated Oct. 30, 2016, 2:52 p.m.) Status -- This change has been

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100400 --- Ship it! Well, call me a nitpicker, but nothing in the

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 251 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 11:32:58 + Build duration: 5 min 12 sec CHANGE SET Revision

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 251 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 11:32:58 + Build duration: 5 min 12 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 232 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/232/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 30 Oct 2016 11:31:48 + Build duration: 4 min 22 sec CHANGE SET

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 232 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/232/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 30 Oct 2016 11:31:48 + Build duration: 4 min 22 sec CHANGE SET

Re: Review Request 128767: Fix crash when no QApplication is available.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128767/ --- (Updated Oct. 30, 2016, 11:31 a.m.) Status -- This change has been

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/ --- (Updated Oct. 30, 2016, 11:25 a.m.) Review request for KDE Frameworks

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100399 --- src/core/storedtransferjob.h (line 92)

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100398 --- Ship it! Ship It! - David Faure On Oct. 30, 2016,

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/ --- (Updated Oct. 30, 2016, 11:17 a.m.) Review request for KDE Frameworks

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/#review100396 --- autotests/jobtest.cpp (line 276)

Re: Review Request 129275: StoredTransferJob: add failing test case

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129275/ --- (Updated Oct. 30, 2016, 11:05 a.m.) Review request for KDE Frameworks

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On Oct. 30, 2016, 10:27 a.m., David Faure wrote: > > Right. We have Shift+Del as an alternate shortcut for cut because when I > > switched from Windows to Linux (last millenium!), I had taken the habit to > > use Ctrl+Insert, Shift+Del, and Shift+Insert for copy/cut/paste (these are > >

Re: Review Request 129275: StoredTransferJob: add failing test case

> On Oct. 29, 2016, 7:49 p.m., David Faure wrote: > > autotests/jobtest.cpp, line 283 > > > > > > It's stream.flush() that you need, to tell QTextStream to do the actual > > writing to the underlying device. >

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

> On okt 30, 2016, 10:27 a.m., David Faure wrote: > > Right. We have Shift+Del as an alternate shortcut for cut because when I > > switched from Windows to Linux (last millenium!), I had taken the habit to > > use Ctrl+Insert, Shift+Del, and Shift+Insert for copy/cut/paste (these are > >

Re: Review Request 129251: Remove Shift+Del as secondary shortcut for Cut

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129251/#review100392 --- Right. We have Shift+Del as an alternate shortcut for cut

Jenkins-kde-ci: kparts master kf5-qt5 » Linux,gcc - Build # 250 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kparts%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/250/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 10:17:38 + Build duration: 29 sec CHANGE SET No changes

Re: Review Request 129275: StoredTransferJob: add failing test case

> On Oct. 29, 2016, 7:49 p.m., David Faure wrote: > > autotests/jobtest.cpp, line 283 > > > > > > It's stream.flush() that you need, to tell QTextStream to do the actual > > writing to the underlying device. >

Re: Review Request 129280: Fix editing autostart items

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129280/#review100390 --- src/widgets/kpropertiesdialog.cpp (line 1242)

Jenkins-kde-ci: kio master kf5-qt5 » Linux,gcc - Build # 249 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/249/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 10:09:22 + Build duration: 7 min 4 sec CHANGE SET Revision b1d709bdc7eb26618a953cf8d897c41cc1b205f7

[Differential] [Accepted] D3178: Make kconfig_compiler autotests use the KCONFIG_ADD_KCFG_FILES

dfaure accepted this revision. dfaure added a reviewer: dfaure. dfaure added a comment. This revision is now accepted and ready to land. Looks sensible to me. BRANCH master REVISION DETAIL https://phabricator.kde.org/D3178 EMAIL PREFERENCES

Re: Review Request 129271: [KOpenWithDialog] Hide TreeView header

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129271/#review100389 --- Ship it! Ship It! - David Faure On Oct. 28, 2016,

Jenkins-kde-ci: kio master stable-kf5-qt5 » Linux,gcc - Build # 251 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/kio%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/251/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 30 Oct 2016 10:09:22 + Build duration: 4 min 43 sec CHANGE SET Revision

Re: ABI break checking in frameworks

On mercredi 26 octobre 2016 23:54:33 CET Albert Astals Cid wrote: > 2) Make it a manual step (sorry David), we could have a script that for > every release downloads and compiles the tarballs of it and the previous > version and runs abidiff on them. > > > Currently I am kind of leaning towards

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 231 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=All,compiler=gcc/231/ Project: PLATFORM=Linux,Variation=All,compiler=gcc Date of build: Sun, 30 Oct 2016 09:16:09 + Build duration: 6 min 22 sec CHANGE SET