Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Nov. 15, 2016, 6:40 p.m., David Faure wrote: > > This fix makes sense to me (well, I suggested it) ;) > > > > As to why it doesn't work, that requires more info about how filenamesearch > > URLs are actually being used. Is this documented somewhere, or does it > > require testing and debu

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129394/#review101007 --- filenamesearch/kded/filenamesearchmodule.cpp (line 84)

Re: Review Request 129426: refactor gpg finding

> On Nov. 18, 2016, 8:05 p.m., Andreas Sturmlechner wrote: > > CMakeLists.txt, line 37 > > > > > > that looks to me as if it does the opposite as in $description; prefer > > the old one to the new one. > > Haral

Re: Review Request 129426: refactor gpg finding

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129426/ --- (Updated Nov. 21, 2016, 8:50 a.m.) Review request for KDE Frameworks. C

Review Request 129517: don't ignore return value, verify it

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129517/ --- Review request for KDE Frameworks. Repository: syntax-highlighting Desc

Re: [KUnitConversion] Question about overloading operators

Hi Aleix, I think at least the most desirable basic feature would be to have the math operators overloaded to be able to operate with Values. Something like : Value operator +(const Value &other) { Q_ASSERT( unit() == other.unit() ); return Value( number() + other.number() , unit()

Re: [KUnitConversion] Question about overloading operators

On Monday, November 21, 2016 8:27:11 AM CET Ander Pijoan wrote: > Hi Aleix, > > I think at least the most desirable basic feature would be to have the > math operators overloaded to be able to operate with Values. Something like > > > Value operator +(const Value &other) > { > Q_ASSERT( un

Re: Review Request 129475: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129475/#review101015 --- Ship it! Ship It! - Marco Martin On Nov. 20, 2016, 4:2

Re: Review Request 129503: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129503/#review101016 --- Ship it! Ship It! - Marco Martin On Nov. 20, 2016, 4:2

Re: Review Request 129419: FrameworksIntegration: Let KPackage have dependencies from packagekit and KNewStuff

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129419/#review101018 --- src/kpackage-install-handlers/appstream/main.cpp (line 15)

Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/ --- Review request for KDE Frameworks, Plasma, Aleix Pol Gonzalez, and Marco Ma

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/#review101021 --- autotests/mockdepresolver/main.cpp (line 26)

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/#review101022 --- autotests/mockdepresolver/CMakeLists.txt (line 3)

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

> On Nov. 21, 2016, 8:19 p.m., Marco Martin wrote: > > autotests/mockdepresolver/CMakeLists.txt, line 3 > > > > > > if qstandardpath is in test mode, would findExecutable() search in > > .qttest as well? We are n

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/#review101023 --- autotests/mockdepresolver/CMakeLists.txt (line 3)

Re: Review Request 129445: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129445/#review101028 --- Ship it! Ship It! - Olivier Churlaud On Nov. 20, 2016,

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/ --- (Updated Nov. 21, 2016, 9:29 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/#review101029 --- Ship it! Ship It! - Marco Martin On Nov. 21, 2016, 3:5

Re: Review Request 129520: [autotests] Add mock kpackage dep resolver for autotests

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129520/ --- (Updated Nov. 21, 2016, 4:26 p.m.) Status -- This change has been ma

Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,NoX11,gcc - Build # 250 - Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/PLATFORM=Linux,Variation=NoX11,compiler=gcc/250/ Project: PLATFORM=Linux,Variation=NoX11,compiler=gcc Date of build: Mon, 21 Nov 2016 16:28:23 + Build duration: 3 min 8 sec CHANGE SET

[Differential] [Updated, 1,043 lines] D2854: New: ECMGenerateApiDox, for generating qch & tag files

kossebau updated this revision to Diff 8348. kossebau added a comment. Rename methods apidox->qch, use targets instead of pattern vars, more apidox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=6993&id=8348 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D

Re: [KUnitConversion] Question about overloading operators

On 21.11.2016 08:27, Ander Pijoan wrote: Value operator +(const Value &other) { Q_ASSERT( unit() == other.unit() ); return Value( number() + other.number() , unit() ); } So when adding "3 m" and "40 cm" you want to have an assert (that isn't compiled into code unless you are in d

[Differential] [Updated] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau retitled this revision from "New: ECMGenerateApiDox, for generating qch & tag files" to "New: ECMAddQCH, for generating qch & doxygen tag files". kossebau updated the summary for this revision. kossebau updated the test plan for this revision. kossebau added a reviewer: Frameworks. kosseb

[Differential] [Request, 29 lines] D3438: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5CoreAddons.qch created by this: https://share.kde.org/index.php/s/IuaDnjh704zu5wM BRANCH addQCHBuild

[Differential] [Request, 32 lines] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud. REVISION SUMMARY See https://phabricator.kde.org/D2854 for central discussion of new ECMAddQCH TEST PLAN KF5JobWidgets.qch created by this: https://share.kde.org/index.php/s/UhVPFAy2cTb8cBL BRANCH addQCHBuild

[Differential] [Changed Subscribers] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

shumski added inline comments. INLINE COMMENTS > CMakeLists.txt:82 > > +ecm_install_qch_export( > +TARGETS KF5JobWidgets_QCH I wonder about the reasoning behind the existence of this export, and installation of it... > CMakeLists.txt:98 > +TAGFILE_INSTALL_DESTINATION ${KDE_INSTALL_FU

[Differential] [Commented On] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

kossebau added inline comments. INLINE COMMENTS > shumski wrote in CMakeLists.txt:82 > I wonder about the reasoning behind the existence of this export, and > installation of it... Imagine another project with a lib MyLib linking against KJobWidgets (in the public interface). For MyLib also a

[Differential] [Commented On] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

shumski added a comment. > a) recommended install path for qch and tag files? At least when KDE_INSTALL_USE_QT_SYS_PATHS is TRUE, one could use QT_INSTALL_DOCS (via ECMQueryQmake) var. REVISION DETAIL https://phabricator.kde.org/D2854 EMAIL PREFERENCES https://phabricator.kde.org/s

[Differential] [Commented On] D3439: Create a QCH file with the API dox, optionally, using ECMAddQCH

shumski added inline comments. INLINE COMMENTS > kossebau wrote in CMakeLists.txt:82 > Imagine another project with a lib MyLib linking against KJobWidgets (in the > public interface). For MyLib also a QCH file should be created. To create > proper links from the QCH file for MyLib into the QCH

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file&url=file:///path/to/file

Re: [KUnitConversion] Question about overloading operators

El dilluns, 21 de novembre de 2016, a les 8:27:11 CET, Ander Pijoan va escriure: > Hi Aleix, > > I think at least the most desirable basic feature would be to have the > math operators overloaded to be able to operate with Values. Something like > > > Value operator +(const Value &other) > { >

Re: [KUnitConversion] Question about overloading operators

El dilluns, 21 de novembre de 2016, a les 18:00:18 CET, Christoph Feck va escriure: > On 21.11.2016 08:27, Ander Pijoan wrote: > > Value operator +(const Value &other) > > { > > > > Q_ASSERT( unit() == other.unit() ); > > return Value( number() + other.number() , unit() ); > > > >

Re: [KUnitConversion] Question about overloading operators

I wasn't expecting to have different Units operations and conversion at math operation. Just same Unit category math operations, now it is no possible to sum or subtract two VALUES whatever their unit is because the operator is not overloaded. Just to be able to do "10m" + "20m" which is not possi

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file&url=file:///path/to/file" then d

Re: Review Request 129526: RFE: kwallet-pam should use XDG_RUNTIME_DIR instead of /tmp for the socketPath

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129526/ --- (Updated Nov. 21, 2016, 11:30 p.m.) Review request for KDE Frameworks.

[Differential] [Updated, 1,039 lines] D2854: New: ECMAddQCH, for generating qch & doxygen tag files

kossebau updated this revision to Diff 8364. kossebau updated the test plan for this revision. kossebau added a comment. Small fixes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2854?vs=8348&id=8364 BRANCH addApiDox REVISION DETAIL https://phabricator.kde.org/D2854 AFFECTED

Re: Review Request 129510: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129510/#review101043 --- Ship it! I didn't try building Kross on FreeBSD, but shou

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Ноев. 21, 2016, 10:34 преди обяд, David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file&url=file:///path/to/file

Re: Review Request 129499: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129499/#review101045 --- Ship it! Ok if it works on freebsd:) - Laurent Montel

Re: Review Request 129495: Add FreeBSD to metainfo.yaml.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129495/#review101047 --- Ship it! Ship it if you confirm that it works on freebsd

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Nov. 21, 2016, 9:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file&url=file:///path/to/file" then d

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Nov. 21, 2016, 10:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file&url=file:///path/to/file" then

Re: Review Request 129394: [filenamesearch] Fix huge ram usage in kded module

> On Nov. 21, 2016, 8:34 a.m., David Faure wrote: > > filenamesearch/kded/filenamesearchmodule.cpp, line 84 > > > > > > Well, if dirUrl looks like > > "filenamesearch:?search=file&url=file:///path/to/file" then d