Re: Compilation failure on Windows: kpeople

On Wed, May 17, 2017 at 7:33 AM, Ralf Habacker wrote: > Hi >> When someone gets the chance, could they please look into the build >> log at >> https://build-sandbox.kde.org/job/Frameworks%20kpeople%20kf5-qt5%20WindowsQt5.7/4/console >> to see why this Framework isn't

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130058/#review103250 --- Thanks for pushing this upstream! - Stefan Brüns On May

D5134: Don't exit if $DISPLAY is not set

aacid abandoned this revision. REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D5134 To: aacid, graesslin Cc: graesslin, rikmills, lukas, #frameworks

D5983: Check error status after every PolKitAuthority usage

skalinichev added inline comments. INLINE COMMENTS > aacid wrote in Polkit1Backend.cpp:220 > This seems a bit weird since we have done nothing with authority here, so how > would it have an error? Well yes it shouldn't happen now with the two other checks above. This check here just in case

D5805: include directory should contains all directory from pkg-config

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Is there a way where we can include a test to make sure this works properly? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D5805 To:

D4906: Fix kactivities-stats into tier3

This revision was automatically updated to reflect the committed changes. Closed by commit R159:b5e20a709fbe: Fix kactivities-stats into tier3 (authored by apol). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4906?vs=12101=14883 REVISION

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130058/ --- (Updated May 27, 2017, 4:32 p.m.) Status -- This change has been

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130058/#review103249 --- Ship it! OK. - David Faure On March 29, 2017, 12:52

D5979: Consistently emit MouseEventListener::pressed signal

broulik added a comment. In `onPressed` I would expect `pressed` to be also true which this patch ensures. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D5979 To: apol, #frameworks Cc: broulik, davidedmundson

KDE CI: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kwindowsystem%20kf5-qt5%20XenialQt5.7/6/ Project: Frameworks kwindowsystem kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:48:56 + Build duration: 2 min 2 sec and counting

D5975: breeze-icons: don't look for bash on Windows

winterz edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D5975 To: winterz Cc: aacid, #frameworks

Re: KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

On Sat, May 27, 2017 at 9:21 PM, Christoph Feck wrote: > On 27.05.2017 08:36, no-re...@kde.org wrote: >> >> # *Failed: TestSuite.kiconloader_unittest > > > If I interpret the unit test correctly, it fails because of missing > 'shared-mime-info' package in the CI. > As it turns out

KDE CI: Frameworks kdeclarative kf5-qt5 XenialQt5.7 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kdeclarative%20kf5-qt5%20XenialQt5.7/7/ Project: Frameworks kdeclarative kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:23:38 + Build duration: 9 min 1 sec and counting

KDE CI: Frameworks ktexteditor kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20ktexteditor%20kf5-qt5%20XenialQt5.7/6/ Project: Frameworks ktexteditor kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:24:17 + Build duration: 7 min 37 sec and counting

KDE CI: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 - Build # 11 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kcoreaddons%20kf5-qt5%20XenialQt5.7/11/ Project: Frameworks kcoreaddons kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:23:34 + Build duration: 4 min 29 sec and counting

KDE CI: Frameworks baloo kf5-qt5 XenialQt5.7 - Build # 7 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20baloo%20kf5-qt5%20XenialQt5.7/7/ Project: Frameworks baloo kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:23:15 + Build duration: 3 min 31 sec and counting JUnit Tests

KDE CI: Frameworks kservice kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kservice%20kf5-qt5%20XenialQt5.7/6/ Project: Frameworks kservice kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:24:13 + Build duration: 2 min 37 sec and counting JUnit

KDE CI: Frameworks bluez-qt kf5-qt5 XenialQt5.7 - Build # 6 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20bluez-qt%20kf5-qt5%20XenialQt5.7/6/ Project: Frameworks bluez-qt kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:23:11 + Build duration: 2 min 53 sec and counting JUnit

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 11 - Fixed!

BUILD SUCCESS Build URL https://build-sandbox.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/11/ Project: Frameworks kiconthemes kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 12:21:00 + Build duration: 1 min 0 sec and counting

D5979: Consistently emit MouseEventListener::pressed signal

davidedmundson added a comment. What things are not consistent? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D5979 To: apol, #frameworks Cc: davidedmundson

Re: Review Request 130058: Make kwalletd5 service both org.kde.kwalletd5 and org.kde.kwalletd

> On April 1, 2017, 7:59 p.m., David Faure wrote: > > Makes sense to me, +1. > > Andreas Sturmlechner wrote: > Thanks, anyone else who wants to +1? > > I've tried to test migration today but it didn't work. May as well have > nothing to do with te patch and be caused by the

D5975: breeze-icons: don't look for bash on Windows

aacid added a comment. In https://phabricator.kde.org/D5975#112013, @winterz wrote: > Because Hannah told me the script doesn't work on Windows. Then you need a better commit message :) Saying "we have bash, let's comment this bash using script" is not what you're doing.

D5983: Check error status after every PolKitAuthority usage

aacid added inline comments. INLINE COMMENTS > Polkit1Backend.cpp:220 > +auto authority = PolkitQt1::Authority::instance(); > +if (authority->hasError()) { > +qWarning() << "Encountered error while enumerating actions, error > code:" << authority->lastError() <<

Re: KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

On 27.05.2017 08:36, no-re...@kde.org wrote: # *Failed: TestSuite.kiconloader_unittest If I interpret the unit test correctly, it fails because of missing 'shared-mime-info' package in the CI.

D5981: Fix compilation of Python bindings

This revision was automatically updated to reflect the committed changes. Closed by commit R249:adca5fa181a0: Fix compilation of Python bindings (authored by aacid). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5981?vs=14868=14877 REVISION DETAIL

future of baloo, cross-platform desktop search (and finding dependents of a shared library)

Hi, I seem to recall having read that baloo's future is incertain, inhowfar is that correct and to what extent are there concrete plans to develop something else? I think there'd be justification for developing a good cross-platfom desktop search engine that applications can use regardless of

D5981: Fix compilation of Python bindings

lbeltrame accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH master REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid, lbeltrame Cc: lbeltrame, #frameworks

D5983: Check error status after every PolKitAuthority usage

skalinichev created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY Otherwise if some error occurred in e.g. checkAuthorizationSync call, enumerateActions call would also fail (as PolKitAuthority already set error flag internally) REPOSITORY R283 KAuth

D5981: Fix compilation of Python bindings

lbeltrame added a comment. I'll try to test and report back. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid Cc: lbeltrame, #frameworks

D5981: Fix compilation of Python bindings

lbeltrame added a reviewer: lbeltrame. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D5981 To: aacid, lbeltrame Cc: lbeltrame, #frameworks

KDE CI: Frameworks kiconthemes kf5-qt5 XenialQt5.7 - Build # 10 - Still Unstable!

BUILD UNSTABLE Build URL https://build-sandbox.kde.org/job/Frameworks%20kiconthemes%20kf5-qt5%20XenialQt5.7/10/ Project: Frameworks kiconthemes kf5-qt5 XenialQt5.7 Date of build: Sat, 27 May 2017 06:35:27 + Build duration: 1 min 2 sec and counting