ltoscano added a comment.
It seems to work, just one question though:
INLINE COMMENTS
> KF5I18NMacros.cmake:178
> + set(pmapc_target "pmapfiles-${lang}")
> + add_custom_target(${pmapc_target} ALL DEPENDS ${pmapc_files})
> + add_dependencies(pmapfiles ${pmapc_target})
Before
On Tuesday July 04 2017 20:16:55 Sebastian Kügler wrote:
>The frame in my understanding is old weight, and can go (do check with the VDG
I noticed it was already there in KDE4, indeed, though not usually rendered.
>but to me, more importantly, reducing its size will
>lead to regressions in
On dinsdag 4 juli 2017 17:55:01 CEST René J.V. Bertin wrote:
> Me neither for myself, I'm happy with how my QtCurve theme looks but I'm
> also trying to improve the way KDE software looks using the native style.
The frame in my understanding is old weight, and can go (do check with the VDG
Hi,
How about this?
In KWidgetAddons (out-commented code shows "stock" 5.35.0):
KTitleWidget::KTitleWidget(QWidget *parent)
: QWidget(parent),
d(new Private(this))
{
QFrame *titleFrame = new QFrame(this);
// titleFrame->setAutoFillBackground(true);
//
On Tuesday July 04 2017 18:02:13 Hugo Pereira Da Costa wrote:
> One should really consult with vdg here, since all these points (larger
> fonts, padding, no frame), was already discussed with them, and agreed
> upon, back in the days.
As far as the official 1 or 2 KDE styles are concerned, I
On Tuesday July 04 2017 15:49:28 Kevin Funk wrote:
>With regards to the "Widget Style and Behaviour" label in the `kcmshell5
>style` dialog: I don't find that particularly attracting under Breeze as well.
>
>It's too "bulky" for my taste.
Indeed. I just notice that contrary to what you'd
apol closed this revision.
apol added a comment.
Submitted
https://commits.kde.org/knewstuff/8d94a0cd28dc4897535197a363193c914f59a9ad
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6492
To: apol, #frameworks, leinir
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
Different approach, but yeah, telling people what'll actually happen works :)
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6492
To: apol,
apol updated this revision to Diff 16178.
apol added a comment.
Fix doc
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6492?vs=16176=16178
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6492
AFFECTED FILES
src/core/engine.h
To:
apol updated this revision to Diff 16176.
apol added a comment.
Just document stuff
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6492?vs=16173=16176
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6492
AFFECTED FILES
On Tuesday, 4 July 2017 14:53:15 CEST René J. V. Bertin wrote:
> René J.V. Bertin wrote:
> > style. I think I figured out the how/where once but can't seem to find the
> > info anymore so I'd appreciate a pointer.
>
> Found it.
>
> > FWIW, drawing this kind of label in a frame and/or with a
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20XenialQt5.7/7/
Project:
Frameworks kirigami kf5-qt5 XenialQt5.7
Date of build:
Tue, 04 Jul 2017 13:39:33 +
Build duration:
1 min 7 sec and counting
JUnit Tests
BUILD UNSTABLE
Build URL
https://build.kde.org/job/Frameworks%20kirigami%20kf5-qt5%20FreeBSDQt5.7/6/
Project:
Frameworks kirigami kf5-qt5 FreeBSDQt5.7
Date of build:
Tue, 04 Jul 2017 13:39:33 +
Build duration:
1 min 0 sec and counting
JUnit Tests
apol updated this revision to Diff 16173.
apol added a comment.
Oops
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6492?vs=16172=16173
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6492
AFFECTED FILES
src/core/engine.cpp
apol updated this revision to Diff 16172.
apol added a comment.
Improve documentation and consistency
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6492?vs=16150=16172
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6492
AFFECTED FILES
René J.V. Bertin wrote:
> style. I think I figured out the how/where once but can't seem to find the
> info anymore so I'd appreciate a pointer.
Found it.
> FWIW, drawing this kind of label in a frame and/or with a different background
> colour isn't appropriate for the native Macintosh style.
leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.
derp, not accepted, my bad...
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6492
To: apol, #frameworks, leinir
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
That is indeed a very good point. I think we might possibly have an issue
here, though, in that since these two searches are no longer stand-alone, if
the filter is not explicitly reset
ilic accepted this revision.
ilic added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> davidedmundson wrote in kcatalog.cpp:124
> I think I still need it.
>
> QHash::value() isn't marked as being atomic so we still need to make sure
> we're not reading at
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:f8de13c67421: Don't list KF5::WindowSystem in public
libraries (authored by davidedmundson).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
davidedmundson marked an inline comment as done.
davidedmundson added inline comments.
INLINE COMMENTS
> ilic wrote in kcatalog.cpp:124
> Also the lock should be removed, now that only read access is used.
I think I still need it.
QHash::value() isn't marked as being atomic so we still need to
21 matches
Mail list logo
