D12538: Always prompt for overwrite on double-click in save dialog

ngraham added a comment. We still need to fix Kate's save dialog before we can land this, because right now it handles the overwrite case itself rather than delegating to the dialog like most KDE apps do. And we should do a sweep of other KDE apps that also have this legacy behavior left

D12538: Always prompt for overwrite on double-click in save dialog

ngraham retitled this revision from "Select item without clicking the Open/Save button" to "Always prompt for overwrite on double-click in save dialog". ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth,

D12538: Select item without clicking the Open/Save button

ngraham added a comment. Oops, I was the one who was confused, sorry. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12569: Pony: fix identifier and keyword

jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY -

D12562: Use "Configure %1..." for text of applet configure action

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This will match KDE apps, +1. REPOSITORY R242 Plasma Framework (Library) BRANCH useConfigureActionText REVISION DETAIL https://phabricator.kde.org/D12562 To: kossebau, #vdg,

D12538: Select item without clicking the Open/Save button

rkflx added a comment. > [remove] BUG: 267749 Now I'm confused: Isn't what we do here exactly what the bug reporter wanted? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, broulik, jtamate, ngraham,

D12385: Thumbnail smooth scaling in filepicker

ngraham added a comment. Any objections to landing this tomorrow if we don't hear any objections from #frameworks people before then? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL

D12544: Don't select file extension

ngraham added a comment. Given that this is fixing a fairly straightforward bug, I feel pretty confident about this patch. #frameworks people: any objections, or shall we land this tomorrow? REPOSITORY R241 KIO BRANCH select_filename_only

D12538: Select item without clicking the Open/Save button

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Makes sense conceptually and doesn't break Baloo for me. REPOSITORY R293 Baloo BRANCH db_robustness REVISION DETAIL https://phabricator.kde.org/D12335 To: bruns, #baloo,

D12335: Avoid infinite loops when fetching the URL from DocumentUrlDB

bruns added a comment. Can someone please review this - would be nice to get rid of all the bug reports and //Baloo is shit, just disable it// "reviews" REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12335 To: bruns, #baloo, michaelh, #frameworks Cc: #frameworks,

D12538: Select item without clicking the Open/Save button

ngraham added a comment. In D12538#254871 , @rkflx wrote: > @ngraham Is this still the case with the changed scope of the patch? Yeah, it's fine now that we're going to handle the single-click overwrite use case in another patch.

D12538: Select item without clicking the Open/Save button

rkflx requested changes to this revision. rkflx added a comment. This revision now requires changes to proceed. Thanks, works great now for single click users. Glad we could skip a huge discussion ;) However, for double click mode and Save, descending into directories is kinda broken.

D12544: Don't select file extension

rkflx accepted this revision. rkflx added a comment. Thanks for the patch. Pondered over the code, but could not find anything wrong. In D12544#254554 , @anemeth wrote: > I removed these checks: `&& !locationEdit->isVisible()` > I assume

D12371: fix always reproducible crash

jtamate updated this revision to Diff 33211. jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. The responsible for changing smb:// into smb:/// was: void KFileWidgetPrivate::_k_enterUrl(const QUrl ) With this patch, the

D12513: CVE-2018-10361: privilege escalation

mgerstner added a comment. Hi, I am the guy that came up with the initial security report. I contacted //cullman// about the issue and we've exchanged a couple of emails about how to improve the code. He asked me about what approach would be better: Setting up the temporary file

D12562: Use "Configure %1..." for text of applet configure action

kossebau created this revision. kossebau added reviewers: VDG, Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Follows HIG in using verb-based name, also starting the

D12545: Set focus on the filename line edit when a file is selected

rkflx edited the summary of this revision. rkflx edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: rkflx, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. Looks like this does what it's supposed to for open and save, in both single and double-click mode. Tested with Kate, Spectacle, and Gwenview. REPOSITORY R241 KIO BRANCH

D12538: Select item without clicking the Open/Save button

ngraham added a comment. In D12538#254764 , @rkflx wrote: > Given the concerns with selection markers in single-select mode and thus for Save in general, and them being potentially far off in the future, can we think about changing this patch

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33204. anemeth added a comment. Add comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33203=33204 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D12538: Select item without clicking the Open/Save button

anemeth added a comment. @rkflx thanks for digging through those old commits. I added that code again, but for saving only. Unfortunately I could not test it with single click because the setting has vanished (??) F5824410: aaa.PNG REPOSITORY

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33203. anemeth added a comment. Only doubleclick triggers save overwrite REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33165=33203 BRANCH doubleclick_save (branched from master) REVISION DETAIL

D12538: Select item without clicking the Open/Save button

rkflx added a comment. > https://bugs.kde.org/show_bug.cgi?id=267749 Wow, reading the bug again, my suggestions is fitting right in! Double click to trigger Save for single click users. Only after some confusion in Comment 1 the only slightly related question of overwriting came up in

D12538: Select item without clicking the Open/Save button

rkflx added a comment. After sleeping over this, I don't feel comfortable the way this is supposed to work for single click: Selection markers only really make sense when enabling multi-select mode. Abusing a single selection marker in single-select mode to mean "put the filename in the

D12520: [PasteJob] Emit KDirNotify on paste

broulik added a comment. Given I've done this twice now, should we perhaps fix `storedPut` to do that? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12520 To: broulik, #frameworks Cc: michaelh, bruns

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 236 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/236/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Fri, 27 Apr 2018 07:46:06 + Build duration: 24 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.9 - Build # 214 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.9/214/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 27 Apr 2018 07:46:06 + Build duration: 8 min 38 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 85 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/85/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Fri, 27 Apr 2018 07:46:06 + Build duration: 4 min 43 sec and counting JUnit Tests Name: (root)

D12557: [XCF/GIMP loader] Raise maximimum allowed image size to 32767x32767 on 64 bit platforms

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D12557 To: cfeck, alexmerry, dfaure Cc: #frameworks, michaelh, bruns

D12371: fix always reproducible crash

dfaure added a comment. This is unrelated to concatPaths because concatPaths is about absolute+relative. smb:// + / isn't about adding a relative path. But yes, please find out where smb:/// comes from, and then we can discuss solutions ;) (Check how `kioclient5 ls smb://` and

D9408: extractors: Hide warnings from system headers

This revision was automatically updated to reflect the committed changes. Closed by commit R286:b680861aa2ed: extractors: Hide warnings from system headers (authored by kfunk). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9408?vs=33189=33191 REVISION