D12662: Add InlineNoteInterface

brauch added inline comments. INLINE COMMENTS > dhaumann wrote in katedocument.cpp:5316-5320 > Btw, may I am wrong here, since this is really called often when painting > lines... So this may be good to have. I also stumbled upon it but it avoids an alloc in a very deep loop, so it might be wo

D11155: handle zip files embedded within zip files

sandsmark updated this revision to Diff 33747. sandsmark marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11155?vs=29011&id=33747 REVISION DETAIL https://phabricator.kde.org/D11155 AFFECTED FILES kzip.cpp To: sandsmark, dfaure, #frameworks Cc: ngrah

D11155: handle zip files embedded within zip files

sandsmark added a comment. In D11155#250677 , @ngraham wrote: > Does this resolve https://bugs.kde.org/show_bug.cgi?id=73821? I believe so REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraha

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a reviewer: Frameworks. muhlenpfordt added subscribers: rkflx, ngraham. muhlenpfordt added a comment. Also see D12509 for Gwenview effects on this issue. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12734

D11155: handle zip files embedded within zip files

ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D11155 To: sandsmark, dfaure, #frameworks Cc: ngraham, #frameworks, michaelh, bruns

D12696: Use the new uds implementation

jtamate updated this revision to Diff 33758. jtamate marked 9 inline comments as done. jtamate edited the summary of this revision. jtamate added a comment. Hopefully, all the issues fixed. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12696?vs=33622&id=33758

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr updated this revision to Diff 33761. chinmoyr added a comment. Used QString::toLocal8Bit() instead of QFile::encodeName(). QFile wasn't supposed to be included in this commit. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10410?vs=26831&id=33761 BRA

D12696: Use the new uds implementation

dfaure requested changes to this revision. dfaure added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > udsentry.cpp:132 > +} > +static void save(QDataStream &s, const UDSEntry &a) > +{ strange that it's static, "a.d" could be this, if it wasn't stat

D12696: Use the new uds implementation

bruns added inline comments. INLINE COMMENTS > udsentry.cpp:132 > +} > +static void save(QDataStream &s, const UDSEntry &a) > +{ Is there a reason to define the methods inside the class declaration? The diff would be significantly smaller if you kept the definition separate. REPOSI

D10411: Create socket file in user's runtime directory

chinmoyr updated this revision to Diff 33765. chinmoyr added a comment. Rebased on D10410 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10411?vs=32414&id=33765 BRANCH master REVISION DETAIL https://phabricator.kde.org

D12744: Add null pointer check when creating SocketAddress

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ossi. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY If for some reason SocketAddress:make_address() fails to

D10411: Create socket file in user's runtime directory

chinmoyr added a dependent revision: D12744: Add null pointer check when creating SocketAddress. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr added a dependency: D10411: Create socket file in user's runtime directory. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: #frameworks, michaelh, ngraham, bruns

D12744: Add null pointer check when creating SocketAddress

chinmoyr added a dependent revision: D12745: Unify API for file descriptor sharing. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12744 To: chinmoyr, dfaure, ossi Cc: #frameworks, michaelh, ngraham, bruns

D12745: Unify API for file descriptor sharing

chinmoyr created this revision. chinmoyr added reviewers: dfaure, ossi. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. chinmoyr requested review of this revision. REVISION SUMMARY Pass socket path as const char* to SocketAddress, FdSend

D10411: Create socket file in user's runtime directory

chinmoyr abandoned this revision. chinmoyr added a comment. Split into D12744 and D12745 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh,

D10273: Create proper SocketAddress

chinmoyr abandoned this revision. chinmoyr added a comment. Split into D12744 and D12745 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10273 To: chinmoyr, #frameworks, dfaure, ossi Cc: ossi, thi

D10411: Create socket file in user's runtime directory

chinmoyr reclaimed this revision. chinmoyr added a comment. This revision is now accepted and ready to land. Sorry, abandoned it by mistake. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D10411 To: chinmoyr, #frameworks, ossi Cc: dfaure, michaelh, ngrah

D9966: [KIO] Fix issues with sharing of file descriptor

chinmoyr removed a dependent revision: D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9966 To: chinmoyr, #frameworks, thiago, dfaure, ossi Cc: ngraham, fvogt, lbeltrame, dfaure, michaelh, b

D10410: Move the task of cleaning up of socket file to file ioslave and FdReceiver

chinmoyr removed a dependency: D9966: [KIO] Fix issues with sharing of file descriptor. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10410 To: chinmoyr, #frameworks, ossi, dfaure Cc: michaelh, ngraham, bruns

D12291: Accept file descriptor only from root owned process

chinmoyr updated this revision to Diff 33776. chinmoyr marked an inline comment as done. chinmoyr added a comment. Updated the comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12291?vs=32410&id=33776 BRANCH master REVISION DETAIL https://phabricator

D7415: kconfig: kcfg.xsd do not require a kcfgfile

This revision was automatically updated to reflect the committed changes. Closed by commit R237:dba6d83ee412: kcfg.xsd - do not require a kcfgfile element (authored by winterz). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7415?vs=18394&id=33780 REVISION DE

KDE CI: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20FreeBSDQt5.10/5/ Project: Frameworks kconfig kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 07 May 2018 17:01:32 + Build duration: 1 min 17 sec and counting JUnit Tests

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.10 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.10/35/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.10 Date of build: Mon, 07 May 2018 17:01:32 + Build duration: 1 min 45 sec and counting JUnit Tests Nam

KDE CI: Frameworks kconfig kf5-qt5 SUSEQt5.9 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kconfig%20kf5-qt5%20SUSEQt5.9/17/ Project: Frameworks kconfig kf5-qt5 SUSEQt5.9 Date of build: Mon, 07 May 2018 17:01:32 + Build duration: 2 min 4 sec and counting JUnit Tests Name:

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham updated this revision to Diff 33786. ngraham added a comment. This revision is now accepted and ready to land. Pre-generate the final background color to resolve extra border issue REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12508?vs=2

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham removed a dependency: D12523: Fix overlapping warning widget. REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoac

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham edited the test plan for this revision. REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, micha

D12696: Use the new uds implementation

dfaure added a comment. I requested it, for proper encapsulation REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: bruns, michaelh, ngraham

D12728: KFileItemActions: fallback to default mimetype when selecting only files

elvisangelaccio added a comment. In D12728#258927 , @dfaure wrote: > Makes sense, but why not do this in KFileItemListProperties::mimeType()? That's what I wanted to do first, but then I realized it could be a change of behavior? The apid

D12734: Scale up folder icon before creating preview overlays

rkflx accepted this revision. rkflx added a comment. This revision is now accepted and ready to land. +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch (sans the `qMax`) here, so perhaps wait until the end of the week for any other opinions before committing. BTW,

D12508: Make KMessageWidget match Kirigami inlineMessage's style

cfeck accepted this revision. cfeck added a comment. My "ship it" still stands, especially after you resolved the transparency issue :) REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc:

D12696: Use the new uds implementation

bruns added a comment. In D12696#259292 , @dfaure wrote: > I requested it, for proper encapsulation Whats the difference between class UDSEntryPrivate { void load(...) { // function body } }; and

D12508: Make KMessageWidget match Kirigami inlineMessage's style

ngraham added a comment. Thanks! I'm waiting for at least @hein before landing it. REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvis

D12696: Use the new uds implementation

dfaure added a comment. Oh OK I had misunderstood your comment. Right, those methods don't have to be inline. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12696 To: jtamate, dfaure, #frameworks Cc: bruns, michaelh, ngraham

D8698: Fix KProtocoInfoTest if krusader is installed

This revision was automatically updated to reflect the committed changes. Closed by commit R241:50b944cd93fe: Fix KProtocoInfoTest if krusader is installed (authored by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8698?vs=22036&id=33793 REVISI

KDE CI: Frameworks kio kf5-qt5 FreeBSDQt5.10 - Build # 12 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20FreeBSDQt5.10/12/ Project: Frameworks kio kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 07 May 2018 20:25:57 + Build duration: 5 min 29 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 257 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/257/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Mon, 07 May 2018 20:25:57 + Build duration: 5 min 36 sec and counting JUnit Tests Name: (roo

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 106 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/106/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Mon, 07 May 2018 20:25:57 + Build duration: 7 min 35 sec and counting JUnit Tests Name: (root)

D12508: Make KMessageWidget match Kirigami inlineMessage's style

abetts added a comment. +1 on this! REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart, fabianr, elvisangelaccio, jnoack, #frameworks, michaelh, ngr

D11891: Fix crashes in NotifyByAudio when closing applications

aacid added a comment. Since i think i have genuinely addressed all of Rene's comments, i will commit this next week unless someone disagrees. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D11891 To: aacid, #frameworks, cullmann, rjvbb Cc: cfeck, rjvbb, mpyn

D11891: Fix crashes in NotifyByAudio when closing applications

apol accepted this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D11891 To: aacid, #frameworks, cullmann, rjvbb, apol Cc: cfeck, rjvbb, mpyne, michaelh, ngraham, bruns

D11891: Fix crashes in NotifyByAudio when closing applications

cfeck added a comment. You could apply my spelling correction before committing :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D11891 To: aacid, #frameworks, cullmann, rjvbb, apol Cc: cfeck, rjvbb, mpyne, michaelh, ngraham, bruns

D12508: Make KMessageWidget match Kirigami inlineMessage's style

hein accepted this revision. hein added a comment. Looks good to me, thanks for working on this. REPOSITORY R236 KWidgetsAddons BRANCH arcpatch-D12508 REVISION DETAIL https://phabricator.kde.org/D12508 To: ngraham, hein, #plasma, #vdg, cfeck Cc: broulik, anemeth, abetts, cfeck, mart,

D12734: Scale up folder icon before creating preview overlays

muhlenpfordt added a comment. In D12734#259336 , @rkflx wrote: > +1, but I'd feel a bit uncomfortable (almost) self-approving my own patch (sans the `qMax`) here, so perhaps wait until the end of the week for any other opinions before committing