D13880: [KMoreTools] Reduce menu hierarchy

dhaumann added a comment. I like the idea as well. +1 REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#287481 , @gregormi wrote: > +1 for your suggestions. Downside: higher implementation effort. I like it, too, and I am willing to put effort in it, as soon as we agree on a way forward. > A bit

D13880: [KMoreTools] Reduce menu hierarchy

gregormi added a comment. > You are the most awesome person in the world today. +1 :-) > Pro: Very flat hierarchy, code could be simplified a lot > Con: Unwanted and uninstalled tools would be present all the time. Exactly my thoughts. The idea behind the More menu was to

D13885: taglibextractor: Restore extracting audio props without tags existing

This revision was automatically updated to reflect the committed changes. Closed by commit R286:41c075129d46: taglibextractor: Restore extracting audio props without tags existing (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added inline comments. INLINE COMMENTS > broulik wrote in kmainwindow_unittest.cpp:267 > `mw->deleteLater()`? Retried with all of these... none of them causes the failure, only closing the window manually cause it QApplication::postEvent(mw, new QDeferredDeleteEvent); // qpa/window

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 updated this revision to Diff 37211. maxrd2 added a comment. Clened up test code. Replaced isVisible() with isHidden() test to match KMainWindow's condition. REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13808?vs=37131=37211 BRANCH

D13906: add missing include

astippich created this revision. astippich added a reviewer: mgallien. Restricted Application added projects: Frameworks, Baloo. Restricted Application added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY add the include of qmap to the

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich edited the summary of this revision. astippich edited the test plan for this revision. REPOSITORY R286 KFileMetaData BRANCH fix_empty_tags REVISION DETAIL https://phabricator.kde.org/D13885 To: astippich, mgallien, michaelh, kossebau Cc: kde-frameworks-devel, #baloo,

D13816: Make KItinerary work as a static library

lepagevalleeemmanuel added a subscriber: mart. lepagevalleeemmanuel added a comment. Hello, > assuming we want static library support in other libraries/frameworks too, I can't talk for everybody, but I do want it. I actually maintain a huge patchset to fix static frameworks for ~30

D13885: taglibextractor: Restore extracting audio props without tags existing

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. @kossebau thanks for your work on this patch @astippich thanks for your quick reaction and the work on this patch REPOSITORY R286 KFileMetaData BRANCH fix_empty_tags REVISION

D13885: taglibextractor: Restore extracting audio props without tags existing

kossebau added a comment. All updated no-meta samplefiles fail for me without the patch, but as wanted do not fail with the patch. So seems fine to me :) @astippich Thanks for picking up this patch and creating proper test files. +1 though only, given I am no maintainer. REPOSITORY

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich updated this revision to Diff 37205. astippich added a comment. -fix the no-meta test case REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13885?vs=37148=37205 BRANCH fix_empty_tags REVISION DETAIL https://phabricator.kde.org/D13885

D13885: taglibextractor: Restore extracting audio props without tags existing

astippich commandeered this revision. astippich edited reviewers, added: kossebau; removed: astippich. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D13885 To: astippich, mgallien, michaelh, kossebau Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D13814: Speedup sort

elvisangelaccio accepted this revision. This revision is now accepted and ready to land. REPOSITORY R318 Dolphin REVISION DETAIL https://phabricator.kde.org/D13814 To: jtamate, #dolphin, #frameworks, markg, elvisangelaccio Cc: elvisangelaccio, apol, bruns, markg, kfm-devel, spoorun,

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 307 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/307/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Jul 2018 17:59:50 + Build duration: 21 min and counting JUnit Tests Name: (root)

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 156 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/156/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Jul 2018 17:59:50 + Build duration: 8 min 50 sec and counting JUnit Tests Name:

D13897: Refactor udsentrytest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:d24a61cae282: Refactor udsentrytest (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13897?vs=37183=37199 REVISION DETAIL

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.10 - Build # 306 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.10/306/ Project: Frameworks kio kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Jul 2018 17:29:45 + Build duration: 6 min 46 sec and counting JUnit Tests Name:

KDE CI: Frameworks kio kf5-qt5 SUSEQt5.9 - Build # 155 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kio%20kf5-qt5%20SUSEQt5.9/155/ Project: Frameworks kio kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Jul 2018 17:29:45 + Build duration: 4 min 50 sec and counting JUnit Tests Name:

D13892: Restore compatibility of UDS::insert

This revision was automatically updated to reflect the committed changes. Closed by commit R241:8cd6be0b1c09: Restore compatibility of UDS::insert (authored by jtamate). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37170=37198 REVISION DETAIL

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

bruns added inline comments. INLINE COMMENTS > file.cpp:909 > * and it has a default ACL, also append that. */ > appendACLAtoms(path, entry, type); > } For UDS_ACCESS, _USER, _GROUP, we follow the symlink (i.e use the corresponding buff), for ACL we do not? >

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

bruns added inline comments. INLINE COMMENTS > file.cpp:864 > while (true) { > ssize_t n = readlink(path.constData(), > linkTargetBuffer.data(), bufferSize); > if (n < 0 && errno != ERANGE) { This is broken (although not new). `buff.st_size` is

D12820: Add KWayland virtual desktop protocol

mart updated this revision to Diff 37197. mart added a comment. - ensure there are never duplicates REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12820?vs=37149=37197 BRANCH mart/plasmavirtualdesktop REVISION DETAIL

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added inline comments. INLINE COMMENTS > file_unix.cpp:566 > +// Bug 392913: NTFS root volume is always "hidden", > ignore this > +if (ep->d_type == DT_DIR) { > +const QString fullFilePath = path + QLatin1Char('/') > +

D13808: Fix KMainWindow saving incorrect widget settings

maxrd2 added inline comments. INLINE COMMENTS > broulik wrote in kmainwindow_unittest.cpp:267 > `mw->deleteLater()`? tried it too... will retry all of them again with isHidden() > broulik wrote in kmainwindow_unittest.cpp:278 > `QCOMPARE(mw->m-dock->isVisible(), true)` mmm.. sorry i was

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. In D13782#287336 , @wbauer wrote: > I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden. > (it's on an internal drive and mounted to /windows/C via fstab in case

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13899 To: rjvbb, #frameworks, #vdg Cc: aacid, broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna, aaronhoneycutt,

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb updated this revision to Diff 37194. rjvbb added a comment. constifies KThemeSettings. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13899?vs=37188=37194 REVISION DETAIL https://phabricator.kde.org/D13899 AFFECTED FILES src/CMakeLists.txt src/kmessagewidget.cpp

D13782: RFC: Ignore NTFS hidden flag for root volume

wbauer added a comment. I tried the patch and it doesn't make a difference here, the mountpoint of my NTFS partition is still hidden. (it's on an internal drive and mounted to /windows/C via fstab in case it matters) Additional debug output showed that ep->d_type is not DT_DIR but 0

D13816: Make KItinerary work as a static library

apol added a subscriber: lepagevalleeemmanuel. apol added a comment. +1 I know @lepagevalleeemmanuel looked into this issue as well, maybe he has some insights. REPOSITORY R1003 KItinerary: Travel Reservation handling library REVISION DETAIL https://phabricator.kde.org/D13816 To:

D13899: KMessageWidget: use theme instead of hardcoded colours

aacid added a comment. I know the class is not exported, but having it be "const correct" is always nice :) INLINE COMMENTS > kthemesettings_p.h:66 > + */ > +bool isValid(); > + const? > kthemesettings_p.h:71 > + */ > +bool contains(const QString ); > + const? >

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb set the repository for this revision to R236 KWidgetsAddons. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13899 To: rjvbb, #frameworks, #vdg Cc: broulik, kde-frameworks-devel, michaelh, crozbo, firef, ngraham, bruns, skadinna, aaronhoneycutt, mbohlender

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb updated this revision to Diff 37188. rjvbb marked 3 inline comments as done. rjvbb edited the summary of this revision. rjvbb edited the test plan for this revision. rjvbb added a comment. Patch updated as requested. CHANGES SINCE LAST UPDATE

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb marked 15 inline comments as done. rjvbb added inline comments. INLINE COMMENTS > broulik wrote in kthemesettings.cpp:30 > This doesn't cascade to system-wide settings I aligned to what KConfig actually does: it only considers the kdeglobals file in the writable generic config location.

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13898 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13897: Refactor udsentrytest

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13897 To: jtamate, dfaure, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13510: Add XDG WM Base support to our XDGShell API

romangg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH master REVISION DETAIL https://phabricator.kde.org/D13510 To: davidedmundson, #kwin, romangg Cc: romangg, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 38 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/38/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Jul 2018 12:08:29 + Build duration: 4 min 11 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 94 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/94/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Jul 2018 12:08:29 + Build duration: 4 min 7 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/14/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 05 Jul 2018 12:08:29 + Build duration: 1 min 23 sec and counting

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 - Build # 93 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.10/93/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.10 Date of build: Thu, 05 Jul 2018 11:56:54 + Build duration: 4 min 15 sec and counting JUnit

KDE CI: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 - Build # 37 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20SUSEQt5.9/37/ Project: Frameworks breeze-icons kf5-qt5 SUSEQt5.9 Date of build: Thu, 05 Jul 2018 11:56:54 + Build duration: 4 min 24 sec and counting JUnit Tests

KDE CI: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20breeze-icons%20kf5-qt5%20FreeBSDQt5.10/13/ Project: Frameworks breeze-icons kf5-qt5 FreeBSDQt5.10 Date of build: Thu, 05 Jul 2018 11:56:54 + Build duration: 1 min 44 sec and counting

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate updated this revision to Diff 37184. jtamate edited the summary of this revision. jtamate added a comment. Renamed isSymLink to isBrokenSymLink. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13898?vs=37178=37184 REVISION DETAIL

D13897: Refactor udsentrytest

jtamate updated this revision to Diff 37183. jtamate added a comment. Commas at the end. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13897?vs=37172=37183 REVISION DETAIL https://phabricator.kde.org/D13897 AFFECTED FILES autotests/udsentrytest.cpp To:

D13814: Speedup sort

jtamate updated this revision to Diff 37182. jtamate added a comment. Remove the friend non-exist class. REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13814?vs=37056=37182 REVISION DETAIL https://phabricator.kde.org/D13814 AFFECTED FILES

D13899: KMessageWidget: use theme instead of hardcoded colours

broulik added a comment. I like the idea INLINE COMMENTS > kmessagewidget.cpp:172 > QColor bgBaseColor; > +const QPalette palette = QGuiApplication::palette(); > Not using the widget's palette was intentional for Konsole or something I recall? > kmessagewidget.cpp:176 > +//

D13897: Refactor udsentrytest

dfaure added a comment. I'm not a big fan of the comma at the beginning of the line (without even a space after the comma). Why not at end of line? I guess search-replace made this way easier, but it doesn't really look good ;) Try kde-dev-scripts's uncrustify script, it might reformat all

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

dfaure added inline comments. INLINE COMMENTS > file.cpp:880 > // A symlink -> follow it only if details>1 > if (details > 1 && QT_STAT(path.constData(), ) == -1) { > +isSymLink = true; BTW the point is that we follow the link (by filling "buff" with

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Yes I guess broken symlinks can have acl informations themselves too, so I don't mind the acl code being called now and not before. INLINE COMMENTS > file.cpp:841 > mode_t

D13895: Fix off by one error in Cache::clear

This revision was automatically updated to reflect the committed changes. Closed by commit R159:3d81d0b314f5: Fix off by one error in Cache::clear (authored by davidedmundson). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13895?vs=37167=37180

D13752: Build solidautoeject only on FreeBSD

broulik added a comment. ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13752 To: broulik, #plasma, #frameworks, adridg, davidedmundson, dfaure, fvogt, ervin Cc: anthonyfieroni, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb added a comment. A few snapshots obtained with runtime theme changes (see also D13881 ) Breeze: F6020556: image.png Breeze Dark: F6020561: image.png

D13899: KMessageWidget: use theme instead of hardcoded colours

rjvbb created this revision. rjvbb added reviewers: Frameworks, VDG. rjvbb added projects: Frameworks, VDG. Restricted Application added a subscriber: kde-frameworks-devel. rjvbb requested review of this revision. REVISION SUMMARY This is a split-off of my D13777

D13808: Fix KMainWindow saving incorrect widget settings

broulik added inline comments. INLINE COMMENTS > dfaure wrote in kmainwindow_unittest.cpp:278 > Or rather `QVERIFY(mw->m_dock->isVisible())`, that's what QVERIFY is for ;-) :D Right, I got distracted by the `==` REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL

D13808: Fix KMainWindow saving incorrect widget settings

dfaure added inline comments. INLINE COMMENTS > broulik wrote in kmainwindow_unittest.cpp:278 > `QCOMPARE(mw->m-dock->isVisible(), true)` Or rather `QVERIFY(mw->m_dock->isVisible())`, that's what QVERIFY is for ;-) REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL

D13808: Fix KMainWindow saving incorrect widget settings

broulik added inline comments. INLINE COMMENTS > kmainwindow_unittest.cpp:265 > +NativeMainWindow *mw = new NativeMainWindow(); > +connect(mw, ::destroyed, [&](QObject *){ el.exit(); }); // > quit event loop when window's gone > + connect(mw, ::destroyed, , ::quit); >

D13808: Fix KMainWindow saving incorrect widget settings

wbauer added a comment. In D13808#286965 , @maxrd2 wrote: > Relative Qt Bug is here: https://bugreports.qt.io/browse/QTBUG-69277 > Seems it's not their bug. Hm. Interestingly, Qt Creator has similar problems with Qt 5.11.1 that are

D13898: Use non deprecated fastInsert in file.cpp (first of many to come)

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Avoid the goto using local variables.

D13895: Fix off by one error in Cache::clear

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R159 KActivities Statistics BRANCH master REVISION DETAIL https://phabricator.kde.org/D13895 To: davidedmundson, broulik Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13897: Refactor udsentrytest

jtamate created this revision. jtamate added reviewers: dfaure, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jtamate requested review of this revision. REVISION SUMMARY Use c++ initialization lists instead of

D13782: RFC: Ignore NTFS hidden flag for root volume

broulik added a reviewer: bruns. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13782 To: broulik, dfaure, ngraham, yurikoles, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 35 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks%20kwidgetsaddons%20kf5-qt5%20WindowsMSVCQt5.10/35/ Project: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 Date of build: Thu, 05 Jul 2018 07:41:31 + Build duration: 10 min and counting

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kwidgetsaddons.git/commit/?id=ea282678c937e0e376b391560c585e835528870f REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D13884 To: broulik, #frameworks, rjvbb, ngraham, cfeck Cc:

KDE CI: Frameworks kwidgetsaddons kf5-qt5 WindowsMSVCQt5.10 - Build # 34 - Failure!

Error processing tokens: Error while parsing action 'Text/ZeroOrMore/FirstOf/Token/DelimitedToken/DelimitedToken_Action3' at input position (line 1, pos 38): ${JELLY_SCRIPT,template="html_gmail"} ^ hudson.remoting.ChannelClosedException: Channel "unknown":

D13884: [KMessageWidget] Update stylesheet when palette changes

broulik added inline comments. INLINE COMMENTS > rjvbb wrote in kmessagewidget.cpp:57 > Nitpick: shouldn't this be called `setStyleSheet` or something similar that > indicates a bit better that it defines the stylesheet itself? It doesn't take any arguments, so I explicitly did not call it

D13892: Restore compatibility of UDS::insert

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13892 To: jtamate, dfaure, #frameworks, aacid Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13892: Restore compatibility of UDS::insert

jtamate updated this revision to Diff 37170. jtamate marked 2 inline comments as done. jtamate added a comment. Added KIOCORE_DEPRECATED REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13892?vs=37163=37170 REVISION DETAIL https://phabricator.kde.org/D13892