D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty added a comment. In D18545#402636 , @ngraham wrote: > So this is now working for me as intended, yay! The effect is very strongly positive. Huge improvement IMO. > > But do we know why? It there indeed a bug in the KWin effect

D18617: AsciiDoc: Fix highlighting of include directive

andreasgr added a comment. In D18617#402600 , @dhaumann wrote: > Looks good to me. Please increase the "version" number whenever you change an highlighting file. Ooops, sorry. Many thanks for the quick review. REPOSITORY R216 Syntax

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

ngraham added a comment. So this is now working for me as intended, yay! The effect is very strongly positive. Huge improvement IMO. But do we know why? It there indeed a bug in the KWin effect somewhere? Or was the SVG previously broken somehow? Or was the prior corner radius too small

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 50581. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=50580=50581 REVISION DETAIL https://phabricator.kde.org/D15189 AFFECTED FILES kioclient/kioclient.cpp To: achauvel, #frameworks, dfaure,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel updated this revision to Diff 50580. achauvel added a comment. Added an `ifdef` so that it could compile with older version of KIO. REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15189?vs=47987=50580 REVISION DETAIL

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

dfaure added a comment. #include #if KIO_VERSION >= QT_VERSION_CHECK(5,55,0) ... #endif REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D15189 To: achauvel, #frameworks, dfaure, cfeck Cc: plasma-devel, anthonyfieroni, ngraham,

D18617: AsciiDoc: Fix highlighting of include directive

This revision was automatically updated to reflect the committed changes. Closed by commit R216:ab0b36345229: AsciiDoc: Fix highlighting of include directive (authored by dhaumann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18617?vs=50556=50578#toc REPOSITORY R216 Syntax

D18617: AsciiDoc: Fix highlighting of include directive

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Looks good to me. Please increase the "version" number whenever you change an highlighting file. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D18563: Don't create directory tree when a new folder has a '/' in the name

andriusr added a comment. Also, Windows does not allow filenames with either `\` or `/` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: andriusr, emateli, cfeck, acrouthamel, markg,

D18563: Don't create directory tree when a new folder has a '/' in the name

andriusr added inline comments. INLINE COMMENTS > ngraham wrote in knewfilemenu.cpp:907 > If Windows allows slashes in the filename, shouldn't they just be a part of > the filename and not create a directory tree? If so, then we don't even need > this `#ifdef` condition at all;

D18563: Don't create directory tree when a new folder has a '/' in the name

emateli added a comment. Agree, something similar is being proposed over at D18384 . These dialogs are getting out of hand. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure,

D15189: [KRun] Don’t follow redirection to speed up and avoid incorrect behavior

achauvel added a comment. @dfaure I don’t see how to do that, since there does not seem to have such `ifdef` in the actual codebase. However I can make `set(KF5_MIN_VERSION "5.55.0")` instead of 5.54.0 in the `CMakeLists.txt`. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL

D18563: Don't create directory tree when a new folder has a '/' in the name

ngraham added a comment. Here's an idea for an overall nicer user experience: instead of letting people choose whatever name they want in the new file & new folder dialogs and then displaying an error message (inline or in dialog form) once they click "OK", we could have the new file & new

D18163: Set the color scheme to Printing when print preview'ing

mwolff requested changes to this revision. mwolff added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kateprinter.cpp:164 > QPrinter printer; > -KatePrinterPrivate p(view->doc(), view); > +KatePrinterPrivate p(view->doc(), view, true); >

D18622: Remove monochrome preferences-system symlinks

ndavis abandoned this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18622 To: ndavis, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 4 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/4/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 30 Jan 2019 18:19:07 + Build duration: 9 min 23 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/22/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 30 Jan 2019 18:19:07 + Build duration: 6 min 4 sec and counting JUnit Tests Name:

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar added a comment. I often struggle with QtCreator but I can't remember what happens there, sorry. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel,

D18622: Remove monochrome preferences-system symlinks

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Instead of landing this patch, please revert the offending commit itself using `git revert 14bbb8f64ba2d4aa29b3a3b3b186fca36979fbef`, add the explanation message from here into the

D18622: Remove monochrome preferences-system symlinks

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D18622 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18622: Remove monochrome preferences-system symlinks

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Remove some monochrome preferences-system symlinks that were added for compatibility with

D18610: Introduce KF5AuthCore

apol added inline comments. INLINE COMMENTS > kauthobjectdecorator.cpp:69 > > -qCWarning(KAUTH) << Q_FUNC_INFO << "We're not decorating an action or a > button"; > +qCWarning(KAUTHWIDGET) << Q_FUNC_INFO << "We're not decorating an action > or a button"; > } It could make sense to

D18610: Introduce KF5AuthCore

aacid updated this revision to Diff 50563. aacid retitled this revision from "Introduce KF5AuthNoWidgets" to "Introduce KF5AuthCore". aacid edited the summary of this revision. aacid added a comment. Much better name as suggested by Aleix REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE

D18608: Save two KFilterDev::compressionTypeForMimeType calls

aacid closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D18608 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » baloo » kf5-qt5 SUSEQt5.12 - Build # 2 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/baloo/job/kf5-qt5%20SUSEQt5.12/2/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 30 Jan 2019 17:06:47 + Build duration: 4 min 49 sec and counting BUILD ARTIFACTS

D18237: Fix ResultIterator

aacid closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

dhaumann added a comment. Fixed: 5a6449c3b3d9bbc2b1bc15a5d5b40d7228f3a406 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann,

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.12 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.12/21/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Wed, 30 Jan 2019 16:19:42 + Build duration: 5 min 39 sec and counting JUnit Tests Name:

KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/3/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 30 Jan 2019 16:19:42 + Build duration: 7 min 12 sec and counting BUILD ARTIFACTS

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

dhaumann added a comment. Unfortunately, the change in the .ui file introduced bug https://bugs.kde.org/show_bug.cgi?id=403422 The minimum and maximum were set from 1...5 to -1...-1. Will post a followup patch. @loh.tar Did you remove and add the slider manually again, or how did

D18563: Don't create directory tree when a new folder has a '/' in the name

markg added a comment. In D18563#402216 , @ngraham wrote: > It's rather ironic that in D18571 , I endorse a hidden productivity booster feature, but here, I reject one. :) > > I think I'm reconsidering.

D18317: Display an error message if loading a dictionary fails

loh.tar added a comment. My observations: - There is no hint when you activate auto spell check (yes, it's out of this scope) - Before showing the combobox by "Change Dictionary" the popup appears - The combobox shows then some other setting, here it was the first entry - When open

D18601: Rewrite taglib writer to use property interface

ngraham added reviewers: broulik, cfeck. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D18601 To: astippich, bruns, mgallien, broulik, cfeck Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D18617: AsciiDoc: Fix highlighting of include directive

andreasgr created this revision. andreasgr added reviewers: Framework: Syntax Highlighting, dhaumann. andreasgr added a project: Framework: Syntax Highlighting. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. andreasgr requested review of this

D18114: FakeInput: add support for pointer move with absolute coordinates

jgrulich added a comment. Ping @graesslin? Martin, can you please look into this? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D18114 To: jgrulich, davidedmundson, graesslin, zzag Cc: graesslin, zzag, kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

rjvbb added a comment. > Right, but I was saying all this because I think IF_SUPPORTED (the keyword in the arguments) should be SUPPORTED_IF. Doh?! I thought that was the case, maybe I just restored the wrong way after the CONDITION experiment. Christophe: can you please be more

D16894: [ECM] use a macro to add compiler flags conditionally

dfaure added a comment. In D16894#402209 , @rjvbb wrote: > > In that sentence, one can read "if supported" for the macro name, ... > > That was my idea too, and the reason the macro ends in "_if_supported". Right, but I was saying

D18563: Don't create directory tree when a new folder has a '/' in the name

cfeck added a comment. It could ask what to do. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18563 To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino Cc: cfeck, acrouthamel, markg, ndavis, dfaure, elvisangelaccio, pino, kde-frameworks-devel,

D18384: Allow creating directory named '~' and throw a warning before creating it.

emateli added a comment. I am of the opinion that such dialogs are not very user friendly and honestly very much against them. Not commenting on the usefulness of this particular warning, but dolphin has quite a few of these kind of dialogs with the same process: `Input something -> Get

D18610: Introduce KF5AuthNoWidgets

apol added inline comments. INLINE COMMENTS > CMakeLists.txt:29 > > +add_library(KF5AuthNoWidgets ${libkauth_no_widgets_SRCS}) > +target_link_libraries(KF5AuthNoWidgets PUBLIC Qt5::Core KF5::CoreAddons) > # for KJob How about we call it KF5AuthCore? REPOSITORY R283 KAuth

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added inline comments. INLINE COMMENTS > ECMAddCompilerFlag.cmake:1-25 > +#= > +# Copyright 2018 René J.V. Bertin > +# > +# Redistribution and use in source and binary forms, with or without > +#

D18237: Fix ResultIterator

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH arcpatch-D18237 REVISION DETAIL https://phabricator.kde.org/D18237 To: aacid, #baloo, bruns, poboiko, apol Cc: apol, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,

D18608: Save two KFilterDev::compressionTypeForMimeType calls

apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D18608 To: aacid, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16894: [ECM] use a macro to add compiler flags conditionally

cgiboudeaux added a comment. PS: don't forget the unit test for the new module. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D16894 To: rjvbb, #build_system, kfunk Cc: cgiboudeaux, dfaure, kfunk, apol, kde-frameworks-devel, kde-buildsystem,

D18612: Cache the default KColorScheme configuration

mwolff added a comment. I see that it's faster when I profile kate/kdev, but I cannot easily write a benchmark for this. It's only noticeable when the KDE_COLOR_SCHEME_PATH variable is set, otherwise the global application config will be used afte rall, which is going to be shared most

D18612: Cache the default KColorScheme configuration

mwolff created this revision. mwolff added reviewers: Kate, KDevelop, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mwolff requested review of this revision. REVISION SUMMARY KDevelop, Kate and probably other applications too, recreate

D18384: Allow creating directory named '~' and throw a warning before creating it.

shubham added a comment. Ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18384 To: shubham, ngraham Cc: pino, dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D18545: [breeze desktop theme/dialogs] Add rounded corners to dialogs

rooty retitled this revision from "[breeze desktop theme/dialogs] WIP, Add rounded corners to dialogs" to "[breeze desktop theme/dialogs] Add rounded corners to dialogs". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D18545 To: rooty, #vdg, ngraham