KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 22 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Wed, 13 Feb 2019 06:12:38 + Build duration: 1 min 57 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 17 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/17/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Feb 2019 06:12:38 + Build duration: 2 min 5 sec and counting BUILD ARTIFACTS abi-compa

D18940: Add battery icons

ndavis added a comment. In D18940#411154 , @ngraham wrote: > So I guess this means some duplication between the Breeze icon theme and the Breeze Plasma theme for a while, right? Not 100%. I need to make a device icon for an uninterruptibl

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.12 - Build # 7 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.12/7/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Feb 2019 04:54:22 + Build duration: 9 min 49 sec and counting BUILD ARTIFACTS abi-compatibili

D18822: Fix Windows build [hopefully]

kossebau added a comment. Given this seems stuck by missing reviewers, IMHO time to test the fix by try & error on the CI. If no-one would dare to do this, would take over, given I got pulled in and now this unsolved thing steals my attention time ;) REPOSITORY R283 KAuth REVISION DETAIL

D18907: Handle the case if createSpeller is passed an unavailable language

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, thought lang ist still lang. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D18907 To: ahmadsamir, sandsmark, cullmann, dhaumann Cc: dhaumann, cullmann, loh

D18948: CubeScript: fixes line continuation escape in strings

nibags closed this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18948 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, gennad, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D18948: CubeScript: fixes line continuation escape in strings

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-escape-cubescript REVISION DETAIL https://phabricator.kde.org/D18948 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-framew

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.12 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 21:33:44 + Build duration: 1 min 43 sec and counting BUILD ARTIFACTS abi-comp

KDE CI: Frameworks » kfilemetadata » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 21:33:44 + Build duration: 2 min 0 sec and counting BUILD ARTIFACTS abi-compa

D18972: Format EXIF photo flash data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:e2bd6629783e: Format EXIF photo flash data (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18972?vs=51548&id=51555 REVISION DETAIL

D18940: Add battery icons

ngraham added a comment. So I guess this means some duplication between the Breeze icon theme and the Breeze Plasma theme for a while, right? If we get this in before Frameworks 5.58, then Plasma 5.16 can depend on having them in the Breeze icon theme and maybe we can port the code to us

D18972: Format EXIF photo flash data

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. OK, looks good then! REPOSITORY R286 KFileMetaData BRANCH format_flash REVISION DETAIL https://phabricator.kde.org/D18972 To: astippich, ngraham Cc: kde-frameworks-devel, #baloo,

D18940: Add battery icons

trickyricky26 added a comment. In D18940#410980 , @ndavis wrote: > I think having a different location based on battery level would get annoying You're probably right. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator

D18968: Word-wrap KMessageWidget text

ngraham updated this revision to Diff 51554. ngraham added a comment. Reference the appropriate Qt bug report REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51551&id=51554 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.

D18972: Format EXIF photo flash data

astippich added inline comments. INLINE COMMENTS > ngraham wrote in formatstrings.cpp:103 > Does this one mean "present but did not fire" or "there is no flash with this > hardware"? If the latter, I might suggest instead "None". Otherwise this is > fine the way it is. Strictly this means that

D18948: CubeScript: fixes line continuation escape in strings

nibags updated this revision to Diff 51553. nibags added a comment. - Add unit test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18948?vs=51486&id=51553 BRANCH fix-escape-cubescript REVISION DETAIL https://phabricator.kde.org/D18948 AFF

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir updated this revision to Diff 51552. ahmadsamir added a comment. Improve api docs. Use constFind() with languageClients, as that's more efficient than searching two separate data structures. REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18907?

D18968: Word-wrap KMessageWidget text

ngraham updated this revision to Diff 51551. ngraham added a comment. Remove bug number in comment REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51538&id=51551 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISI

D18968: Word-wrap KMessageWidget text

ngraham retitled this revision from "Word-drap KMessageWidget text" to "Word-wrap KMessageWidget text". REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraham, #dolphin, #framewor

D12950: add test which checks the property types

astippich added a comment. If no-one objects, I will land this next week REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12950 To: astippich, mgallien, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abraham

D18972: Format EXIF photo flash data

ngraham added inline comments. INLINE COMMENTS > formatstrings.cpp:103 > +const QMap flashTranslation = { > +{ 0x00, i18nc("Description of photo flash", "No flash") > }, > +{ 0x01, i18nc("Description of photo flash", "Fired

D18968: Word-drap KMessageWidget text

cfeck added a comment. Well, fix the TODO, and you can remove the comment ;) I guess QLabel needs new API to set https://doc.qt.io/qt-5/qtextoption.html#WrapMode-enum But those plans should be tracked elsewhere, not in source. IMHO, you or maintainer decides, not me. REPOSITORY R

D12950: add test which checks the property types

astippich updated this revision to Diff 51550. astippich added a comment. - fix space REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12950?vs=48691&id=51550 BRANCH property_tests REVISION DETAIL https://phabricator.kde.org/D12950 AFFECTED FILES

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

nibags accepted this revision. nibags added a comment. It's good, I think it's a better solution ;D REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel

D18972: Format EXIF photo flash data

astippich added a comment. The data is taken from exiv2 library: https://github.com/Exiv2/exiv2/blob/master/src/tags_int.cpp#L348 Unfortunately, reusing that data would introduce a lot of #ifdefs in the code, hence I added it to KFileMetaData. This is the only property remaining that nee

D18972: Format EXIF photo flash data

astippich created this revision. astippich added a reviewer: ngraham. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Translate the number of the EXIF photo data to a human readable

D18907: Handle the case if createSpeller is passed an unavailable language

ahmadsamir added a comment. In D18907#410973 , @cullmann wrote: > I think the const at the end for the signal is not wanted, otherwise, this seems to make sense for me. The **this** pointer of Loader::createSpeller is const, so the signal

D18968: Word-drap KMessageWidget text

ngraham added a comment. Well, the code is not wrong but rather incomplete. :) Do you want me to remove the `TODO: ` too? REPOSITORY R318 Dolphin BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION DETAIL https://phabricator.kde.org/D18968 To: ngraha

D18968: Word-drap KMessageWidget text

cfeck accepted this revision. cfeck added a comment. This revision is now accepted and ready to land. I would just remove the comment. The commit references the bug anyway, and a bug reference in the code is only helpful if the code is wrong, and someone wants to understand why. REPOSITORY

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann updated this revision to Diff 51542. cullmann added a comment. I would propose this, OK for you? REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18746?vs=50913&id=51542 REVISION DETAIL https://phabricator.kde.org/D18746 AFFECTED FILE

D18746: Avoid duplicate *-php.xml files in "data/CMakeLists.txt"

cullmann commandeered this revision. cullmann edited reviewers, added: nibags; removed: cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D18746 To: cullmann, #framework_syntax_highlighting, dhaumann, nibags Cc: kwrite-devel, kde-frameworks-devel, genn

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 124 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/124/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 12 Feb 2019 20:07:04 + Build duration: 3 min 37 sec and counting JUnit Test

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 16 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/16/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 20:07:04 + Build duration: 1 min 54 sec and counting BUILD ARTIFACTS abi

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 22 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/22/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 20:07:04 + Build duration: 2 min 7 sec and counting BUILD ARTIFACTS abi-

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 30 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/30/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 20:07:04 + Build duration: 1 min 29 sec and counting JUnit Tests N

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 15 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/15/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 20:01:35 + Build duration: 1 min 55 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 14 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/14/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 19:56:24 + Build duration: 5 min 10 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/21/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:58:20 + Build duration: 1 min 48 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 29 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/29/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 19:57:48 + Build duration: 1 min 18 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 20 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:56:24 + Build duration: 1 min 55 sec and counting BUILD ARTIFACTS ab

D18734: Update octave.xml to Octave 4.2.0

cullmann added a comment. Good question: I added a minimal howto to the README.md: https://commits.kde.org/syntax-highlighting/9343341f91274f899f74b1ffe3fa260dadbc0978 Does that help you? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D1873

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 28 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/28/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 19:56:24 + Build duration: 1 min 21 sec and counting JUnit Tests

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/19/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:47:34 + Build duration: 6 min 10 sec and counting BUILD ARTIFACTS ab

D18894: [RFC] General config interface

cullmann added a comment. First: the current framework for settings suck, I feel guilty. Second: I think a QVariant based approach would be nicer. I should think about how to do that best. Dominik, didn't you have some generic property stuff in your TikzKit? REPOSITORY R39 KTextE

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 WindowsMSVCQt5.11 - Build # 122 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20WindowsMSVCQt5.11/122/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 7 min 10 sec and counting JUnit Tes

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 13 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/13/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 19:44:24 + Build duration: 3 min 14 sec and counting BUILD ARTIFACTS ab

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.10 - Build # 18 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.10/18/ Project: kf5-qt5 SUSEQt5.10 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 5 min 23 sec and counting BUILD ARTIFACTS ab

D18968: Word-drap KMessageWidget text

ngraham updated this revision to Diff 51538. ngraham added a comment. Add a TODO: to the comment REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18968?vs=51536&id=51538 BRANCH word-wrap-long-kmessagewidget-text (branched from Applications/18.12) REVISION

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 SUSEQt5.12 - Build # 12 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20SUSEQt5.12/12/ Project: kf5-qt5 SUSEQt5.12 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 2 min 13 sec and counting BUILD ARTIFACTS ab

D18968: Word-drap KMessageWidget text

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. ngraham requested review of this revision. REVISION SUMMARY Word-wrap KMessageWidget text to prevent the window from being widened when the text i

KDE CI: Frameworks » syntax-highlighting » kf5-qt5 FreeBSDQt5.12 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/syntax-highlighting/job/kf5-qt5%20FreeBSDQt5.12/27/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Tue, 12 Feb 2019 19:42:09 + Build duration: 1 min 40 sec and counting JUnit Tests

D18734: Update octave.xml to Octave 4.2.0

sirgienko added a comment. In D18734#410977 , @cullmann wrote: > I think this is fine now, but I would like to have some autotests input file to have something we can later check for regressions. > Could you provide some MIT or otherwise freel

D18951: HTML: highlight JSX, TypeScript & MustacheJS code in the

This revision was automatically updated to reflect the committed changes. Closed by commit R216:33ad9cdec824: HTML: highlight JSX, TypeScript & MustacheJS code in the