KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 79 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/79/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 07:42:22 + Build duration: 8 min 24 sec and counting JUnit Tests Name:

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar updated this revision to Diff 53574. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. >> me wrote: >> >> 2. Please test with right to left text layout, and mixed text layout. > > Can't say what is to be expect in such case, so test is

KDE CI: Frameworks » breeze-icons » kf5-qt5 FreeBSDQt5.12 - Build # 78 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20FreeBSDQt5.12/78/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 06:32:20 + Build duration: 1 hr 9 min and counting JUnit Tests Name:

D19633: Improve consistency of window-* and add more

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53571. ndavis added a comment. - Add window-unpin-symbolic REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53569=53571 BRANCH window-states (branched from master) REVISION DETAIL

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53569. ndavis added a comment. - Add window-unpin REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19633?vs=53516=53569 BRANCH window-states (branched from master) REVISION DETAIL

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 48 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/48/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 06:40:05 + Build duration: 2 min 13 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 71 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/71/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 06:40:05 + Build duration: 2 min 38 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 70 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/70/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 06:37:33 + Build duration: 2 min 24 sec and counting JUnit Tests Name: (root)

D19638: Make go-bottom/first/last/top look more like media-skip*

This revision was automatically updated to reflect the committed changes. Closed by commit R266:24067c74c2d6: Make go-bottom/first/last/top look more like media-skip* (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis updated this revision to Diff 53563. ndavis added a comment. Rebase on master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19638?vs=53530=53563 BRANCH go-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19638

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 47 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/47/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 06:35:05 + Build duration: 2 min 49 sec and counting JUnit Tests Name: (root)

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.10 - Build # 69 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.10/69/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 06:32:20 + Build duration: 5 min 13 sec and counting JUnit Tests Name: (root)

D19639: Change go-up/down-search symlinks target to go-up/down

This revision was automatically updated to reflect the committed changes. Closed by commit R266:f2509047d437: Change go-up/down-search symlinks target to go-up/down (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19639?vs=53560=53562

KDE CI: Frameworks » breeze-icons » kf5-qt5 SUSEQt5.12 - Build # 46 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/46/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 06:32:20 + Build duration: 2 min 11 sec and counting JUnit Tests Name: (root)

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis updated this revision to Diff 53560. ndavis added a comment. Rebase on master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19639?vs=53531=53560 BRANCH go-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D19639

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

This revision was automatically updated to reflect the committed changes. Closed by commit R266:612a0134603d: Improve pixel grid alignment of go-up/down/next/previous/jump (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis updated this revision to Diff 53558. ndavis edited the test plan for this revision. ndavis added a comment. Rebase on master REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19641?vs=53533=53558 BRANCH go-icons (branched from master) REVISION

D19511: ViewPrivate: Disable read-only mode action when doc is modified

ngraham added a comment. In general I don't think it makes sense to be able to mark an already-modified-but-not-yet-saved document as read-only. It's already been written to! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19511 To: loh.tar, #ktexteditor,

D19646: Redesign KDE Connect and bluetooth config pages

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Better! Could we get a frame and a white background behind this list? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella,

D13150: Add ellipsis where appropriate

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. This results in every item in the menu getting an ellipsis, which isn't appropriate because not all of them require more user action to proceed (the imgur plugin is one such

D19639: Change go-up/down-search symlinks target to go-up/down

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH window-states3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19639 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19633: Improve consistency of window-* and add more

ngraham added a comment. In D19633#427965 , @ndavis wrote: > In D19633#427913 , @ngraham wrote: > > > Neat! Very helpful, thanks. > > > > While you're at it, do you think you could add a

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH window-states4 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19641 To: ndavis, #vdg, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

KDE CI: Frameworks » purpose » kf5-qt5 SUSEQt5.10 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/purpose/job/kf5-qt5%20SUSEQt5.10/20/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 04:36:14 + Build duration: 15 min and counting BUILD ARTIFACTS

D19638: Make go-bottom/first/last/top look more like media-skip*

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I think this makes sense! REPOSITORY R266 Breeze Icons BRANCH window-states2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg, ngraham

KDE CI: Frameworks » plasma-framework » kf5-qt5 FreeBSDQt5.12 - Build # 44 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20FreeBSDQt5.12/44/ Project: kf5-qt5 FreeBSDQt5.12 Date of build: Sun, 10 Mar 2019 04:36:08 + Build duration: 11 min and counting JUnit Tests Name:

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.10 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.10/40/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sun, 10 Mar 2019 04:36:08 + Build duration: 8 min 17 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 32 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/32/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sun, 10 Mar 2019 04:36:08 + Build duration: 7 min 54 sec and counting BUILD ARTIFACTS

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella edited the summary of this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19646: Redesign KDE Connect and bluetooth config pages

nicolasfella created this revision. nicolasfella added reviewers: VDG, apol, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REPOSITORY R495 Purpose Library BRANCH settings REVISION DETAIL

D13150: Add ellipsis where appropriate

nicolasfella updated this revision to Diff 53551. nicolasfella added a comment. - Use i18n REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=53550=53551 BRANCH ellipsis REVISION DETAIL https://phabricator.kde.org/D13150 AFFECTED FILES

D13150: Add ellipsis where appropriate

nicolasfella updated this revision to Diff 53550. nicolasfella added a comment. Move ellipsis from plugin name to menu REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13150?vs=34975=53550 BRANCH ellipsis REVISION DETAIL

D19644: Reduce balooctl index/clear memory usage

davispuh added a comment. In D19644#428074 , @bruns wrote: > Do not create a new transaction per file, thats costly. Still less expensive than single transaction for 1k files REPOSITORY R293 Baloo REVISION DETAIL

D19644: Reduce balooctl index/clear memory usage

davispuh updated this revision to Diff 53549. davispuh edited the summary of this revision. davispuh edited the test plan for this revision. davispuh added a comment. Don't create transaction for every file REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

loh.tar updated this revision to Diff 53548. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Add autoReloadThrottle - Add some var settings/signal which looks missed, pls compare to onModOnHdReload() - not sure if that static single shot make

D17305: Add KDE Connect SMS plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:617e09707f0f: Add KDE Connect SMS plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17305?vs=47226=53547 REVISION DETAIL

D19557: Update css

ognarb updated this revision to Diff 53546. ognarb added a comment. Apply optipng. Thanks @bruns I learned something new :D. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53545=53546 BRANCH master REVISION DETAIL

D19557: Update css

bruns added a comment. and now, apply optipng and you are down to 2kB REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19557: Update css

ognarb updated this revision to Diff 53545. ognarb added a comment. Use inkscape to generate png REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53544=53545 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

bruns added a comment. In D19557#428096 , @ognarb wrote: > Lol 128x128 png image 6kb, 129x129 png image 2kb The new PNG is fuzzy, thats probably the reason it does not compress well. Try exporting it with inkscape, and check if the

D19557: Update css

ognarb added a comment. Lol 128x128 png image 6kb, 129x129 png image 2kb REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham,

D19557: Update css

ognarb updated this revision to Diff 53544. ognarb added a comment. Use a 128x128 png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53542=53544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb added a comment. In D19557#428086 , @bruns wrote: > Is it intentional the PNG is 129x129 while the JPEG is 128x128? I have no idea why 129x129. I used `convert` to convert the svg to png, just like I did with the jpg. But I will

D19621: ViewPrivate: Make deselection by arrow keys more handy

dhaumann added a comment. The unit test is good, but it does not yet test the right-to-left case (e.g. arabic text). Could you add one for this as well? Maybe you can even use KateViewTest::testDeselectByArrowKeys_data() along with QFETCH to reuse the same code in the test function (see

D19621: ViewPrivate: Make deselection by arrow keys more handy

dhaumann edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns, demsking, sars

D19557: Update css

bruns added a comment. Is it intentional the PNG is 129x129 while the JPEG is 128x128? Also, the JPEG shold be removed. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: bruns, abetts, broulik, aacid,

D19644: Reduce balooctl index/clear memory usage

bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Do not create a new transaction per file, thats costly. INLINE COMMENTS > main.cpp:222 > out << "Skipping: " << url << " Reason: Already scheduled > for

D19557: Update css

ognarb updated this revision to Diff 53542. ognarb added a comment. Change png image REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53541=53542 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19557: Update css

ognarb updated this revision to Diff 53541. ognarb added a comment. Use png instead of jpg REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53521=53541 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 AFFECTED FILES

D19635: Fix for showing argument hint tree on non-primary screen.

tfry closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19635 To: tfry, cullmann Cc: cullmann, kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar updated this revision to Diff 53540. loh.tar added a comment. - Consider RTL text CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19621?vs=53508=53540 REVISION DETAIL https://phabricator.kde.org/D19621 AFFECTED FILES autotests/src/kateview_test.cpp

D19644: Reduce balooctl index/clear memory usage

davispuh added a comment. In D19644#428047 , @bruns wrote: > A transaction can not be split up, thats the reason it is a transaction ... It can and they must be split in a lot smaller transactions. Currently sometimes baloo uses way too

D19644: Reduce balooctl index/clear memory usage

davispuh edited the summary of this revision. davispuh edited the test plan for this revision. davispuh added reviewers: dhaumann, bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19644 To: davispuh, dhaumann, bruns, ngraham Cc: bruns, kde-frameworks-devel,

D19644: Reduce balooctl index/clear memory usage

bruns added a comment. A transaction can not be split up, thats the reason it is a transaction ... REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19644 To: davispuh Cc: bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun,

D19644: Reduce balooctl index/clear memory usage

davispuh created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davispuh requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D19644 AFFECTED FILES

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19639 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19641 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19641: Improve pixel grid alignment of go-up/down/next/previous/jump

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These icons had subtle alignment issues. They weren't even always visible, but it's a

D19639: Change go-up/down-search symlinks target to go-up/down

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY go-up/down is more appropriate because go-top/bottom is supposed to be for skipping to the

D19633: Improve consistency of window-* and add more

ndavis added a comment. In D19633#427913 , @ngraham wrote: > Neat! Very helpful, thanks. > > While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 Yes, but I'm not sure

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19638 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19638: Make go-bottom/first/last/top look more like media-skip*

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Once D19575 lands, the style of `go-top` will

D19557: Update css

bruns added a comment. In D19557#426051 , @aacid wrote: > Why changing from jpg to png for the image file ? The logo is just 2 colors, and the PNG is smaller than the JPEG, without introducing artifacts. I would definitely prefer a PNG

D11828: Simplify orPostingIterator and make it faster

bruns added a comment. Ping! REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11828 To: bruns, #baloo, #frameworks, poboiko Cc: fvogt, kde-frameworks-devel, #frameworks, gennad, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19575: Add collapse-all and expand-all action icons

ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so: F6677924: Screenshot_20190309_114706.png

D18664: Baloo engine: treat every non-success code as a failure

bruns added a comment. @valeriymalov - are you going to update this? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D18664 To: valeriymalov, #baloo, bruns, poboiko Cc: cullmann, ngraham, bruns, kde-frameworks-devel, #baloo, gennad, domson, ashaposhnikov, michaelh,

D19633: Improve consistency of window-* and add more

ngraham added a comment. Also `window-shade`? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D19633: Improve consistency of window-* and add more

ngraham added a comment. Neat! Very helpful, thanks. While you're at it, do you think you could add a `window-unpin` icon too? https://bugs.kde.org/show_bug.cgi?id=405195 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: ngraham,

D11828: Simplify orPostingIterator and make it faster

bruns updated this revision to Diff 53527. bruns added a comment. rebase REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11828?vs=36944=53527 BRANCH speedup_orpostingoperator REVISION DETAIL https://phabricator.kde.org/D11828 AFFECTED FILES

D19635: Fix for showing argument hint tree on non-primary screen.

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Given all other calls use m_parent->... for the screenGeometry call, this looks sane. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL

D19635: Fix for showing argument hint tree on non-primary screen.

tfry created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. tfry requested review of this revision. REVISION SUMMARY If the texteditor window is on a secondary screen of a multi-screen desktop, *and* the argument hint has

D19575: Add collapse-all and expand-all action icons

trickyricky26 edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19575 To: trickyricky26, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, michaelh, bruns

D19575: Add collapse-all and expand-all action icons

trickyricky26 updated this revision to Diff 53522. trickyricky26 added a comment. - Use design by @ndavis with tighter spacing REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19575?vs=53430=53522 BRANCH collapse-expand-all-icons (branched from

D19557: Update css

ognarb added a comment. @aacid it is ready to land? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation Cc: abetts, broulik, aacid, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19557: Update css

ognarb updated this revision to Diff 53521. ognarb added a comment. Use correct breeze color for important and warning REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19557?vs=53469=53521 BRANCH master REVISION DETAIL

D19517: DocumentPrivate: Add option "Enable Auto Reload" to ModOnHdPrompt

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Perhaps in addition to the message, one should just add a menu entry in Tools like "Read Only Mode", then the user can turn it of again. And as said, I think one needs some

D19621: ViewPrivate: Make deselection by arrow keys more handy

brauch added a comment. Sorry, yeah, I misunderstood! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: cullmann, brauch, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, #ktexteditor, gennad, domson, michaelh, bruns,

D19633: Improve consistency of window-* and add more

ndavis edited the summary of this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19532: Don't crash when no contexts are present

This revision was automatically updated to reflect the committed changes. Closed by commit R216:7289a7088065: fix highlighter crash for broken hl file (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19532?vs=53234=53517#toc REPOSITORY R216 Syntax Highlighting

D19532: Don't crash when no contexts are present

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I will commit the minimal needed fix to get this solved. REPOSITORY R216 Syntax Highlighting BRANCH context REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh,

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R216 Syntax Highlighting BRANCH octave-weak-delimiter REVISION DETAIL https://phabricator.kde.org/D19570 To: sirgienko, #framework_syntax_highlighting,

D19633: Improve consistency of window-* and add more

ndavis updated this revision to Diff 53516. ndavis edited the test plan for this revision. ndavis added a comment. Rename window-maximized to window-restore for better 3rd party compatibility REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

sirgienko updated this revision to Diff 53515. sirgienko added a comment. Increase syntax file version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19570?vs=53292=53515 BRANCH octave-weak-delimiter REVISION DETAIL

D19570: Add "." as weakDeliminator in Octave syntax file and update tests

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I guess this is ok, please increment the version of the syntax file and this can go in. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D19633: Improve consistency of window-* and add more

ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D19633 To: ndavis, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19621: ViewPrivate: Make deselection by arrow keys more handy

cullmann added a comment. I think for the bidi stuff, one needs to honor the if (m_viewInternal->m_view->currentTextLine().isRightToLeft()) flag. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19621 To: loh.tar, #ktexteditor Cc: cullmann, brauch, dhaumann,

D19633: Improve consistency of window-* and add more

ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Add window-keep-above/below Add window-maximize/maximized/minimize Change

D19629: Change media-skip* and media-seek* style

This revision was automatically updated to reflect the committed changes. Closed by commit R266:581ce275edbd: Change media-skip* and media-seek* style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19629?vs=53494=53510 REVISION

D19621: ViewPrivate: Make deselection by arrow keys more handy

loh.tar updated this revision to Diff 53508. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Add autotest REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19621?vs=53501=53508 REVISION DETAIL

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 50 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/50/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 11:47:42 + Build duration: 17 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 36 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/36/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 11:45:56 + Build duration: 7 min 1 sec and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.10 - Build # 49 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.10/49/ Project: kf5-qt5 SUSEQt5.10 Date of build: Sat, 09 Mar 2019 11:16:12 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » kio » kf5-qt5 SUSEQt5.12 - Build # 35 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20SUSEQt5.12/35/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 11:14:16 + Build duration: 31 min and counting BUILD ARTIFACTS

KDE CI: Frameworks » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 31 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/31/ Project: kf5-qt5 SUSEQt5.12 Date of build: Sat, 09 Mar 2019 09:45:49 + Build duration: 1 hr 51 min and counting BUILD ARTIFACTS

  1   2   >