D24959: Add new preferences search icons

trickyricky26 requested changes to this revision. trickyricky26 added a comment. This revision now requires changes to proceed. On the technical side, we usually convert everything to paths, and even though I can't imagine Qt SVG Renderer would have a problem with `circle`, it might be

D24957: Add new baloo icons

trickyricky26 added a comment. Some of my thoughts on the new preferences-desktop-search icons (D24959#554523 ) also apply here: I think that lines of the magnifying glass symbol feel a bit too thick for Breeze, and IMO the large glass-to-handle

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554516 , @dfaure wrote: > A sort model allows to define any sorting criteria you want (see QSortFilterProxyModel::lessThan), so this is technically possible: the criteria would say "if A is a match and B

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

dfaure added a comment. By "jumping around" I mean that even order can change, not just things being added/removed. A would be before B, and then you type something, and B jumps before A. Or do I misunderstand and this could never happen? REPOSITORY R241 KIO REVISION DETAIL

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ngraham added a comment. In D24951#554516 , @dfaure wrote: > I'm not 100% sure that things jumping around while typing is a good idea though. That's exactly what already happens though, as the list of search narrows itself while you

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

dfaure added a comment. A sort model allows to define any sorting criteria you want (see QSortFilterProxyModel::lessThan), so this is technically possible: the criteria would say "if A is a match and B isn't, then Ahttps://phabricator.kde.org/D24951 To: ahmadsamir, dfaure, ngraham Cc:

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554485 , @ngraham wrote: > In D24951#554468 , @ahmadsamir wrote: > > > The user typing 'arc' then pressing Enter, and getting the file opened with wireshark is

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

ahmadsamir added a comment. In D24928#553952 , @vkrause wrote: > The cipher naming stuff looks very fishy though, that's not due to your changes though but coming from old KSslCipher code. I'm wondering where the ssl_cipher meta data is being

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.13 - Build # 19 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.13/19/ Project: kf5-qt5 SUSEQt5.13 Date of build: Sat, 26 Oct 2019 21:21:42 + Build duration: 4 min 43 sec and counting JUnit Tests Name:

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/16/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 26 Oct 2019 21:21:42 + Build duration: 1 min 11 sec and counting JUnit Tests Name:

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added a comment. Funnily enough, the 5.39 is irrelevant, since we don't support building with older versions of KConfig. But it becomes relevant because we support enabling one and not the other, as you mention. We could cheat and just s/38/39/ here, it wouldn't harm anyone. If

Re: Developing an GLFW app that links makes use of KWindowEffects?

On mercredi 16 octobre 2019 09:30:13 CEST Christian Parpart wrote: > Hi guys, > > I hope I landed into the right channel (it's many many years ago I did > stuff with KDE), so I've to apologize in advance, eventually. :-) > > I am developing an OpenGL / GLFW application (for highest platform >

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

dfaure created this revision. dfaure added reviewers: kossebau, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY kded needs to keep being able to load kded modules that install desktop

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ngraham added a comment. In D24951#554468 , @ahmadsamir wrote: > The user typing 'arc' then pressing Enter, and getting the file opened with wireshark is broken behaviour form the user's POV, that's the crux of the bug report in question.

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. The user typing 'arc' then pressing Enter, and getting the file opened with wireshark is broken behaviour form the user's POV, that's the crux of the bug report in question. That combobox uses KCompletion and not having the up/down arrow keys navigate

D24959: Add new preferences search icons

astippich added a comment. Yes, that is the plan REPOSITORY R266 Breeze Icons BRANCH newSearchIcon REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24593: Modified breeze shadows

ngraham added a comment. Still not working, sorry. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24593 To: niccolove, #vdg Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. In D24951#554226 , @ahmadsamir wrote: > In D24951#554138 , @ngraham wrote: > > >

D24932: [WIP]: Add Button to open the folder in filelight for more details

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. It doesn't compile: /home/nate/kde/src/kio/src/widgets/kpropertiesdialog.cpp:1389:72: error: ‘QString::QString(const char*)’ is private within this context 1389 |

D24957: Add new baloo icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely. REPOSITORY R266 Breeze Icons BRANCH newBalooIcon REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel,

D24959: Add new preferences search icons

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice. So after this, you'll change https://cgit.kde.org/systemsettings.git/tree/categories/settings-workspace-search.desktop#n7, right? REPOSITORY R266 Breeze Icons BRANCH

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 51 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/51/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Sat, 26 Oct 2019 17:42:20 + Build duration: 2 min 32 sec and counting JUnit Tests Name:

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

dfaure closed this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24971 To: dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

ngraham edited the summary of this revision. ngraham added a task: T7878: Create or find Icon. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24958: Delete nepomuk icon

ngraham accepted this revision. REPOSITORY R266 Breeze Icons BRANCH deleteNepomuk REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Good with me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24971 To: dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

dfaure updated this revision to Diff 68798. dfaure added a comment. Revert change to CMakeLists.txt; explain change as comment REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24971?vs=68796=68798 BRANCH master REVISION DETAIL

D24965: KConfigWidgets: port away from KF5 deprecated API

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kstandardaction_p.h:103 > Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed > to be used here. > Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO >

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kstandardaction_p.h:103 > Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed > to be used here. > Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO > ECMGenerateExportHeader

D24965: KConfigWidgets: port away from KF5 deprecated API

kossebau added inline comments. INLINE COMMENTS > kstandardaction_p.h:103 > #if KCONFIGWIDGETS_BUILD_DEPRECATED_SINCE(5, 38) > -{ SaveOptions, KStandardShortcut::SaveOptions, "options_save_options", > I18N_NOOP(" Settings"), nullptr, nullptr }, > +{ SaveOptions,

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:96 > add_definitions(-DQT_DEPRECATED_WARNINGS_SINCE=0x06) > +add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00) > add_definitions(-DQT_NO_FOREACH) Given KCOreAddons does not link against other KF modules, this

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

kossebau added inline comments. INLINE COMMENTS > kaboutdata.h:944 > > -#if KCOREADDONS_ENABLE_DEPRECATED_SINCE(5, 2) > +#if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 2) > /** Possibly best to document why only BUILD, pointing out infrastructure code supporting legacy code needs to always

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure updated this revision to Diff 68797. dfaure added a comment. Keep code for compat. Requires D24971 . REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24965?vs=68789=68797 BRANCH master REVISION DETAIL

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

dfaure created this revision. dfaure added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY NO_CHANGELOG TEST PLAN Builds, and allows to build kconfigwidgets REPOSITORY

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added a comment. Sorry, you were very clear, I just forgot that the compiler warning comes from a different macro :-) REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24965 To: dfaure, kossebau, elvisangelaccio, vkrause Cc: kde-frameworks-devel,

D24773: kio_trash: Add size, modification, access and create date for trash:/

dfaure added a comment. You can do whatever you want in the GUI -- I'll happily step out of that part of the discussion --, as long as you don't abuse UDS_SIZE for what it was not meant for, thus creating an ambiguous meaning for it. My suggestion would be to add a UDS_RECURSIVE_SIZE

D24965: KConfigWidgets: port away from KF5 deprecated API

kossebau added a comment. So seems I missed to make clear what I meant, next try :) The goal is: make clients (e.g. apps) which are still using this method to set the app icon aware by a compiler warning that they should port their code to use QApplication::setWindowIcon. For that we

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

dfaure added a comment. +1 from me, the reasoning makes sense. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24951 To: ahmadsamir, dfaure Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added a comment. Why would I need to push/pop warning, if the method call doesn't trigger any warning anymore? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24965 To: dfaure, kossebau, elvisangelaccio, vkrause Cc: kde-frameworks-devel, LeGast00n,

D24965: KConfigWidgets: port away from KF5 deprecated API

kossebau added a comment. In D24965#554393 , @dfaure wrote: > So basically we just use //KF6 TODO REMOVE for programIconName, but still use the macro around setProgramIconName? Works for me. Yes, remove the

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D24960 To: vkrause, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added a comment. So basically we just use //KF6 TODO REMOVE for programIconName, but still use the macro around setProgramIconName? Works for me. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24965 To: dfaure, kossebau, elvisangelaccio, vkrause Cc:

D24970: Port away from I18N_NOOP2 and KLocalizedString::insertQtDomain

dfaure created this revision. dfaure added reviewers: aacid, ilic. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY - Remove duplication of the untranslated (but marked for translation) string.

D21004: [UserMetaData] Shortcut attribute queries for the common case

astippich added a comment. ping REPOSITORY R824 Baloo Widgets BRANCH bulk_query REVISION DETAIL https://phabricator.kde.org/D21004 To: bruns, #baloo, #frameworks, ngraham, astippich, lbeltrame Cc: hurikhan77, lots0logs, fbampaloukas, domson, ashaposhnikov, astippich, spoorun,

D24959: Add new preferences search icons

astippich added a comment. Correct REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham

D24965: KConfigWidgets: port away from KF5 deprecated API

kossebau added a comment. This falls into a category I also saw elsewhere doing all the patches, where the same API is used from two sides: the client side, like application code, and the serving side, like infrastructure. While we want to tell the client side, stop using this and for

D24968: Port away from KF5 deprecated API: use setWindowIcon

dfaure closed this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D24968 To: dfaure, vkrause, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24968: Port away from KF5 deprecated API: use setWindowIcon

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R311 KWallet BRANCH master REVISION DETAIL https://phabricator.kde.org/D24968 To: dfaure, vkrause, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added a comment. The goal is to set KF_DISABLE_DEPRECATED_BEFORE_AND_AT, so this isn't just about a warning, it's about API that no longer exists. But I guess we can't do that then, if we want to preserve compatible behavior until KF6... REPOSITORY R265 KConfigWidgets REVISION

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure added a reviewer: vkrause. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D24965 To: dfaure, kossebau, elvisangelaccio, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24968: Port away from KF5 deprecated API: use setWindowIcon

dfaure created this revision. dfaure added reviewers: vkrause, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. TEST PLAN Restarted kwalletd5, made it open a wallet (via kwalletmanager), the dialog that

D24966: KXmlGui: port away from KF5 deprecated API

kossebau added a comment. For backward-compatibility, we want to support this still, no? See D24965#554354 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24966 To: dfaure, kossebau, elvisangelaccio, vkrause Cc:

D24965: KConfigWidgets: port away from KF5 deprecated API

kossebau added a comment. While being deprecated, there might be code still using it, and you are killing support for that now, which is backwards-incompatibel. IMHO the support should be kept. And we want to rather have a generic way to disable the warning here (still TODO to have

D24958: Delete nepomuk icon

bruns accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH deleteNepomuk REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24957: Add new baloo icons

bruns added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24966: KXmlGui: port away from KF5 deprecated API

dfaure created this revision. dfaure added reviewers: kossebau, elvisangelaccio, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KAboutData::setProgramIconName is deprecated and says "Use

D24959: Add new preferences search icons

bruns added a comment. Thats the "top level" icon, with "Krunner" and "File Search" (aka Baloo) below, correct? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To: astippich, #vdg, ngraham Cc: bruns, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24965: KConfigWidgets: port away from KF5 deprecated API

dfaure created this revision. dfaure added reviewers: kossebau, elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY KAboutData::setProgramIconName is deprecated and says "Use

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. For reference here is the relevant part in the kcm https://cgit.kde.org/plasma-desktop.git/tree/kcms/keys/kglobalshortcutseditor.cpp#n176 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc:

D24593: Modified breeze shadows

niccolove added a comment. In D24593#552915 , @ngraham wrote: > Needs a rebase on master. It doesn't apply for me. Does it apply now? If not, I messed up something and I will just reset to master and add the svgs again. REPOSITORY

D24593: Modified breeze shadows

niccolove updated this revision to Diff 68788. niccolove added a comment. Rebase on master - test REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24593?vs=68626=68788 BRANCH breeze-shadows (branched from master) REVISION DETAIL

D24956: Consider desktop files with NoDisplay attribute

meven added a comment. In D24956#554190 , @davidre wrote: > I think you have also to check the the kcm as i also saw some `nodisplay` there. > Also it seems kglobalaccel uses nodisplay when a component is disabled.

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added a comment. In D24773#551497 , @ngraham wrote: > In D24773#551245 , @meven wrote: > > > I would argue that "Disk space usage" and "Size" might be confusing to users. A folder size is the

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

meven updated this revision to Diff 68785. meven added a comment. Formatting REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24962?vs=68784=68785 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24962 AFFECTED FILES src/core/deletejob.cpp

D24752: WIP: Use a separate worker thread to run the actual deletion of files

meven abandoned this revision. meven added a comment. In favor of D24962 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24752 To: meven, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24962: WIP [DeleteJob] Use a separate worker thread to run actual IO operation

meven retitled this revision from "WIP Ues a separate worker thread to run actual IO operation" to "WIP [DeleteJob] Use a separate worker thread to run actual IO operation". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24962 To: meven, dfaure Cc: kde-frameworks-devel,

D24962: WIP Ues a separate worker thread to run actual IO operation

meven created this revision. meven added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY Part of T11627 REPOSITORY R241 KIO BRANCH master

D24931: Port KSSLD internals from KSslError to QSslError

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24931 To: vkrause, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24961 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24961: Port to the QSslError variant of KSslInfoDialog

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24961 AFFECTED FILES src/widgets/sslui.cpp To:

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause added a comment. In D24892#554048 , @kossebau wrote: > In D24892#553597 , @vkrause wrote: > > > In D24892#552838 , @kossebau wrote: > > > > >

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D24892 To: vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

vkrause added a task: T11865: Deprecate KIconTheme::assignIconsToContextMenu. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D24960 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24960: Remove call to no longer needed KIconTheme::assignIconsToContextMenu

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Qt does set icons itself nowadays, so assignIconToContextMenu got deprecated. REPOSITORY R310 KTextWidgets BRANCH

D24959: Add new preferences search icons

astippich added a comment. F7673429: preferences-desktop-search.svg.png Basically the icon from D24957 without the paw REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24959 To:

D24959: Add new preferences search icons

astippich created this revision. astippich added reviewers: VDG, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add a new icon for usage with the system-settings "search" category,

D24957: Add new baloo icons

astippich added a comment. Before: F7673421: test.png which is basically a copy of the kfind icon REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc: kde-frameworks-devel,

D24951: [KOpenWithDialog] Automatically select the result if the model filter has only one match

ahmadsamir added a comment. In D24951#554138 , @ngraham wrote: > Why wouldn't you want the first result chosen when there's more than one result? If you enter a search term and get (say) 2 results and the one you want to select is the first

D24958: Delete nepomuk icon

astippich created this revision. astippich added a reviewer: ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY It's long gone, and is just a symlink to the preference-desktop-baloo icon

D24957: Add new baloo icons

astippich added a comment. F7673101: baloo48.png F7673103: baloo32.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24957 To: astippich, #vdg, ngraham, bruns Cc:

D24957: Add new baloo icons

astippich created this revision. astippich added reviewers: VDG, ngraham, bruns. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Add new baloo 48px icon and update the preference-desktop-baloo

D24956: Consider desktop files with NoDisplay attribute

davidre added a comment. I think you have also to check the the kcm as i also saw some `nodisplay` there. Also it seems kglobalaccel uses nodisplay when a component is disabled. https://cgit.kde.org/kglobalaccel.git/tree/src/runtime/kserviceactioncomponent.cpp#n144 REPOSITORY R268

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

mlaurent added a comment. Ok thanks. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24884 To: mlaurent, dfaure, ilic Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24773: kio_trash: Add size, modification, access and create date for trash:/

meven added a comment. In D24773#551497 , @ngraham wrote: > In D24773#551245 , @meven wrote: > > > I would argue that "Disk space usage" and "Size" might be confusing to users. A folder size is the

D24956: Consider desktop files with NoDisplay attribute

meven added a comment. This was added previously in D2103 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D24956 To: meven, mart, #plasma, fvogt, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24956: Consider desktop files with NoDisplay attribute

meven created this revision. meven added reviewers: mart, Plasma, fvogt, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. meven requested review of this revision. REVISION SUMMARY > NoDisplay means "this application exists, but don't display it in the

D24652: Add folder-recent, extend hand of clock in folder-temp

This revision was automatically updated to reflect the committed changes. Closed by commit R266:2a36922a8cc4: Add folder-recent, extend hand of clock in folder-temp (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24652?vs=67939=68773

D24625: Fill middle mouse button area

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:8732c6a99ad1: Fill middle mouse button area (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST