D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-25 Thread Ahmad Samir
ahmadsamir planned changes to this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26226 To: ahmadsamir, #frameworks, mpyne, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26226: [KListOpenFilesJob] Use QString::splitRef()

2019-12-25 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, mpyne, dfaure, apol. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY As per apol's suggestion in D26210 , use splitRef(). And Since it

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 82 - Still Unstable!

2019-12-25 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/82/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 26 Dec 2019 05:44:23 + Build duration: 1 min 54 sec and counting JUnit Tests Name: pr

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

2019-12-25 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R244:9578a7d875f1: [KCoreAddons] Port QRegExp to QRegularExpression (authored by ahmadsamir). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26210?vs=72147&id=72186

D26210: [KCoreAddons] Port QRegExp to QRegularExpression

2019-12-25 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ahmadsamir wrote in klistopenfilesjob_unix.cpp:69 > I didn't even know there was a splitRef... > > It'll have to be something like: > > QVector pidList = > out.splitRef

D26191: Add support for FileJob->truncate() in smb/sftp slaves

2019-12-25 Thread Alexander Saoutkin
feverfew updated this revision to Diff 72181. feverfew added a comment. Add fact that protocol supports truncation REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26191?vs=72155&id=72181 BRANCH arcpatch-D26191 REVISION DETAIL https://phabricator.kde

D26148: Add truncation support to FileJob

2019-12-25 Thread Alexander Saoutkin
feverfew edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26148 To: feverfew, fvogt, dfaure, sitter Cc: apol, ngraham, sitter, dfaure, kde-frameworks-devel, fvogt, LeGast00n, GB_2, michaelh, bruns

D26148: Add truncation support to FileJob

2019-12-25 Thread Alexander Saoutkin
feverfew updated this revision to Diff 72180. feverfew added a comment. Add feature to determine if protocol supports truncation REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26148?vs=71990&id=72180 BRANCH arcpatch-D26148 REVISION DETAIL https://phabrica

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-25 Thread Nathaniel Graham
ngraham added inline comments. INLINE COMMENTS > asemke wrote in kcolorschememanager.cpp:107 > Many applications like kdevelop, digikam, labplot, etc. create a menu "Color > Scheme" in the main menu bar and add then menu item via KColorSchemeManager. > By using "System color scheme" here we'd h

D26202: WIP: Refactor KConfigXT

2019-12-25 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 72171. tcanabrava added a comment. - Finish header / Move basename to the ParameterConfiguration REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=72166&id=72171 BRANCH megaRefactor REVISION DETAIL https:

D26202: WIP: Refactor KConfigXT

2019-12-25 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 72166. tcanabrava added a comment. - Port more header functions - Move CreateItemAcessors and CreateSignals - Remove indentation level - Move NonDPointerMembers and DPointerMembers REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://pha

D25877: [KColorschemeManager] Add option to reenable following global theme

2019-12-25 Thread Alexander Semke
asemke added inline comments. INLINE COMMENTS > kcolorschememanager.cpp:107 > }); > +m_data.prepend({i18n("System color scheme"), QString(), > QIcon::fromTheme("edit-undo")}); > endResetModel(); Many applications like kdevelop, digikam, labplot, etc. create a menu "Color Scheme"