asemke added inline comments.
INLINE COMMENTS
> kcolorschememanager.cpp:107
> });
> + m_data.prepend({i18n("System color scheme"), QString(),
> QIcon::fromTheme("edit-undo")});
> endResetModel();
Many applications like kdevelop, digikam, labplot, etc. create a menu "Color
Scheme" in the main menu bar and add then menu item via KColorSchemeManager. By
using "System color scheme" here we'd have "Color Scheme" -> "System color
scheme" with this repeated "color scheme" string. Can we simply use "Default"
or "System" or "Desktop" here?
> kcolorschememanager.cpp:229
> qApp->setProperty("KDE_COLOR_SCHEME_PATH", index.data(Qt::UserRole));
> -
> qApp->setPalette(KColorScheme::createApplicationPalette(KSharedConfig::openConfig(index.data(Qt::UserRole).toString())));
> + if (index.data(Qt::UserRole).toString().isNull()) {
> + qApp->setPalette(qApp->style()->standardPalette());
if (index.row() == 0) would also do the job and is simpler and faster.
> kcolorschememanager.h:129
> + */
> + void followSystemScheme();
> +
What should be the use-case for this new function and should it really be a
slot?
REPOSITORY
R265 KConfigWidgets
BRANCH
systemthem (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D25877
To: davidre, #frameworks, ngraham
Cc: asemke, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh,
bruns
