D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

catherinez added a comment. Catherine Zotov REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D27356 To: catherinez, #kwin, davidedmundson Cc: ngraham, davidedmundson, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28397: Replace Vokoscreen with VokoscreenNG

pino added a comment. please do //not// change translated keys (eg `Name[lang]`) in desktop-alike files when you change the English string: we have a system in place to handle translations REPOSITORY R304 KNewStuff BRANCH update-vokoscreen-url (branched from master) REVISION DETAIL h

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

ngraham added a comment. In D28353#637213 , @niccolove wrote: > Heh, you're right here. And I think that... > > > I might have proposed this before, but I think an improvement would be to dynamically change the transparency of the panel and

D28397: Replace Vokoscreen with VokoscreenNG

ngraham accepted this revision. ngraham added a reviewer: leinir. ngraham added a comment. This revision is now accepted and ready to land. It's also in openSUSE Tumbleweed, FWIW--where it's replaced the old Vokoscreen entirely. Since the newer distros that will get a new KNewStuff are al

D27356: Fix EWMH non-compliance for NET::{OnScreenDisplay, CriticalNotification}

ngraham added a comment. Sorry for the delay, I can land this for you. However I'll need your full name and email address so we can populate the git authorship information with that, as Phabricator stripped all of that out because this patch was not submitted with `arc` (silly Phabricator...

D28387: [QueryTest] Make phrase test case data driven and extend

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28387 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domso

D28384: [Extractor] Delay mimetype check, cleanup debug output

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good catch! REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28384 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGa

D28372: Added a merged look to the plasmoidheading and remove roundedborders

ngraham added a comment. So I have a heretical thought here: maybe we should consider using a CSD-style headerbar for system tray plasmoids with toolbar-style controls and put the controls on the same row as the header. No wait, hear me out! This pop-up doesn't suffer from most of the d

D28391: [pc3/busyindicator] Hide when not running

This revision was automatically updated to reflect the committed changes. Closed by commit R242:bc3ccd1782cb: [pc3/busyindicator] Hide when not running (authored by nicolasfella). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28391?vs=78768

D28409: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows

dfaure created this revision. dfaure added reviewers: kossebau, apol, cgiboudeaux. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. dfaure requested review of this revision. REVISION SUMMARY Not passing CMAKE_INSTALL_PREFIX is a we

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 21 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/21/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 20:38:02 + Build duration: 8 min 7 sec and counting JUnit Tests Name: projectroot

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 107 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/107/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 29 Mar 2020 20:38:02 + Build duration: 2 min 13 sec and counting

D28406: Fix sonnet autodetect test failure

dfaure added a comment. Well if the test is tolerant about correctLangCode, it might as well not require a specific variant upfront. What about replacing en_US-large with en_US and de_DE_frami with de_DE in SonnetAutoDetectTest::autodetect_data? This makes the first test pass for me (I

D28406: Fix sonnet autodetect test failure

waqar added a comment. In D28406#637359 , @dfaure wrote: > I'm no expert in this stuff, but here's my feedback > > 1. on my own system (!= CI), all three tests were failing before, due to finding en_AU-variant_1, en_AU-variant_1 and "". > 2

D28406: Fix sonnet autodetect test failure

waqar added inline comments. INLINE COMMENTS > dfaure wrote in test_autodetect.cpp:51 > This will have an effect on *other* instances of the Speller class? Yes, behind the scenes it is saved in the Settings. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waq

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.14 - Build # 20 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.14/20/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 18:19:39 + Build duration: 9 min 25 sec and counting JUnit Tests Name: projectroo

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 106 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/106/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 29 Mar 2020 18:19:38 + Build duration: 2 min 22 sec and counting CONSOLE OUTPUT [...t

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28388 To: dfaure, trmdi, ahmadsamir, meven Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

dfaure added a comment. In D28388#637417 , @ahmadsamir wrote: > (Now the other issue, "DEVICE" (from the kproperties patch) is always "8", whether I use ~/.bashrc, /usr/bin/file, or some file on a usb stick. But that's not really related to thi

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir accepted this revision. ahmadsamir added a comment. In D28388#637416 , @dfaure wrote: > kdeinit5 is the one who needs to see that QT_PLUGIN_PATH in order to locate kio_file.so. > > > $ export QT_PLUGIN_PATH=$PWD/bin > $

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

dfaure added a comment. kdeinit5 is the one who needs to see that QT_PLUGIN_PATH in order to locate kio_file.so. $ export QT_PLUGIN_PATH=$PWD/bin $ kdeinit5 $ kioclient5 openProperties ~/.bashrc 19:23:54.253 kio_file(27069/27069) createUDSEntry HELLO AHMAD REPOSITORY

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. $ export QT_LOGGING_RULES="*kio*=true" $ kdeinit5 from the build dir $ LD_LIBRARY_PATH=./ QT_PLUGIN_PATH=./ kioclient5 openProperties ~/.bashrc still not getting the qDebug() I put in createUDSEntry()... IIUC, qDebug() always worked regardless of the QT_L

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

dfaure added a comment. Type `kdeinit5` in a terminal, the output from ioslaves (created after that) will go there. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28388 To: dfaure, trmdi, ahmadsamir, meven Cc: kde-frameworks-devel, LeGast00n, cblack, G

D28406: Fix sonnet autodetect test failure

apol retitled this revision from ""Fix sonnet autodetect test failure"" to "Fix sonnet autodetect test failure". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

ahmadsamir added a comment. I spent some time trying to to get some output of a qDebug() that I put in createUDSEntry(), but got the total sum of nothing; for future reference, any pointers? (I tried the kpropertiesdialog small patch from D27951 among oth

D28407: Fix configure when xmllint is not present

This revision was automatically updated to reflect the committed changes. Closed by commit R266:23b32c25f0be: Fix configure when xmllint is not present (authored by tcberner). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28407?vs=78796&id=78801 REVISIO

D28407: Fix configure when xmllint is not present

kossebau accepted this revision. kossebau added a subscriber: ngraham. kossebau added a comment. This revision is now accepted and ready to land. Indeed was missing from the hotfix, thanks for catching. @ngraham How far have you come with learning cmake to clean up all this? :) REPOSITORY

D28388: kio_file: honour KIO::StatResolveSymlink for UDS_DEVICE_ID and UDS_INODE

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. This gonna change the behavior of the function compared to before the StatDetails stat patch (details = 3 returned the inode of the link and not the one of the link destination), but it make

D28407: Fix configure when xmllint is not present

tcberner created this revision. tcberner added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcberner requested review of this revision. REVISION SUMMARY The breeze-validate-svg target is only generated when xmllint is found. breeze-

D28406: "Fix sonnet autodetect test failure"

dfaure added a comment. I'm no expert in this stuff, but here's my feedback 1. on my own system (!= CI), all three tests were failing before, due to finding en_AU-variant_1, en_AU-variant_1 and "". 2. now the test passes locally, but because all tests are skipped SKIP : SonnetAut

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. > Please have a look and submit fixes. Patch sent at: D28406 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25495 To: waqar, mludwig, cullmann, apol Cc: dfaure, apol, ognarb, kde-frameworks-devel, LeGas

D28406: "Fix sonnet autodetect test failure"

waqar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. waqar requested review of this revision. REPOSITORY R246 Sonnet BRANCH fix-autodetect-test (branched from master) REVISION DETAIL https://phabricator.kde.org/D28406 AFFECTED F

D25495: Fix Sonnet autodetect failing on Indian langs

waqar added a comment. INLINE COMMENTS > dfaure wrote in test_autodetect.cpp:39 > Is there an explicit way to check whether a dictionary is installed? > The test row should be skipped, if not. On it. I will fix and send the patch REPOSITORY R246 Sonnet REVISION DETAIL https://phabricat

D28401: [SearchStore] Handle double values in property queries

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Allows to e.g. query Photo exposure times, aperture etc. Depends on D28400

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns added a dependent revision: D28401: [SearchStore] Handle double values in property queries. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28400 To: bruns, #baloo, ngraham Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, doms

D28400: [AdvancedQueryParser] Move semantic handling of tokens to SearchStore

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY The AdvancedQueryParser has no knowledge about the semantics of a value, whil

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 105 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/105/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 29 Mar 2020 11:10:32 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT [...t

D28396: [MTimeDB] Consolidate time interval handling code

bruns updated this revision to Diff 78782. bruns added a comment. . REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28396?vs=78775&id=78782 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D28396 AFFECTED FILES autotests/unit/engine/mtimedbte

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28268 To: dfaure, davidedmundson, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 11:05:12 + Build duration: 56 sec and counting JUnit Tests Name: projectr

D28295: Introduce KNotificationJobUiDelegate

dfaure added inline comments. INLINE COMMENTS > broulik wrote in knotificationjobuidelegate.cpp:24 > I thought we wanted to migrate towards nested `Private` class? :0 I don't remember any past discussion about this, but as I discovered in KIO commit 3d2330968b

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 104 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/104/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 29 Mar 2020 10:39:38 + Build duration: 1 min 34 sec and counting CONSOLE OUTPUT [...t

D28367: KServiceAction: store parent service

dfaure closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28367 To: dfaure, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 103 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/103/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 29 Mar 2020 10:37:59 + Build duration: 1 min 33 sec and counting CONSOLE OUTPUT [...t

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28266 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

dfaure added inline comments. INLINE COMMENTS > broulik wrote in applicationlauncherjob.h:50 > Please add this in a separate commit Done in https://commits.kde.org/kio/01a4b70803d5bc9144a7ca7aec12081b4356c638 (also in CommandLauncherJob) > broulik wrote in kpropertiesdialog.cpp:1458 > Call this

KDE CI: Frameworks » kio » kf5-qt5 WindowsMSVCQt5.14 - Build # 102 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20WindowsMSVCQt5.14/102/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Sun, 29 Mar 2020 10:35:32 + Build duration: 2 min 17 sec and counting CONSOLE OUTPUT [...t

D28295: Introduce KNotificationJobUiDelegate

broulik planned changes to this revision. broulik added inline comments. INLINE COMMENTS > kossebau wrote in knotificationjobuidelegate.cpp:24 > Not using a nested class `Private` but a normal separate one like here to be > named `KNotificationJobUiDelegatePrivate` seems more simple, avoids the

D28390: KIO: remove waitForStarted() from the launcher jobs public API

dfaure closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28390 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28268: KDesktopFileActions: port from KRun::run to KIO::ApplicationLauncherJob

broulik accepted this revision. broulik added a comment. Much nicer :) REPOSITORY R241 KIO BRANCH kdesktopfileactions REVISION DETAIL https://phabricator.kde.org/D28268 To: dfaure, davidedmundson, apol, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, brun

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Also +1 for porting to kservice rather than launching binary INLINE COMMENTS > applicationlauncherjob.h:50 > * > + * For error handling, either connect to the result() signal, or for a

D28367: KServiceAction: store parent service

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kserviceaction.cpp:50 > bool noDisplay) > : d(new KServiceActionPrivate(name, text, icon, exec, noDisplay)) > { You can just del

D28390: KIO: remove waitForStarted() from the launcher jobs public API

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D28390 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Sun, 29 Mar 2020 10:14:52 + Build duration: 1 min 2 sec and counting JUnit Tests Name: pr

D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

niccolove added a comment. In D28353#636931 , @ngraham wrote: > It would be helpful to remind people of those details in the Test Plan section in the future. :) I will! Sorry. It applied to me without cache clearing, so I assumed it didn

D28266: KPropertiesDialog: port KRun::run to ApplicationLauncherJob

dfaure added a comment. ping? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28266 To: dfaure, davidedmundson, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D17816: Support for xattrs on kio copy/move

dfaure accepted this revision. dfaure added a comment. Thanks. I agree :-) INLINE COMMENTS > bruns wrote in file_unix.cpp:232 > what about `#elif defined(Q_OS_MAC)`? @bruns HAVE_SYS_XATTR_H covers mac and non-mac here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17

D28372: Added a merged look to the plasmoidheading and remove roundedborders

mart added inline comments. INLINE COMMENTS > niccolove wrote in PlasmoidHeading.qml:77 > I'd go with no SVG, to make sure that the theme creators will see that it's > broken and add a merged- look. Keep in mind that the plasmoidheading svg was > added barely one month ago, and no big Plasma re

D28397: Replace Vokoscreen with VokoscreenNG

harogaston added a comment. In D28397#637193 , @IlyaBizyaev wrote: > It seems that of released distros, only Fedora has vokoscreenNG in repositories so far It's in the AUR also https://aur.archlinux.org/packages/vokoscreen but I can see

D28397: Replace Vokoscreen with VokoscreenNG

IlyaBizyaev added a comment. It seems that of released distros, only Fedora has vokoscreenNG in repositories so far REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham Cc: IlyaBizyaev, kde-frameworks-devel, LeGast00n, cblack,

D28397: Replace Vokoscreen with VokoscreenNG

harogaston edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28397: Replace Vokoscreen with VokoscreenNG

harogaston edited the summary of this revision. harogaston edited the test plan for this revision. harogaston added reviewers: KNewStuff, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D28397 To: harogaston, #knewstuff, ngraham Cc: kde-frameworks-devel, LeGast

D28397: Replace Vokoscreen with VokoscreenNG

harogaston created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. harogaston requested review of this revision. REVISION SUMMARY The original Vokoscreen project has been abandoned and superseeded by VokoscreenNG. This patch updates