KDE CI: Frameworks » kdelibs4support » kf5-qt5 FreeBSDQt5.14 - Build # 3 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/kdelibs4support/job/kf5-qt5%20FreeBSDQt5.14/3/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 09 Apr 2020 04:20:18 + Build duration: 30 min and counting JUnit Tests Name:

D28682: export done signal in filecontentindexer

bruns added a comment. In D28682#644430 , @astippich wrote: > In D28682#644414 , @bruns wrote: > > > In general fine for me. > > > > How will Elisa deal with the indexer maybe crashing

D28682: export done signal in filecontentindexer

astippich added a comment. > Quoted Text > >> ! In D28682#644412 , @mgallien wrote: > > This is the reason why it is so slow in Elisa? Do you mean slow for picking up changes in files? Then yes. This happens when a track is modified

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. OK, thanks for the pointers. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28682: export done signal in filecontentindexer

bruns added a comment. In general fine for me. How will Elisa deal with the indexer maybe crashing inbetween? Do we also need a signal for a batch start? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien,

D28682: export done signal in filecontentindexer

mgallien added a comment. This is the reason why it is so slow in Elisa? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D28682 To: astippich, #baloo, bruns Cc: mgallien, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson,

D28669: make CopyJob non-recursive

dfaure requested changes to this revision. dfaure added inline comments. INLINE COMMENTS > copyjob.cpp:809 > ++m_currentStatSrc; > -statCurrentSrc(); > } Why did you remove this call? Your patch has no context (please use `arc` to upload patches to phabricator), but I can see here

D28406: Fix sonnet autodetect test failure

dfaure added a comment. @waqar ping? What do you think about my suggestion? If you agree, can you update the patch? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D28682: export done signal in filecontentindexer

astippich created this revision. astippich added reviewers: Baloo, bruns. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. astippich requested review of this revision. REVISION SUMMARY Applications can subsribe for new files being indexed by baloo via

D28406: Fix sonnet autodetect test failure

dfaure requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28406: Fix sonnet autodetect test failure

dfaure added a reviewer: dfaure. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28406 To: waqar, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin updated this revision to Diff 79656. ervin marked 6 inline comments as done. ervin added a comment. Addresses David's comments REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=78703=79656 REVISION DETAIL

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin marked 6 inline comments as done. ervin added inline comments. INLINE COMMENTS > davidedmundson wrote in kconfigdialogmanager.cpp:609 > Why not item->readDefault()? Wouldn't do the same thing at all. readDefault() takes a KConfig object and updates the default value stored in the item

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin added a comment. In D27540#638985 , @ndavis wrote: > Somehow I missed the notification that this was updated. > > Thanks for the horizontal alignment. Could you also add a left margin to the column of reset buttons? It should be the

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis, broulik Cc: alexde, ndavis, iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack,

Re: Problems in KWayland causes by API and ABI compatibility promises

Hello, On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote: > Here is a list of active uses of the KWayland::Client API. > > frameworks > plasma-framework (for window positioning) > > apps: > spectacle (for window positioning) > kdeconnect-kde (for fake input) >

Re: Tips for testing and debugging KWindowSystem

Hi Victor, We usually recommend installing the packages to test into a separate prefix so you can only test whatever you want against it, so that you don't break your own system. Now for more details I guess we'd need to know what you're trying to improve. Aleix On Tue, Apr 7, 2020 at 11:49 PM

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Hm. So, this is a bit complicated I've noticed. Let's consider the following cases: - `desktop:` is not a local file but can set and read dir icons without penalty - `camera:` is not a local file AND `Class=:local` BUT (I think?) cannot set dir icons as it

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir updated this revision to Diff 79643. ahmadsamir added a comment. --verbatim REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28679?vs=79640=79643 BRANCH l-kprop (branched from master) REVISION DETAIL https://phabricator.kde.org/D28679 AFFECTED

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. I thought about that, but since I am not experienced with network mounts (I rarely use them), I didn't expand the test In D28679#644274 , @sitter wrote: > Looks reasonable. Though... Shouldn't that rather be any

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

broulik added a comment. > assuming we have a way of telling which slaves are remote `KProtocolInfo::protocolClass(url.scheme())` not being `":local"` REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: broulik,

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

sitter added a comment. Looks reasonable. Though... Shouldn't that rather be any protocol that isn't `file`? Or at least all that are remote? (assuming we have a way of telling which slaves are remote) If I open sftp it also shows no dir icons yet lets me set one. REPOSITORY R241 KIO

KDE CI: Frameworks » kirigami » kf5-qt5 SUSEQt5.12 - Build # 414 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/414/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 08 Apr 2020 13:41:13 + Build duration: 2 min 16 sec and counting BUILD ARTIFACTS

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir added a comment. I don't have access to a samba share so I tested with an sftp:// one, after modifying the diff locally. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28679 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n,

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Changing the icon of a dir on a samba share doesn't seem to have an effect, this is intentional as

D28336: Drop klauncher usage from KCrash

davidedmundson updated this revision to Diff 79634. davidedmundson added a comment. and merge methods REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28336?vs=78636=79634 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28336 AFFECTED FILES

D28336: Drop klauncher usage from KCrash

This revision was automatically updated to reflect the committed changes. Closed by commit R285:d8e41e64b7d0: Drop klauncher usage from KCrash (authored by davidedmundson). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28336?vs=79634=79635 REVISION DETAIL

D28336: Drop klauncher usage from KCrash

sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcrash.cpp:627 > > void KCrash::startProcess(int argc, const char *argv[], bool waitAndExit) > { This seems to serve no purpose anymore. startProcessInternal could

D28669: make CopyJob non-recursive

anthonyfieroni added inline comments. INLINE COMMENTS > meven wrote in copyjob.cpp:814 > about @anthonyfieroni comment > Add `&& !isKilled()` with a code path to handle it properly. It'll not help, message queue will be blocked and you kill the from other thread, which is not what we want.

D28675: [KMimeTypeChooser] Add the ability to filter the treeview with a QSFPM

ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, cfeck, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY - Add each mimetype comment as a tooltip instead of an optional column; adjust the docs accordingly -

D28673: [PackageUrlInterceptor] Make QRegularExpression static

pino added a comment. Does it really need to be a regular expression, though? A simple string search & replace should do the same thing. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: broulik, #plasma Cc: pino, kde-frameworks-devel,

D28673: [PackageUrlInterceptor] Make QRegularExpression static

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Avoids recompiling it every time. TEST PLAN Called 27 times on plasmashell startup

D28669: make CopyJob non-recursive

meven requested changes to this revision. meven added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > copyjob.cpp:814 > Q_Q(CopyJob); > -if (m_currentStatSrc != m_srcList.constEnd()) { > +while (m_currentStatSrc != m_srcList.constEnd()) { >

D28669: make CopyJob non-recursive

anthonyfieroni added a comment. If you want to kill the job how this loop will be break? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28669 To: McPain, #frameworks, dfaure, meven, ahmadsamir Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,