D19811: Add Smali syntax highlighting file

davispuh updated this revision to Diff 54631. davispuh added a comment. Reduce size of test file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19811?vs=54120=54631 BRANCH smali REVISION DETAIL https://phabricator.kde.org/D19811 AFFECTED

D19811: Add Smali syntax highlighting file

davispuh updated this revision to Diff 54120. davispuh added a comment. Add a test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19811?vs=54046=54120 BRANCH smali REVISION DETAIL https://phabricator.kde.org/D19811 AFFECTED FILES

D19811: Add Smali syntax highlighting file

davispuh updated this revision to Diff 54046. davispuh added a comment. Use MIT license REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19811?vs=54045=54046 BRANCH smali REVISION DETAIL https://phabricator.kde.org/D19811 AFFECTED FILES

D19811: Add Smali syntax highlighting file

davispuh created this revision. davispuh added reviewers: cullmann, dhaumann, vkrause. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davispuh requested review of this revision. TEST PLAN Open

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53970. davispuh added a comment. Also check for present formats REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53237=53970 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533

D19644: Reduce balooctl index/clear memory usage

davispuh added a comment. In D19644#428074 , @bruns wrote: > Do not create a new transaction per file, thats costly. Still less expensive than single transaction for 1k files REPOSITORY R293 Baloo REVISION DETAIL

D19644: Reduce balooctl index/clear memory usage

davispuh updated this revision to Diff 53549. davispuh edited the summary of this revision. davispuh edited the test plan for this revision. davispuh added a comment. Don't create transaction for every file REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE

D19644: Reduce balooctl index/clear memory usage

davispuh added a comment. In D19644#428047 , @bruns wrote: > A transaction can not be split up, thats the reason it is a transaction ... It can and they must be split in a lot smaller transactions. Currently sometimes baloo uses way too

D19644: Reduce balooctl index/clear memory usage

davispuh edited the summary of this revision. davispuh edited the test plan for this revision. davispuh added reviewers: dhaumann, bruns, ngraham. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19644 To: davispuh, dhaumann, bruns, ngraham Cc: bruns, kde-frameworks-devel,

D19644: Reduce balooctl index/clear memory usage

davispuh created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. davispuh requested review of this revision. REPOSITORY R293 Baloo BRANCH master REVISION DETAIL https://phabricator.kde.org/D19644 AFFECTED FILES

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53237. davispuh added a comment. Don't duplicate code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53236=53237 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFECTED FILES

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53236. davispuh added a comment. Whoops... REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53235=53236 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFECTED FILES

D19533: Don't crash on malformed syntax highlighting files

davispuh updated this revision to Diff 53235. davispuh added a comment. Allow invalid Format() REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19533?vs=53177=53235 BRANCH malformed REVISION DETAIL https://phabricator.kde.org/D19533 AFFECTED FILES

D19532: Don't crash when no contexts are present

davispuh updated this revision to Diff 53234. davispuh added a comment. Improvements REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19532?vs=53175=53234 BRANCH context REVISION DETAIL https://phabricator.kde.org/D19532 AFFECTED FILES

D19532: Don't crash when no contexts are present

davispuh added a comment. In D19532#425381 , @cullmann wrote: > Calling the ::get is no issue. That's good then, but we can't use `applyFormat(0, text.size(), Format());` because Kate asserts when `!Format->isValid()` which it won't be

D19532: Don't crash when no contexts are present

davispuh added a comment. In D19532#425376 , @cullmann wrote: > No, because defData isn't defined there yet, it's created only later with auto defData = DefinitionData::get(d->m_definition); > > => you can just move that up some lines, or?

D19532: Don't crash when no contexts are present

davispuh added a comment. In D19532#424926 , @cullmann wrote: > Hi, first: good thing to get this fixed, yes, it shall not crash. > > For the fix: Wouldn't it be enough to just change the > > if (!d->m_definition.isValid()) { > >

D19533: Don't crash on malformed syntax highlighting files

davispuh added reviewers: cullmann, dhaumann. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19533 To: davispuh, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D19532: Don't crash when no contexts are present

davispuh added a dependent revision: D19533: Don't crash on malformed syntax highlighting files. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh,

D19533: Don't crash on malformed syntax highlighting files

davispuh added a dependency: D19532: Don't crash when no contexts are present. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D19533 To: davispuh, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D19533: Don't crash on malformed syntax highlighting files

davispuh created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davispuh requested review of this revision. TEST PLAN 1. Create malformed syntax highlighting file with missing end tags 2. Place it in

D19532: Don't crash when no contexts are present

davispuh updated this revision to Diff 53175. davispuh added a comment. Actually fix it REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19532?vs=53170=53175 BRANCH context REVISION DETAIL https://phabricator.kde.org/D19532 AFFECTED FILES

D19532: Don't crash when no contexts are present

davispuh added a comment. Creating a syntax highlighting file with few unclosed tags made Kate to crash. No matter how malformed XML it loads, editor should never crash as it can cause loss of unsaved work. Crash is caused by Context* DefinitionData::initialContext() const {

D19532: Don't crash when no contexts are present

davispuh added reviewers: cullmann, dhaumann, vandenoever. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19532 To: davispuh, cullmann, dhaumann, vandenoever Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann,

D19532: Don't crash when no contexts are present

davispuh created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davispuh requested review of this revision. TEST PLAN 1. Compiled 2. Placed malformed XML in ~/.local/share/katepart5/syntax/ 3. Opened a file which uses

Re: Scrap baloo?

What about using already existing solutions for indexing and storage? like for example there are projects: * Apache Lucene - https://lucene.apache.org/ * Apache Solr - https://lucene.apache.org/solr/ (it's built on top of Lucene) * ElasticSearch - https://www.elastic.co/ * Xapian -

Re: Review Request 127281: [kio-extras] Audio (id3) thumbnailer

-frameworks ? it works fine with Qt5/KF5 and I've been using to for months. I wonder if there would be some better way with either merging it all in here or something without duplicating code. Currently it supports more formats than this RR gives. - Dāvis Mosāns On marts 4, 2016, 11:43 p.m

Re: Review Request 127187: Fix build for MSVC (2013) on Windows

tps://git.reviewboard.kde.org/r/127187/#comment63238> Wouldn't it be better to use _MSC_VER <= 1800 /* MSVC2013 */ as maybe it works for MSVC2015? - Dāvis Mosāns On Feb. 26, 2016, 11:32 a.m., Thomas Friedrichsme

Re: Review Request 126587: Add option to build with gcov support

e. Indeed. - Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90426 --- On Dec. 31, 2015, 11:13 p.m

Re: Review Request 126587: Add option to build with gcov support

, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126587: Add option to build with gcov support

- Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126587/#review90423 --- On Dec. 31, 2015, 11:13 p.m., Dāvis Mosāns wrote: > > --- > This i

Review Request 126587: Add option to build with gcov support

--- Add option to build with gcov support Diffs - CMakeLists.txt 916970287c070c07a60f8dbcd5f0758ac602038e Diff: https://git.reviewboard.kde.org/r/126587/diff/ Testing --- Compiles Thanks, Dāvis Mosāns ___ Kde-frameworks-devel

Review Request 125756: Initialize QFunctionPointer to nullptr

Diffs - src/declarativeimports/core/windowthumbnail.h 576b053229a8cfc15b6fadd8d4e6ff07f937565d Diff: https://git.reviewboard.kde.org/r/125756/diff/ Testing --- Verified that plasmashell doesn't crash anymore. Thanks, Dāvis Mosāns

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

Diff: https://git.reviewboard.kde.org/r/125756/diff/ Testing --- Verified that plasmashell doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 125756: Initialize QFunctionPointer to Q_NULLPTR

5a5274e1eacdb9b91ff500e1ebf9046930891ecf Diff: https://git.reviewboard.kde.org/r/125756/diff/ Testing --- Verified that plasmashell doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 125556: Install CamelCase headers

s.txt - Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86657 --- On Oct. 11, 2015, 10:46 p.m., Dāv

Re: Review Request 125556: Install CamelCase headers

/ Testing --- Compiles and headers are installed. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125556: Install CamelCase headers

e) because currently it uses KF5MediaWiki - Dāvis --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125556/#review86673 -------

Re: Review Request 125556: Install CamelCase headers

--- Compiles and headers are installed. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125556: Install CamelCase headers

. Repository: libmediawiki Description --- They were generated but wasn't installed. Diffs - src/CMakeLists.txt a8e095ab0a5eaf86c2fc3b5035ef5d476b899023 Diff: https://git.reviewboard.kde.org/r/125556/diff/ Testing --- Compiles and headers are installed. Thanks, Dāvis Mosāns

Re: Review Request 124542: CMake fixes for Windows build

On Aug. 8, 2015, 5:40 p.m., Kevin Funk wrote: @Luigi: Bump? Luigi Toscano wrote: I was waiting for D?vis' answer, but given that 5.13 is out, there is enough time to fix it before 5.14. So let's go, and thanks. Luigi Toscano wrote: Just please remember to use a more

Re: Review Request 124542: CMake fixes for Windows build

On Aug. 2, 2015, 12:35 a.m., Kevin Funk wrote: Looking back at the review which introduced the escaping, namely https://git.reviewboard.kde.org/r/120648/ , I escaped the comma as well in the first review. I don't remember why I removed them. Apart from that usage, comma are invalid

Re: Review Request 124414: Fix kbuildsycoca5 --global

) - src/kbuildsycoca/kbuildsycoca.cpp 074a7d830f7d3781960e64c16f721fae9edc26f9 Diff: https://git.reviewboard.kde.org/r/124414/diff/ Testing --- Seems to be working, atleast doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel

Re: Review Request 124414: Fix kbuildsycoca5 --global

--- On jūlijs 22, 2015, 6:04 p.m., Dāvis Mosāns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414

Re: Review Request 124414: Fix kbuildsycoca5 --global

/ Testing --- Seems to be working, atleast doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124414: Fix kbuildsycoca5 --global

--- On jūlijs 21, 2015, 11:51 p.m., Dāvis Mosāns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414

Review Request 124414: Fix kbuildsycoca5 --global

074a7d830f7d3781960e64c16f721fae9edc26f9 Diff: https://git.reviewboard.kde.org/r/124414/diff/ Testing --- Seems to be working, atleast doesn't crash anymore. Thanks, Dāvis Mosāns ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 124414: Fix kbuildsycoca5 --global

--- On jūlijs 21, 2015, 11:51 p.m., Dāvis Mosāns wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124414