D26000: [Plasma Dialog] Use QXcbWindowFunctions for setting window types Qt WindowFlags don't knows

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY ... but Qt XCB knows, such as Notifications type. This ensures QXcbWindow keeps the

D25991: [KFilePlacesModel] Fix supported scheme check for devices

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A device doesn't usually have a URL so we need to actutally check the underlying devic

D25984: Load translations

broulik added a comment. Sounds good to me lol REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, ma

D25984: Load translations

broulik edited the summary of this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, he

D25984: Load translations

broulik added a reviewer: sitter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25984: Load translations

broulik created this revision. broulik added reviewers: Kirigami, Frameworks, kossebau, aacid. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't

D25859: Add Battery1 interface

This revision was automatically updated to reflect the committed changes. Closed by commit R269:5eabf3ac55c7: Add Battery1 interface (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D25859?vs=71431&id=71441#toc REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE ht

D25859: Add Battery1 interface

broulik updated this revision to Diff 71431. broulik added a comment. - Fix crash due to uninitialized q ptr REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25859?vs=71215&id=71431 REVISION DETAIL https://phabricator.kde.org/D25859 AFFECTED FILES autot

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik added inline comments. INLINE COMMENTS > ksortfilterproxymodel.h:2 > +/* > + * Copyright 2010 by Marco MArtin > + *Martin > ksortfilterproxymodel.h:44 > + */ > +Q_PROPERTY(QString filterRegExp READ filterRegExp WRITE setFilterRegExp > NOTIFY filterRegExpChanged) > + Did you

D25887: [ColorScope] Work with plain QObjects again

This revision was automatically updated to reflect the committed changes. Closed by commit R242:8f7b2c9ae099: [ColorScope] Work with plain QObjects again (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25887?vs=71280&id

D25887: [ColorScope] Work with plain QObjects again

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise `colorScope` doesn't attach to things like `Plasma.Svg`. Also remove

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

This revision was automatically updated to reflect the committed changes. Closed by commit R242:e44cab6ab55b: [Breeze Desktop Theme] Add monochrome user-desktop icon (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25885

D25885: [Breeze Desktop Theme] Add monochrome user-desktop icon

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This ensures the "show desktop" plasmoid remains monochrome in the panel at any s

D25878: Use clearer relative dates

broulik added a comment. Yeah i think yesterday and tomorrow is fine but everything beyond that becomes more annoying than helpful REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik, kde-frameworks-de

D25878: Use clearer relative dates

broulik added a comment. Not a fan of Mathematics there. "Five days ago" I first have to open my calendar and count what day that was. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D25878 To: ngraham, davidedmundson, #vdg, #frameworks Cc: broulik, kde-framework

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

This revision was automatically updated to reflect the committed changes. Closed by commit R296:c3e6627e598b: [QImageItem/QPixmapItem] Don't lose precision during calculation (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25685?vs=7

D25859: Add Battery1 interface

broulik added a dependent revision: D25860: [plasmoid] Show device battery percentage. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D25859 To: broulik, #frameworks, drosca Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25856: Show IOSlaves that return local files when in local file mode

broulik added a comment. Isn't that what `KProtocolInfo::protocolClass() == ":local"` is for? REPOSITORY R229 KDialog REVISION DETAIL https://phabricator.kde.org/D25856 To: ngraham, #frameworks, #dolphin Cc: broulik, meven

D25859: Add Battery1 interface

broulik created this revision. broulik added reviewers: Frameworks, drosca. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Allows querying for a Bluetooth device's battery status. TEST PLAN - Add

D25833: Expose getter to KConfigWatcher's config

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kconfigwatcher.h:56 > + * Returns the config being watched > + * @since 5.65 > + */ 5.66 - tagging for 5.65 was last Sunday REPOSITORY R237 KConfig BR

D15763: Set correct image attributes on directory thumbnail

broulik added a comment. @dfaure Ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15763 To: broulik, #frameworks, dfaure, anthonyfieroni, jtamate, ngraham Cc: ngraham, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampalouk

D25815: Transmission-Qt tray icon added

broulik added a comment. I chceked transmission git code and the icon name it uses is actually `transmission-tray-icon`, so you want to have a `transmission.svg` file and the "id" to be `transmission-tray-icon`, then it should work: https://github.com/transmission/transmission/blob/master/qt

D25755: Replace iterators with range-based for

broulik added a comment. In D25755#572418 , @apol wrote: > Do we dislike iterators now? We don't, and they still make sense for when you need the `key`, but range for is just much nier to look at :) REPOSITORY R297 KDED REVISION DETAI

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added inline comments. INLINE COMMENTS > dfaure wrote in desktopexecparser.cpp:356 > This blocks. > > I don't mind much myself, but I know some people had a mandate to remove as > many blocking calls as possible from KRun and related code. Or was that only > avoiding blocking I/O becau

D25756: Port from QStringList::ConstIterator to range-based for

broulik added inline comments. INLINE COMMENTS > kauthorized.cpp:252 > QStringList result; > -for (QStringList::ConstIterator it = menuIds.begin(); > -it != menuIds.end(); ++it) { > -if (cg.readEntry(*it, true)) { > -result.append(*it); > +for (const Q

D25749: [CopyJob] When linking also consider https for text-html icon

This revision was automatically updated to reflect the committed changes. Closed by commit R241:b78027f01176: [CopyJob] When linking also consider https for text-html icon (authored by broulik). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25749?vs=70918&id=7091

D25749: [CopyJob] When linking also consider https for text-html icon

broulik edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25749 To: broulik, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25749: [CopyJob] When linking also consider https for text-html icon

broulik created this revision. broulik added reviewers: Frameworks, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Ensures dragging a "https" link, which is most of them these days, has a

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added a comment. Can you please move the DBus XML file in a common location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23384 To: feverfew, fvogt, davidedmundson, dfaure, ngraham Cc: alexde, broulik, sitter, davidedmundson, kde-frameworks-devel, ngraham, LeG

D25717: [KSqueezedTextLabel] Add icon for "Copy entire text" action

This revision was automatically updated to reflect the committed changes. Closed by commit R236:d45ea2c6c0f3: [KSqueezedTextLabel] Add icon for "Copy entire text" action (authored by broulik). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25717?vs=7083

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

broulik added a comment. Why is it ugly? I think the fallback is usually meant to fall back to e.g. a built-in icon pixmap, but doing a chain of `fromTheme` fallbacks is just fine imho. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks

D25717: [KSqueezedTextLabel] Add icon for "Copy entire text" action

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It is a "Copy" action, after all REPOSITORY R236 KWidgetsAddons REVISION DETAI

D25716: [KPropertiesDialog] Show extra fields

broulik updated this revision to Diff 70831. broulik added a comment. - Use `KSqueezedTextLabel` REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25716?vs=70829&id=70831 REVISION DETAIL https://phabricator.kde.org/D25716 AFFECTED FILES src/widgets/kproperti

D25716: [KPropertiesDialog] Show extra fields

broulik created this revision. broulik added reviewers: Frameworks, VDG, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY This can be additional useful information about the file, such as dele

D25707: [renamedialog] Replace KIconLoader usage with QIcon::fromTheme

broulik added a comment. From what I understood `loadMimeTypeIcon` has this fallback to use "Unknown" icon, see D15451 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25707 To: nicolasfella, #frameworks Cc: broulik, kde-frameworks-de

D25678: Document Notifiers setting

This revision was automatically updated to reflect the committed changes. Closed by commit R237:f366253557c6: Document Notifiers setting (authored by broulik). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25678?vs=70722&id=70814 REVISION DETAIL https://ph

D25685: [QImageItem/QPixmapItem] Don't lose precision during calculation

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Operate on `QRectF`/`QSizeF` and only round back to integer at the end. TEST PLAN I

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

broulik added a comment. It appears to open everything remote through kiofuse. - Click a text file in `sftp://foo/bar` will kiofuse it and then open it in Kate - Clicking a http link in my chat app now kiofuses it and then has the browser desperately try to open `/run/user/1000/kio-fus

D25461: [KCM GridDelegate] Use non-attached ToolTip

broulik added a comment. Kirigami has a `toolTipDelay` in `Units`. The other bit is hardcoded to some heuristic: https://cgit.kde.org/qqc2-desktop-style.git/tree/org.kde.desktop/ToolTip.qml#n48 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25461 To: brouli

D25678: Document Notifiers setting

broulik created this revision. broulik added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25678 AFFECTED FILE

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

broulik added a comment. Alternatively we could fix the scroll view container taking into account the `scroll` enabled, so that `view.enabled` does the right thing REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, da

D25520: GridViewKCM expose a property to disable the GridView in a KCM without disabling the whole KCM

broulik added a comment. Can't you do `view.enabled: false`? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D25520 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica from KAboutDialog

broulik retitled this revision from "Remove Attica" to "Remove Attica from KAboutDialog". REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25506 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica from KAboutDialog

broulik edited the summary of this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25506 To: broulik, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25506: Remove Attica

broulik created this revision. broulik added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It's defunct and unused. Gets rid of everything that cannot be done with just `K

D25500: Remove dependency on QtWidgets

broulik added a comment. -1 There's UI shown by kded, like network manager prompts and other bits. Also, some bits probably need windowing capabilities. Certainly something to look into (e.g. use `QGuiApplication` and turn off platform awareness) but not something we can "just" do in a min

D25485: Remove KIconThemes use

This revision was automatically updated to reflect the committed changes. Closed by commit R39:c7d64230aa34: Remove KIconThemes use (authored by broulik). Herald added a project: Kate. Herald added a subscriber: kwrite-devel. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabri

D25485: Remove KIconThemes use

broulik created this revision. broulik added reviewers: Frameworks, cullmann. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY It was effectively unused. TEST PLAN - help button on the variable edi

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > ... which people say is ABI-compatible "You can ... reimplement virtual functions defined in the primary base class hierarchy (that is, virtuals defined in the first non-virtual base class, or i

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > broulik wrote in personssortfilterproxymodel.h:53 > Can you just forward the entire thing: > > Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) > override; ... which people say is ABI-compatible REPOSITORY R307 KP

D24046: Allow triggering sort from QML

broulik added inline comments. INLINE COMMENTS > personssortfilterproxymodel.h:53 > bool filterAcceptsRow(int source_row, const QModelIndex &source_parent) > const override; > +Q_INVOKABLE void sortNow(); > Can you just forward the entire thing: Q_INVOKABLE void sort(int column, Q

D25461: [KCM GridDelegate] Use non-attached ToolTip

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Then it can just follow the style's delay and timeout. TEST PLAN - Hovered gri

D25435: [Network Ioslave] Add Display name to network:/

broulik added a comment. I think this needs a `add_definitions(-DTRANSLATION_DOMAIN` and `Messages.sh` file? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25435 To: meven, ngraham, #frameworks Cc: broulik, kde-frameworks-devel, kfm-devel, pberestov, iasensio, f

D25394: support Qt File selectors in KPackage

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage BRANCH phab/selectors REVISION DETAIL https://phabricator.kde.org/D25394 To: mart, #plasma, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25223: Avoid side effects during menu initialization

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D25223 To: kmaterka, #plasma, #frameworks, broulik Cc: nicolasfella, davidedmundson, cgiboud

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in sortfiltermodel.h:43 > It's not listed in https://doc.qt.io/qt-5/qtqml-cppintegration-data.html > > We need to test Bummer. I tried, a JS `RegExp` (both `new RegExp()` and `/literal syntax/`) get turned into a `QRegExp`.

D25360: Conditionally set SH_ScrollBar_LeftClickAbsolutePosition based on kdeglobals setting

broulik added inline comments. INLINE COMMENTS > kstyle.cpp:504 > +KConfigGroup g(KSharedConfig::openConfig(), "KDE"); > +return !g.readEntry("LeftClickNavigatesByPage", true); > +} `ScrollBarLeftClick...`? REPOSITORY R252 Framework Integration REVISION DETAIL https://p

D25326: Move Plasma's SortFilterProxyModel into KItemModel's QML plugin

broulik added inline comments. INLINE COMMENTS > sortfiltermodel.cpp:84 > +QQmlEngine *engine = QQmlEngine::contextForObject(this)->engine(); > +args << > engine->toScriptValue(idx.data(m_roleIds.value(m_filterRole))); > + Can we also just have it send `source_row` and `source_p

D25223: Avoid side effects during menu initialization

broulik added inline comments. INLINE COMMENTS > kdeplatformsystemtrayicon.cpp:27 > #include > +#include > Already included in the header file > kdeplatformsystemtrayicon.cpp:33 > : QPlatformMenu() > -, m_enabled(true) > -, m_visible(true) > -, m_separatorsCollapsible(true

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

broulik added a comment. This causes menus (mostly submenus) to randomly show up when the SNI is updated, e.g. every time VLC changes a track I get its "speed (slower, normal, faster)" menu open: F7748305: Screenshot_20191108_151344.png (note the th

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a subscriber: davidedmundson. broulik added a comment. In D25119#558084 , @cullmann wrote: > Hmm, where does that happen? https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n888 > And does that work for icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a comment. > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. But why would you need this anyway? At least with `KIconEngine` we colorize the icons dynamically. I don't have to switch to breeze-dark when I use a dark color scheme on Pl

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

broulik added a comment. Can you expand on that dark theme issue? We just colorize the same SVGs as needed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt Cc: broulik, rempt, kde-frameworks-devel, LeGast0

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

broulik added a comment. `KDesktopFile::desktopGroup()` just gives you a `KConfigGroup` of the ´[Desktop Entry]` section at which point you can read whatever you want REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25003 To: meven, #frameworks, apol Cc: broulik, kde

T11627: Improve KIO asynchronicity

broulik added a comment. I'm pretty sure there's a tonne of blocking DBus calls being done all over the place during file copy (checking for slaves on hold, updating kuiserver job tracking info, etc) which can cause apps to hang or slow down if whatever they're trying to call into is busy. B

D24958: Delete nepomuk icon

broulik added a comment. https://cgit.kde.org/dolphin.git/tree/src/panels/information/informationpanelcontent.cpp#n231 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michae

D24958: Delete nepomuk icon

broulik added a comment. Note that Dolphin still uses that icon for its information panel when in search mode. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24958 To: astippich, ngraham, bruns Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D24476: [KPropertiesDialog] Only show volume-related info for volumes

broulik added a comment. > Don't you already have the free space information in the status bar though? Isn't that supposed to be removed by default in that ominous Dolphin redesign? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks

D24895: [RFC] Drop implicit size from PC buttons

broulik added a comment. Perhaps only when it has no text so icon-only can become rightfully square? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24895 To: nicolasfella, #plasma, mart, #vdg Cc: broulik, ngraham, kde-frameworks-devel, mart, LeGas

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

broulik added a comment. However, `setDummyHistoryEntry` has some logic for icon being `null` and "reuse previous pixmap if null" which would be moot if I change it to always fall back to `application-octet-stream`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451

D15451: Let KUrlCombo operate on QIcon instead of QPixmap

broulik planned changes to this revision. broulik added a comment. Yes. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15451 To: broulik, #frameworks, dfaure, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

broulik added a comment. Alternatively you could make the `KeySequenceHelper` itself a `QQuickItem` so it gets assigned a window. INLINE COMMENTS > keysequencehelper.cpp:118 > QString shortcutDisplay; > - > +QQuickItem* keySequenceItem; > //! Check the key sequence against KSta

D24716: Fix memory leak of KQuickAddons::ConfigModule objects

broulik accepted this revision. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D24716 To: davidedmundson, #plasma, ervin, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24667: [KStatusNotifierItem] Allow left click when menu is null

broulik added a comment. > bool takeOwnership = true); If only Qt/we used modern C++ features to communicate object ownership :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D24667 To: kmaterka, davidedmundson, broulik, nicolasfella, #frameworks Cc: kde

D24697: Expose isImmutable to introspection (e.g. QML)

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24697 To: ervin, #plasma, #frameworks, mart, dfaure, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D18299: ComboBox: fix default delegate

broulik added a comment. I checked Qt source code and Qt indeed should handle this on its own, it also works fine hwere without the code. Worse, the explicit assignment from QML breaks any binding set on `currentIndex`. In the handler that's called when the delegate model creates a delega

D24431: Restore cursor thumbnailer

broulik planned changes to this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24431 To: broulik, #plasma, fredrik, ngraham Cc: adridg, ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, fev

D23835: Add TabKCM

broulik added a comment. Don't use ECMAScript 6 stuff in KDeclarative or plasma-framework! It is a Framework which has a minimum version version support of Qt 5.11 (last three, 5.13, 5.12, 5.11). ECMAScript 6 is only in Qt 5.12 REPOSITORY R296 KDeclarative REVISION DETAIL https://phabri

D24263: edit mode action

broulik added inline comments. INLINE COMMENTS > corona.cpp:378 > +switch (d->immutability) { > +case Types::UserImmutable: > +action->setEnabled(false); Why is this switch to explicitly stating all the cases? The action is always visible and enabled only when Mutable

D24430: [KCModuleLoader] Show error when QML fails to load

broulik closed this revision. broulik added a comment. https://cgit.kde.org/kcmutils.git/commit/?id=8cea2dacd80565f6d22bf1e5151e5c7be1620eab REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D24430 To: broulik, #plasma, ngraham, mart Cc: kde-frameworks-devel, LeGast00

D24429: [ConfigModule] Expose mainUi component status and error string

This revision was automatically updated to reflect the committed changes. Closed by commit R296:2c2942cee9ec: [ConfigModule] Expose mainUi component status and error string (authored by broulik). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24429?vs=673

D24476: [KPropertiesDialog] Only show volume-related info for volumes

broulik added a comment. Perhaps, but right clicking on my HOME will then give me no information as it's not a separate mount. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michae

D24476: [KPropertiesDialog] Only show volume-related info for volumes

broulik added a comment. Having the free space info bar on folders was always very useful imho REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24476 To: ngraham, #vdg, #frameworks, broulik Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24463: Treat "application/x-ms-dos-executable" as executable on all platforms

broulik added a comment. +1 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24463 To: guoyunhe, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24429: [ConfigModule] Expose mainUi component status and error string

broulik added a comment. > Is the text in the window mouse-selectable? I don't think so (didn't test, just read the code) but should be trivial to add. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: ngraham, kde-frameworks-d

D24442: ensure winId() not called on non-native widgets

broulik added a comment. Can you also check `KRun`, I'm sure we've had issues with startup reporting stuff in the past REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngra

D24431: Restore cursor thumbnailer

broulik created this revision. broulik added reviewers: Plasma, fredrik. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Baiscally just find xlib and change the link targets. Ther

D24429: [ConfigModule] Expose mainUi component status and error string

broulik added a dependent revision: D24430: [KCModuleLoader] Show error when QML fails to load. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 To: broulik, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24430: [KCModuleLoader] Show error when QML fails to load

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REVISION SUMMARY Currently it just prints a warning to console and shows an empty dialog leaving the u

D24429: [ConfigModule] Expose mainUi component status and error string

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. broulik requested review of this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24429 AFFECTED FILES sr

D24239: make editMode a corona global property

broulik added inline comments. INLINE COMMENTS > broulik wrote in containmentinterface.cpp:416 > I think you should check for `SystemImmutable` here (KIOSK) Nevermind, it just moved :) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D24239 To: mart,

D24239: make editMode a corona global property

broulik added inline comments. INLINE COMMENTS > containmentinterface.cpp:416 > - > -if (m_containment->immutability() != Plasma::Types::Mutable) { > -return; I think you should check for `SystemImmutable` here (KIOSK) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

Re: Review Request 129083: [KIconLoader] Take into account devicePixelRatio for overlays

cons don't show up though) Thanks, Kai Uwe Broulik

D23857: Honor global animation speed factor

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d5a5d07f0f89: Honor global animation speed factor (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23857?vs=65804&id=66828

D21897: Address some issues reported by Krazy analysis

broulik added inline comments. INLINE COMMENTS > ktextedit.cpp:373 > + > +delete dialog; > } You can do `dialog->setAttribute(Qt::WA_DeleteOnClose);` when creating the dialog instead of an explicit delete call REPOSITORY R310 KTextWidgets BRANCH krazy-50b2564 (branched from master)

D24046: Allow triggering sort from QML

broulik added a comment. Meh, I could have sworn `sort` was `Q_INVOKABLE` :( REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24025: Don't use KCrash on Android

broulik added a comment. I surely don't want to have apps start to #ifdef a ton of stuff out, which works against the nature of Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel, LeGast00n,

D24025: Don't use KCrash on Android

broulik added a comment. Can't we make KCrash just no-op on Android? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24023: Delete QQmlObjectSharedEngine context in sync with QQmlObject

broulik added a reviewer: dfaure. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D24023 To: davidedmundson, #plasma, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23985: Consider UNC paths as NetworkShare context

This revision was automatically updated to reflect the committed changes. Closed by commit R308:8df6c719617e: Consider UNC paths as NetworkShare context (authored by broulik). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23985?vs=66194&id=66289 REVISION DET

<    1   2   3   4   5   6   7   8   9   10   >