kossebau added inline comments.
INLINE COMMENTS
> kcombobox.cpp:363
> +connect(d->klineEdit, ::completionBoxActivated,
> +this, QOverload QString&>::of(::textActivated));
> +#endif
Why the `QOverload::of()` with `::textActivated`?
Accidental copy?
After all the purpose
dfaure added inline comments.
INLINE COMMENTS
> broulik wrote in kcombobox.cpp:59
> With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind
> autocompletes history entries rather than paths when hitting tab.
Good catch!
More precisely, history entries are offered in the lineedit
broulik added inline comments.
INLINE COMMENTS
> kcombobox.cpp:59
> Q_Q(KComboBox);
> -q->QComboBox::setAutoCompletion(false); // otherwise setLineEdit will
> create a completer...
>
With this removed, the `KUrlComboBox` in e.g. "Look in" in KFind autocompletes
history entries
dfaure closed this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D23842
To: dfaure, cfeck, dhaumann, aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
vkrause accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R284 KCompletion
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23842
To: dfaure, cfeck, dhaumann, aacid, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns
dfaure created this revision.
dfaure added reviewers: cfeck, dhaumann, aacid.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
dfaure requested review of this revision.
REVISION SUMMARY
the QComboBox::activated(QString) signal being deprecated
and
