D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > broulik wrote in ktoolbar.cpp:908 > I just realized this is false-y deprecated. The feature adds the > configuration options for toolbar buttons. > What needs to be done here for proper deprecation is port that over to >

D24466: Use ECMGenerateExportHeader to manage deprecated API better

broulik added inline comments. INLINE COMMENTS > ktoolbar.cpp:908 > { > -#ifndef KXMLGUI_NO_DEPRECATED > +#if KXMLGUI_BUILD_DEPRECATED_SINCE(5, 0) > if (mainWindow() && d->enableContext) { I just realized this is false-y deprecated. The feature adds the configuration options for toolbar

D24466: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R263:808bd05b37e4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24466?vs=67733=68160#toc REPOSITORY R263

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:308 > Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a > virtual method, which the compiler needs to always know about. Eh, fixed to KXMLGUI_BUILD_DEPRECATED_SINCE actually :)

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > kactioncollection.h:308 > > +#if KXMLGUI_ENABLE_DEPRECATED_SINCE(5, 0) > /** Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a virtual method, which the compiler needs to always know about. REPOSITORY R263

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. dfaure added a comment. Yep all good from my point of view. REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. @dfaure Any remaining issues from your side, or is your +1 available as well now? :) REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. For the record, I get WARNING: QObject::connect|main QObject::connect: Connecting from COMPAT signal (Object::signalIt()) But indeed that's because I build my Qt in debug mode. The only mode that truly matters for developers :-) Maybe Qt shouldn't use

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24466#547084 , @dfaure wrote: > check_and_warn_compat does not warn for this testcase because the slot is deprecated too. > Try a deprecated signal and a non-deprecated slot :-) > > 2714│ if

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. Thanks for the investigation. check_and_warn_compat does not warn for this testcase because the slot is deprecated too. Try a deprecated signal and a non-deprecated slot :-) 2714│ if (signal.attributes() & QMetaMethod::Compatibility) { 2715│

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24466#546952 , @dfaure wrote: > Maybe Qt doesn't have any deprecated signals? That would be nice :) A few there are though, e.g. see here some for QComboBox, only using `QT_DEPRECATED_SINCE` &

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. Maybe Qt doesn't have any deprecated signals? REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:314 > Okay, so "QT_MOC_COMPAT" is still a (just undocumented) thing, and thus > something we should use for deprecated signal/slots then as before, right? > > Had now another look based on your info, and

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kactioncollection.h:314 > Taking this from the other side: warnings when connecting to deprecated > signals actually work. They happen in check_and_warn_compat in qobject.cpp > > ... this does support warning about connecting to

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:314 > No idea. I started a few times to look up what QT_MOC_COMPAT actually is > about, but never had quick results, so delayed into the future. > > Just had a look again, but as before stranding with

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kactioncollection.h:278 > Does this work? It's a signal. Won't this only warn at emit time? (while > QT_MOC_COMPAT is what leads to a warning at connect time) > > Asking because you didn't do this in D24465 >

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kactioncollection.h:314 > (pre-existing) QT_MOC_COMPAT for a slot? Any idea what this might do? No idea. I started a few times to look up what QT_MOC_COMPAT actually is about, but never had quick results, so delayed into the

D24466: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > kactioncollection.h:278 > */ > +KXMLGUI_DEPRECATED_VERSION(5, 0, "Do not rely on") > QT_MOC_COMPAT void removed(QAction *action); Does this work? It's a signal. Won't this only warn at emit time? (while QT_MOC_COMPAT is what leads

D24466: Use ECMGenerateExportHeader to manage deprecated API better

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 67733. kossebau added a comment. - disable KF group deprecation macros for now - set DEPRECATED_BASE_VERSION=0, to not disable any API by default REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24466?vs=67429=67733

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. If no-one objects, would be pushing on Monday evening, Oct. 14th. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24466: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KXmlGui to hide deprecated API up to