Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116461/ --- (Updated March 29, 2014, 9:08 a.m.) Status -- This change has been d

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-23 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-17 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-16 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-06 Thread Matthew Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-04 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > > immed

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-01 Thread Matthew John Dawson
> On Feb. 28, 2014, 3:41 p.m., Matthew John Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > >

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-03-01 Thread David Faure
> On Feb. 28, 2014, 8:41 p.m., Matthew John Dawson wrote: > > While I'm fine with the idea behind this optimization, I worry that this > > implementation could create situations were a configuration change is not > > picked up by the system. For instance, what happens if the user doesn't > >

Re: Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-02-28 Thread Matthew John Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116461/#review51374 --- While I'm fine with the idea behind this optimization, I worry

Review Request 116461: KConfigSkeleton: avoid calling reparseConfiguration() immediately after creation.

2014-02-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116461/ --- Review request for KDE Frameworks and Matthew John Dawson. Repository: kc