Re: Review Request 120728: Install public header for KNotifyPlugin and rename it to KNotificationPlugin

2014-11-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/ --- (Updated Nov. 6, 2014, 11:36 a.m.) Status -- This change has been ma

Re: Review Request 120728: Install public header for KNotifyPlugin and rename it to KNotificationPlugin

2014-10-29 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/ --- (Updated Oct. 29, 2014, 10 a.m.) Review request for KDE Frameworks. Cha

Re: Review Request 120728: Install public header for KNotifyPlugin

2014-10-27 Thread Lukáš Tinkl
> On Říj. 23, 2014, 1:12 dop., Aleix Pol Gonzalez wrote: > > You can rename it AFAIU. > > Given that no external project has seen the header file, nobody is linking > > against it (if they don't copy the header over, which is not supported, of > > course). > > Martin Klapetek wrote: > My t

Re: Review Request 120728: Install public header for KNotifyPlugin

2014-10-27 Thread Martin Klapetek
> On Oct. 23, 2014, 1:12 a.m., Aleix Pol Gonzalez wrote: > > You can rename it AFAIU. > > Given that no external project has seen the header file, nobody is linking > > against it (if they don't copy the header over, which is not supported, of > > course). My thinking is that rename = remove a

Re: Review Request 120728: Install public header for KNotifyPlugin

2014-10-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/#review68952 --- You can rename it AFAIU. Given that no external project has se

Review Request 120728: Install public header for KNotifyPlugin

2014-10-22 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/ --- Review request for KDE Frameworks. Repository: knotifications Descripti