---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126105/#review88544
---
Errr... you intend to crash applications depending on whether
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126105/
---
Review request for Baloo, KDE Frameworks, Pinak Ahuja, and Vishesh Handa.
> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote:
> > Errr... you intend to crash applications depending on whether some file is
> > present??
> > Please fix the actual bug instead of such workaround, got a backtrace?
Err... it **doesn't** cause a crash with the patch, causes a crash
> On Nov. 18, 2015, 8:06 nachm., Thomas Lübking wrote:
> > Errr... you intend to crash applications depending on whether some file is
> > present??
> > Please fix the actual bug instead of such workaround, got a backtrace?
>
> Boudhayan Gupta wrote:
> Err... it **doesn't** cause a crash
> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote:
> > Errr... you intend to crash applications depending on whether some file is
> > present??
> > Please fix the actual bug instead of such workaround, got a backtrace?
>
> Boudhayan Gupta wrote:
> Err... it **doesn't** cause a crash with
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126105/#review88554
---
Ship it!
I'm a little hesitant about this, but ship it.
A
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126105/#review88556
---
without actualy knowing the code in question, a brief look
> On Nov. 19, 2015, 6:03 a.m., Vishesh Handa wrote:
> > I'm a little hesitant about this, but ship it.
> >
> > A couple of things though -
> > 1. Dolphin should probably not be sending Baloo so many requests if Baloo
> > is disabled. Perhaps we should fix this in Dolphin.
> > 2. This patch is
> On Nov. 19, 2015, 1:36 a.m., Thomas Lübking wrote:
> > Errr... you intend to crash applications depending on whether some file is
> > present??
> > Please fix the actual bug instead of such workaround, got a backtrace?
>
> Boudhayan Gupta wrote:
> Err... it **doesn't** cause a crash with
> On Nov. 19, 2015, 10:35 a.m., Sune Vuorela wrote:
> > without actualy knowing the code in question, a brief look over gives me
> > the impression that the error handling could be improved and that would
> > make this patch not needed.
The assumption here is that if (rc != 0) in normal
> On Nov. 18, 2015, 8:06 nachm., Thomas Lübking wrote:
> > Errr... you intend to crash applications depending on whether some file is
> > present??
> > Please fix the actual bug instead of such workaround, got a backtrace?
>
> Boudhayan Gupta wrote:
> Err... it **doesn't** cause a crash
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126105/
---
(Updated Nov. 19, 2015, 7:11 a.m.)
Status
--
This change has been
> On Nov. 18, 2015, 8:06 nachm., Thomas Lübking wrote:
> > Errr... you intend to crash applications depending on whether some file is
> > present??
> > Please fix the actual bug instead of such workaround, got a backtrace?
>
> Boudhayan Gupta wrote:
> Err... it **doesn't** cause a crash
13 matches
Mail list logo
